Roland Häder [Thu, 20 Apr 2017 08:39:51 +0000 (10:39 +0200)]
Please cherry-pick:
- don't get local logger here, local invokations are CDI, but here JNDI would be
needed
- maybe old-feshioned System.out.println() ?
Roland Häder [Wed, 24 Aug 2016 08:52:00 +0000 (10:52 +0200)]
Please cherry-pick:
- got rid of redundant hasFoos() as #{ no someController.allFoos().isEmpty()} works fine
- renamed controller method allMobileProvider() -> allMobileProviders()
Roland Häder [Wed, 19 Apr 2017 14:52:47 +0000 (16:52 +0200)]
Continued porting templates:
- added a lot missing templates which are used for handling fax/land-line
numbers
- no more cellphone, now all mobiles are welcome ...
- renamed files as they belong to user (not generic)
Roland Häder [Wed, 19 Apr 2017 12:24:14 +0000 (14:24 +0200)]
Cleanups:
- added id for menu include (maybe more follow? or I revert all these?)
- removed no longer used i18n strings
- user_menu is no longer included in page template, only in user_base.xhtml
Roland Häder [Sun, 16 Apr 2017 09:23:47 +0000 (11:23 +0200)]
Please cherry-pick:
- renamed login_change_* to login_user_change_* as these are user-specific
changes
- also renamed i18n strings
- renamed method in email-change controller as it is user-specific, too
- deleted left-over index.xhtml
Roland Häder [Sat, 15 Apr 2017 18:55:54 +0000 (20:55 +0200)]
Continued:
- addressbook-core/mailer are now referenced as projects as they are
application-specific projects and not libraries (like e.g. juser-core is)
Roland Haeder [Tue, 11 Apr 2017 09:20:11 +0000 (11:20 +0200)]
Nope. keep these names unified, but class names project-dependent so the IDE is not getting confused which implementation (if you have all projects loaded into it) is meant.
Roland Häder [Mon, 8 Aug 2016 15:43:11 +0000 (17:43 +0200)]
Continued with splitting/cleanup: (please cherry-pick)
- removed all boolean hasFoos() methods as isEmpty() works the same way
- got rid of many Collections.unmodifiableList() calls as they may confuse the developer, please watch out!
- splitted contact's special phone stuff out to own controller (bean)
Roland Häder [Mon, 8 Aug 2016 14:51:58 +0000 (16:51 +0200)]
Continued with rewrite: (please cherry-pick)
- renamed some admin_contact_cellphone_???.xhtml to admin_cellphone_???.xhtml as they are generic enough (not depending on contact)
- moved phone-contact stuff to adminContactController
- renamed i18n strings properly
- no need to have contact in adminPhoneController, better is the obvious one: beanHelper
- started with listing all cell phone numbers (similar JSF will follow for land-line and fax numbers)
- the contact stuff in adminPhoneHelper was deprecated anyway
Signed-off-by: Roland Häder <roland@haeder.net> Signed-off-by: Roland Häder <roland@mxchange.org>
Roland Häder [Mon, 8 Aug 2016 13:22:38 +0000 (15:22 +0200)]
Please rename:
- this is no longer a contact's land-line/cellphone number controller, it only handles the number data itself
- unlink/link with contact or employees or anything must be done in that specific controller
Signed-off-by: Roland Häder <roland@haeder.net> Signed-off-by: Roland Häder <roland@mxchange.org>
Roland Haeder [Sat, 6 Aug 2016 20:16:43 +0000 (22:16 +0200)]
Some fixes: (please cherry-pick)
- added missing import for MessageFormat
- renamed loginController to userLoginController as this is only for user logins
Roland Häder [Sat, 6 Aug 2016 10:26:59 +0000 (12:26 +0200)]
Continued with rewrites: (please cherry-pick)
- the contact phone controller becomes a generic phone controller (see jcontacts-business-core)
- marked contact-related stuff in it as deprecated
- renamed it's JSF name to adminPhoneController
- all phone instances are being set by beanHelper's copyUserToController() method
- private method setPhoneInstances() introduced
- rewrote all parameters that cannot be auto-completed by IDE to beanHelper and phone controller
- added missing i18n string(s)
Roland Häder [Sat, 6 Aug 2016 08:45:35 +0000 (10:45 +0200)]
Fixed house number extension: (please cherry-pick)
- the contact's house number extension was not exposed in template
- and also not cleared in clear() method
Roland Häder [Sat, 6 Aug 2016 08:15:05 +0000 (10:15 +0200)]
Please cherry-pick:
- Well, ui:fragment is according to my trainer not right. What I want here is a navigation to edit/delete/lock/unlock pages depending on the user's account status.
- If the account status is UNCONFIRMED, currently only show edit and delete
- If it is CONFIRMED, add a link to "lock" page.
- If it is LOCKED, add a link to "unlock" page.
- Currently I do this with ui:fragment because it seems to be the only JSF tag that is NOT rendering it's body when the rendered attribute resolves to false.
- If you can find a drop-in replacement, please notify me at roland[AT]mxchange[DOT]org
- And please keep in mind that c:if or anything like that is JSP which is being executed on an other life-cycle step than JSFs.
Roland Häder [Sat, 6 Aug 2016 07:55:12 +0000 (09:55 +0200)]
Continued a bit: (please cherry-pick)
- don't wrap command buttons in rendered="" conditions and not with ui:fragment (please name me a full replacement for all the other cases where I'm using it)
- this makes it impossible for the button's action (controller method) being executed as this depends on the life-cycle of the JSF
- it may work in viewing the JSF page but not when you submit it.
- rewrote parameter 'user' to beanHelper.user as this was already being used
- show proper lock/unlock link depending on user's account status
- added navigation rule for new user lock JSF page
projects / addressbook-war.git / log