Apply suggestions from code review

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>

Twitter: Move config to key value

Merge pull request #1351 from MrPetovan/bug/12665-monolog

[various] Remove App dependency from hook functions

[various] Remove App dependency from hook functions

Merge pull request #1350 from MrPetovan/bug/fatal-errors

[impressum] Avoid calling obfuscate_email on a null value

[impressum] Avoid calling obfuscate_email on a null value

- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1378416688

Merge pull request #1349 from annando/twitter-wall

Twitter: Set "wall" on remote-self

Twitter: Set "wall" on remote-self

Merge pull request #1348 from MrPetovan/bug/warnings

[public_server] Add expected "event" key in public_server_cron()

[public_server] Add expected "event" key in public_server_cron()

- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1372634282

Welcome 2023!

Merge pull request #1347 from annando/blockem-unsupported

Blockem: set to unsupported

Blockem: set to unsupported

Merge pull request #1346 from mexon/mat/mailstream-media

mailstream includes post media in message body

mailstream includes post media in message body

Merge pull request #1345 from nupplaphil/feat/addons_load

[various] Move `addon` config

[various] adapt README.md

[gravatar] Use addon config entries instead of the db

Merge pull request #1343 from nupplaphil/feat/node.config.php

[various] Introduce ConfigFileManager for config files

Merge pull request #1344 from friendica/bug/nofifyall

[notifyall] Fix email selection

[notifyall] Fix email selection

FollowUp #1313

Introduce ConfigFileManager for config files

Merge pull request #1342 from MrPetovan/bug/deprecated

[tictac] Move the addon to unsupported

[tictac] Move the addon to unsupported

- PHP 8.1 deprecation messages were reported

Merge pull request #1341 from nupplaphil/feat/keyvalue_storage

[various] Replace addon "last" config entries with key-value entries

Replace addon "last" config entries with key-value entries

Merge pull request #1339 from annando/no-gs-import

GNU-Social import is removed

Updated messages.po

More unneeded stuff removed

GNU-Social import is removed

Merge pull request #1338 from brockhaus/2022.12-rc

Added ALT and TITLE of original IMG to fancybox popup.

Added ALT and TITLE of original IMG to fancybox popup.

Merge pull request #1337 from tobiasd/20221217-lng

FR, HU, PL translation updates

removed translation files from addons deprecated

HU translation of various addons updated

PL translation of various addons updated

HU translation of various addons updated

FR translation of various addons updated

Merge pull request #1336 from MrPetovan/bug/12405-pumpio-log

[pumpio] Cast variable as array before being passed to Logger::info

[pumpio] Cast variable as array before being passed to Logger::info

Merge pull request #1335 from brockhaus/develop

v.1.0.4: Support for upcoming imagegrid

v.1.0.4: Support for upcoming imagegrid

Merge pull request #1334 from AndyHee/2022.12-rc

Deprecated Addons: windowsphonepush, notifyall

Merge branch 'friendica:2022.12-rc' into 2022.12-rc

deleted:    namethingy/namethingy.php
deleted:    windowsphonepush/lang/C/messages.po
deleted:    windowsphonepush/lang/ar/messages.po
deleted:    windowsphonepush/lang/ar/strings.php
deleted:    windowsphonepush/lang/cs/messages.po
deleted:    windowsphonepush/lang/cs/strings.php
deleted:    windowsphonepush/lang/da-dk/messages.po
deleted:    windowsphonepush/lang/da-dk/strings.php
deleted:    windowsphonepush/lang/de/messages.po
deleted:    windowsphonepush/lang/de/strings.php
deleted:    windowsphonepush/lang/es/messages.po
deleted:    windowsphonepush/lang/es/strings.php
deleted:    windowsphonepush/lang/fi-fi/messages.po
deleted:    windowsphonepush/lang/fi-fi/strings.php
deleted:    windowsphonepush/lang/fr/messages.po
deleted:    windowsphonepush/lang/fr/strings.php
deleted:    windowsphonepush/lang/hu/messages.po
deleted:    windowsphonepush/lang/hu/strings.php
deleted:    windowsphonepush/lang/it/messages.po
deleted:    windowsphonepush/lang/it/strings.php
deleted:    windowsphonepush/lang/nl/messages.po
deleted:    windowsphonepush/lang/nl/strings.php
deleted:    windowsphonepush/lang/pl/messages.po
deleted:    windowsphonepush/lang/pl/strings.php
deleted:    windowsphonepush/lang/ro/messages.po
deleted:    windowsphonepush/lang/ro/strings.php
deleted:    windowsphonepush/lang/sv/messages.po
deleted:    windowsphonepush/lang/sv/strings.php
deleted:    windowsphonepush/lang/zh-cn/messages.po
deleted:    windowsphonepush/lang/zh-cn/strings.php
deleted:    windowsphonepush/templates/settings.tpl
deleted:    windowsphonepush/windowsphonepush.php

Merge pull request #1333 from AndyHee/2022.12-rc

Deprecated Superblock Addon

deleted:    superblock/lang/C/messages.po
deleted:    superblock/lang/ar/messages.po
deleted:    superblock/lang/ar/strings.php
deleted:    superblock/lang/ca/strings.php
deleted:    superblock/lang/cs/messages.po
deleted:    superblock/lang/cs/strings.php
deleted:    superblock/lang/da-dk/messages.po
deleted:    superblock/lang/da-dk/strings.php
deleted:    superblock/lang/de/messages.po
deleted:    superblock/lang/de/strings.php
deleted:    superblock/lang/en-gb/messages.po
deleted:    superblock/lang/en-gb/strings.php
deleted:    superblock/lang/en-us/messages.po
deleted:    superblock/lang/en-us/strings.php
deleted:    superblock/lang/eo/strings.php
deleted:    superblock/lang/es/messages.po
deleted:    superblock/lang/es/strings.php
deleted:    superblock/lang/fi-fi/messages.po
deleted:    superblock/lang/fi-fi/strings.php
deleted:    superblock/lang/fr/messages.po
deleted:    superblock/lang/fr/strings.php
deleted:    superblock/lang/hu/messages.po
deleted:    superblock/lang/hu/strings.php
deleted:    superblock/lang/is/strings.php
deleted:    superblock/lang/it/messages.po
deleted:    superblock/lang/it/strings.php
deleted:    superblock/lang/nb-no/strings.php
deleted:    superblock/lang/nl/messages.po
deleted:    superblock/lang/nl/strings.php
deleted:    superblock/lang/pl/messages.po
deleted:    superblock/lang/pl/strings.php
deleted:    superblock/lang/pt-br/messages.po
deleted:    superblock/lang/pt-br/strings.php
deleted:    superblock/lang/ro/messages.po
deleted:    superblock/lang/ro/strings.php
deleted:    superblock/lang/ru/messages.po
deleted:    superblock/lang/ru/strings.php
deleted:    superblock/lang/sv/messages.po
deleted:    superblock/lang/sv/strings.php
deleted:    superblock/lang/zh-cn/strings.php
deleted:    superblock/superblock.php
deleted:    superblock/templates/settings.tpl

Merge pull request #1332 from AndyHee/2022.12-rc

[nitter] Update wording

modified:   nitter/lang/C/messages.po

Update nitter.php

[Now really] Reduced font size of notice

Update nitter.php

Replaced verbose sentence with succinct notice  and reduced its font size.

Update nitter.php

Changed  protocol of example URL to secure to avoid confusion as all Nitter servers operate in secure mode only.

Merge pull request #1331 from MrPetovan/bug/warnings

[twitter] Ward against missing remote_images array key

[twitter] Ward against missing remote_images array key

- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1345387060

Merge pull request #1330 from MrPetovan/bug/warnings

[nsfw] Suppress warnings about failed regexp compilation

[nsfw] Suppress warnings about failed regexp compilation

- Add failed regexp compilation system messages on addon settings submit
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1336418781

Merge branch '2022.12-rc' of https://github.com/friendica/friendica-addons into 2022.12-rc

Twitter: Improve uploading of images

Merge pull request #1328 from tobiasd/20221208-fr

Twitter addon translation update THX kalon33

Twitter addon translation update THX kalon33

Merge pull request #1327 from brockhaus/develop

fancybox addon v.1.03

Changes added because of good remarks by hypolite@friendica.mrpetovan.com

Version 1.03

* imgages in body-attach with title / alt attribute get them removed while adding fancy attributes
* Added fancybox to image inlined in posts. Un-hooked the old lightbox from frio and vier and excahnged that with fancybox hooks.
* Excluded images in "type-link" divs from being "fancied" as they have no images but pages linked to.

Merge pull request #1326 from MrPetovan/bug/warnings

[twitter] Use correct variable to store application name

[twitter] Use correct variable to store application name

- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1336015957

Merge pull request #1325 from MarekBenjamin/fix_jsupload

Adjusted code use of shorthandnotation for image size upload limits

Wrapped Strings::getBytesFromShorthand() around the last overseen DI::config()->get('system', 'maximagesize')

Adjusted code use of shorthandnotation for image size upload limits

Merge pull request #1324 from MrPetovan/bug/deprecated

[various] Address a couple of PHP 8.1 notices

[various] Address a couple of PHP 8.1 notices

- Replace a couple of strstr calls by strpos
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1331012289

Merge pull request #1323 from nupplaphil/bug/rendertime

[rendertime] Fix empty minimal_time

[rendertime] Fix empty minimal_time

Merge pull request #1322 from tobiasd/20221128-de

[twitter, nsfw] DE translation update

[twitter, nsfw] DE translation update

Merge pull request #1321 from nupplaphil/mod/fbrowser

[rendertime] Adapt ignored_modules

Move Browser & Upload to own namespace

Move FileBrowser to own namespace & Bugfix album usage

[rendertime] Adapt ignored_modules

Merge pull request #1319 from MrPetovan/bug/deprecated

[various] Address a couple of PHP8.1 deprecation notices

Merge pull request #1320 from brockhaus/develop

AddOn Fancybox

Code formatting from hell..

Code formatting

Wow.. This is very picky... |-(

Code style

gitignore

AddOn Fancybox

This addon loads all media attachments of a post into a "fancybox" instead of linking directly to the media.
Each post gets its own attachment library, when there are more than one media attached you can scroll through them.

[startpage] Remove deprecated call to strlen

- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513

[securemail] Upgrade singpolyma/openpgp to version 0.6.0

- Add missing use statement in SecureTestEmail
- Address https://github.com/friendica/friendica/issues/12011#issuecomment-1321196332
- phpseclib version 3 dependency is implied from the core so it is removed from the addon

Merge pull request #1318 from annando/no-mod-item

Calls to "item_post" are replaced

Merge remote-tracking branch 'upstream/develop' into no-mod-item

Don't call mod/item.php anymore

Merge pull request #1317 from MrPetovan/task/10188-addon-config

[various] Set config loaded from default values to SOURCE_STATIC

[various] Set config loaded from default values to SOURCE_STATIC

- This prevents from clobbering values loaded from base `config/` folder

[various] Remove config/addon.config.php in favor of per-addon configuration file

Merge pull request #1316 from simcop2387/develop

Fix signature of SAML hooks to work with modern friendica

SLO takes no params apparently

Fix signature of hooks to work with modern friendica

Merge pull request #1315 from MrPetovan/bug/warnings

[various] Fix PHP 8 deprecation warnings

[various] Fix PHP 8 deprecation warnings

Merge pull request #1314 from MrPetovan/task/nsfw-case-sensitive

[nsfw] Match regular words with case sensitivity

Merge pull request #1313 from MrPetovan/bug/7574-notifications-deleted-users

[various] Use new centralized admin account retrieval methods