Roland Häder [Sat, 25 Apr 2020 16:54:17 +0000 (18:54 +0200)]
Don't cherry-pick:
- introduced administrative action backing bean for receipt items
- introduced converter for receipt items
- introduced uniqueAddReceiptItem() and CDI observers for updating cache/lists
- introduced findReceiptItemById()
- let's distinguish between administrative and user events
- updateReceipt returns now a redirection outcome (back to admin-list-receipts
view)
- reformatted Java code a bit for having all parameter of huge constructors
in a separate line
- added missing navigation rules from edit -> list views
- added missing i18n strings
Roland Häder [Sat, 25 Apr 2020 16:48:28 +0000 (18:48 +0200)]
Product-only
- admin_product_price_input_panel_grid.tpl to a ui:include with fixed backing
bean reference for type-safety
- decimalSeparator and thousandSeparator are both not localizable, let's dump
them then and current user's locale will handle it
- FSC number exposed in product list and modal
- categoryEntryUpdated exposed in admin-list-category view
- removed unneeded id attribute
- removed product.jsf.taglib.xml
Roland Häder [Sat, 25 Apr 2020 16:41:39 +0000 (18:41 +0200)]
Please cherry-pick:
- introduced new administrative action backing bean (add/update/delete being
done here)
- land-line, fax and mobile instances must be intialized with null first, then
check all respective backing bean properties if they all exist. This fixes
the NPEs coming from updated constructors
- check Country instance against the interface Country and not not being null
- added missing i18n string
Roland Häder [Fri, 24 Apr 2020 12:47:09 +0000 (14:47 +0200)]
Product-only:
- added navigation rule from admin-edit-generic-product to admin-list-generic-products
- added returned outcome when a product has been successfully updated (admin)
- renamed outcome admin_list_product to admin_list_generic_products
- renamed outcome admin_list_category to admin_list_product_categories
- if the product data has not been updated, output a proper warning message
- added missing i18n strings
Roland Häder [Fri, 24 Apr 2020 03:05:31 +0000 (05:05 +0200)]
Please cherry-pick:
- added view admin-edit-branch-office view including backing bean action method
- added navigation rule from admin-edit-branch-office to
admin-list-branch-offices view, including redirect
- added event observer for when an administrator has updated a branch office
- renamed adminBranchOfficeController to adminBranchOfficeActionController
- added many missing i18n strings
- renamed i18n string
Roland Häder [Thu, 23 Apr 2020 01:29:33 +0000 (03:29 +0200)]
Don't cherry-pick:
- some renderFoo() methods have extra parameters, added
- in converters/validators now the FOO_LIST_CONTROLLER static instance shall
always be initialized directly before the try{} block
Roland Häder [Thu, 23 Apr 2020 00:29:42 +0000 (02:29 +0200)]
Please cherry-pick:
- got rid of admin_form_basic_data.tpl, now moved back to original view, I guess
I will do that for all forms, which would lead to "duplicate" forms elements
butter with no targetController which was never resolvable anyway.
- added showEmailAddress boolean flag to many renderFoo() methods to whether
show email address which is mostly not wanted in selection boxes ...
- added companyRoadNumber to basic-data backing bean and proper forms/list view
- in converters/validators now the FOO_LIST_CONTROLLER static instance shall
always be initialized directly before the try{} block
Roland Häder [Sun, 19 Apr 2020 16:58:49 +0000 (18:58 +0200)]
Please cherry-pick:
- rewrote to not use fax_input_table_row.tpl
- realigned JSF tags to have attributes in a separate line
- got rid of some old tags from pre-PrimeFaces times
Roland Häder [Sun, 19 Apr 2020 00:07:53 +0000 (02:07 +0200)]
Please cherry-pick:
- got rid of admin-contact-links menu template
- reformatted a lot templates
- got rid of some core:outputMessageBox as p:growl does it already
- implemented missing deleteContactData() action method
- also implemented missing even observer for updating cache and list
- replaced FaceletException with FacesException
- renamed variables
Roland Häder [Fri, 17 Apr 2020 14:59:29 +0000 (16:59 +0200)]
Don't cherry-pick:
- heavy rewrite on (almost?) all admin-list-foo views, to use @ViewScoped beans
and working JSR107 caching
- also sorted out mixed usage of userController (or so?) as the login and
register backing beans can surely have their own properties
- rewrote web/WEB-INF/resources/tags/admin/dropdown/ to have it included back
in views again, was a bad idea
Roland Häder [Fri, 17 Apr 2020 14:58:31 +0000 (16:58 +0200)]
Product-only:
- heavy rewrite on (almost?) all admin-list-foo views, to use @ViewScoped beans
and working JSR107 caching
- also sorted out mixed usage of userController (or so?) as the login and
register backing beans can surely have their own properties
- rewrote web/WEB-INF/resources/tags/admin/dropdown/ to have it included back
in views again, was a bad idea
Roland Häder [Fri, 17 Apr 2020 14:54:20 +0000 (16:54 +0200)]
Please cherry-pick:
- heavy rewrite on (almost?) all admin-list-foo views, to use @ViewScoped beans
and working JSR107 caching
- also sorted out mixed usage of userController (or so?) as the login and
register backing beans can surely have their own properties
- rewrote web/WEB-INF/resources/tags/admin/dropdown/ to have it included back
in views again, was a bad idea
Roland Häder [Fri, 10 Apr 2020 19:38:06 +0000 (21:38 +0200)]
Please cherry-pick:
- WIP: rewrote admin-list-users view into ViewScoped
- added missing "global search" to it
- added initial p:dialog box to it
- also output userLastLock[Reason] and userMustChangePassword
- added/removed/renamed some i18n strings
- rewrote cache initialization to avoid a local List<Entity> copy
Roland Häder [Fri, 10 Apr 2020 04:13:21 +0000 (06:13 +0200)]
Please cherry-pick:
- updated PrimeFaces JAR from 6.2 to 8.0
- updated OmniFaces JAR from 2.7.2 to 2.7.3
- still OmniFaces causes a NPE in container startup
Roland Häder [Fri, 10 Apr 2020 04:12:46 +0000 (06:12 +0200)]
Don't cherry-pick:
- updated PrimeFaces 8.0 doesn't have pm:x around? Id references such as
":master:foo:bar" won't work then anymore, but "foo:bar" still does
Roland Häder [Fri, 10 Apr 2020 04:11:15 +0000 (06:11 +0200)]
Product-only:
- updated PrimeFaces 8.0 doesn't have pm:x around? Id references such as
":master:foo:bar" won't work then anymore, but "foo:bar" still does
Roland Häder [Fri, 10 Apr 2020 04:05:27 +0000 (06:05 +0200)]
Please cherry-pick:
- upgraded PrimeFaces to 8.0
- there is no more pm:x available in latest PrimeFaces, so ":master:foo:bar"
doesn't work but "foo:bar" does
- also the language selector may work now?
Roland Häder [Wed, 8 Apr 2020 18:59:27 +0000 (20:59 +0200)]
Don't cherry-pick:
- created "admin-receipt-action" controller for add/edit (later delete, too)
actions
- this change made the "admin-generic-receipt" controller empty for now, but
that is so far okay here.
- added admin-receipt-edit view
- reformatted p:panelGrid/p:outputLabel/p:inputText to have each attribute in a
separate line
- added missing i18n strings
Roland Häder [Wed, 8 Apr 2020 18:39:21 +0000 (20:39 +0200)]
Product-only:
- renamed adminGenericProductActionController.product ->
adminGenericProductActionController.currentProduct
- p:message is here not required as p:growl does the job nicely already
- reformatted p:outputLabel/p:inputText to have each attribute in separate line
Roland Häder [Wed, 8 Apr 2020 18:29:11 +0000 (20:29 +0200)]
Please cherry-pick:
- reformatted some p:outputLabel/p:inputText to have all attributes in single
line
- as jcoreee's showFacesMessage() methods require severity now, added
FacesMessage.SEVERITY_* to those method calls, strange that still it still
shows no effect? Where is the bug here?
Roland Häder [Thu, 2 Apr 2020 16:29:54 +0000 (18:29 +0200)]
Please cherry-pick:
- rewrote admin-headquarters-list to have filters and sorting (newer approach)
- added p:panelGrid around reset/submit buttons, still administrative contact
list is not being updated on record insert
- used beanHelper.renderEmployee() to render department leader (employee
instance again)
- fixed some wrong references due to last rewrite for departments
- added missing i18n key
Roland Häder [Thu, 2 Apr 2020 13:38:24 +0000 (15:38 +0200)]
Please cherry-pick:
- rewrote admin-departments-list view to have working filters and sorting
(wasn't done correctly)
- also included a "global" search (all columns)
- moved isDepartmentAlreadyAdded() to departmentListController to avoid getter
for allDepartments being exposed in interface
Roland Häder [Wed, 1 Apr 2020 18:24:20 +0000 (20:24 +0200)]
Please cherry-pick:
- rewrote admin-countries-list view to more modern approach with filters and
sorting
- rewrote many while(iterator) implementations to use for(item:List/Map.Entry)
instead
- added some missing i18n keys
Roland Häder [Wed, 1 Apr 2020 00:13:14 +0000 (02:13 +0200)]
Please cherry-pick:
- initialize BASIC_DATA_LIST_CONTROLLER (and others, too) only right before it
is needed.
- added contactUpdated to "admin-contacts-list" view
- contact usage (user/no user) is now pre-last column
- added missing i18n string
Roland Häder [Sun, 29 Mar 2020 22:33:19 +0000 (00:33 +0200)]
Please cherry-pick:
- was still using contactController.allContacts() should be
contactListController.allContacts as "allContacts" is a bean property now.
Roland Häder [Sun, 29 Mar 2020 21:58:10 +0000 (23:58 +0200)]
Please cherry-pick:
- rewrote to use DATA_ZIP_CODE only, other *_DATA_ZIP_CODE has been deleted
- continued a bit with details p:dialog (modal) box, still need to add all
fields, including for administrative list
Roland Häder [Sun, 29 Mar 2020 19:00:35 +0000 (21:00 +0200)]
Please cherry-pick/repeat:
- rewrote "contacts-list view" into modern approach, with filters and sorting
- in the progress a ViewScoped backing bean has been added which needs to
duplicated to all other projects, that handles "jcontacts-core data"
Roland Häder [Sat, 30 Nov 2019 01:13:44 +0000 (02:13 +0100)]
Don't cherry-pick:
- rewrote isReceiptItemAdded() as contains() didn't work as expected
- but still skip longer running code when contains() return true (same object)
Roland Häder [Sat, 5 Oct 2019 00:24:41 +0000 (02:24 +0200)]
Please cherry-pick:
- okay, that PaymentType is here in because other projects might (still) have it
- added TODOs.txt file with project management-related todos
Roland Häder [Fri, 12 Jul 2019 00:58:05 +0000 (02:58 +0200)]
Don't cherry-pick:
- converted single-line to multi-line for better readability
- added closeOnEscape="true" attribute to have p:dialog closing press on ESC key
Roland Häder [Fri, 12 Jul 2019 00:57:33 +0000 (02:57 +0200)]
Product-only:
- converted single-line to multi-line for better readability
- added closeOnEscape="true" attribute to have p:dialog closing press on ESC key
Roland Häder [Fri, 12 Jul 2019 00:55:20 +0000 (02:55 +0200)]
Please cherry-pick:
- converted single-line to multi-line for better readability
- added closeOnEscape="true" attribute to have p:dialog closing press on ESC key
Roland Häder [Wed, 12 Jun 2019 07:01:54 +0000 (09:01 +0200)]
Product-only:
- added barcode to administrative "list" view for products
- undone swapping out form to include (also later own JSF tags, sorry) as this
was a bad idea, it was then unsafe due to missing auto-completion
- fixed some UTF-8 encoding
- added missing i18n string(s)
Roland Häder [Wed, 12 Jun 2019 00:31:46 +0000 (02:31 +0200)]
Please cherry-pick:
- moved metadata (not for HTML, but for JSF engine) out of "first" facet block,
should not belong there?
- fixed some missing UTF-8 encodings
Roland Häder [Tue, 12 Mar 2019 13:16:24 +0000 (14:16 +0100)]
Don't cherry-pick:
- renamed more i18n strings to follow naming-convention
- rewrote p:link and p:column to have each attribute in separate line which
helps reading JSF views/templates
Roland Häder [Tue, 12 Mar 2019 13:08:51 +0000 (14:08 +0100)]
Please cherry-pick:
- rewrote p:column and p:link to have each attribute in a separate line which
helps reading JSF views/templates
- renamed ADMIN_ASSIGNED_USER_HEADER to ADMIN_USER_HEADER
- added more country i18n strings
Roland Häder [Mon, 28 Jan 2019 15:36:51 +0000 (16:36 +0100)]
Product-only:
- separated product-specific i18n keys to own files from project-specific
- converted some single-line JSF tags to multi-line to have each attribute in
a distinct line
Roland Häder [Sat, 22 Dec 2018 01:12:27 +0000 (02:12 +0100)]
Don't cherry-pick:
- used beanHelper.renderBasicData() instead of direct access to BasicData's
properties
- added 2nd parameter for beanHelper.renderBasicData()
- re-formatted JSF tag to have distinct lines for each attribute
Roland Häder [Sat, 22 Dec 2018 00:15:33 +0000 (01:15 +0100)]
Please cherry-pick:
- introduced 2nd parameter for beanHelper.renderBasicData() to include short or
long name in view components
- also use that method instead of invoking getter in same helper backing-bean
- re-aligned some JSF tags to have their attributes in distinct lines (easy to
add another)
Roland Häder [Thu, 20 Dec 2018 11:13:28 +0000 (12:13 +0100)]
Don't cherry-pick:
- converted single-line JSF tag to multi-line, having attributes in distinct
lines
- ID_NUMBER_HEADER is to long, just let us use ID_HEADER, allowing more space
for other columns
- removed spurious id attributes, thumb of a rule: only use them when really
needed and don't "over-id" everthing!
- removed no longer used i18n keys
Roland Häder [Thu, 20 Dec 2018 11:07:51 +0000 (12:07 +0100)]
Product-only:
- implemented allowDuplicates in product i18n key validator (default: FALSE)
- added it to product:genericProductForm tag (custom JSF tag)
- allowed "duplicates" in edit view, still the generic string validation applies)
- parentCategory is optional and must be set "manually" by setter
- removed clear() method (which sets NULL to all backing-bean fields/properties (?)
- realigned code a bit (createProductInstance())
Roland Häder [Thu, 13 Dec 2018 21:47:24 +0000 (22:47 +0100)]
Please cherry-pick:
- removed "id" where it is not explicitly needed
- removed process="@form" as later one hides a more serious bug (was wrong
scope)
- removed contenttype from f:view which makes rendering AJAX requests by
Primefaces trigger an exception
- rewrote single-line attributes to distinct lines (each attribute of a tag in
a separate line for better readability) in master.tpl
Roland Häder [Thu, 13 Dec 2018 21:40:35 +0000 (22:40 +0100)]
Product-only:
- converted ui:include template admin_form_product_data.tpl to custom JSF tag
product:genericProductForm
- introduced view-scoped action backing bean for Product entity which hold code
from request-scoped backing bean, this is required to have edit/delete/show
views working again
- removed beanProductHelper.product property and
notifyControllerProductConverted() in favor of copyAllProductProperties()
- renamed some language strings
Roland Häder [Thu, 13 Dec 2018 21:25:32 +0000 (22:25 +0100)]
Please cherry-pick:
- created validator for company's short name (BasicData entity)
- renamed email-address validator for branch office according to naming-convention
- removed "id" attribute from everywhere where it is not explicitly needed
- changed some single-line tags to multi-lines for better readability
- added companyShortName to view and backing bean
- it is now the default instead of companyName which is now fully optional
- also added method isCompanyShortNameUsed() to interface