Brion Vibber [Tue, 10 Nov 2009 16:23:24 +0000 (08:23 -0800)]
Adjusting indexes to make favorites query more efficient, based on feedback from ops.
fave_user_id_idx index changed from (user_id) to (user_id,modified), so the timestamp ordering can be done straight from the index while we're looking up the user's notices.
Added to 08to09.sql and 08to09_pg.sql; may need to be run manually by folks doing development.
(No harm if you don't update it, the favorites tab/rss feed will just stay inefficent.)
Brion Vibber [Tue, 10 Nov 2009 15:57:58 +0000 (07:57 -0800)]
Revert untested code; spews PHP notice warnings on every page view: "just sent a http 200 for the check-fancy from install.php"
Notice: Undefined index: p in /Library/WebServer/Documents/mublog/lib/common.php on line 41
Rebuild pot file *without* --join-existing to get rid of the cruft. Not sure why "--join-existing" must be in. Only thing I can think of is manual additions, which I could not find.
"SMS address" header here makes no sense; it would be inconsistent with the other tabs and headings on the same and related pages, and would look very awkward with another giant "SMS" right above it
Brion Vibber [Sun, 8 Nov 2009 22:22:13 +0000 (23:22 +0100)]
Revert "* check usage of 'people' in UI and change it to 'users' or something else in most places"
This reverts commit 81b4a381d9ddc71ed8a53c074ea10910882d3156.
IMO "user" is a bit impersonal and we shouldn't go changing the tone of the UI willy-nilly when we're updating localisations.
Evan Prodromou [Sun, 8 Nov 2009 22:04:46 +0000 (17:04 -0500)]
Restructure theme.php to define a class Theme
For various reasons, it's nicer to have a class for theme-file paths
and such. So, I've rewritten the code for determining the locations of
theme files to be more OOPy.
I changed all the uses of the two functions in the module (theme_file
and theme_path) to use Theme::file and Theme::path respectively.
I've also removed the code in common.php that require's the module;
using a class means we can autoload it instead.
Brion Vibber [Sun, 8 Nov 2009 13:33:22 +0000 (14:33 +0100)]
Fix bug 1962: deleteuser.php regression when OpenID plugin not enabled
The User_openid data object was explicitly listed as a related field to delete from in User::delete(); this class doesn't exist anymore by default since OpenID was broken out to a plugin.
Added UserDeleteRelated event for plugins to add related tables to delete from at user delete time.
Localisation updates from translatewiki.net
* found some duplication in the large "Commands:" messages. Manually removed from the pot file, and then updated. Have to ask someone if I can just rebuild the complete pot from scratch, or if --join-existing is always needed (and if so, why). File appears to contain at least some dirt.
Zach Copley [Sat, 7 Nov 2009 01:21:08 +0000 (17:21 -0800)]
Better workaround for PHP returning empty $_POST and $_FILES when
POST length > post_max_size in php.ini. I also added this check to
avatar upload, which was failing with huge files.
Brion Vibber [Fri, 6 Nov 2009 13:31:39 +0000 (14:31 +0100)]
console.php terminal script provides interactive PHP console in StatusNet environment, handy for testing!
Uses readline for line input editing if available; falls back to bash+readline if not native, and takes fgets() in worst case.
Currently a bit awkward in that each input line is parsed separately, so loops and function defs have to be squished to one line.
Brion Vibber [Fri, 6 Nov 2009 13:31:39 +0000 (14:31 +0100)]
console.php terminal script provides interactive PHP console in StatusNet environment, handy for testing!
Uses readline for line input editing if available; falls back to bash+readline if not native, and takes fgets() in worst case.
Currently a bit awkward in that each input line is parsed separately, so loops and function defs have to be squished to one line.