]> git.mxchange.org Git - friendica.git/log
friendica.git
6 years agoMerge pull request #5522 from Quix0r/fixes/portable-contact-empty-body
Michael Vogel [Mon, 30 Jul 2018 02:40:25 +0000 (04:40 +0200)]
Merge pull request #5522 from Quix0r/fixes/portable-contact-empty-body

Fixed fatal error about when returned 'body' field is empty

6 years agoFixed fatal error about when returned 'body' field is empty:
Roland Häder [Sun, 29 Jul 2018 15:34:20 +0000 (17:34 +0200)]
Fixed fatal error about when returned 'body' field is empty:

````
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Friendica\Protocol\PortableContact::discoverServer() must be of the type array, null given, called in /var/www/../src/Protocol/PortableContact.php on line 1664 and defined in /var/www/../src/Protocol/PortableContact.php:1765
Stack trace:
````

6 years agoMerge pull request #5519 from annando/test-2
Tobias Diekershoff [Sun, 29 Jul 2018 09:45:50 +0000 (11:45 +0200)]
Merge pull request #5519 from annando/test-2

Moved expiring of item content

6 years agoMerge pull request #5520 from annando/notices
Tobias Diekershoff [Sun, 29 Jul 2018 06:20:11 +0000 (08:20 +0200)]
Merge pull request #5520 from annando/notices

Some more notices removed

6 years agoAnd another notice removed
Michael [Sun, 29 Jul 2018 06:08:02 +0000 (06:08 +0000)]
And another notice removed

6 years agoRemoved some test logging
Michael [Sun, 29 Jul 2018 04:38:14 +0000 (04:38 +0000)]
Removed some test logging

6 years agoSome more notices removed
Michael [Sun, 29 Jul 2018 04:04:23 +0000 (04:04 +0000)]
Some more notices removed

6 years agoMoved expiring of item content
Michael [Sun, 29 Jul 2018 03:54:34 +0000 (03:54 +0000)]
Moved expiring of item content

6 years agoTrying to clean up a little bit more (#5517)
Michael Vogel [Sat, 28 Jul 2018 20:04:56 +0000 (22:04 +0200)]
Trying to clean up a little bit more (#5517)

* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* Post update now stores the permission set

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* The permission set is now removed upon expiry

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* Multiplicated update functions

* And some more duplicated functions ...

* Removed duplicate functions

6 years ago Fix for post update (#5513)
Michael Vogel [Sat, 28 Jul 2018 17:12:35 +0000 (19:12 +0200)]
 Fix for post update  (#5513)

* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* Fix for post update

6 years agoMissing stuff in "develop"? (#5516)
Michael Vogel [Sat, 28 Jul 2018 17:11:46 +0000 (19:11 +0200)]
Missing stuff in "develop"? (#5516)

* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* "post-type" replaces "bookmark" and "type"

* The permission set is now stored

* The permission set is now removed upon expiry

* Postupdate now handles "postopts" as well

6 years agoFix parse error in Protocol\PortableContact (#5515)
Hypolite Petovan [Sat, 28 Jul 2018 12:52:57 +0000 (08:52 -0400)]
Fix parse error in Protocol\PortableContact (#5515)

6 years agoPossible fix for #5470 - json_decode() (#5511)
Roland Häder [Sat, 28 Jul 2018 05:35:27 +0000 (07:35 +0200)]
Possible fix for #5470 - json_decode() (#5511)

* Possible fix for #5470:
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability

* Rewrite:
- mixture of object/array was here, causing under newer PHP versions some E_NOTICE
- this has been now finally fixed by converting any `object` type to an
  associative `array`
- also changed `is_object()` to `is_array()`

6 years agoMoved global PAGE_* to Profile class (#5500)
Roland Häder [Fri, 27 Jul 2018 23:25:57 +0000 (01:25 +0200)]
Moved global PAGE_* to Profile class (#5500)

* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class

* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*

* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`

* Ops, melting brain cells here ... :-/

6 years agoPostupdate is now working again (#5512)
Michael Vogel [Fri, 27 Jul 2018 23:24:26 +0000 (01:24 +0200)]
Postupdate is now working again (#5512)

* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

6 years agoMerge pull request #5509 from friendica/revert-5506-fixes/portable-contact
Michael Vogel [Fri, 27 Jul 2018 06:04:19 +0000 (08:04 +0200)]
Merge pull request #5509 from friendica/revert-5506-fixes/portable-contact

Revert "Possible fix for #5470 and empty() usage"

6 years agoRevert "Possible fix for #5470: (#5506)"
Michael Vogel [Fri, 27 Jul 2018 06:02:41 +0000 (08:02 +0200)]
Revert "Possible fix for #5470: (#5506)"

This reverts commit 1e20fd84f7e942c9cce8c1fbdecf6ec73b4c8a43.

6 years agoRevert "Continued: (#5508)"
Michael Vogel [Fri, 27 Jul 2018 06:02:41 +0000 (08:02 +0200)]
Revert "Continued: (#5508)"

This reverts commit 592190892c17ab61cce132dee1a4a2020575b180.

6 years agoContinued: (#5508)
Roland Häder [Fri, 27 Jul 2018 02:27:28 +0000 (04:27 +0200)]
Continued: (#5508)

- `App` is now "imported" to avoid having \Friendica\App::* everywhere

6 years agoPossible fix for #5470: (#5506)
Roland Häder [Thu, 26 Jul 2018 22:27:12 +0000 (00:27 +0200)]
Possible fix for #5470: (#5506)

- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability

6 years ago[frio] Fix wrongly removed content wrapper and fix CSS instead. (#5496) (#5505)
Andreas Neustifter [Thu, 26 Jul 2018 15:42:26 +0000 (17:42 +0200)]
[frio] Fix wrongly removed content wrapper and fix CSS instead. (#5496) (#5505)

6 years agoItem storage: Permissions aren't stored in the items anymore (#5495)
Michael Vogel [Wed, 25 Jul 2018 23:14:55 +0000 (01:14 +0200)]
Item storage: Permissions aren't stored in the items anymore (#5495)

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

6 years ago[frio] Remove frame around recent photos. (#5496) (#5499)
Andreas Neustifter [Wed, 25 Jul 2018 20:21:43 +0000 (22:21 +0200)]
[frio] Remove frame around recent photos. (#5496) (#5499)

Also layout file properly.

6 years ago[frio] Fix layout of profile aside. (#5497) (#5498)
Andreas Neustifter [Wed, 25 Jul 2018 20:12:30 +0000 (22:12 +0200)]
[frio] Fix layout of profile aside. (#5497) (#5498)

See issue (#5497)[https://github.com/friendica/friendica/issues/5497] for details.

6 years agoBugfix: Session handling hadn't been initialized (#5493)
Michael Vogel [Wed, 25 Jul 2018 14:25:40 +0000 (16:25 +0200)]
Bugfix: Session handling hadn't been initialized (#5493)

6 years agoMerge pull request #5491 from tobiasd/20180725-issue1391
Michael Vogel [Wed, 25 Jul 2018 09:18:01 +0000 (11:18 +0200)]
Merge pull request #5491 from tobiasd/20180725-issue1391

Make profile settings available in the user settings

6 years agoadd accesskey to the docs
Tobias Diekershoff [Wed, 25 Jul 2018 07:39:26 +0000 (09:39 +0200)]
add accesskey to the docs

6 years agoMake profile settings available in the user settings
Tobias Diekershoff [Wed, 25 Jul 2018 07:37:08 +0000 (09:37 +0200)]
Make profile settings available in the user settings

6 years agoFixes/rewrites on videos.php (#5489)
Roland Häder [Wed, 25 Jul 2018 02:54:00 +0000 (04:54 +0200)]
Fixes/rewrites on videos.php (#5489)

* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability

* CR request:
- removed stray spaces
- added some where they improve readability

6 years agoMoved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespac...
Roland Häder [Wed, 25 Jul 2018 02:53:46 +0000 (04:53 +0200)]
Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace (#5490)

* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)

6 years agoRemoval of x() and added missing columns of contact (#5479)
Roland Häder [Tue, 24 Jul 2018 21:48:47 +0000 (23:48 +0200)]
Removal of x() and added missing columns of contact (#5479)

* Fixes:
- got rid of x() in whole mod/item.php file
- added missing 'prv' and 'forum' columns, maybe one day, let's rewrite this
  again. it is kinda a maintenance nightmare, keeping up with column renames and
  such. Well, for now it should be okay.

* Should be DBA::isResult()

6 years agoFallback to Diaspora if DFRN transmission fails (#5487)
Michael Vogel [Tue, 24 Jul 2018 18:12:09 +0000 (20:12 +0200)]
Fallback to Diaspora if DFRN transmission fails (#5487)

6 years agoMerge pull request #5452 from MrPetovan/bug/5443-fix-worker-notices
Michael Vogel [Tue, 24 Jul 2018 15:11:53 +0000 (17:11 +0200)]
Merge pull request #5452 from MrPetovan/bug/5443-fix-worker-notices

Fix notices in OEmbed et al.

6 years agoReduce cache time for OEmbed error
Hypolite Petovan [Tue, 24 Jul 2018 15:05:09 +0000 (11:05 -0400)]
Reduce cache time for OEmbed error

6 years ago[frio] Fix profile edit links. [#5474] (#5475)
Andreas Neustifter [Tue, 24 Jul 2018 14:20:16 +0000 (16:20 +0200)]
[frio] Fix profile edit links. [#5474] (#5475)

6 years agoStore guid and plink with event (#5485)
Michael Vogel [Tue, 24 Jul 2018 14:01:31 +0000 (16:01 +0200)]
Store guid and plink with event (#5485)

* Store guid and plink with event

* One space too much

6 years agoMove addLanguageToItemArray call when body is ensured
Hypolite Petovan [Tue, 24 Jul 2018 12:52:25 +0000 (08:52 -0400)]
Move addLanguageToItemArray call when body is ensured

6 years agoAdded bootstrap tables to queues (#5484)
Jeroen De Meerleer [Tue, 24 Jul 2018 12:10:20 +0000 (14:10 +0200)]
Added bootstrap tables to queues (#5484)

* Added bootstrap tables to queues

* Changed to double quotes

6 years agoFix undefined oembed properties
Hypolite Petovan [Sun, 22 Jul 2018 17:01:53 +0000 (13:01 -0400)]
Fix undefined oembed properties

- Add Object\OEmbed class

6 years agoFix Undefined index: nurl in Protocol\PortableContact
Hypolite Petovan [Sun, 22 Jul 2018 16:50:13 +0000 (12:50 -0400)]
Fix Undefined index: nurl in Protocol\PortableContact

6 years agoFix by reference notice in Protocol\PortableContact
Hypolite Petovan [Sun, 22 Jul 2018 16:45:24 +0000 (12:45 -0400)]
Fix by reference notice in Protocol\PortableContact

6 years agoFix undefined index body in Model\Item
Hypolite Petovan [Sun, 22 Jul 2018 16:41:48 +0000 (12:41 -0400)]
Fix undefined index body in Model\Item

6 years agoFix getimagesizefromstring() read errors
Hypolite Petovan [Sun, 22 Jul 2018 16:38:53 +0000 (12:38 -0400)]
Fix getimagesizefromstring() read errors

6 years agoSome removed notices when viewing events (#5483)
Michael Vogel [Tue, 24 Jul 2018 11:51:50 +0000 (13:51 +0200)]
Some removed notices when viewing events (#5483)

6 years agoFixes for E_NOTICE in editpost.php (#5480)
Roland Häder [Tue, 24 Jul 2018 11:47:25 +0000 (13:47 +0200)]
Fixes for E_NOTICE in editpost.php (#5480)

* Added missing columns 'wall' and 'post-type'.

* Convention:
- curly brace after a a method/function declaration belongs to next line
- added space for better readability

6 years agoMerge pull request #5482 from annando/issue-5467a
Tobias Diekershoff [Tue, 24 Jul 2018 06:57:28 +0000 (08:57 +0200)]
Merge pull request #5482 from annando/issue-5467a

Issue 5467: Cron jobs hadn't been executed

6 years agoIssue 5467: Cron jobs hadn't been executed
Michael [Tue, 24 Jul 2018 06:15:58 +0000 (06:15 +0000)]
Issue 5467: Cron jobs hadn't been executed

6 years agoMerge pull request #5481 from annando/issue-5467
Tobias Diekershoff [Tue, 24 Jul 2018 04:27:05 +0000 (06:27 +0200)]
Merge pull request #5481 from annando/issue-5467

Issue 5467: Fix worker and daemon

6 years agoSome code cleanup
Michael [Tue, 24 Jul 2018 04:15:19 +0000 (04:15 +0000)]
Some code cleanup

6 years agoIssue 5467: Fix worker and daemon
Michael [Tue, 24 Jul 2018 03:42:44 +0000 (03:42 +0000)]
Issue 5467: Fix worker and daemon

6 years agoMerge pull request #5478 from MrPetovan/task/5410-add-missing-use-statements
Michael Vogel [Tue, 24 Jul 2018 01:57:20 +0000 (03:57 +0200)]
Merge pull request #5478 from MrPetovan/task/5410-add-missing-use-statements

Add missing use statements after dbesc conversion

6 years agoFixes: (#5477)
Roland Häder [Mon, 23 Jul 2018 22:52:48 +0000 (00:52 +0200)]
Fixes: (#5477)
- use DBA::isResult() and not count()
- fixed 4 E_NOTICE when POST fields are not set

6 years agoAvoid no needed call on parse2str() when there is nothing to parse (#5476)
Roland Häder [Mon, 23 Jul 2018 22:52:07 +0000 (00:52 +0200)]
Avoid no needed call on parse2str() when there is nothing to parse (#5476)

6 years agoAd missing use statements after dbesc conversion
Hypolite Petovan [Mon, 23 Jul 2018 22:44:05 +0000 (18:44 -0400)]
Ad missing use statements after dbesc conversion

6 years agoMerge pull request #5439 from MrPetovan/task/5410-remove-dbesc
Michael Vogel [Mon, 23 Jul 2018 19:51:49 +0000 (21:51 +0200)]
Merge pull request #5439 from MrPetovan/task/5410-remove-dbesc

Move DBA to src/ part 4.1: Remove dbesc()

6 years agoAdded true to json_decode (#5471)
Jeroen De Meerleer [Mon, 23 Jul 2018 19:51:08 +0000 (21:51 +0200)]
Added true to json_decode (#5471)

6 years agoRemove dbesc() and dba_timer() function declarations
Hypolite Petovan [Sat, 21 Jul 2018 13:17:10 +0000 (09:17 -0400)]
Remove dbesc() and dba_timer() function declarations

6 years agoRename dbesc to DBA::escape
Hypolite Petovan [Sat, 21 Jul 2018 13:10:13 +0000 (09:10 -0400)]
Rename dbesc to DBA::escape

6 years agoUpdate DBA::escape to match dbesc()
Hypolite Petovan [Sat, 21 Jul 2018 13:07:20 +0000 (09:07 -0400)]
Update DBA::escape to match dbesc()

6 years agoMerge pull request #5438 from MrPetovan/task/5410-remove-dbm-class
Michael Vogel [Mon, 23 Jul 2018 19:05:32 +0000 (21:05 +0200)]
Merge pull request #5438 from MrPetovan/task/5410-remove-dbm-class

Move DBA to src/ part 3.2: Remove DBM class

6 years agoDelete Database\DBM class file
Hypolite Petovan [Sat, 21 Jul 2018 12:49:18 +0000 (08:49 -0400)]
Delete Database\DBM class file

6 years agoRename DBA::esc_array to DBA::escapeArray
Hypolite Petovan [Sat, 21 Jul 2018 12:48:29 +0000 (08:48 -0400)]
Rename DBA::esc_array to DBA::escapeArray

- Rename internal method DBA::esc_array_callback to
DBA::escapeArrayCallback

6 years agoRename DBA::is_result to DBA::isResult
Hypolite Petovan [Sat, 21 Jul 2018 12:46:04 +0000 (08:46 -0400)]
Rename DBA::is_result to DBA::isResult

6 years agoRename DBM method calls to DBA method calls
Hypolite Petovan [Sat, 21 Jul 2018 12:40:21 +0000 (08:40 -0400)]
Rename DBM method calls to DBA method calls

6 years agoUse DateTimeFormat::utc() instead of DBM::date()
Hypolite Petovan [Sat, 21 Jul 2018 12:25:11 +0000 (08:25 -0400)]
Use DateTimeFormat::utc() instead of DBM::date()

6 years agoAdd Database\DBM methods to Database\DBA
Hypolite Petovan [Sat, 21 Jul 2018 12:21:23 +0000 (08:21 -0400)]
Add Database\DBM methods to Database\DBA

6 years agoAdd missing space between PHP path and script in App->proc_run (#5468)
Hypolite Petovan [Mon, 23 Jul 2018 14:43:39 +0000 (10:43 -0400)]
Add missing space between PHP path and script in App->proc_run (#5468)

6 years agoMerge pull request #5431 from MrPetovan/task/5410-rename-database-methods
Michael Vogel [Mon, 23 Jul 2018 13:18:58 +0000 (15:18 +0200)]
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods

Move DBA to src/ part 3.1: Rename DBA methods

6 years agoFix Fatal errors in Protocol\OStatus (#5466)
Hypolite Petovan [Mon, 23 Jul 2018 11:48:44 +0000 (07:48 -0400)]
Fix Fatal errors in Protocol\OStatus (#5466)

6 years agoAnd some more removed notices in the core (#5465)
Michael Vogel [Mon, 23 Jul 2018 11:43:18 +0000 (13:43 +0200)]
And some more removed notices in the core (#5465)

6 years agoUsing getopt for CLI arguments (#5446)
Philipp [Mon, 23 Jul 2018 11:40:52 +0000 (13:40 +0200)]
Using getopt for CLI arguments (#5446)

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* fixing arguments for `spawnWorker`

* Adding `use Friendica\BaseObject` to `ApiTest.php`

* Refactoring the argument-usages of Friendica

* Refactoring the argument-usages of Friendica

* removing superfluous []

6 years agoCleaned up: (#5461)
Roland Häder [Mon, 23 Jul 2018 01:19:28 +0000 (03:19 +0200)]
Cleaned up: (#5461)

- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)

6 years agoCleanup: (#5463)
Roland Häder [Mon, 23 Jul 2018 01:18:21 +0000 (03:18 +0200)]
Cleanup: (#5463)

- rewrote x() to empty() as it is deprecated
- fixed indending for some entries

6 years agoFixes: (#5462)
Roland Häder [Mon, 23 Jul 2018 01:17:44 +0000 (03:17 +0200)]
Fixes: (#5462)
- fixed E_NOTICE about missing array element "page-flags-raw" (should be
  "page_flags_raw"?)
- same with account-type-raw -> account_type_raw
- added spaces to nicely indent code

6 years agoPrevents 4 E_NOTICEs when POST fields are not set. (#5458)
Roland Häder [Sun, 22 Jul 2018 23:49:16 +0000 (01:49 +0200)]
Prevents 4 E_NOTICEs when POST fields are not set. (#5458)

* Prevents 4 E_NOTICEs when POST fields are not set.

* Don't use x().

* Replaced usage of x() which is deprecated with !isset().

* Use empty() according to MrPetovan

6 years agoRename DBA::get_db to DBA::getConnection
Hypolite Petovan [Sat, 21 Jul 2018 02:11:11 +0000 (22:11 -0400)]
Rename DBA::get_db to DBA::getConnection

- Rename DBA::$db to DBA::$connection

6 years agoRename DBA::num_rows to DBA::numRows
Hypolite Petovan [Sat, 21 Jul 2018 02:05:12 +0000 (22:05 -0400)]
Rename DBA::num_rows to DBA::numRows

6 years agoRename DBA::server_info to DBA::serverInfo
Hypolite Petovan [Sat, 21 Jul 2018 02:04:43 +0000 (22:04 -0400)]
Rename DBA::server_info to DBA::serverInfo

6 years agoRename DBA::inArray to DBA::toArray
Hypolite Petovan [Sat, 21 Jul 2018 02:03:40 +0000 (22:03 -0400)]
Rename DBA::inArray to DBA::toArray

6 years agoRename DBA::fetch_first to DBA::fetchFirst
Hypolite Petovan [Sat, 21 Jul 2018 02:01:53 +0000 (22:01 -0400)]
Rename DBA::fetch_first to DBA::fetchFirst

6 years agoRename DBA::database_name to DBA::databaseName
Hypolite Petovan [Sat, 21 Jul 2018 02:00:16 +0000 (22:00 -0400)]
Rename DBA::database_name to DBA::databaseName

6 years agoRename DBA::clean_query to DBA::cleanQuery
Hypolite Petovan [Sat, 21 Jul 2018 01:59:17 +0000 (21:59 -0400)]
Rename DBA::clean_query to DBA::cleanQuery

6 years agoRename DBA::any_value_fallback to DBA::anyValueFallback
Hypolite Petovan [Sat, 21 Jul 2018 01:58:30 +0000 (21:58 -0400)]
Rename DBA::any_value_fallback to DBA::anyValueFallback

6 years agoRename DBA::affected_rows to DBA::affectedRows
Hypolite Petovan [Sat, 21 Jul 2018 01:58:15 +0000 (21:58 -0400)]
Rename DBA::affected_rows to DBA::affectedRows

6 years agoNeed to load "verb" from notify table, too. This whole thing is a maintenance (#5459)
Roland Häder [Sun, 22 Jul 2018 23:25:07 +0000 (01:25 +0200)]
Need to load "verb" from notify table, too. This whole thing is a maintenance (#5459)

nightmare. Let's use the new database frontend/backend system and load all
columns anywhere the "entity" is requested.

6 years agoFix Fatal error in Protocol\Diaspora (#5460)
Hypolite Petovan [Sun, 22 Jul 2018 23:22:41 +0000 (19:22 -0400)]
Fix Fatal error in Protocol\Diaspora (#5460)

6 years agoFixed E_NOTICE when no valid result has been returned. (#5457)
Roland Häder [Sun, 22 Jul 2018 22:05:10 +0000 (00:05 +0200)]
Fixed E_NOTICE when no valid result has been returned. (#5457)

6 years agoFixed E_NOTICEs when uploading profile picture (#5456)
Roland Häder [Sun, 22 Jul 2018 20:01:14 +0000 (22:01 +0200)]
Fixed E_NOTICEs when uploading profile picture (#5456)

* Fixed E_NOTICEs when uploading profile picture.

* Fixed E_NOTICEs when $_POST doesn't contain these fields.

6 years agoUncommon logger levels in Friendica (#5453)
Roland Häder [Sun, 22 Jul 2018 18:07:44 +0000 (20:07 +0200)]
Uncommon logger levels in Friendica (#5453)

* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)

* Used constants instead of values (MrPetovan)

6 years agoFix yet another Fatal Error in Protocol\OStatus (#5454)
Hypolite Petovan [Sun, 22 Jul 2018 17:32:34 +0000 (13:32 -0400)]
Fix yet another Fatal Error in Protocol\OStatus (#5454)

6 years ago Fix another Fatal error in Protocol\OStatus (#5451)
Hypolite Petovan [Sun, 22 Jul 2018 16:57:33 +0000 (12:57 -0400)]
 Fix another Fatal error in Protocol\OStatus (#5451)

* Fix Fatal error in Protocol\OStatus

* Fix another Fatal error in Protocol\OStatus

6 years agoFixed E_NOTICE in boot.php and DBA class (#5430)
Roland Häder [Sun, 22 Jul 2018 16:53:46 +0000 (18:53 +0200)]
Fixed E_NOTICE in boot.php and DBA class (#5430)

* Fixes:
- fixed missing variable $port (MySQL: 3306)
- "imported" mysqli class

Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed:
- better use `false` and `$port > 0`

* And better only provide `$port` when larger zero.

* Initialize `$port` with zero value (int) and not `false` (bool).

* Removed duplicate mysqli "import".

* `$post_update` is no longer used. Instead `$prefix` needs to be checked.

6 years agoFix Fatal error in Protocol\OStatus (#5450)
Hypolite Petovan [Sun, 22 Jul 2018 16:52:38 +0000 (12:52 -0400)]
Fix Fatal error in Protocol\OStatus (#5450)

6 years agoFixes/tye-hints (#5449)
Roland Häder [Sun, 22 Jul 2018 16:35:20 +0000 (18:35 +0200)]
Fixes/tye-hints (#5449)

- added type-hints for DOMDocument, DOMXPath and array
- added missing documentation about optional parameter
- `if ($foo['bar'])` is not a good choice, better use
  `if (!empty($foo['bar']))` instead

6 years agoThere is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either (...
Roland Häder [Sun, 22 Jul 2018 16:33:28 +0000 (18:33 +0200)]
There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either (#5448)

declare it and push all other numbers higher or use LOGGER_NORMAL.

6 years agoFixes: (#5447)
Roland Häder [Sun, 22 Jul 2018 16:28:39 +0000 (18:28 +0200)]
Fixes: (#5447)
- rewrote to first check if PID file is readable, then if found load it
- next addition is to cast it's content to int. Any non-integer content will
  result in 0 (as I know).
- Give warnings a voice! (xdebug's scream option showed a warning)
- added some spaces for better readability

6 years agoAdded a for-loop (#5442)
Jeroen De Meerleer [Sat, 21 Jul 2018 21:29:39 +0000 (23:29 +0200)]
Added a for-loop (#5442)

* Using json_decode instead of reinventing hot water

Guys, you could have told me ;)

* changed spaces to tabs

* Guess I'll need a beer ;)

6 years agoWorker-details: Using json_decode instead of reinventing hot water (#5441)
Jeroen De Meerleer [Sat, 21 Jul 2018 17:24:03 +0000 (19:24 +0200)]
Worker-details: Using json_decode instead of reinventing hot water (#5441)

* Using json_decode instead of reinventing hot water

Guys, you could have told me ;)

* changed spaces to tabs

6 years agoDBStructure enhancements (#5437)
Philipp [Sat, 21 Jul 2018 12:43:43 +0000 (14:43 +0200)]
DBStructure enhancements (#5437)

* Adding DBStructure enhancements

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 4ae06ec)

* Adding `pre_update_1279` method

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 8496d84)

* code standards

(cherry picked from commit 551d09b)

* simplify to `empty` instead `is_null`

(cherry picked from commit ce68835)

6 years agoMake frio more consistent by replacing textual links with icons everywhere. (#5415)
Andreas Neustifter [Sat, 21 Jul 2018 11:31:05 +0000 (13:31 +0200)]
Make frio more consistent by replacing textual links with icons everywhere. (#5415)

* Make frio more consistent by replacing textual links with icons everywhere I could find them.

* [frio] Move profile add link to icon.