]> git.mxchange.org Git - friendica.git/log
friendica.git
3 years agoRelocate system user creation
Michael [Wed, 18 Nov 2020 05:33:17 +0000 (05:33 +0000)]
Relocate system user creation

3 years agoEnsure to never delete the "0" user
Michael [Wed, 18 Nov 2020 05:24:04 +0000 (05:24 +0000)]
Ensure to never delete the "0" user

3 years agoTest: only insert empty user
Michael [Wed, 18 Nov 2020 05:04:17 +0000 (05:04 +0000)]
Test: only insert empty user

3 years agoNo "not null"
Michael [Wed, 18 Nov 2020 00:31:05 +0000 (00:31 +0000)]
No "not null"

3 years agoAvoid foreign key problem
Michael [Wed, 18 Nov 2020 00:24:38 +0000 (00:24 +0000)]
Avoid foreign key problem

3 years agoChanged order of inserts
Michael [Wed, 18 Nov 2020 00:13:39 +0000 (00:13 +0000)]
Changed order of inserts

3 years agoFix condition
Michael [Tue, 17 Nov 2020 23:59:14 +0000 (23:59 +0000)]
Fix condition

3 years agoChanged order
Michael [Tue, 17 Nov 2020 23:45:16 +0000 (23:45 +0000)]
Changed order

3 years agoMerge remote-tracking branch 'upstream/develop' into post-user
Michael [Tue, 17 Nov 2020 23:31:41 +0000 (23:31 +0000)]
Merge remote-tracking branch 'upstream/develop' into post-user

3 years agoMerge pull request #9543 from MrPetovan/bug/notices
Michael Vogel [Tue, 17 Nov 2020 23:30:31 +0000 (00:30 +0100)]
Merge pull request #9543 from MrPetovan/bug/notices

Address several notices

3 years agoMerge pull request #9540 from MrPetovan/bug/9538-security-blind-attack-username
Michael Vogel [Tue, 17 Nov 2020 23:20:43 +0000 (00:20 +0100)]
Merge pull request #9540 from MrPetovan/bug/9538-security-blind-attack-username

Escape contact names in several HTML snippets/jQuery insert contexts

3 years agoSuppress notice when causer-id exists but not causer-link in Model\Item::isAllowedByUser
Hypolite Petovan [Tue, 17 Nov 2020 23:06:16 +0000 (18:06 -0500)]
Suppress notice when causer-id exists but not causer-link in Model\Item::isAllowedByUser

- Address https://github.com/friendica/friendica/issues/9252#issuecomment-723440980

3 years agoImprove expectation for not modified check in theme/vier/style
Hypolite Petovan [Tue, 17 Nov 2020 23:01:03 +0000 (18:01 -0500)]
Improve expectation for not modified check in theme/vier/style

- Address https://github.com/friendica/friendica/issues/9252#issuecomment-721994406

3 years agoUse correct contact key in Protocol\ActivityPub\Transmitter
Hypolite Petovan [Tue, 17 Nov 2020 22:59:39 +0000 (17:59 -0500)]
Use correct contact key in Protocol\ActivityPub\Transmitter

- Address https://github.com/friendica/friendica/issues/9252#issuecomment-719866843

3 years agoSuppress notice while logging in Model\Contact
Hypolite Petovan [Tue, 17 Nov 2020 22:57:37 +0000 (17:57 -0500)]
Suppress notice while logging in Model\Contact

- Address https://github.com/friendica/friendica/issues/9252#issuecomment-716042132

3 years agoRemove top-level parent check from Protocol\OStatus
Hypolite Petovan [Tue, 17 Nov 2020 22:53:03 +0000 (17:53 -0500)]
Remove top-level parent check from Protocol\OStatus

- It's done in Item::insert instead
- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051

3 years agoRemove superfluous mentions of parent-uri in Protocol\Diaspora
Hypolite Petovan [Tue, 17 Nov 2020 22:52:30 +0000 (17:52 -0500)]
Remove superfluous mentions of parent-uri in Protocol\Diaspora

- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051

3 years agoMoved table definition
Michael [Tue, 17 Nov 2020 22:49:55 +0000 (22:49 +0000)]
Moved table definition

3 years agoImproved logging
Michael [Tue, 17 Nov 2020 22:41:53 +0000 (22:41 +0000)]
Improved logging

3 years agoRemoved test logging
Michael [Tue, 17 Nov 2020 22:38:52 +0000 (22:38 +0000)]
Removed test logging

3 years agoNew table "post-user" and more foreign keys
Michael [Tue, 17 Nov 2020 22:33:44 +0000 (22:33 +0000)]
New table "post-user" and more foreign keys

3 years agoEscape user name in introduction fields help text
Hypolite Petovan [Mon, 16 Nov 2020 23:18:11 +0000 (18:18 -0500)]
Escape user name in introduction fields help text

- HTML help text aren't escaped in the template

# Conflicts:
# src/Module/Notifications/Introductions.php

3 years agoEscape user names in notifications
Hypolite Petovan [Mon, 16 Nov 2020 23:17:24 +0000 (18:17 -0500)]
Escape user names in notifications

- The HTML notification message interpolation is unfiltered by the template

# Conflicts:
# mod/ping.php

3 years agoReplace JQuery .text by .html
Hypolite Petovan [Mon, 16 Nov 2020 23:16:20 +0000 (18:16 -0500)]
Replace JQuery .text by .html

- Prevents inserting unescaped HTML in page

3 years agoMerge pull request #9537 from annando/item-lock
Hypolite Petovan [Mon, 16 Nov 2020 21:05:24 +0000 (16:05 -0500)]
Merge pull request #9537 from annando/item-lock

Fallback to database lock if locking fails

3 years agoFallback to database lock if locking fails
Michael [Mon, 16 Nov 2020 19:46:20 +0000 (19:46 +0000)]
Fallback to database lock if locking fails

3 years agoMerge pull request #9535 from annando/ap-relay
Hypolite Petovan [Mon, 16 Nov 2020 01:27:08 +0000 (20:27 -0500)]
Merge pull request #9535 from annando/ap-relay

Relay code reworked to support AP delivery

3 years agoRelay code reworked to support AP delivery
Michael [Sun, 15 Nov 2020 23:28:05 +0000 (23:28 +0000)]
Relay code reworked to support AP delivery

3 years agoMerge pull request #9515 from MrPetovan/task/9464-block-replies
Michael Vogel [Sun, 15 Nov 2020 17:44:48 +0000 (18:44 +0100)]
Merge pull request #9515 from MrPetovan/task/9464-block-replies

Reject replies when author is blocked by thread owner

3 years agoUpdate database.sql with the latest structure changes
Hypolite Petovan [Sun, 15 Nov 2020 16:42:46 +0000 (11:42 -0500)]
Update database.sql with the latest structure changes

3 years agoMerge pull request #9534 from MrPetovan/bug/smilies-image-description
Michael Vogel [Sun, 15 Nov 2020 06:21:27 +0000 (07:21 +0100)]
Merge pull request #9534 from MrPetovan/bug/smilies-image-description

Prevent image descriptions from being replaced by local smilies

3 years agoPrevent image descriptions from being replaced by local smilies
Hypolite Petovan [Sun, 15 Nov 2020 05:12:26 +0000 (00:12 -0500)]
Prevent image descriptions from being replaced by local smilies

- AP-received emojis have their code in the image description

3 years agoMove top-level permission check outside of Model\Item::getTopLevelParentData
Hypolite Petovan [Sat, 14 Nov 2020 12:41:01 +0000 (07:41 -0500)]
Move top-level permission check outside of Model\Item::getTopLevelParentData

- It wasn't checked when the direct parent was also the top-level parent

3 years agoRetrieve local top level parent item separately to check permissions in Model\Item...
Hypolite Petovan [Sat, 14 Nov 2020 04:56:19 +0000 (23:56 -0500)]
Retrieve local top level parent item separately to check permissions in Model\Item::getTopLevelParentData

3 years ago[Database version 1375] Add update method to populate missing item.thr-parent values
Hypolite Petovan [Fri, 13 Nov 2020 10:05:52 +0000 (05:05 -0500)]
[Database version 1375] Add update method to populate missing item.thr-parent values

3 years agoRevert wrong item.thr-parent field usage in Protocol\OStatus
Hypolite Petovan [Fri, 13 Nov 2020 10:01:29 +0000 (05:01 -0500)]
Revert wrong item.thr-parent field usage in Protocol\OStatus

3 years agoRemove unnecessary data array assignment in Protocol\Feed
Hypolite Petovan [Fri, 13 Nov 2020 10:00:52 +0000 (05:00 -0500)]
Remove unnecessary data array assignment in Protocol\Feed

3 years agoClarify parameter type in DFRN::mail
Hypolite Petovan [Fri, 13 Nov 2020 10:00:31 +0000 (05:00 -0500)]
Clarify parameter type in DFRN::mail

3 years agoRemove references to item.parent-uri in Worker\OnePoll
Hypolite Petovan [Fri, 13 Nov 2020 09:54:01 +0000 (04:54 -0500)]
Remove references to item.parent-uri in Worker\OnePoll

3 years agoEnsure the parent field isn't set during Item insertion
Hypolite Petovan [Thu, 12 Nov 2020 15:23:50 +0000 (10:23 -0500)]
Ensure the parent field isn't set during Item insertion

- Avoid a database error if a null value is provided

3 years agoFix null value for item.parent column
Hypolite Petovan [Thu, 12 Nov 2020 14:29:37 +0000 (09:29 -0500)]
Fix null value for item.parent column

3 years agoFix wrong variable use in Model\Item::getTopLevelParent
Hypolite Petovan [Thu, 12 Nov 2020 03:59:57 +0000 (22:59 -0500)]
Fix wrong variable use in Model\Item::getTopLevelParent

- It was preventing items at levels 3 and beyond to be inserted
- Logging for missing top level parent has been bumped to notice

3 years agoSeparate $parent_item and $toplevel_item in mod/item
Hypolite Petovan [Thu, 12 Nov 2020 03:58:34 +0000 (22:58 -0500)]
Separate $parent_item and $toplevel_item in mod/item

3 years agoReplace uri fields conditions by gravity condition in Model\Item::insert
Hypolite Petovan [Wed, 11 Nov 2020 15:07:39 +0000 (10:07 -0500)]
Replace uri fields conditions by gravity condition in Model\Item::insert

3 years agoReject replies when author is blocked by thread owner in Model\Item::insert
Hypolite Petovan [Wed, 11 Nov 2020 07:50:22 +0000 (02:50 -0500)]
Reject replies when author is blocked by thread owner in Model\Item::insert

- Move user-level item permission to Model\Item::isAllowedByUser
- Add user-level check for comments on top-level item

3 years agoClarify item.parent-uri use in database field comment
Hypolite Petovan [Wed, 11 Nov 2020 07:48:52 +0000 (02:48 -0500)]
Clarify item.parent-uri use in database field comment

3 years agoReplace confusing uses of item.parent-uri with expected item.thr-parent
Hypolite Petovan [Wed, 11 Nov 2020 07:47:48 +0000 (02:47 -0500)]
Replace confusing uses of item.parent-uri with expected item.thr-parent

3 years agoRemove obsolete references to item.parent-uri
Hypolite Petovan [Mon, 9 Nov 2020 16:13:18 +0000 (11:13 -0500)]
Remove obsolete references to item.parent-uri

3 years agoUse item.thr-parent as expected in Model\Item::insert()
Hypolite Petovan [Wed, 11 Nov 2020 07:44:43 +0000 (02:44 -0500)]
Use item.thr-parent as expected in Model\Item::insert()

- Rework Model\Item::getTopLevelParent
- Backward compatibility with item.parent-uri is ensured

3 years agoMerge pull request #9532 from Quix0r/fixes/pconfig-k-cat-varchar
Hypolite Petovan [Sat, 14 Nov 2020 15:03:22 +0000 (10:03 -0500)]
Merge pull request #9532 from Quix0r/fixes/pconfig-k-cat-varchar

Some fixes: not needed varbinary and missing UPDATE::SUCCESS

3 years agoOps!
Roland Häder [Sat, 14 Nov 2020 14:50:24 +0000 (15:50 +0100)]
Ops!

Signed-off-by: Roland Häder <roland@mxchange.org>
3 years agoSome fixes:
Roland Häder [Sat, 14 Nov 2020 14:22:56 +0000 (15:22 +0100)]
Some fixes:
- varbinary() is not needed when clear-text words like 'xmpp' are used for them,
  it also hinders using external tools like Adminer/phpMyAdmin to search for
  them as e.g. Adminer wraps a HEX() call (SQL) around `k` and `cat` (see table
  `pconfig`)
- added missing UPDATE::SUCCESS

Signed-off-by: Roland Häder <roland@mxchange.org>
3 years agoMerge pull request #9531 from annando/fatal
Hypolite Petovan [Thu, 12 Nov 2020 18:41:26 +0000 (13:41 -0500)]
Merge pull request #9531 from annando/fatal

Check for empty body to prevent a fatal error

3 years agoCheck for empty body to prevent a fatal error
Michael [Thu, 12 Nov 2020 16:52:55 +0000 (16:52 +0000)]
Check for empty body to prevent a fatal error

3 years agoMerge pull request #9530 from annando/fatal
Hypolite Petovan [Thu, 12 Nov 2020 12:57:53 +0000 (07:57 -0500)]
Merge pull request #9530 from annando/fatal

Fix fatal errors

3 years agoFix fatal errors
Michael [Thu, 12 Nov 2020 05:17:48 +0000 (05:17 +0000)]
Fix fatal errors

3 years agoMerge pull request #9526 from MrPetovan/bug/9525-mastodon-emojis-tag
Michael Vogel [Thu, 12 Nov 2020 04:47:46 +0000 (05:47 +0100)]
Merge pull request #9526 from MrPetovan/bug/9525-mastodon-emojis-tag

Restore expected implementation of JsonLD::fetchElementArray

3 years agoPrevent multiple replacements for the same emoji in Protocol\ActivityPub\Processor...
Hypolite Petovan [Wed, 11 Nov 2020 23:28:26 +0000 (18:28 -0500)]
Prevent multiple replacements for the same emoji in Protocol\ActivityPub\Processor::replaceEmojis

3 years agoMerge pull request #9529 from annando/api-not-found
Hypolite Petovan [Wed, 11 Nov 2020 21:15:24 +0000 (16:15 -0500)]
Merge pull request #9529 from annando/api-not-found

API: Not implemented stuff should return 404

3 years agoFix test
Michael [Wed, 11 Nov 2020 20:49:34 +0000 (20:49 +0000)]
Fix test

3 years agoAPI: Not implemented stuff should return 404
Michael [Wed, 11 Nov 2020 20:28:36 +0000 (20:28 +0000)]
API: Not implemented stuff should return 404

3 years agoMerge pull request #9527 from annando/fetch-object-by-url
Hypolite Petovan [Wed, 11 Nov 2020 18:14:20 +0000 (13:14 -0500)]
Merge pull request #9527 from annando/fetch-object-by-url

Fix: Fetch object by URL

3 years agoFix: Fetch object by URL
Michael [Wed, 11 Nov 2020 17:55:33 +0000 (17:55 +0000)]
Fix: Fetch object by URL

3 years agoAdded new test for JsonLD::fetchElementArray type matching
Hypolite Petovan [Wed, 11 Nov 2020 16:19:27 +0000 (11:19 -0500)]
Added new test for JsonLD::fetchElementArray type matching

3 years agoFix expected implementation of JsonLD::fetchElementArray
Hypolite Petovan [Wed, 11 Nov 2020 16:19:08 +0000 (11:19 -0500)]
Fix expected implementation of JsonLD::fetchElementArray

- Added expected field value matching

3 years agoMerge pull request #9522 from MrPetovan/bug/ap-blocked-followers
Michael Vogel [Wed, 11 Nov 2020 14:28:04 +0000 (15:28 +0100)]
Merge pull request #9522 from MrPetovan/bug/ap-blocked-followers

Prevent ActivityPub message transmission to blocked followers

3 years agoFilter blocked contacts out from Protocol\ActivityPub\Transmitter::getContacts
Hypolite Petovan [Wed, 11 Nov 2020 14:18:51 +0000 (09:18 -0500)]
Filter blocked contacts out from Protocol\ActivityPub\Transmitter::getContacts

3 years agoMerge pull request #9523 from MrPetovan/bug/notices
Michael Vogel [Wed, 11 Nov 2020 14:16:58 +0000 (15:16 +0100)]
Merge pull request #9523 from MrPetovan/bug/notices

Suppress notice when network page is empty

3 years agoSuppress notice when network page is empty
Hypolite Petovan [Wed, 11 Nov 2020 08:05:12 +0000 (03:05 -0500)]
Suppress notice when network page is empty

3 years agoPrevent ActivityPub message transmission to blocked followers
Hypolite Petovan [Wed, 11 Nov 2020 07:48:22 +0000 (02:48 -0500)]
Prevent ActivityPub message transmission to blocked followers

3 years agoMerge pull request #9521 from annando/issue-9520
Hypolite Petovan [Tue, 10 Nov 2020 20:07:01 +0000 (15:07 -0500)]
Merge pull request #9521 from annando/issue-9520

Issue 9520: Fix resharer hovercard

3 years agoIssue 9520: Fix resharer hovercard
Michael [Tue, 10 Nov 2020 19:43:12 +0000 (19:43 +0000)]
Issue 9520: Fix resharer hovercard

3 years agoMerge pull request #9519 from annando/fix-contact-import
Hypolite Petovan [Tue, 10 Nov 2020 15:28:35 +0000 (10:28 -0500)]
Merge pull request #9519 from annando/fix-contact-import

Fix contact import with Frio

3 years agoFix contact import with Frio
Michael [Tue, 10 Nov 2020 06:37:27 +0000 (06:37 +0000)]
Fix contact import with Frio

3 years agoMerge pull request #9512 from MrPetovan/bug/9501-admin-users-fixes
Michael Vogel [Tue, 10 Nov 2020 06:07:59 +0000 (07:07 +0100)]
Merge pull request #9512 from MrPetovan/bug/9501-admin-users-fixes

[frio] Improve admin user list display

3 years agoMerge pull request #9517 from annando/no-duplicated
Hypolite Petovan [Mon, 9 Nov 2020 21:00:52 +0000 (16:00 -0500)]
Merge pull request #9517 from annando/no-duplicated

Improve duplicate check

3 years agoImprove duplicate check
Michael [Mon, 9 Nov 2020 20:29:42 +0000 (20:29 +0000)]
Improve duplicate check

3 years agoMerge pull request #9509 from MrPetovan/task/5616-clear-notifications-display
Michael Vogel [Mon, 9 Nov 2020 20:01:36 +0000 (21:01 +0100)]
Merge pull request #9509 from MrPetovan/task/5616-clear-notifications-display

Set thread notifications as seen in mod/display

3 years agoOnly set the current notify as seen when user enabled detailed notifications
Hypolite Petovan [Mon, 9 Nov 2020 16:41:21 +0000 (11:41 -0500)]
Only set the current notify as seen when user enabled detailed notifications

3 years ago[frio] Improve admin user list display
Hypolite Petovan [Mon, 9 Nov 2020 03:03:35 +0000 (22:03 -0500)]
[frio] Improve admin user list display

3 years agoImprove admin user field is_deletable to check user.account_removed
Hypolite Petovan [Mon, 9 Nov 2020 03:02:15 +0000 (22:02 -0500)]
Improve admin user field is_deletable to check user.account_removed

3 years agoUpdate source translation file after adding strings
Hypolite Petovan [Mon, 9 Nov 2020 14:47:36 +0000 (09:47 -0500)]
Update source translation file after adding strings

3 years agoGroup registration requests in a single line for users without detailed_notif
Hypolite Petovan [Mon, 9 Nov 2020 14:33:59 +0000 (09:33 -0500)]
Group registration requests in a single line for users without detailed_notif

3 years agoSet thread notifications as seen in mod/display
Hypolite Petovan [Sun, 8 Nov 2020 21:59:57 +0000 (16:59 -0500)]
Set thread notifications as seen in mod/display

- Only for users without detailed notifications

3 years agoMerge pull request #9513 from MrPetovan/task/9508-mastodon-handled-mentions
Michael Vogel [Mon, 9 Nov 2020 06:45:27 +0000 (07:45 +0100)]
Merge pull request #9513 from MrPetovan/task/9508-mastodon-handled-mentions

[AP] Use contact.alias if it exists instead of contact.url for mention links

3 years ago[AP] Use contact.alias if it exists instead of contact.url for mention links
Hypolite Petovan [Mon, 9 Nov 2020 04:32:02 +0000 (23:32 -0500)]
[AP] Use contact.alias if it exists instead of contact.url for mention links

- Make mentions links handled by Mastodon for logged in users

3 years agoSimplify code in Content\Text\BBCode::convert
Hypolite Petovan [Mon, 9 Nov 2020 04:25:46 +0000 (23:25 -0500)]
Simplify code in Content\Text\BBCode::convert

- Use performWithEscapedTags instead of custom solution

3 years agoMerge pull request #9511 from MrPetovan/bug/9501-admin-users-fixes
Michael Vogel [Mon, 9 Nov 2020 02:39:49 +0000 (03:39 +0100)]
Merge pull request #9511 from MrPetovan/bug/9501-admin-users-fixes

Fix redirect/form paths in Module\Admin\Users\Index|Active

3 years agoFix redirect/form paths in Module\Admin\Users\Index|Active
Hypolite Petovan [Mon, 9 Nov 2020 01:09:10 +0000 (20:09 -0500)]
Fix redirect/form paths in Module\Admin\Users\Index|Active

3 years agoMerge pull request #9507 from MrPetovan/bug/9480-never-mention-yourself
Michael Vogel [Sun, 8 Nov 2020 21:37:07 +0000 (22:37 +0100)]
Merge pull request #9507 from MrPetovan/bug/9480-never-mention-yourself

Never mention yourself

3 years agoNormalize mention formatting for AP
Hypolite Petovan [Sun, 8 Nov 2020 19:21:20 +0000 (14:21 -0500)]
Normalize mention formatting for AP

3 years agoNever mention yourself in AP messages
Hypolite Petovan [Sun, 8 Nov 2020 19:21:08 +0000 (14:21 -0500)]
Never mention yourself in AP messages

3 years agoMerge pull request #9506 from annando/test-mysql-no-pdo
Hypolite Petovan [Sun, 8 Nov 2020 18:55:53 +0000 (13:55 -0500)]
Merge pull request #9506 from annando/test-mysql-no-pdo

Only disable PDO in tests for versions lower than 7.3

3 years agoMerge pull request #9501 from MrPetovan/bug/9496-rework-admin-users
Michael Vogel [Sun, 8 Nov 2020 18:42:40 +0000 (19:42 +0100)]
Merge pull request #9501 from MrPetovan/bug/9496-rework-admin-users

Split admin/users into 6 separate modules

3 years agoUpdate the target URL for pending registration notifications
Hypolite Petovan [Sun, 8 Nov 2020 17:02:58 +0000 (12:02 -0500)]
Update the target URL for pending registration notifications

3 years ago[frio] Improve admin/users/* page display
Hypolite Petovan [Sun, 8 Nov 2020 07:29:54 +0000 (02:29 -0500)]
[frio] Improve admin/users/* page display

3 years agoSplit admin/users into 6 separate modules
Hypolite Petovan [Sun, 8 Nov 2020 07:28:33 +0000 (02:28 -0500)]
Split admin/users into 6 separate modules

- They now feature working pagination

3 years agoRemove unused code in Module\Register
Hypolite Petovan [Sun, 8 Nov 2020 07:27:44 +0000 (02:27 -0500)]
Remove unused code in Module\Register

3 years ago[frio] Add link to settings in account delegation page
Hypolite Petovan [Sun, 8 Nov 2020 07:26:52 +0000 (02:26 -0500)]
[frio] Add link to settings in account delegation page

3 years agoImprove accuracy of User::getList with type = blocked
Hypolite Petovan [Sun, 8 Nov 2020 07:26:12 +0000 (02:26 -0500)]
Improve accuracy of User::getList with type = blocked

- user.blocked is used for pending registrations as well