]> git.mxchange.org Git - quix0rs-gnu-social.git/log
quix0rs-gnu-social.git
14 years agoMerge branch '0.8.x' into 0.9.x
Evan Prodromou [Fri, 21 Aug 2009 19:42:11 +0000 (15:42 -0400)]
Merge branch '0.8.x' into 0.9.x

Conflicts:
actions/updateprofile.php
actions/userauthorization.php
classes/User_group.php
index.php
install.php
lib/accountsettingsaction.php
lib/logingroupnav.php

14 years agoMerge branch '0.8.x' of git@gitorious.org:laconica/mainline into 0.8.x
Evan Prodromou [Fri, 21 Aug 2009 19:30:03 +0000 (15:30 -0400)]
Merge branch '0.8.x' of git@gitorious.org:laconica/mainline into 0.8.x

14 years agoWe don't need to re-distribute jquery-autocomplete demo
Evan Prodromou [Fri, 21 Aug 2009 19:29:28 +0000 (15:29 -0400)]
We don't need to re-distribute jquery-autocomplete demo

14 years agoMerge branch '0.9.x' of git@gitorious.org:laconica/mainline into 0.9.x
Evan Prodromou [Fri, 21 Aug 2009 12:29:51 +0000 (08:29 -0400)]
Merge branch '0.9.x' of git@gitorious.org:laconica/mainline into 0.9.x

Conflicts:
actions/postnotice.php

14 years agoapi update correctly checks max length of notices
Evan Prodromou [Fri, 21 Aug 2009 12:27:21 +0000 (08:27 -0400)]
api update correctly checks max length of notices

14 years agofacebook action correctly checks max notice length
Evan Prodromou [Fri, 21 Aug 2009 12:23:52 +0000 (08:23 -0400)]
facebook action correctly checks max notice length

14 years agomaildaemon correctly checks max notice length
Evan Prodromou [Fri, 21 Aug 2009 12:21:55 +0000 (08:21 -0400)]
maildaemon correctly checks max notice length

14 years agocorrectly check for max notice length in xmppdaemon
Evan Prodromou [Fri, 21 Aug 2009 12:19:09 +0000 (08:19 -0400)]
correctly check for max notice length in xmppdaemon

14 years agourl-shortening check correctly checks max notice length
Evan Prodromou [Fri, 21 Aug 2009 12:16:08 +0000 (08:16 -0400)]
url-shortening check correctly checks max notice length

14 years agopostnotice for OMB correctly checks max notice size
Evan Prodromou [Fri, 21 Aug 2009 12:14:37 +0000 (08:14 -0400)]
postnotice for OMB correctly checks max notice size

14 years agoWeb UI for notices correctly shows and checks max content length
Evan Prodromou [Fri, 21 Aug 2009 12:13:17 +0000 (08:13 -0400)]
Web UI for notices correctly shows and checks max content length

14 years agovalidation code in Notice correctly checks length of content
Evan Prodromou [Fri, 21 Aug 2009 12:12:57 +0000 (08:12 -0400)]
validation code in Notice correctly checks length of content

14 years agoNotice class has methods to check content length
Evan Prodromou [Fri, 21 Aug 2009 12:05:13 +0000 (08:05 -0400)]
Notice class has methods to check content length

14 years agoregister checks Profile bio length correctly
Evan Prodromou [Fri, 21 Aug 2009 12:03:40 +0000 (08:03 -0400)]
register checks Profile bio length correctly

14 years agocheck and show max bio length in profilesettings
Evan Prodromou [Fri, 21 Aug 2009 11:48:30 +0000 (07:48 -0400)]
check and show max bio length in profilesettings

14 years agocheck correct setting in Profile bio length
Evan Prodromou [Fri, 21 Aug 2009 11:48:14 +0000 (07:48 -0400)]
check correct setting in Profile bio length

14 years agoProfile class has methods to check bio length
Evan Prodromou [Fri, 21 Aug 2009 11:40:46 +0000 (07:40 -0400)]
Profile class has methods to check bio length

14 years agoAPI for direct messages correctly checks length
Evan Prodromou [Fri, 21 Aug 2009 11:32:08 +0000 (07:32 -0400)]
API for direct messages correctly checks length

14 years agomessage input form correctly shows and check max length
Evan Prodromou [Fri, 21 Aug 2009 11:23:27 +0000 (07:23 -0400)]
message input form correctly shows and check max length

14 years agocounter in notice/message form uses global variable for max length
Evan Prodromou [Fri, 21 Aug 2009 11:22:53 +0000 (07:22 -0400)]
counter in notice/message form uses global variable for max length

14 years agocorrectly check Message length for d-commands
Evan Prodromou [Fri, 21 Aug 2009 11:21:29 +0000 (07:21 -0400)]
correctly check Message length for d-commands

14 years agomethods for Message to check max content length
Evan Prodromou [Fri, 21 Aug 2009 11:20:59 +0000 (07:20 -0400)]
methods for Message to check max content length

14 years agocorrect instructions for length in groupeditform
Evan Prodromou [Fri, 21 Aug 2009 10:37:22 +0000 (06:37 -0400)]
correct instructions for length in groupeditform

14 years agocan set group desc limit to unlimited without resetting global limit
Evan Prodromou [Fri, 21 Aug 2009 10:36:55 +0000 (06:36 -0400)]
can set group desc limit to unlimited without resetting global limit

14 years ago0 means no limit for text (distinct from null)
Evan Prodromou [Fri, 21 Aug 2009 10:24:21 +0000 (06:24 -0400)]
0 means no limit for text (distinct from null)

14 years agoallow configurable length for user group description
Evan Prodromou [Fri, 21 Aug 2009 10:13:41 +0000 (06:13 -0400)]
allow configurable length for user group description

14 years agoconfiguration options for text limits
Evan Prodromou [Thu, 20 Aug 2009 21:25:54 +0000 (17:25 -0400)]
configuration options for text limits

14 years agodata classes allow >140c in user group descriptions
Evan Prodromou [Thu, 20 Aug 2009 21:12:52 +0000 (17:12 -0400)]
data classes allow >140c in user group descriptions

14 years agoupdate database to allow >140c in group descriptions
Evan Prodromou [Thu, 20 Aug 2009 21:11:34 +0000 (17:11 -0400)]
update database to allow >140c in group descriptions

14 years agodata classes allow >140 bios in profiles
Evan Prodromou [Thu, 20 Aug 2009 21:09:04 +0000 (17:09 -0400)]
data classes allow >140 bios in profiles

14 years agoAllow unlimited-size bios in profiles
Evan Prodromou [Thu, 20 Aug 2009 21:07:20 +0000 (17:07 -0400)]
Allow unlimited-size bios in profiles

14 years agoMessages can be >140c in classes
Evan Prodromou [Thu, 20 Aug 2009 21:03:49 +0000 (17:03 -0400)]
Messages can be >140c in classes

14 years agoallow unlimited text in messages in DB
Evan Prodromou [Thu, 20 Aug 2009 21:02:25 +0000 (17:02 -0400)]
allow unlimited text in messages in DB

14 years agoupdate data classes for TEXT content in notice
Evan Prodromou [Thu, 20 Aug 2009 20:56:26 +0000 (16:56 -0400)]
update data classes for TEXT content in notice

14 years agoupdate database to allow large posts
Evan Prodromou [Thu, 20 Aug 2009 20:53:00 +0000 (16:53 -0400)]
update database to allow large posts

14 years agomake common_config() handle nulls correctly
Evan Prodromou [Fri, 21 Aug 2009 10:33:12 +0000 (06:33 -0400)]
make common_config() handle nulls correctly

14 years agoreformat groupeditform.php
Evan Prodromou [Fri, 21 Aug 2009 10:17:13 +0000 (06:17 -0400)]
reformat groupeditform.php

14 years agoUpdate libomb, fix some omb handling stuff, improve error handling.
Adrian Lang [Fri, 21 Aug 2009 10:13:24 +0000 (12:13 +0200)]
Update libomb, fix some omb handling stuff, improve error handling.

14 years agoMerge branch '0.9.x' of git@gitorious.org:laconica/mainline into 0.9.x
Evan Prodromou [Thu, 20 Aug 2009 21:13:40 +0000 (17:13 -0400)]
Merge branch '0.9.x' of git@gitorious.org:laconica/mainline into 0.9.x

14 years agovar empty check did not function as expected.
Eric Helgeson [Thu, 20 Aug 2009 19:25:50 +0000 (14:25 -0500)]
var empty check did not function as expected.
made script executable

14 years agoadd $config['attachments']['path'] to the config.php.sample
mEDI [Tue, 18 Aug 2009 20:55:42 +0000 (22:55 +0200)]
add $config['attachments']['path'] to the config.php.sample

14 years agoChange the notice type defines all into class constants and adapt all files.
Marcel van der Boom [Wed, 19 Aug 2009 06:34:17 +0000 (08:34 +0200)]
Change the notice type defines all into class constants and adapt all files.

14 years agoMerge commit 'cvollick/resolveAliases' into 0.8.x
Craig Andrews [Thu, 20 Aug 2009 17:08:10 +0000 (13:08 -0400)]
Merge commit 'cvollick/resolveAliases' into 0.8.x

14 years agoFix the default value of ['server']['path'] when running from command line scripts
Francois Marier [Thu, 20 Aug 2009 05:46:26 +0000 (17:46 +1200)]
Fix the default value of ['server']['path'] when running from command line scripts

The logic in _sn_to_path() doesn't make sense when not running via a remote server.

Default to the empty string if running from the command line and ['server']['path']
is not set manually in config.php

14 years agoResolve Group Aliases in showgroup.php
Christopher Vollick [Wed, 19 Aug 2009 13:22:06 +0000 (09:22 -0400)]
Resolve Group Aliases in showgroup.php

For Example, let's say 'alias' was an alias for the group 'group'.
Previously, if you went to '/group/group' it'd work, but '/group/alias' it'd say "No Such Group".
This was untrue.

Now it checks aliases when it can't find a group with a given name.
If it finds one it redirects you to the original group.

14 years agoMerge branch '0.8.x' of git@gitorious.org:laconica/mainline into 0.8.x
Zach Copley [Wed, 19 Aug 2009 01:00:48 +0000 (18:00 -0700)]
Merge branch '0.8.x' of git@gitorious.org:laconica/mainline into 0.8.x

* '0.8.x' of git@gitorious.org:laconica/mainline:
  Removed all the redundant logic in common_replace_urls_callback

14 years agoUpdated Twitter bridge section
Zach Copley [Wed, 19 Aug 2009 00:59:57 +0000 (17:59 -0700)]
Updated Twitter bridge section

14 years agoRemoved all the redundant logic in common_replace_urls_callback
Craig Andrews [Wed, 19 Aug 2009 00:40:16 +0000 (20:40 -0400)]
Removed all the redundant logic in common_replace_urls_callback
Modified the regex so that strings such as /usr/share/perl5/HTML/Mason/ApacheHandler.pm as not turned into links

14 years agoBetter logging
Zach Copley [Tue, 18 Aug 2009 23:41:24 +0000 (23:41 +0000)]
Better logging

14 years agoReturn null if all columns in the compound primary key aren't specified
Zach Copley [Tue, 18 Aug 2009 22:59:14 +0000 (22:59 +0000)]
Return null if all columns in the compound primary key aren't specified

14 years agoKick user out if she doesn't have FB cookies
Zach Copley [Tue, 18 Aug 2009 22:18:01 +0000 (22:18 +0000)]
Kick user out if she doesn't have FB cookies

14 years agoIPv4 and IPv6 addresses are picked up in URLs
Craig Andrews [Tue, 18 Aug 2009 18:15:55 +0000 (14:15 -0400)]
IPv4 and IPv6 addresses are picked up in URLs
Added ".onion" as a possible TLD

14 years agoUse spinner icon while performing AJAX submissions of favorite/unfavorite button...
brion [Sun, 16 Aug 2009 17:17:03 +0000 (10:17 -0700)]
Use spinner icon while performing AJAX submissions of favorite/unfavorite button so there's some visual feedback that something's happening.

14 years agoMerge commit 'jeff-themovie/0.8.x-openid-enabled' into 0.8.x
Craig Andrews [Sun, 16 Aug 2009 23:50:37 +0000 (19:50 -0400)]
Merge commit 'jeff-themovie/0.8.x-openid-enabled' into 0.8.x

14 years agoFix bug bug 1563 "opensearch content type incorrectly set"
brion [Sun, 16 Aug 2009 18:56:22 +0000 (11:56 -0700)]
Fix bug bug 1563 "opensearch content type incorrectly set"
http://laconi.ca/trac/ticket/1563

OpenSearch description info is now sent with correct Content-Type: application/opensearchdescription+xml instead of text/html.

14 years agoRevert "Revert "Return a 404 when a page is request that has no notices""
Evan Prodromou [Sun, 16 Aug 2009 14:37:15 +0000 (10:37 -0400)]
Revert "Revert "Return a 404 when a page is request that has no notices""

This reverts commit 1b204fde39271acd38bb8f9dd16734f15c68138a.

14 years agoRevert "Revert "Return a 404 when a page is request that has no notices""
Evan Prodromou [Sun, 16 Aug 2009 14:37:04 +0000 (10:37 -0400)]
Revert "Revert "Return a 404 when a page is request that has no notices""

This reverts commit 6c597eabecf2368224938a136d7ac588702bbfd7.

14 years agoRevert "Return a 404 when a page is request that has no notices"
Evan Prodromou [Fri, 14 Aug 2009 20:05:57 +0000 (13:05 -0700)]
Revert "Return a 404 when a page is request that has no notices"

An empty list still exists; we should not return a 404 for empty lists.

This reverts commit 355effe6315ab7927a54f44fc9ce903085769b5f.

14 years agoRevert "Return a 404 when a page is request that has no notices"
Evan Prodromou [Fri, 14 Aug 2009 20:05:29 +0000 (13:05 -0700)]
Revert "Return a 404 when a page is request that has no notices"

An empty list still exists; we shouldn't return a 404.

This reverts commit c29892c87573e0575b9a4a13210c562e08411148.

14 years agoFixed OpenID appearing in primary nav when OpenID is enabled but not OpenID-only
Jeffery To [Fri, 14 Aug 2009 16:17:00 +0000 (00:17 +0800)]
Fixed OpenID appearing in primary nav when OpenID is enabled but not OpenID-only

14 years agowhitespace in error.php
Evan Prodromou [Fri, 14 Aug 2009 15:04:03 +0000 (08:04 -0700)]
whitespace in error.php

14 years agoAdded a configuration option to disable OpenID.
Jeffery To [Thu, 13 Aug 2009 14:18:06 +0000 (22:18 +0800)]
Added a configuration option to disable OpenID.

If $config['openid']['enabled'] is set to false, OpenID is removed from
the navigation and direct accesses to OpenID login pages redirect to the
login page.

If OpenID is enabled, $config['site']['openidonly'] is ignored, i.e.
OpenID is required to go OpenID-only.

14 years agoServerErrorAction always logs
Evan Prodromou [Wed, 12 Aug 2009 18:16:31 +0000 (11:16 -0700)]
ServerErrorAction always logs

14 years agoMerge branch '0.8.x' of git@gitorious.org:laconica/mainline into 0.8.x
Evan Prodromou [Wed, 12 Aug 2009 17:50:46 +0000 (10:50 -0700)]
Merge branch '0.8.x' of git@gitorious.org:laconica/mainline into 0.8.x

14 years agoDefine the member variable N
Craig Andrews [Wed, 12 Aug 2009 15:51:43 +0000 (11:51 -0400)]
Define the member variable N

N is defined in the DB_DataObject class, which this class kind of extends. So to keep a consistent interface for consumers, we need to have N defined here.

14 years agoPrevents redirect URLs that have canonical URLs longer than 255 chars from being...
Brett Taylor [Wed, 12 Aug 2009 04:00:46 +0000 (16:00 +1200)]
Prevents redirect URLs that have canonical URLs longer than 255 chars from being written to the database as their canonical. Redirecting URLs will instead be saved to the database as given.

The reason for this is that table 'file' column 'url' is a VARCHAR(255) in MySQL and it silently truncates URLs longer than 255 characters, breaking the url.

The proper fix for this is to improve this column, making its type TEXT, but there are no database changes for 0.8.x, so this is the next best thing for data integrity. A migration script for 0.9.x could be written to audit the database checking for redirects and updating these urls to their proper canonical url.

14 years agoCorrected the Infinite Scroll CSS Selectors
Craig Andrews [Wed, 12 Aug 2009 03:05:46 +0000 (23:05 -0400)]
Corrected the Infinite Scroll CSS Selectors

Thanks dcostalis for making me aware of the issue!

14 years agoReturn a 404 when a page is request that has no notices
Craig Andrews [Wed, 12 Aug 2009 02:48:35 +0000 (22:48 -0400)]
Return a 404 when a page is request that has no notices

14 years agoReturn a 404 when a page is request that has no notices
Craig Andrews [Wed, 12 Aug 2009 02:09:02 +0000 (22:09 -0400)]
Return a 404 when a page is request that has no notices

14 years agooEmbed provider does not use the twitter api library classes any more
Craig Andrews [Wed, 12 Aug 2009 01:15:42 +0000 (21:15 -0400)]
oEmbed provider does not use the twitter api library classes any more

14 years agoMake notice attachment lightbox work after an infinite scroll happens
Craig Andrews [Tue, 11 Aug 2009 20:36:34 +0000 (16:36 -0400)]
Make notice attachment lightbox work after an infinite scroll happens

14 years agoreformat newnotice.php
Evan Prodromou [Tue, 11 Aug 2009 15:18:24 +0000 (11:18 -0400)]
reformat newnotice.php

14 years agoMerge commit 'jeff-themovie/0.8.x-private-returnto' into 0.8.x
Craig Andrews [Tue, 11 Aug 2009 14:42:04 +0000 (10:42 -0400)]
Merge commit 'jeff-themovie/0.8.x-private-returnto' into 0.8.x

14 years agoMerge commit 'jeff-themovie/0.8.x-jcrop-0.9.8' into 0.8.x
Craig Andrews [Tue, 11 Aug 2009 14:41:17 +0000 (10:41 -0400)]
Merge commit 'jeff-themovie/0.8.x-jcrop-0.9.8' into 0.8.x

14 years agoMerge commit 'jeff-themovie/0.8.x-private-search' into 0.8.x
Craig Andrews [Tue, 11 Aug 2009 14:39:44 +0000 (10:39 -0400)]
Merge commit 'jeff-themovie/0.8.x-private-search' into 0.8.x

14 years agoMerge branch 'master' into 0.8.x
Evan Prodromou [Tue, 11 Aug 2009 14:23:11 +0000 (10:23 -0400)]
Merge branch 'master' into 0.8.x

Conflicts:
lib/mail.php
lib/rssaction.php
lib/twitterapi.php

14 years agoSet returnto when redirected to login of a private install
Jeffery To [Tue, 11 Aug 2009 13:55:24 +0000 (21:55 +0800)]
Set returnto when redirected to login of a private install

14 years agoAdded opensearch to the list of public actions.
Jeffery To [Tue, 11 Aug 2009 13:00:51 +0000 (21:00 +0800)]
Added opensearch to the list of public actions.

IE7+ will ask for this (opensearch/people and opensearch/notice) on every page access, and as the content is not sensitive, returning it is better than a 307 redirect.

14 years agoDon't show Search in the primary nav if the user isn't logged in and the site is...
Jeffery To [Tue, 11 Aug 2009 12:47:41 +0000 (20:47 +0800)]
Don't show Search in the primary nav if the user isn't logged in and the site is private

14 years agoUpdated Jcrop to 0.9.8 (avatar cropping wasn't working in IE7 with 0.9.5)
Jeffery To [Tue, 11 Aug 2009 12:29:45 +0000 (20:29 +0800)]
Updated Jcrop to 0.9.8 (avatar cropping wasn't working in IE7 with 0.9.5)

14 years agoMerge commit 'mainline/0.8.x' into 0.8.x-notices-in-htmloutputter
Brett Taylor [Tue, 11 Aug 2009 03:57:53 +0000 (15:57 +1200)]
Merge commit 'mainline/0.8.x' into 0.8.x-notices-in-htmloutputter

14 years agotwo variables $public and $system were generating notices in lib/htmloutputter.php...
Brett Taylor [Tue, 11 Aug 2009 03:53:37 +0000 (15:53 +1200)]
two variables $public and $system were generating notices  in lib/htmloutputter.php, removed because these two parameters are null by default.

14 years agofix for trac bug #1805:
Brett Taylor [Tue, 11 Aug 2009 03:26:41 +0000 (15:26 +1200)]
fix for trac bug #1805:
bug on line 381 referred to non existant variable, and caused a php notice and potentially would create a misconfigured config.php database type setting.

14 years agoinstall.php: improved support for running Laconica in a sub folder and on a non-stand...
Brett Taylor [Fri, 7 Aug 2009 02:17:55 +0000 (14:17 +1200)]
install.php: improved support for running Laconica in a sub folder and on a non-standard port,
tidyed up configuration file generation, removing duplication from db functions,

14 years agoRevert "changed file.url column type from varcahr(255) to varchar(2047)"
Brenda Wallace [Tue, 11 Aug 2009 02:41:48 +0000 (14:41 +1200)]
Revert "changed file.url column type from varcahr(255) to varchar(2047)"

This reverts commit c1b19929f6234c4b9e30e16bae419c89c38c1169.

14 years agoRevert "change file.url to from a varchar(255) to varchar(2047)"
Brenda Wallace [Mon, 10 Aug 2009 21:38:17 +0000 (09:38 +1200)]
Revert "change file.url to from a varchar(255) to varchar(2047)"

This reverts commit 002cc755b2a521486b0216e2d6f8a3952bda0bae.

mysql doesn't allow varchar > 255 chars
reverting until have a working solution

14 years agochange file.url to from a varchar(255) to varchar(2047)
Brenda Wallace [Mon, 10 Aug 2009 21:25:13 +0000 (09:25 +1200)]
change file.url to from a varchar(255) to varchar(2047)
because urls get translated from tinyurl.com etc into their originals before saving
and urls can be that long

14 years agoupgrade script for postgres
Brenda Wallace [Mon, 10 Aug 2009 21:24:18 +0000 (09:24 +1200)]
upgrade script for postgres

14 years agoRevert "common_config returns false if the config value is not set. Design::toWebColo...
Evan Prodromou [Mon, 10 Aug 2009 20:42:21 +0000 (16:42 -0400)]
Revert "common_config returns false if the config value is not set. Design::toWebColor checks with is_null. Hence the common_config value should be adjusted."

This reverts commit 5ba46186b7dd179253023426f6d7cdbbee67ad98.

14 years agoRevert "Typo, session_name is a function."
Evan Prodromou [Mon, 10 Aug 2009 20:42:10 +0000 (16:42 -0400)]
Revert "Typo, session_name is a function."

This reverts commit d0793c0f44aabb76af2556a690013c143ac9f7a3.

14 years agoRevert "UnsubscribeAction: Add LACONICA gate, fix PHPCS errors, fix error handling...
Evan Prodromou [Mon, 10 Aug 2009 20:42:04 +0000 (16:42 -0400)]
Revert "UnsubscribeAction: Add LACONICA gate, fix PHPCS errors, fix error handling typo."

This reverts commit e1270b26f5eae1c3d7ea4b954f0bc1f51d73494c.

14 years agocommon_config returns false if the config value is not set. Design::toWebColor checks...
Adrian Lang [Mon, 10 Aug 2009 13:01:00 +0000 (15:01 +0200)]
common_config returns false if the config value is not set. Design::toWebColor checks with is_null. Hence the common_config value should be adjusted.

14 years agoUnsubscribeAction: Add LACONICA gate, fix PHPCS errors, fix error handling typo.
Adrian Lang [Fri, 7 Aug 2009 10:21:36 +0000 (12:21 +0200)]
UnsubscribeAction: Add LACONICA gate, fix PHPCS errors, fix error handling typo.

14 years agoMerge branch 'master' of git@gitorious.org:laconica/mainline
Evan Prodromou [Mon, 10 Aug 2009 20:33:36 +0000 (16:33 -0400)]
Merge branch 'master' of git@gitorious.org:laconica/mainline

14 years ago$args Was Out Of Scope in CheckMirror.
Christopher Vollick [Fri, 7 Aug 2009 12:28:20 +0000 (08:28 -0400)]
$args Was Out Of Scope in CheckMirror.

It looks like when the code was factored out no one noticed this variable doesn't exist here.

14 years agoMerge commit 'dcostalis/econversation' into 0.8.x
Craig Andrews [Mon, 10 Aug 2009 17:20:56 +0000 (13:20 -0400)]
Merge commit 'dcostalis/econversation' into 0.8.x

14 years agoWorkaround for bug 1317 '"What's up" textarea on iPhone missing proper submit button'
brion [Mon, 10 Aug 2009 01:39:51 +0000 (18:39 -0700)]
Workaround for bug 1317 '"What's up" textarea on iPhone missing proper submit button'
http://laconi.ca/trac/ticket/1317

Mobile Safari shows a 'return' button for making newlines in a <textarea> where it would show a submit button for plain <input> text fields...
However there's a keydown event handler which is supposed to detect hitting enter and submit the form for us. This didn't work on Mobile Safari because it was checking of 13 ("\r") but the iPhone sends us char 10 ("\n") here. Changed to accept both, so we now submit on hitting 'return' on iPhone.

Note: I also added a blur() to move focus out of the textarea, which closes the on-screen keyboard. It will also take focus out of the textarea on other platforms, but this is probably the right thing -- the same thing happens when you push the "send" button after all.

Also note: unfortunately the layout right now looks pretty awful generally while editing on the iPhone; you can't see the send button or character counter while typing at the default zoom, and it doesn't zoom out after you submit so you can't really see where your message is going. This should be dealt with in general by fixing up the mobile skin variant...

14 years agoMerge commit 'jeff-themovie/0.8.x-openidonly' into 0.8.x
Craig Andrews [Mon, 10 Aug 2009 15:53:35 +0000 (11:53 -0400)]
Merge commit 'jeff-themovie/0.8.x-openidonly' into 0.8.x

14 years agoTypo, session_name is a function.
Adrian Lang [Mon, 10 Aug 2009 13:24:27 +0000 (15:24 +0200)]
Typo, session_name is a function.

14 years agocommon_config returns false if the config value is not set. Design::toWebColor checks...
Adrian Lang [Mon, 10 Aug 2009 13:01:00 +0000 (15:01 +0200)]
common_config returns false if the config value is not set. Design::toWebColor checks with is_null. Hence the common_config value should be adjusted.