]> git.mxchange.org Git - friendica.git/log
friendica.git
8 years agoJust another commit message :-)
Michael Vogel [Tue, 1 Mar 2016 18:10:35 +0000 (19:10 +0100)]
Just another commit message :-)

8 years agoReshares could work now, code is cleaned
Michael Vogel [Tue, 1 Mar 2016 06:57:26 +0000 (07:57 +0100)]
Reshares could work now, code is cleaned

8 years agoAccount deletion should work, status messages works - reshares are half done.
Michael Vogel [Mon, 29 Feb 2016 22:54:25 +0000 (23:54 +0100)]
Account deletion should work, status messages works - reshares are half done.

8 years ago"profile". "like" and "comment" could work, status messages only partly.
Michael Vogel [Mon, 29 Feb 2016 07:02:50 +0000 (08:02 +0100)]
"profile". "like" and "comment" could work, status messages only partly.

8 years agoLike and Comment could work (partially)
Michael Vogel [Sun, 28 Feb 2016 18:05:23 +0000 (19:05 +0100)]
Like and Comment could work (partially)

8 years agoNew Diaspora code
Michael Vogel [Sat, 27 Feb 2016 22:54:17 +0000 (23:54 +0100)]
New Diaspora code

8 years agorework autocomplete: polishing class and methods naming
rabuzarus [Fri, 5 Feb 2016 13:26:22 +0000 (14:26 +0100)]
rework autocomplete: polishing class and methods naming

8 years agorework autocomplete: some styling if contact is forum
rabuzarus [Tue, 2 Feb 2016 23:25:33 +0000 (00:25 +0100)]
rework autocomplete: some styling if contact is forum

8 years agorework autocomplete: add NavBar forum search
rabuzarus [Tue, 2 Feb 2016 21:33:14 +0000 (22:33 +0100)]
rework autocomplete: add NavBar forum search

8 years agorework autocomplete: add bbcode autocompletion to editor
rabuzarus [Mon, 1 Feb 2016 17:22:26 +0000 (18:22 +0100)]
rework autocomplete: add bbcode autocompletion to editor

8 years agorework autocomplete: add class dir and static function
rabuzarus [Mon, 1 Feb 2016 17:21:29 +0000 (18:21 +0100)]
rework autocomplete: add class dir and static function

8 years agorework autocomplete: Access list of smilies over JSON
rabuzarus [Mon, 1 Feb 2016 16:43:12 +0000 (17:43 +0100)]
rework autocomplete: Access list of smilies over JSON

8 years agorework autocomplete: update query-textcomplete
rabuzarus [Sat, 30 Jan 2016 15:42:46 +0000 (16:42 +0100)]
rework autocomplete: update query-textcomplete

8 years agorework autocomplete: some cleanup and docu
rabuzarus [Sun, 24 Jan 2016 18:56:23 +0000 (19:56 +0100)]
rework autocomplete: some cleanup and docu

8 years agorework autocomplete: new ac for poke, contacts, prv_messages
rabuzarus [Fri, 22 Jan 2016 16:47:48 +0000 (17:47 +0100)]
rework autocomplete: new ac for poke, contacts, prv_messages

8 years agorework autocomplete: css work
rabuzarus [Thu, 21 Jan 2016 12:28:29 +0000 (13:28 +0100)]
rework autocomplete: css work

8 years agorework autocomplete: make remote and local search work
rabuzarus [Wed, 20 Jan 2016 02:34:22 +0000 (03:34 +0100)]
rework autocomplete: make remote and local search work

8 years agorework autocomplete: initial commit
rabuzarus [Tue, 19 Jan 2016 17:11:40 +0000 (18:11 +0100)]
rework autocomplete: initial commit

8 years agoMerge branch 'rewrites/is_filled_array_introduced' into rhaeder-develop
Roland Haeder [Sat, 12 Mar 2016 22:03:06 +0000 (23:03 +0100)]
Merge branch 'rewrites/is_filled_array_introduced' into rhaeder-develop

8 years agoFixes another warning because of count()'s lazyness. #2390
Roland Haeder [Sat, 12 Mar 2016 22:02:42 +0000 (23:02 +0100)]
Fixes another warning because of count()'s lazyness. #2390

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge branch 'develop' of github.com:friendica/friendica into rhaeder-develop
Roland Haeder [Sat, 12 Mar 2016 21:57:10 +0000 (22:57 +0100)]
Merge branch 'develop' of github.com:friendica/friendica into rhaeder-develop

8 years agocount() didn't notice about FALSE ... #2390
Roland Haeder [Sat, 12 Mar 2016 21:54:06 +0000 (22:54 +0100)]
count() didn't notice about FALSE ... #2390

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agocount() didn't notice about FALSE ... #2390
Roland Haeder [Sat, 12 Mar 2016 21:54:06 +0000 (22:54 +0100)]
count() didn't notice about FALSE ... #2390

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge pull request #2413 from tobiasd/20160312-socnetsettings
Michael Vogel [Sat, 12 Mar 2016 18:49:03 +0000 (19:49 +0100)]
Merge pull request #2413 from tobiasd/20160312-socnetsettings

missing include file for the SocNet settings

8 years agoMoved is_filled_array() to both dba classes and named it is_result().
Roland Haeder [Sat, 12 Mar 2016 17:54:55 +0000 (18:54 +0100)]
Moved is_filled_array() to both dba classes and named it is_result().

Please see ticket #2390 for full discussion.

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge branch 'develop' of github.com:friendica/friendica into rhaeder-develop
Roland Haeder [Sat, 12 Mar 2016 17:50:14 +0000 (18:50 +0100)]
Merge branch 'develop' of github.com:friendica/friendica into rhaeder-develop

8 years agomissing include file for the SocNet settings
Tobias Diekershoff [Sat, 12 Mar 2016 15:25:17 +0000 (16:25 +0100)]
missing include file for the SocNet settings

8 years agoMerge pull request #2411 from tobiasd/20160312-dos
Michael Vogel [Sat, 12 Mar 2016 09:23:45 +0000 (10:23 +0100)]
Merge pull request #2411 from tobiasd/20160312-dos

Hotkey documentation

8 years agoMerge pull request #2412 from annando/1603-double-encode-ping
Tobias Diekershoff [Sat, 12 Mar 2016 08:43:41 +0000 (09:43 +0100)]
Merge pull request #2412 from annando/1603-double-encode-ping

The name in the notifications has to be double encoded

8 years agoThe name in the notifications has to be double encoded
Michael Vogel [Sat, 12 Mar 2016 08:21:13 +0000 (09:21 +0100)]
The name in the notifications has to be double encoded

8 years agoHotkey documentation
Tobias Diekershoff [Sat, 12 Mar 2016 07:57:07 +0000 (08:57 +0100)]
Hotkey documentation

8 years agoMerge pull request #2410 from tobiasd/20160312-messagespo
Michael Vogel [Sat, 12 Mar 2016 07:42:55 +0000 (08:42 +0100)]
Merge pull request #2410 from tobiasd/20160312-messagespo

regenerated messages.po file for picking up the workers

8 years agoregenerated messages.po file for picking up the workers
Tobias Diekershoff [Sat, 12 Mar 2016 06:36:44 +0000 (07:36 +0100)]
regenerated messages.po file for picking up the workers

8 years agoMerge pull request #2409 from annando/1503-worker-setting
Tobias Diekershoff [Sat, 12 Mar 2016 06:30:55 +0000 (07:30 +0100)]
Merge pull request #2409 from annando/1503-worker-setting

The worker settings are now available in the admin settings

8 years agoMerge pull request #2408 from annando/1603-goaway
Tobias Diekershoff [Sat, 12 Mar 2016 06:29:32 +0000 (07:29 +0100)]
Merge pull request #2408 from annando/1603-goaway

Another fix for "goaway". Hopefully now finale.

8 years agoMerge pull request #2407 from annando/1603-optimize-table
Tobias Diekershoff [Sat, 12 Mar 2016 06:28:44 +0000 (07:28 +0100)]
Merge pull request #2407 from annando/1603-optimize-table

The table optimisation level calculation is now also using the index size

8 years agoRemove the setting description from the documentation since it isn't a hidden one...
Michael Vogel [Fri, 11 Mar 2016 22:44:46 +0000 (23:44 +0100)]
Remove the setting description from the documentation since it isn't a hidden one anymore.

8 years agoThe worker settings are now available in the admin settings
Michael Vogel [Fri, 11 Mar 2016 22:28:11 +0000 (23:28 +0100)]
The worker settings are now available in the admin settings

8 years agoAnother fix for "goaway". Hopefully now finale.
Michael Vogel [Fri, 11 Mar 2016 19:43:31 +0000 (20:43 +0100)]
Another fix for "goaway". Hopefully now finale.

8 years agoThe table optimisation level calculation is now using the index size as well
Michael Vogel [Fri, 11 Mar 2016 19:32:22 +0000 (20:32 +0100)]
The table optimisation level calculation is now using the index size as well

8 years agoMerge pull request #2405 from annando/1603-ostatus4-bugfix
fabrixxm [Thu, 10 Mar 2016 05:08:30 +0000 (06:08 +0100)]
Merge pull request #2405 from annando/1603-ostatus4-bugfix

Bugfix: A parameter was missing for the OStatus author check

8 years agoBugfix: A parameter was missing for the OStatus author check
Michael Vogel [Wed, 9 Mar 2016 21:51:17 +0000 (22:51 +0100)]
Bugfix: A parameter was missing for the OStatus author check

8 years agoMerge pull request #2404 from annando/1603-no-lock
fabrixxm [Wed, 9 Mar 2016 21:08:41 +0000 (22:08 +0100)]
Merge pull request #2404 from annando/1603-no-lock

Don't create lock files if the process is called from the poller

8 years agoSome small addition to the OStatus part. Better check if we follow the actor.
Michael Vogel [Wed, 9 Mar 2016 20:53:30 +0000 (21:53 +0100)]
Some small addition to the OStatus part. Better check if we follow the actor.

8 years agoAdded documentation
Michael Vogel [Tue, 8 Mar 2016 21:42:37 +0000 (22:42 +0100)]
Added documentation

8 years agoChanged parameter order
Michael Vogel [Tue, 8 Mar 2016 21:28:49 +0000 (22:28 +0100)]
Changed parameter order

8 years agoThe function to check for maxload and the lockfile is centralized
Michael Vogel [Tue, 8 Mar 2016 19:28:09 +0000 (20:28 +0100)]
The function to check for maxload and the lockfile is centralized

8 years agoDon't create lock files if the process is called from the poller via the worker
Michael Vogel [Mon, 7 Mar 2016 23:20:06 +0000 (00:20 +0100)]
Don't create lock files if the process is called from the poller via the worker

8 years agoMerge pull request #2401 from annando/1603-ostatus-completion
Tobias Diekershoff [Sun, 6 Mar 2016 20:13:05 +0000 (21:13 +0100)]
Merge pull request #2401 from annando/1603-ostatus-completion

New way of fetching the conversation id for thread completion

8 years agoAdded documentation
Michael Vogel [Sun, 6 Mar 2016 20:06:52 +0000 (21:06 +0100)]
Added documentation

8 years agoMerge remote-tracking branch 'upstream/develop' into 1603-ostatus-completion
Michael Vogel [Sun, 6 Mar 2016 19:37:51 +0000 (20:37 +0100)]
Merge remote-tracking branch 'upstream/develop' into 1603-ostatus-completion

8 years agoNew way of fetching the conversation id for thread completion
Michael Vogel [Sun, 6 Mar 2016 19:36:28 +0000 (20:36 +0100)]
New way of fetching the conversation id for thread completion

8 years agoMerge pull request #2328 from rabuzarus/0602_contact_profile
fabrixxm [Sun, 6 Mar 2016 18:56:59 +0000 (19:56 +0100)]
Merge pull request #2328 from rabuzarus/0602_contact_profile

polishing of the contact-edit page

8 years agoMerge pull request #2400 from annando/1603-ostatus-thread
Tobias Diekershoff [Sun, 6 Mar 2016 18:40:01 +0000 (19:40 +0100)]
Merge pull request #2400 from annando/1603-ostatus-thread

Only import OStatus threads that are started by our contacts

8 years agoThis should work better ...
Michael Vogel [Sun, 6 Mar 2016 18:27:34 +0000 (19:27 +0100)]
This should work better ...

8 years agoOr back ...
Michael Vogel [Sun, 6 Mar 2016 14:13:19 +0000 (15:13 +0100)]
Or back ...

8 years agoRelocated the check.
Michael Vogel [Sun, 6 Mar 2016 14:11:04 +0000 (15:11 +0100)]
Relocated the check.

8 years agoOnly import OStatus threads if we follow the thread starter
Michael Vogel [Sun, 6 Mar 2016 13:53:30 +0000 (14:53 +0100)]
Only import OStatus threads if we follow the thread starter

8 years agoMerge pull request #2399 from annando/1603-default-group
Tobias Diekershoff [Sun, 6 Mar 2016 13:42:27 +0000 (14:42 +0100)]
Merge pull request #2399 from annando/1603-default-group

Central function for default group, special setting for OStatus

8 years agoSettings for only importing threads from our ostatus contacts
Michael Vogel [Sun, 6 Mar 2016 13:09:04 +0000 (14:09 +0100)]
Settings for only importing threads from our ostatus contacts

8 years agoClarification of description
Michael Vogel [Sun, 6 Mar 2016 12:26:30 +0000 (13:26 +0100)]
Clarification of description

8 years agoCentral function for default group, special setting for OStatus
Michael Vogel [Sun, 6 Mar 2016 12:15:27 +0000 (13:15 +0100)]
Central function for default group, special setting for OStatus

8 years agoMerge pull request #2398 from annando/1603-fontawesome4
Tobias Diekershoff [Sun, 6 Mar 2016 00:49:46 +0000 (01:49 +0100)]
Merge pull request #2398 from annando/1603-fontawesome4

The Font Awesome library is now updated, the reply button is changed

8 years agoMerge pull request #2397 from Quix0r/fixes/poller-warning
Michael Vogel [Sat, 5 Mar 2016 12:35:43 +0000 (13:35 +0100)]
Merge pull request #2397 from Quix0r/fixes/poller-warning

No processing if error or empty array

8 years agoThe Font Awesome library is now updated, the replxy button is changed
Michael Vogel [Sat, 5 Mar 2016 12:29:01 +0000 (13:29 +0100)]
The Font Awesome library is now updated, the replxy button is changed

8 years agoMerge branch 'rewrites/is_filled_array_introduced' into rhaeder-develop
Roland Haeder [Fri, 4 Mar 2016 21:53:42 +0000 (22:53 +0100)]
Merge branch 'rewrites/is_filled_array_introduced' into rhaeder-develop

8 years agoFixes E_WARNING from foreach() because count() seem to return TRUE even when $r is...
Roland Haeder [Fri, 4 Mar 2016 21:46:30 +0000 (22:46 +0100)]
Fixes E_WARNING from foreach() because count() seem to return TRUE even when $r is no array ?!

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoFixes E_WARNING from foreach() because count() seem to return TRUE even when $r is...
Roland Haeder [Fri, 4 Mar 2016 21:46:30 +0000 (22:46 +0100)]
Fixes E_WARNING from foreach() because count() seem to return TRUE even when $r is no array ?!

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoJust easier code ...
Roland Haeder [Fri, 4 Mar 2016 21:39:08 +0000 (22:39 +0100)]
Just easier code ...

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge branch 'fixes/poller-warning' into rhaeder-develop
Roland Haeder [Fri, 4 Mar 2016 21:38:47 +0000 (22:38 +0100)]
Merge branch 'fixes/poller-warning' into rhaeder-develop

8 years agoNo processing if error or empty array
Roland Haeder [Fri, 4 Mar 2016 21:38:18 +0000 (22:38 +0100)]
No processing if error or empty array

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge branch 'develop' of github.com:friendica/friendica into rhaeder-develop
Roland Haeder [Fri, 4 Mar 2016 19:05:15 +0000 (20:05 +0100)]
Merge branch 'develop' of github.com:friendica/friendica into rhaeder-develop

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge pull request #2392 from Quix0r/minor/logging
fabrixxm [Wed, 2 Mar 2016 11:21:18 +0000 (12:21 +0100)]
Merge pull request #2392 from Quix0r/minor/logging

Minor: Some more logging to trace down bugs

8 years agoMerge pull request #2394 from annando/1603-federation
Tobias Diekershoff [Wed, 2 Mar 2016 09:41:02 +0000 (10:41 +0100)]
Merge pull request #2394 from annando/1603-federation

Small bugfix: Fixes problen when version number contains linebreaks

8 years agoMerge pull request #2393 from annando/1603-api-speed
Tobias Diekershoff [Wed, 2 Mar 2016 09:40:23 +0000 (10:40 +0100)]
Merge pull request #2393 from annando/1603-api-speed

API: Some small speed improvement when calling the home timeline.

8 years agoAPI: Some small speed improvement when calling the home timeline.
Michael Vogel [Tue, 1 Mar 2016 18:17:01 +0000 (19:17 +0100)]
API: Some small speed improvement when calling the home timeline.

8 years agoSmall bugfix: Fixes problen when version number contains linebreaks
Michael Vogel [Tue, 1 Mar 2016 18:14:45 +0000 (19:14 +0100)]
Small bugfix: Fixes problen when version number contains linebreaks

8 years agoMerge branch 'rhaeder-develop' of github.com:Quix0r/friendica into rhaeder-develop
Roland Haeder [Tue, 1 Mar 2016 17:32:21 +0000 (18:32 +0100)]
Merge branch 'rhaeder-develop' of github.com:Quix0r/friendica into rhaeder-develop

8 years agoClosed TODO: no .= needed here. #2392
Roland Haeder [Tue, 1 Mar 2016 17:28:06 +0000 (18:28 +0100)]
Closed TODO: no .= needed here. #2392

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMore logging in case of errors + logged network type + added TODO (for ugly E_NOTICE).
Roland Haeder [Tue, 1 Mar 2016 13:42:55 +0000 (14:42 +0100)]
More logging in case of errors + logged network type + added TODO (for ugly E_NOTICE).

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoAlso use is_filled_array() here, too. if $contacts is FALSE count() issues are E_WARNING
Roland Haeder [Tue, 1 Mar 2016 13:38:02 +0000 (14:38 +0100)]
Also use is_filled_array() here, too. if $contacts is FALSE count() issues are E_WARNING

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoIntroduced is_filled_array() + added some missing array initialization
Roland Haeder [Tue, 1 Mar 2016 13:33:54 +0000 (14:33 +0100)]
Introduced is_filled_array() + added some missing array initialization

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge branch 'rhaeder-develop' of github.com:Quix0r/friendica into rhaeder-develop
Roland Haeder [Tue, 1 Mar 2016 17:31:33 +0000 (18:31 +0100)]
Merge branch 'rhaeder-develop' of github.com:Quix0r/friendica into rhaeder-develop

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge branch 'develop' of github.com:friendica/friendica into rhaeder-develop
Roland Haeder [Tue, 1 Mar 2016 17:29:34 +0000 (18:29 +0100)]
Merge branch 'develop' of github.com:friendica/friendica into rhaeder-develop

8 years agoClosed TODO: no .= needed here. #2392
Roland Haeder [Tue, 1 Mar 2016 17:28:06 +0000 (18:28 +0100)]
Closed TODO: no .= needed here. #2392

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoAlso use is_filled_array() here, too. if $contacts is FALSE count() issues are E_WARNING
Roland Haeder [Tue, 1 Mar 2016 13:38:02 +0000 (14:38 +0100)]
Also use is_filled_array() here, too. if $contacts is FALSE count() issues are E_WARNING

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoIntroduced is_filled_array() + added some missing array initialization
Roland Haeder [Tue, 1 Mar 2016 13:33:54 +0000 (14:33 +0100)]
Introduced is_filled_array() + added some missing array initialization

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years ago<form> and <html> or <head> are not self-closing tags.
Roland Haeder [Tue, 1 Mar 2016 13:49:56 +0000 (14:49 +0100)]
<form> and <html> or <head> are not self-closing tags.

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoDon't miss to add exit() after header('Location: bla') as header() does *NOT*
Roland Haeder [Tue, 1 Mar 2016 13:49:07 +0000 (14:49 +0100)]
Don't miss to add exit() after header('Location: bla') as header() does *NOT*
exit the script quickly enough. Always use an explicit exit() or you get real
trouble.

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMore logging in case of errors + logged network type + added TODO (for ugly E_NOTICE).
Roland Haeder [Tue, 1 Mar 2016 13:42:55 +0000 (14:42 +0100)]
More logging in case of errors + logged network type + added TODO (for ugly E_NOTICE).

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoPrevent some E_NOTICE in identity.php
Roland Haeder [Tue, 1 Mar 2016 13:36:23 +0000 (14:36 +0100)]
Prevent some E_NOTICE in identity.php

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoPrevent some E_NOTICE in boot.php
Roland Haeder [Tue, 1 Mar 2016 13:32:19 +0000 (14:32 +0100)]
Prevent some E_NOTICE in boot.php

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoNo need to set $a->theme_info = array() everywhere if you can define it in App
Roland Haeder [Tue, 1 Mar 2016 13:27:38 +0000 (14:27 +0100)]
No need to set $a->theme_info = array() everywhere if you can define it in App
itself.

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoClosed TODO: no .= needed here. #2392
Roland Haeder [Tue, 1 Mar 2016 17:28:06 +0000 (18:28 +0100)]
Closed TODO: no .= needed here. #2392

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMore calls replaced with is_filled_array(), ticket #2390
Roland Haeder [Tue, 1 Mar 2016 15:00:55 +0000 (16:00 +0100)]
More calls replaced with is_filled_array(), ticket #2390

Signed-off-by: Roland Haeder <roland@mxchange.org>
8 years agoMerge pull request #2388 from Quix0r/fixes/prevent-e_notice_boot_php
fabrixxm [Tue, 1 Mar 2016 14:50:20 +0000 (15:50 +0100)]
Merge pull request #2388 from Quix0r/fixes/prevent-e_notice_boot_php

Prevent some E_NOTICE

8 years agoMerge pull request #2391 from Quix0r/fixes/http-security
fabrixxm [Tue, 1 Mar 2016 14:33:31 +0000 (15:33 +0100)]
Merge pull request #2391 from Quix0r/fixes/http-security

Missing exit() after header('Location: bla') is bad news

8 years agoMerge pull request #2389 from Quix0r/rewrites/theme_info_array_init
fabrixxm [Tue, 1 Mar 2016 14:32:34 +0000 (15:32 +0100)]
Merge pull request #2389 from Quix0r/rewrites/theme_info_array_init

$a->theme_info = array() should be avoided

8 years agoMerge pull request #2387 from Quix0r/fixes/html-errors
fabrixxm [Tue, 1 Mar 2016 14:31:28 +0000 (15:31 +0100)]
Merge pull request #2387 from Quix0r/fixes/html-errors

Some tags should not be self-closed

8 years ago<form> and <html> or <head> are not self-closing tags.
Roland Haeder [Tue, 1 Mar 2016 13:49:56 +0000 (14:49 +0100)]
<form> and <html> or <head> are not self-closing tags.

Signed-off-by: Roland Haeder <roland@mxchange.org>