]> git.mxchange.org Git - quix0rs-gnu-social.git/log
quix0rs-gnu-social.git
14 years agoMerge branch 'master' of git@gitorious.org:statusnet/mainline
Evan Prodromou [Thu, 25 Mar 2010 21:24:10 +0000 (17:24 -0400)]
Merge branch 'master' of git@gitorious.org:statusnet/mainline

14 years agoIf indenting is disabled on the output, this fixes the entity_tags crop
Sarven Capadisli [Thu, 25 Mar 2010 16:47:04 +0000 (17:47 +0100)]
If indenting is disabled on the output, this fixes the entity_tags crop

14 years agoFix for processing indicator for aside
Sarven Capadisli [Thu, 25 Mar 2010 16:33:59 +0000 (17:33 +0100)]
Fix for processing indicator for aside

14 years agoUpdated biz theme to use realtime icons from core
Sarven Capadisli [Thu, 25 Mar 2010 14:08:00 +0000 (15:08 +0100)]
Updated biz theme to use realtime icons from core

14 years agoA lot of updates to keep the themes current (at least in functionality)
Sarven Capadisli [Wed, 24 Mar 2010 22:31:30 +0000 (23:31 +0100)]
A lot of updates to keep the themes current (at least in functionality)

14 years agolocation -> label class for cloudy
Sarven Capadisli [Wed, 24 Mar 2010 21:40:59 +0000 (22:40 +0100)]
location -> label class for cloudy

14 years agoUsing unique @for, @id pair for jabber and sms options in subscriptions
Sarven Capadisli [Wed, 24 Mar 2010 20:34:53 +0000 (21:34 +0100)]
Using unique @for, @id pair for jabber and sms options in subscriptions

14 years agoUsing hCard label instead of location. Matches userprofile.
Sarven Capadisli [Wed, 24 Mar 2010 19:58:13 +0000 (20:58 +0100)]
Using hCard label instead of location. Matches userprofile.

14 years agoUpdated tag list output in subscriptions list. Matches userprofile.
Sarven Capadisli [Wed, 24 Mar 2010 19:50:07 +0000 (20:50 +0100)]
Updated tag list output in subscriptions list. Matches userprofile.

14 years agoRemoved print stylesheet
Sarven Capadisli [Wed, 24 Mar 2010 14:13:38 +0000 (15:13 +0100)]
Removed print stylesheet

14 years agoMoved print inside base stylesheet using media rules. One less HTTP GET.
Sarven Capadisli [Wed, 24 Mar 2010 13:50:12 +0000 (14:50 +0100)]
Moved print inside base stylesheet using media rules. One less HTTP GET.

14 years agoMinor core alignment for cloudy
Sarven Capadisli [Mon, 22 Mar 2010 13:14:07 +0000 (14:14 +0100)]
Minor core alignment for cloudy

14 years agoUpdated logos
Sarven Capadisli [Mon, 22 Mar 2010 13:07:59 +0000 (14:07 +0100)]
Updated logos

14 years agoRemoved box-shadow and outline on notice more link focus
Sarven Capadisli [Fri, 19 Mar 2010 21:26:50 +0000 (22:26 +0100)]
Removed box-shadow and outline on notice more link focus

14 years agoUsing opacity on the notice more link icon
Sarven Capadisli [Fri, 19 Mar 2010 18:06:54 +0000 (19:06 +0100)]
Using opacity on the notice more link icon

14 years agoMinor margin to more link
Sarven Capadisli [Fri, 19 Mar 2010 17:35:40 +0000 (18:35 +0100)]
Minor margin to more link

14 years agoUpdated biz theme logo
Sarven Capadisli [Fri, 19 Mar 2010 09:06:06 +0000 (10:06 +0100)]
Updated biz theme logo

14 years agoAdded processing indicator for more anchor
Sarven Capadisli [Thu, 18 Mar 2010 22:00:38 +0000 (23:00 +0100)]
Added processing indicator for more anchor

14 years agoUsing an icon to represent the action for more text
Sarven Capadisli [Thu, 18 Mar 2010 13:29:35 +0000 (14:29 +0100)]
Using an icon to represent the action for more text

14 years agoUsing … (hellip) instead of "more" for link text
Sarven Capadisli [Thu, 18 Mar 2010 13:26:30 +0000 (14:26 +0100)]
Using … (hellip) instead of "more" for link text

14 years agoUpdated 'more' anchor for attachments to do an XHR GET
Brion Vibber [Thu, 25 Mar 2010 21:15:54 +0000 (14:15 -0700)]
Updated 'more' anchor for attachments to do an XHR GET

Conflicts:

lib/attachmentlist.php
plugins/OStatus/classes/Ostatus_profile.php

Merge tried to delete things that it seems it shouldn't, very confusing order. Hope rest of the cherry-picking isn't a problem.

14 years agoadd whitelist and blacklist for openid URLs
Evan Prodromou [Thu, 25 Mar 2010 20:58:05 +0000 (16:58 -0400)]
add whitelist and blacklist for openid URLs

14 years agoRemoved unnecessary form_id. Using jQuery .find() instead of
Sarven Capadisli [Tue, 16 Mar 2010 20:02:56 +0000 (21:02 +0100)]
Removed unnecessary form_id. Using jQuery .find() instead of
constructing the selector.

14 years agoAdded extra condition to focusing on notice form on page load. If the
Sarven Capadisli [Tue, 16 Mar 2010 19:53:49 +0000 (20:53 +0100)]
Added extra condition to focusing on notice form on page load. If the
window location contains a fragument identifier, it will skip focus
and do what the UA does natively.

14 years agoRemoved dangling stylesheet
Sarven Capadisli [Tue, 16 Mar 2010 18:34:20 +0000 (19:34 +0100)]
Removed dangling stylesheet

14 years agoMerge branch 'testing' of git@gitorious.org:statusnet/mainline into testing
Evan Prodromou [Thu, 25 Mar 2010 20:35:35 +0000 (16:35 -0400)]
Merge branch 'testing' of git@gitorious.org:statusnet/mainline into testing

14 years agoremove debugging calls
Evan Prodromou [Thu, 25 Mar 2010 20:35:22 +0000 (16:35 -0400)]
remove debugging calls

14 years agoUsing rel=external instead of class=external for jOverlay title link
Sarven Capadisli [Sun, 14 Mar 2010 19:01:24 +0000 (15:01 -0400)]
Using rel=external instead of class=external for jOverlay title link

14 years agoAdded rel=external to geo location link
Sarven Capadisli [Sun, 14 Mar 2010 18:11:21 +0000 (14:11 -0400)]
Added rel=external to geo location link

14 years agoUpdated plugin to open external links on a new window that are not
Sarven Capadisli [Sun, 14 Mar 2010 18:06:14 +0000 (14:06 -0400)]
Updated plugin to open external links on a new window that are not
attachments

14 years agoAssigned an identifier for the representative user and group profile
Sarven Capadisli [Sat, 13 Mar 2010 21:48:21 +0000 (16:48 -0500)]
Assigned an identifier for the representative user and group profile

14 years agoAnd clarify a little more
Brion Vibber [Thu, 25 Mar 2010 19:48:31 +0000 (12:48 -0700)]
And clarify a little more

14 years agoClarify RewriteBase comment in htaccess.sample
Brion Vibber [Thu, 25 Mar 2010 19:21:02 +0000 (12:21 -0700)]
Clarify RewriteBase comment in htaccess.sample

14 years agoMerge commit 'origin/master' into testing
Brion Vibber [Thu, 25 Mar 2010 18:43:26 +0000 (11:43 -0700)]
Merge commit 'origin/master' into testing

Conflicts:
classes/Notice.php

14 years agoMerge branch 'blacklisttable' into testing
Evan Prodromou [Thu, 25 Mar 2010 17:51:52 +0000 (13:51 -0400)]
Merge branch 'blacklisttable' into testing

14 years agoMerge branch 'testing' of git@gitorious.org:statusnet/mainline into testing
Evan Prodromou [Thu, 25 Mar 2010 17:50:49 +0000 (13:50 -0400)]
Merge branch 'testing' of git@gitorious.org:statusnet/mainline into testing

14 years agoStore blacklist patterns in their own tables
Evan Prodromou [Thu, 25 Mar 2010 17:49:12 +0000 (13:49 -0400)]
Store blacklist patterns in their own tables

We were bumping into limits on the config format in the Blacklist
plugin. So, added new tables for nickname and homepage blacklists, and
changed the plugin to use those instead of config file (actually,
still uses config file in addition, for compatibility).

14 years agoFix for API group methods, caused failure or output corruption when pulling up local...
Brion Vibber [Wed, 24 Mar 2010 20:36:57 +0000 (13:36 -0700)]
Fix for API group methods, caused failure or output corruption when pulling up local groups by name in api/statusnet/groups/is_member.json/xml

14 years agoFix for API group methods, caused failure or output corruption when pulling up local...
Brion Vibber [Wed, 24 Mar 2010 20:36:57 +0000 (13:36 -0700)]
Fix for API group methods, caused failure or output corruption when pulling up local groups by name in api/statusnet/groups/is_member.json/xml

14 years agoMake sure we're requiring the library
James Walker [Wed, 24 Mar 2010 19:26:03 +0000 (15:26 -0400)]
Make sure we're requiring the library

14 years agoUpdated Math_Biginteger from upstream - removing safe* workarounds
James Walker [Wed, 24 Mar 2010 19:18:41 +0000 (15:18 -0400)]
Updated Math_Biginteger from upstream - removing safe* workarounds

14 years agoCheck for 0.9.0 bad keys from old Crypt_RSA library
James Walker [Wed, 24 Mar 2010 19:15:20 +0000 (15:15 -0400)]
Check for 0.9.0 bad keys from old Crypt_RSA library

14 years agoA bit safer checking in the keypair parsing
James Walker [Wed, 24 Mar 2010 18:27:35 +0000 (14:27 -0400)]
A bit safer checking in the keypair parsing

14 years agoLook for the first object in the Activity
Zach Copley [Wed, 24 Mar 2010 07:00:55 +0000 (00:00 -0700)]
Look for the first object in the Activity

14 years agoImprove legibility of OStatus remote tests output
Brion Vibber [Wed, 24 Mar 2010 01:56:40 +0000 (18:56 -0700)]
Improve legibility of OStatus remote tests output

14 years agoadd a general PuSHed post and an @-reply back to a subscribee by name to OStatus...
Brion Vibber [Wed, 24 Mar 2010 01:44:54 +0000 (18:44 -0700)]
add a general PuSHed post and an @-reply back to a subscribee by name to OStatus remote test cases

14 years agofixup_deletions.php script to look for notices posted by now-deleted profiles and...
Brion Vibber [Wed, 24 Mar 2010 00:24:01 +0000 (17:24 -0700)]
fixup_deletions.php script to look for notices posted by now-deleted profiles and remove them.

14 years agofixup_deletions.php script to look for notices posted by now-deleted profiles and...
Brion Vibber [Wed, 24 Mar 2010 00:24:01 +0000 (17:24 -0700)]
fixup_deletions.php script to look for notices posted by now-deleted profiles and remove them.

14 years agoAdd basic subscribe/unsubscribe test to OStatus test cases
Brion Vibber [Tue, 23 Mar 2010 21:19:12 +0000 (14:19 -0700)]
Add basic subscribe/unsubscribe test to OStatus test cases

14 years agoDon't spew XML parse warnings to output when checking a remote XRD page
Brion Vibber [Tue, 23 Mar 2010 21:18:45 +0000 (14:18 -0700)]
Don't spew XML parse warnings to output when checking a remote XRD page

14 years agoFOAF was missing OStatus remote subscriptions, now fixed.
Brion Vibber [Tue, 23 Mar 2010 20:10:23 +0000 (13:10 -0700)]
FOAF was missing OStatus remote subscriptions, now fixed.

14 years agoMerge branch 'master' of git@gitorious.org:statusnet/mainline into testing
Brion Vibber [Tue, 23 Mar 2010 19:13:32 +0000 (12:13 -0700)]
Merge branch 'master' of git@gitorious.org:statusnet/mainline into testing

14 years agoConsistently send Profiles into Fave::addNew()
Brion Vibber [Tue, 23 Mar 2010 18:06:37 +0000 (11:06 -0700)]
Consistently send Profiles into Fave::addNew()

14 years agoprevent password login actions in OpenID-only mode
Evan Prodromou [Tue, 23 Mar 2010 16:58:10 +0000 (12:58 -0400)]
prevent password login actions in OpenID-only mode

14 years agoDon't add PHPSESSID parameter onto notice and conversation URIs if we save a notice...
Brion Vibber [Tue, 23 Mar 2010 16:50:01 +0000 (09:50 -0700)]
Don't add PHPSESSID parameter onto notice and conversation URIs if we save a notice during a session override.
This was being triggered by welcomebot messages created at account creation time, then propagated through replies.

14 years agochange router to allow hooking path connections
Evan Prodromou [Tue, 23 Mar 2010 16:33:41 +0000 (12:33 -0400)]
change router to allow hooking path connections

14 years agostart making OpenID-only mode work
Evan Prodromou [Tue, 23 Mar 2010 16:10:26 +0000 (12:10 -0400)]
start making OpenID-only mode work

14 years agoreformat OpenIDPlugin for PHPCS
Evan Prodromou [Tue, 23 Mar 2010 15:36:02 +0000 (11:36 -0400)]
reformat OpenIDPlugin for PHPCS

14 years agoFix reference. Look at the first ActivityObject in the list.
Zach Copley [Tue, 23 Mar 2010 04:48:21 +0000 (21:48 -0700)]
Fix reference. Look at the first ActivityObject in the list.

14 years agoSome initial media parsing
Zach Copley [Tue, 23 Mar 2010 01:53:09 +0000 (18:53 -0700)]
Some initial media parsing
- Activity now returns a list of activity objects
- Processing of photo objects

14 years agoMerge branch 'testing' of gitorious.org:statusnet/mainline into testing
Zach Copley [Tue, 23 Mar 2010 01:54:46 +0000 (18:54 -0700)]
Merge branch 'testing' of gitorious.org:statusnet/mainline into testing

* 'testing' of gitorious.org:statusnet/mainline:
  OStatus remote sending test cases. Doesn't actually run within PHPUnit right now, must be run from command line -- specify base URLs to two StatusNet sites that will be able to communicate with each other.
  Math_BigInteger doesn't correctly handle serialization/deserialization for a value of 0, which can end up spewing notices to output and otherwise intefering with Salmon signature setup and verification when using memcached.
  Log backtraces for non-ClientException exceptions caught at the top-level handler.
  Confirm there's actually user and domain portions of acct string before assigning things from output of explode(); avoids notice message when invalid input passed to main/xrd
  Fixing HTTP Header LRDD parsing (sites in subdirectories need this)
  Replace the "give up and dump object" attachment view fallback with a client-side redirect to the target URL, which will at least be useful.
  ignore unrecognized object types
  Pull <atom:author> info as well as <activity:actor> when we have an old-style ActivityStreams feed. This fixes subscription setup for Cliqset feeds, which currently have a bogus activity:actor/atom:id but a good atom:author/atom:uri
  Accept 'tag' and other non-http id URIs in Ostatus_profile::getActivityObjectProfileURI().

14 years agoOStatus remote sending test cases. Doesn't actually run within PHPUnit right now...
Brion Vibber [Mon, 22 Mar 2010 22:55:13 +0000 (15:55 -0700)]
OStatus remote sending test cases. Doesn't actually run within PHPUnit right now, must be run from command line -- specify base URLs to two StatusNet sites that will be able to communicate with each other.

Current test run includes:
* register accounts (via web form)
* local post
* @-mention using path (@domain/path/to/user)

Subscriptions, webfinger mentions, various paths to subscription and unsubscription, etc to come.

14 years agoMath_BigInteger doesn't correctly handle serialization/deserialization for a value...
Brion Vibber [Mon, 22 Mar 2010 19:17:45 +0000 (12:17 -0700)]
Math_BigInteger doesn't correctly handle serialization/deserialization for a value of 0, which can end up spewing notices to output and otherwise intefering with Salmon signature setup and verification when using memcached.
Worked around this with a subclass that fixes the wakeup, used for the stored 0 value in the subclassed Crypt_RSA.

14 years agoLog backtraces for non-ClientException exceptions caught at the top-level handler.
Brion Vibber [Mon, 22 Mar 2010 18:33:56 +0000 (11:33 -0700)]
Log backtraces for non-ClientException exceptions caught at the top-level handler.

14 years agoConfirm there's actually user and domain portions of acct string before assigning...
Brion Vibber [Mon, 22 Mar 2010 18:27:39 +0000 (11:27 -0700)]
Confirm there's actually user and domain portions of acct string before assigning things from output of explode(); avoids notice message when invalid input passed to main/xrd

14 years agoReplace the "give up and dump object" attachment view fallback with a client-side...
Brion Vibber [Mon, 22 Mar 2010 17:35:54 +0000 (10:35 -0700)]
Replace the "give up and dump object" attachment view fallback with a client-side redirect to the target URL, which will at least be useful.

14 years agoFixing HTTP Header LRDD parsing (sites in subdirectories need this)
James Walker [Mon, 22 Mar 2010 17:44:05 +0000 (13:44 -0400)]
Fixing HTTP Header LRDD parsing (sites in subdirectories need this)

14 years agoReplace the "give up and dump object" attachment view fallback with a client-side...
Brion Vibber [Mon, 22 Mar 2010 17:35:54 +0000 (10:35 -0700)]
Replace the "give up and dump object" attachment view fallback with a client-side redirect to the target URL, which will at least be useful.

14 years agoignore unrecognized object types
Evan Prodromou [Mon, 22 Mar 2010 12:17:14 +0000 (08:17 -0400)]
ignore unrecognized object types

14 years agoFix broken assertion
Zach Copley [Mon, 22 Mar 2010 01:47:43 +0000 (18:47 -0700)]
Fix broken assertion

14 years agoPull <atom:author> info as well as <activity:actor> when we have an old-style Activit...
Brion Vibber [Sun, 21 Mar 2010 23:25:12 +0000 (16:25 -0700)]
Pull <atom:author> info as well as <activity:actor> when we have an old-style ActivityStreams feed. This fixes subscription setup for Cliqset feeds, which currently have a bogus activity:actor/atom:id but a good atom:author/atom:uri

14 years agoAccept 'tag' and other non-http id URIs in Ostatus_profile::getActivityObjectProfileU...
Brion Vibber [Sun, 21 Mar 2010 22:46:28 +0000 (15:46 -0700)]
Accept 'tag' and other non-http id URIs in Ostatus_profile::getActivityObjectProfileURI().

(If there's not a valid ID we fall back to the link, which we do still validate as http/s.)

14 years agoOStatus profile setup cleanup
Brion Vibber [Sun, 21 Mar 2010 22:18:37 +0000 (15:18 -0700)]
OStatus profile setup cleanup
* drop OStatusPlugin::localProfileFromUrl(), we can just look up on user.uri
* clean up a few edge cases that returned null through Ostatus_profile::ensure* code paths, now throws clear exception when we can't find a feed from the given profile url
* add some doc comments on the ensure* methods

14 years agoonly use Posterous author data if it matches the profile URL
Evan Prodromou [Sun, 21 Mar 2010 12:37:58 +0000 (07:37 -0500)]
only use Posterous author data if it matches the profile URL

14 years agouse Posterous element if available for RssChannel discovery
Evan Prodromou [Sat, 20 Mar 2010 22:18:55 +0000 (17:18 -0500)]
use Posterous element if available for RssChannel discovery

14 years agocorrect creation of avatar links for RSS and Posterous elements
Evan Prodromou [Sat, 20 Mar 2010 22:18:24 +0000 (17:18 -0500)]
correct creation of avatar links for RSS and Posterous elements

14 years agomove atom category to its own file, too
Evan Prodromou [Sat, 20 Mar 2010 21:55:36 +0000 (16:55 -0500)]
move atom category to its own file, too

14 years agotest posterous author use
Evan Prodromou [Sat, 20 Mar 2010 21:53:47 +0000 (16:53 -0500)]
test posterous author use

14 years agospecial-case Posterous author element for activity actor
Evan Prodromou [Sat, 20 Mar 2010 21:53:30 +0000 (16:53 -0500)]
special-case Posterous author element for activity actor

14 years agoMove activity classes to their own files
Evan Prodromou [Sat, 20 Mar 2010 21:06:22 +0000 (16:06 -0500)]
Move activity classes to their own files

Moved the various classes used by the Activity class to their own
files. There were >10 classes in the same file, with around 1500 lines
in the file. Just too big.

This change makes autoloading work for these classes, so also removed
the hard require in lib/common.php.

14 years agouse feedEl for discovery
Evan Prodromou [Sat, 20 Mar 2010 14:46:22 +0000 (09:46 -0500)]
use feedEl for discovery

14 years agofall back to summary or title if content not available
Evan Prodromou [Sat, 20 Mar 2010 14:30:57 +0000 (09:30 -0500)]
fall back to summary or title if content not available

14 years agoallow html content in summary and clean it out of title
Evan Prodromou [Sat, 20 Mar 2010 14:30:28 +0000 (09:30 -0500)]
allow html content in summary and clean it out of title

14 years agoAllow PuSH posts without author information
Evan Prodromou [Sat, 20 Mar 2010 13:25:56 +0000 (08:25 -0500)]
Allow PuSH posts without author information

Superfeedr (sp.?) posts entries without author information. We can
assume that this is intended to be by the original author.
Re-structured the checks for entries that come in by PuSH so they can
either have no author or an empty author, but not a different author.

14 years agohandle RSS as well as Atom in Ostatus push hits
Evan Prodromou [Sat, 20 Mar 2010 12:23:13 +0000 (07:23 -0500)]
handle RSS as well as Atom in Ostatus push hits

14 years agorename $rss to $channel to prevent misunderstanding
Evan Prodromou [Sat, 20 Mar 2010 12:19:54 +0000 (07:19 -0500)]
rename $rss to $channel to prevent misunderstanding

RSS feeds have the format
<rss><channel><item/><item/><item/></channel></rss>. The element named
$rss was actually the <channel> element, so I renamed the variable so
I wouldn't hurt my head.

14 years agoMerge branch 'testing' of git@gitorious.org:statusnet/mainline into testing
Evan Prodromou [Sat, 20 Mar 2010 11:44:55 +0000 (06:44 -0500)]
Merge branch 'testing' of git@gitorious.org:statusnet/mainline into testing

14 years agotry to make a nickname from the user profile url before using the URI
Evan Prodromou [Sat, 20 Mar 2010 11:44:38 +0000 (06:44 -0500)]
try to make a nickname from the user profile url before using the URI

14 years agoAvoid notices for accessing undefined array indices in hcard processing
Brion Vibber [Fri, 19 Mar 2010 22:54:16 +0000 (15:54 -0700)]
Avoid notices for accessing undefined array indices in hcard processing

14 years agoOStatus: be a little laxer about attempts to start/stop PuSH subscriptions that were...
Brion Vibber [Fri, 19 Mar 2010 22:47:43 +0000 (15:47 -0700)]
OStatus: be a little laxer about attempts to start/stop PuSH subscriptions that were left in an inconsistent state.
Instead of aborting, we'll try to reconfirm the sub/unsub, which once confirmed will replace whatever the previous state was on the server side.

14 years agoMerge branch 'master' of git@gitorious.org:statusnet/mainline into testing
Brion Vibber [Fri, 19 Mar 2010 22:29:00 +0000 (15:29 -0700)]
Merge branch 'master' of git@gitorious.org:statusnet/mainline into testing

14 years agoensure from an RSS channel
Evan Prodromou [Fri, 19 Mar 2010 20:50:06 +0000 (15:50 -0500)]
ensure from an RSS channel

14 years agomake deriving a subject from an RSS channel work
Evan Prodromou [Fri, 19 Mar 2010 20:49:38 +0000 (15:49 -0500)]
make deriving a subject from an RSS channel work

14 years agomove ActivityObject constructors from Activity to ActivityObject
Evan Prodromou [Fri, 19 Mar 2010 20:41:48 +0000 (15:41 -0500)]
move ActivityObject constructors from Activity to ActivityObject

14 years agoonly search elements for links
Evan Prodromou [Fri, 19 Mar 2010 20:28:25 +0000 (15:28 -0500)]
only search elements for links

14 years agoreturn empty hints if no hcard in the html
Evan Prodromou [Fri, 19 Mar 2010 20:28:06 +0000 (15:28 -0500)]
return empty hints if no hcard in the html

14 years agodefine a 'root' attribute for the channel or feed
Evan Prodromou [Fri, 19 Mar 2010 20:23:30 +0000 (15:23 -0500)]
define a 'root' attribute for the channel or feed

14 years agoFix typo in public tag cloud query setup which caused the cutoff to get skipped.
Brion Vibber [Fri, 19 Mar 2010 19:50:34 +0000 (12:50 -0700)]
Fix typo in public tag cloud query setup which caused the cutoff to get skipped.

14 years agoDrop result ID from data objects on clone(). This keeps the original object working...
Brion Vibber [Mon, 15 Mar 2010 22:41:57 +0000 (15:41 -0700)]
Drop result ID from data objects on clone(). This keeps the original object working if it was in the middle of a query loop, even if the cloned object falls out of scope and triggers its destructor.
This bug was hitting a number of places where we had the pattern:

$db->find();
while($dbo->fetch()) {
  $x = clone($dbo);
  // do anything with $x other than storing it in an array
}

The cloned object's destructor would trigger on the second run through the loop, freeing the database result set -- not really what we wanted.
(Loops that stored the clones into an array were fine, since the clones stay in scope in the array longer than the original does.)

Detaching the database result from the clone lets us work with its data without interfering with the rest of the query.
In the unlikely even that somebody is making clones in the middle of a query, then trying to continue the query with the clone instead of the original object, well they're gonna be broken now.

14 years agoclarify output on fixup-shadow.php
Brion Vibber [Fri, 19 Mar 2010 18:17:56 +0000 (11:17 -0700)]
clarify output on fixup-shadow.php