Evan Prodromou [Tue, 7 Dec 2010 20:26:43 +0000 (15:26 -0500)]
fix whitespace in lib/xrdaction.php
Brion Vibber [Tue, 7 Dec 2010 01:20:14 +0000 (17:20 -0800)]
For good measure, don't return autocomplete results when not logged in.
Brion Vibber [Tue, 7 Dec 2010 01:16:47 +0000 (17:16 -0800)]
reindent
Brion Vibber [Tue, 7 Dec 2010 01:15:56 +0000 (17:15 -0800)]
Tweak router target URL for Autocomplete suggestions
Brion Vibber [Tue, 7 Dec 2010 01:13:02 +0000 (17:13 -0800)]
Update Autocomplete readme: current state seems to work fine on private sites, so removing that note.
Brion Vibber [Tue, 7 Dec 2010 00:55:16 +0000 (16:55 -0800)]
Ticket #2924: include mini avatars in Autocomplete plugin drop-down list
Ticket #2923: don't show "(null)" for some profiles with no full name set
Brion Vibber [Tue, 7 Dec 2010 00:20:54 +0000 (16:20 -0800)]
Start tweaking Autocomplete js
Brion Vibber [Mon, 6 Dec 2010 23:20:49 +0000 (15:20 -0800)]
fix breakage in AutocompletePlugin
Brion Vibber [Mon, 6 Dec 2010 23:14:47 +0000 (15:14 -0800)]
Merge branch 'linkpreview-fix' into 0.9.x
Brion Vibber [Mon, 6 Dec 2010 23:11:42 +0000 (15:11 -0800)]
minify LinkPreview JS code
Brion Vibber [Mon, 6 Dec 2010 22:49:24 +0000 (14:49 -0800)]
Ticket #2921: cleanup on LinkPreview to make fewer requests while typing. Will now wait for each link's preview request to complete (successfully or unsuccessfully) before re-running it)
Evan Prodromou [Mon, 6 Dec 2010 22:28:22 +0000 (17:28 -0500)]
use codeKey() in activity caching
Evan Prodromou [Mon, 6 Dec 2010 22:22:34 +0000 (17:22 -0500)]
Merge branch '0.9.x' into cacheactivity
Evan Prodromou [Mon, 6 Dec 2010 22:22:03 +0000 (17:22 -0500)]
Merge branch 'master' into 0.9.x
Evan Prodromou [Mon, 6 Dec 2010 22:21:38 +0000 (17:21 -0500)]
Merge branch 'master' of gitorious.org:statusnet/mainline
Evan Prodromou [Mon, 6 Dec 2010 22:19:41 +0000 (17:19 -0500)]
Config flag to disable router caching if needed
Evan Prodromou [Mon, 6 Dec 2010 22:08:52 +0000 (17:08 -0500)]
use Cache::codeKey() in Router class
Evan Prodromou [Mon, 6 Dec 2010 22:05:32 +0000 (17:05 -0500)]
Make code-dependent cache entries more volatile
If a cache entry is dependent on the code that's running, upgrading
(or enabling/disabling plugins) can generate hard-to-track
inconsistencies.
This change adds a close-to-unique fingerprint of the running code to
some cache keys, so that if the fingerprint changes, the old values
are ignored and new values are used.
If the automated uniqueness fails, an administrator can add an extra
config value, $config['site']['build'], that's thrown into the key also.
Evan Prodromou [Mon, 6 Dec 2010 22:19:41 +0000 (17:19 -0500)]
Config flag to disable router caching if needed
Evan Prodromou [Mon, 6 Dec 2010 22:08:52 +0000 (17:08 -0500)]
use Cache::codeKey() in Router class
Evan Prodromou [Mon, 6 Dec 2010 22:05:32 +0000 (17:05 -0500)]
Make code-dependent cache entries more volatile
If a cache entry is dependent on the code that's running, upgrading
(or enabling/disabling plugins) can generate hard-to-track
inconsistencies.
This change adds a close-to-unique fingerprint of the running code to
some cache keys, so that if the fingerprint changes, the old values
are ignored and new values are used.
If the automated uniqueness fails, an administrator can add an extra
config value, $config['site']['build'], that's thrown into the key also.
Evan Prodromou [Mon, 6 Dec 2010 21:38:02 +0000 (16:38 -0500)]
cache generated activity info
Brion Vibber [Mon, 6 Dec 2010 21:37:57 +0000 (13:37 -0800)]
Use short API-style error responses for LinkPreview's oembed proxy
Evan Prodromou [Mon, 6 Dec 2010 20:52:03 +0000 (15:52 -0500)]
Merge branch '0.9.x' of gitorious.org:statusnet/mainline into 0.9.x
Evan Prodromou [Mon, 6 Dec 2010 20:51:42 +0000 (15:51 -0500)]
correctly generate enclosure in Activity::asString()
Brion Vibber [Mon, 6 Dec 2010 20:44:19 +0000 (12:44 -0800)]
Merge branch 'master' of gitorious.org:statusnet/mainline into 0.9.x
Conflicts:
classes/User.php
Brion Vibber [Mon, 6 Dec 2010 20:39:09 +0000 (12:39 -0800)]
Added User::singleUserNickname() as (temporary?) fallback for single-user lookup as a workaround for site setup of 1user sites. We found that an external tool attempting to spin up StatusNet and then register the user would fail because StatusNet's router setup dies on being unable to find its single-user account, since the nickname is needed in setting up routing entries. This tweak will let it survive, using the configured setting as a fallback if it can't actually find the user account.
Evan Prodromou [Mon, 6 Dec 2010 20:22:52 +0000 (15:22 -0500)]
remove common_debug() from Activity::asString()
Evan Prodromou [Sun, 5 Dec 2010 21:31:43 +0000 (16:31 -0500)]
updated NoticeTitle plugin to use new activity events
Evan Prodromou [Sun, 5 Dec 2010 21:20:00 +0000 (16:20 -0500)]
Change documentation for notice-to-activity events
Because I changed Notice::asAtomEntry() to use Notice::asActivity(),
all the events that happened in that function have been removed. I
removed the documentation for those events, and added documentation
for the new events.
Evan Prodromou [Sun, 5 Dec 2010 21:15:05 +0000 (16:15 -0500)]
Convert Notice::asAtomEntry() to use Notice::asActivity() and Activity::asString()
We had two ways to generate an activity entry from a notice; one through
Notice::asAtomEntry() and one through Notice::asActivity() and
Activity::asString(). The code paths had already diverged somewhat. I
took the conditions that were in Notice::asAtomEntry() and made sure
they were replicated in the other two functions. Then, I rewrote
Notice::asAtomEntry() to use the other two functions instead.
This change passes the ActivityGenerationTests unit tests, but there
may be some other stuff that's not getting covered.
Brion Vibber [Thu, 2 Dec 2010 21:59:51 +0000 (13:59 -0800)]
URL shortening fix for direct messages: if we're going to shorten the text, shorten the rendered text too.
Brion Vibber [Thu, 2 Dec 2010 18:56:44 +0000 (10:56 -0800)]
Fix for tickets #2917, #2262: user URL shortening options not being applied in non-web channels
common_shorten_links() can only access the web session's logged-in user, so never properly took user options into effect for posting via XMPP, API, mail, etc.
Adds an optional $user parameter on common_shorten_links(), and a $user->shortenLinks() as a clearer interface for that.
Tweaked some lower-level functions so $user gets passed down -- making the $notice_id param previously there for saving URLs at notice save time generalized a little.
Note also ticket #2919: there's a lot of duplicate code calling the shortening, checking the length, and reporting near-identical error messages. These should be consolidated to aid in code and translation maintenance.
Siebrand Mazeland [Thu, 2 Dec 2010 11:42:58 +0000 (12:42 +0100)]
* fix typo in parameter notation
* add FIXME for unused message
* remove superfluous whitespace
Siebrand Mazeland [Thu, 2 Dec 2010 11:33:03 +0000 (12:33 +0100)]
* Fix an incorrectly formatted message parameter in line 334.
* i18n/L10n updates
* translator documentation updated
Brion Vibber [Wed, 1 Dec 2010 22:23:56 +0000 (14:23 -0800)]
Ticket #2912 further cleanup: use JS on emailsettings form to help connect the 'I want to post by email' checkbox with the controls for adding or removing a post-by-email alias.
Now, when you first come up the checkbox will most likely be off and the button to create an address is grayed out.
Checking the box enables use of the 'new' button to generate an email address -- it's left disabled until you check the box, so you can't accidentally trip it.
Actually adding the address now enables the post-by-mail option, as well, thus ensuring that it's saved. WARNING: OTHER CHANGES ON THE FORM WILL STILL BE LOST.
Removing the address now disables the post-by-mail option, so it's not sitting around confusingly enabled but useless.
You can still disable the checkbox manually without removing the address, in case you want to keep it for later.
It's also still possible to actually save it in the state where the option is enabled, but there's no configured address, but that shouldn't happen too often. Possibly that should be prevented outright though.
Brion Vibber [Wed, 1 Dec 2010 21:10:54 +0000 (13:10 -0800)]
Ticket #2912 tweaks: clean up wording on the incoming email generator box a bit.
Brion Vibber [Wed, 1 Dec 2010 21:04:18 +0000 (13:04 -0800)]
Ticket #2912: move 'I want to post notices by email" checkbox up from the email *output* prefs up into the box for the address to post to, so they're next to each other.
Brion Vibber [Wed, 1 Dec 2010 20:21:00 +0000 (12:21 -0800)]
Fix for ticket #2911: Hitting enter on the "associate with current account" in OpenID flow failed due to forms being mixed together
Separating the two forms (one to create a local account, the other to attach the OpenID to an existing account) gets them working -- enter activates the appropriate default button.
Brion Vibber [Wed, 1 Dec 2010 19:21:00 +0000 (11:21 -0800)]
Fix dumb mistake -- changed function names partway through writing Nickname and forgot to update a couple places. :)
Evan Prodromou [Wed, 1 Dec 2010 18:43:34 +0000 (13:43 -0500)]
add OpenID data to the Webfinger XRD file so you can login with it elsewhere
Evan Prodromou [Wed, 1 Dec 2010 14:48:58 +0000 (09:48 -0500)]
Merge remote branch 'gitorious/0.9.x' into 0.9.x
Brion Vibber [Wed, 1 Dec 2010 01:09:14 +0000 (01:09 +0000)]
Ticket #2913: Realtime background update marker no longer triggers false positives when clearing the marker on switching away from the tab in Firefox 4
We were clearing the counter on the window title in the blur event, which gets fired *after* we switch away, thus triggering Firefox to mark the tab as updated again.
Clearing the counter on *focus* instead avoids this, and keeps the counter out of the way as well.
Brion Vibber [Wed, 1 Dec 2010 00:46:11 +0000 (16:46 -0800)]
Fix ticket #2914: Realtime no longer tells you it's got a message queued up when it's really the one you just sent out and is already visible.
Brion Vibber [Wed, 1 Dec 2010 00:35:47 +0000 (16:35 -0800)]
Went through realtimeupdate.js and added documentation comments -- does not alter the minified version. :)
Identified several bugs and fixmes, and added more thorough labeling of the issues with replicating the entire HTML structure of notices (no i18n, missing new features, maintenance problems, possible other issues)
Brion Vibber [Wed, 1 Dec 2010 00:34:52 +0000 (16:34 -0800)]
Merge branch 'master' of gitorious.org:statusnet/mainline into 0.9.x
Conflicts:
lib/router.php
Brion Vibber [Tue, 30 Nov 2010 20:46:33 +0000 (12:46 -0800)]
Flush router cache when saving Twitter admin settings: adding/removing keys can enable/disable some actions. This avoids having users' Twitter settings unreachable after adding your keys to an installation with TwitterBridge on but not pre-configured.
Brion Vibber [Tue, 30 Nov 2010 20:40:23 +0000 (12:40 -0800)]
BitlyPlugin: fix for shortening URLs containing ampersand (&)
Siebrand Mazeland [Tue, 30 Nov 2010 20:35:25 +0000 (21:35 +0100)]
Localisation updates from http://translatewiki.net.
Evan Prodromou [Tue, 30 Nov 2010 19:46:45 +0000 (14:46 -0500)]
Merge branch '0.9.x' of gitorious.org:statusnet/mainline into 0.9.x
Evan Prodromou [Tue, 30 Nov 2010 19:46:26 +0000 (14:46 -0500)]
Merge branch 'master' into 0.9.x
Conflicts:
lib/router.php
Evan Prodromou [Tue, 30 Nov 2010 19:44:16 +0000 (14:44 -0500)]
was using Cache::get() and ::set() wrong
Siebrand Mazeland [Tue, 30 Nov 2010 17:53:04 +0000 (18:53 +0100)]
Localisation updates from http://translatewiki.net.
Evan Prodromou [Tue, 30 Nov 2010 15:27:32 +0000 (10:27 -0500)]
a quick script to flush the router from cache if needed
Evan Prodromou [Tue, 30 Nov 2010 15:27:32 +0000 (10:27 -0500)]
a quick script to flush the router from cache if needed
Evan Prodromou [Tue, 30 Nov 2010 15:11:39 +0000 (10:11 -0500)]
use a CRC32 of the plugin names rather than actual names
Evan Prodromou [Tue, 30 Nov 2010 15:11:39 +0000 (10:11 -0500)]
use a CRC32 of the plugin names rather than actual names
Evan Prodromou [Tue, 30 Nov 2010 14:57:02 +0000 (09:57 -0500)]
Squashed commit of the following:
commit
39fdd181d95d2c39a3ea1ca330b10a99a92b961f
Author: Evan Prodromou <evan@status.net>
Date: Mon Nov 29 10:37:49 2010 -0500
use cache key prefix for router cache key
commit
4cb9e56941922489b83d6425c059cf770991e68f
Author: Evan Prodromou <evan@status.net>
Date: Mon Nov 29 10:31:21 2010 -0500
use a unique hashkey based on the software version and loaded plugins
commit
44458b48aef719543e11f83b41fded65cbcb8be9
Author: Evan Prodromou <evan@status.net>
Date: Sat Nov 27 17:04:15 2010 -0500
cache the NUM object
commit
809c188307a9b4ada15f3d7fa573a6034341efef
Author: Evan Prodromou <evan@status.net>
Date: Sat Nov 27 15:44:12 2010 -0500
accelerate routing by pivoting paths on actions
Evan Prodromou [Tue, 30 Nov 2010 14:57:02 +0000 (09:57 -0500)]
Squashed commit of the following:
commit
39fdd181d95d2c39a3ea1ca330b10a99a92b961f
Author: Evan Prodromou <evan@status.net>
Date: Mon Nov 29 10:37:49 2010 -0500
use cache key prefix for router cache key
commit
4cb9e56941922489b83d6425c059cf770991e68f
Author: Evan Prodromou <evan@status.net>
Date: Mon Nov 29 10:31:21 2010 -0500
use a unique hashkey based on the software version and loaded plugins
commit
44458b48aef719543e11f83b41fded65cbcb8be9
Author: Evan Prodromou <evan@status.net>
Date: Sat Nov 27 17:04:15 2010 -0500
cache the NUM object
commit
809c188307a9b4ada15f3d7fa573a6034341efef
Author: Evan Prodromou <evan@status.net>
Date: Sat Nov 27 15:44:12 2010 -0500
accelerate routing by pivoting paths on actions
Brion Vibber [Tue, 30 Nov 2010 00:47:51 +0000 (16:47 -0800)]
Merge branch 'namecase' into 0.9.x
Brion Vibber [Tue, 30 Nov 2010 00:44:40 +0000 (16:44 -0800)]
Normalize username strings in command parsing
Brion Vibber [Tue, 30 Nov 2010 00:44:01 +0000 (16:44 -0800)]
General code safety: validate input and escape SQL strings in common_relative_profile()
Brion Vibber [Tue, 30 Nov 2010 00:02:35 +0000 (16:02 -0800)]
Use Nickname::DISPLAY_FMT instead of manual regex fragments in router setup for nickname parameters.
Zach Copley [Mon, 29 Nov 2010 23:57:41 +0000 (23:57 +0000)]
FacebookBridge:
- Don't try to access Foreign_link if it doesn't exist
- Remove noisy debugging statement
Brion Vibber [Mon, 29 Nov 2010 23:11:07 +0000 (15:11 -0800)]
Replace a couple plugin usages of NICKNAME_FMT with Nickname::normalize()
Brion Vibber [Mon, 29 Nov 2010 23:04:21 +0000 (15:04 -0800)]
Add Nickname test cases for @-reply regexes in common_find_mentions
Brion Vibber [Mon, 29 Nov 2010 22:46:10 +0000 (14:46 -0800)]
Nickname class to encapsulate validation & common regexes for nickname formats.
This provides initial infrastructure for decoupling display names from internal canonical names, but continues to have us storing and using the canonical forms.
It should be/become possible to provide mixed-case and underscore-containing names in links, @-mention, !-group, etc, but we don't store those alternate forms generally.
Brion Vibber [Mon, 29 Nov 2010 22:15:25 +0000 (14:15 -0800)]
Work in progress on nickname validation changes. lib/nickname.php appears to have been destroyed by NetBeans and will be rewritten shortly. Sigh.
Brion Vibber [Mon, 29 Nov 2010 19:57:27 +0000 (11:57 -0800)]
doc comments on User::allowed_nickname
Brion Vibber [Mon, 29 Nov 2010 19:31:33 +0000 (11:31 -0800)]
Start on some nickname-validation test cases: several of these fail right now because we had regressions in 0.8 or 0.9 where we lost normalization of uppercase and some other chars.
Brion Vibber [Mon, 29 Nov 2010 19:31:10 +0000 (11:31 -0800)]
Add some doc comments on nickname-related stuff in util.php
Siebrand Mazeland [Mon, 29 Nov 2010 19:18:13 +0000 (20:18 +0100)]
Localisation updates from http://translatewiki.net.
Evan Prodromou [Sat, 27 Nov 2010 21:52:32 +0000 (16:52 -0500)]
Net URL Mapper Path plex file
Evan Prodromou [Sat, 27 Nov 2010 21:48:52 +0000 (16:48 -0500)]
Net_URL_Mapper 0.9.1
Evan Prodromou [Sat, 27 Nov 2010 03:11:12 +0000 (22:11 -0500)]
Merge remote branch 'gitorious/0.9.x' into 0.9.x
Evan Prodromou [Sat, 27 Nov 2010 03:10:18 +0000 (22:10 -0500)]
Make OStatusPlugin define push feed rel
Evan Prodromou [Sat, 27 Nov 2010 03:09:51 +0000 (22:09 -0500)]
Make userxrd work without OStatus enabled
Evan Prodromou [Sat, 27 Nov 2010 02:46:51 +0000 (21:46 -0500)]
Make userxrd part of the default hostmeta
Evan Prodromou [Sat, 27 Nov 2010 02:38:38 +0000 (21:38 -0500)]
Move user xrd action to core and use hooks to extend
Moved the Webfinger user XRD action from the OStatus plugin to core.
Added hooks to add OStatus-specific stuff, but kept general stuff in
the core.
Craig Andrews [Sun, 5 Sep 2010 21:43:29 +0000 (17:43 -0400)]
move xrd and hostmeta out of the OStatus plugin and into core
add event for setting up hostmeta, and use them in the OStatus plugin
Evan Prodromou [Fri, 26 Nov 2010 16:18:41 +0000 (11:18 -0500)]
Revert "Ticket #2796: don't allow arbitrary overriding of the 'action' class and other parameters pulled from the URL mapper."
This reverts commit
4193a826d3500c1c8771e2a55ca197011fe637c8.
Brion Vibber [Thu, 25 Nov 2010 01:36:40 +0000 (17:36 -0800)]
Update util.min.js for attachment preview on Firefox, Chrome
Brion Vibber [Wed, 24 Nov 2010 20:20:25 +0000 (12:20 -0800)]
Preview thumbnails of uploaded image attachments before posting on supporting browsers.
Tested working so far:
* Firefox 3.6 and 4.0 (FileReader -> data URL)
* Chrome 8 (createObjectURL; FileReader also works)
Tested with limited support:
* Safari 5.0.3 (no preview, but we can show type and size)
Tested and known not to support FileAPI, keeps current behavior:
* Opera 11 beta
Brion Vibber [Wed, 24 Nov 2010 18:13:03 +0000 (10:13 -0800)]
Add LogFilter plugin: quickie way to filter out/in log output based on priority or keyword matches. Should be helpful for folks who can't easily adjust their syslog filtering.
Brion Vibber [Tue, 23 Nov 2010 17:49:32 +0000 (09:49 -0800)]
logging tweak for Twitter status ID issue
Brion Vibber [Tue, 23 Nov 2010 17:28:47 +0000 (09:28 -0800)]
Fixes for Twitter bridge breakage on 32-bit servers. New "Snowflake" 64-bit IDs have become too big to fit in the integer portion of double-precision floats, so to reliably use these IDs we need to pull the new string form now.
Machines with 64-bit PHP installation should have had no problems (except on Windows, where integers are still 32 bits)
Zach Copley [Mon, 22 Nov 2010 21:40:47 +0000 (21:40 +0000)]
FacebookBridge - fail gracefully if the user has already deleted a
linked notice on Facebook.
Brion Vibber [Mon, 22 Nov 2010 20:39:38 +0000 (12:39 -0800)]
Update doc comment for Awesomeness plugin
Brion Vibber [Mon, 22 Nov 2010 20:38:47 +0000 (12:38 -0800)]
Tweak regex in Awesomeness plugin
Brion Vibber [Mon, 22 Nov 2010 20:31:24 +0000 (12:31 -0800)]
Merge commit 'refs/merge-requests/2224' of git://gitorious.org/statusnet/mainline into int
Brion Vibber [Mon, 22 Nov 2010 19:13:22 +0000 (11:13 -0800)]
Merge branch 'master' into 0.9.x
Brion Vibber [Mon, 22 Nov 2010 19:10:10 +0000 (11:10 -0800)]
Fixes for delete_status_network.sh:
* add some sanity checking: abort on failures instead of plodding through
* add some progress / error output
* fetch the target database server name from the status_network entry and use that to target the DROP DATABASE
Note that database names and other overrides in status_network entry may still not be seen.
Jeroen De Dauw [Sat, 20 Nov 2010 14:14:12 +0000 (15:14 +0100)]
Added Awesomeness extension
Brion Vibber [Sat, 20 Nov 2010 00:18:53 +0000 (16:18 -0800)]
Merge branch 'master' into 0.9.x
Brion Vibber [Sat, 20 Nov 2010 00:12:28 +0000 (16:12 -0800)]
Fix ticket #2700: some numeric IDs were misinterpreted as hex numbers instead of strings when '0x123' passed in.
Switched from is_numeric() to a custom self::is_decimal() which is more strict.
This makes our behavior match Twitter's API a bit better, so eg this:
http://identi.ca/api/statuses/home_timeline/0x6d686b.xml
should now be equivalent to:
http://identi.ca/api/statuses/home_timeline.xml?screen_name=0x6d686b
instead of:
http://identi.ca/api/statuses/home_timeline.xml?user_id=
7170155
Brion Vibber [Fri, 19 Nov 2010 23:53:29 +0000 (15:53 -0800)]
Merge branch 'master' into 0.9.x
Brion Vibber [Fri, 19 Nov 2010 23:51:08 +0000 (15:51 -0800)]
Ticket #2724: gracefully handle attempts to delete or fave/unfave a remote Twitter notice if a failure occurs.
Most annoying error case being where the notice was already faved or deleted on Twitter! :)
Such errors will now just fail out and log a note to the syslog -- the rest of what we were doing will continue on unhindered, so you can still delete, favorite, etc and it just won't sync the info over in that case.
Brion Vibber [Fri, 19 Nov 2010 23:38:20 +0000 (15:38 -0800)]
Merge branch 'master' into 0.9.x
Brion Vibber [Fri, 19 Nov 2010 23:30:52 +0000 (15:30 -0800)]
Ticket #2796: don't allow arbitrary overriding of the 'action' class and other parameters pulled from the URL mapper.
This protects against oddities such as manual invocation of the ClientError action, which can spoof error messages.
Brion Vibber [Fri, 19 Nov 2010 23:06:26 +0000 (15:06 -0800)]
Ticket #2797: replace addslashes() with explicit escape calls on the DB objects