]>
git.mxchange.org Git - friendica.git/log
Hypolite Petovan [Wed, 22 Jun 2022 01:12:09 +0000 (21:12 -0400)]
Remove email subject encoding from ItemCCEmail constructor
- It was wrongly re-encoded in Emailer::send
Hypolite Petovan [Tue, 21 Jun 2022 01:53:17 +0000 (21:53 -0400)]
Merge pull request #11660 from Quix0r/fixes/more-type-hints-003
More type-hints - Batch 003
Roland Häder [Mon, 20 Jun 2022 23:41:34 +0000 (01:41 +0200)]
Fixed:
- prevent NULL from being handled over to XML::escape()
- still I wonder that an object can be? It is a string-only accepting method
Roland Häder [Mon, 20 Jun 2022 23:29:20 +0000 (01:29 +0200)]
Fixed indenting
Hypolite Petovan [Mon, 20 Jun 2022 23:17:13 +0000 (19:17 -0400)]
Merge pull request #11663 from Quix0r/composer/upgrade
Updated composer.phar
Roland Häder [Mon, 20 Jun 2022 21:49:29 +0000 (23:49 +0200)]
Changes:
- added type-hints
- added some documentation
- marked some generic methods to be moved to Util\Strings class instead
Roland Häder [Mon, 20 Jun 2022 20:54:45 +0000 (22:54 +0200)]
Updated composer.phar
Roland Häder [Mon, 20 Jun 2022 19:21:32 +0000 (21:21 +0200)]
Changes:
- renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion
- added missing type-hints
- added missing documentation
Roland Häder [Mon, 20 Jun 2022 19:02:18 +0000 (21:02 +0200)]
Added documentation
Roland Häder [Mon, 20 Jun 2022 18:59:08 +0000 (20:59 +0200)]
Changes:
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
Roland Häder [Mon, 20 Jun 2022 18:01:25 +0000 (20:01 +0200)]
Changes:
- null was 2nd argument's value before, an empty string is basically the same here
Roland Häder [Mon, 20 Jun 2022 17:08:23 +0000 (19:08 +0200)]
Changes:
- let's start throwing exceptions on e.g. invalid arguments instead of returning
FALSE
Roland Häder [Mon, 20 Jun 2022 17:04:01 +0000 (19:04 +0200)]
Changes:
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
Roland Häder [Mon, 20 Jun 2022 16:55:17 +0000 (18:55 +0200)]
Changes:
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
/var/www/.../src/Model/GServer.php on line 940" error
Roland Häder [Mon, 20 Jun 2022 06:25:17 +0000 (08:25 +0200)]
Fixes:
- Strings::isHex() should not be misused for checking on NULL
Roland Häder [Mon, 20 Jun 2022 06:18:53 +0000 (08:18 +0200)]
Changed:
- DBA::exists() should only be used for checking if records exists.
- if you want to check if a table exists, please ALWAYS use
DBStructure::existsTable() instead
Roland Häder [Mon, 20 Jun 2022 06:12:09 +0000 (08:12 +0200)]
Changes:
- some methods now need to return bool to be compatible
- added some missing type-hints
Roland Häder [Mon, 20 Jun 2022 06:06:45 +0000 (08:06 +0200)]
Both declarations must be the same
Tobias Diekershoff [Mon, 20 Jun 2022 04:26:33 +0000 (06:26 +0200)]
Merge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier
Add missing identifier quote in Database->replaceInTableFields
Roland Häder [Mon, 20 Jun 2022 01:48:12 +0000 (03:48 +0200)]
Changed:
- cannot have type-hints :-(
Roland Häder [Mon, 20 Jun 2022 01:36:13 +0000 (03:36 +0200)]
Ops, wrong type-hint
Roland Häder [Mon, 20 Jun 2022 01:10:02 +0000 (03:10 +0200)]
Changes:
- added type-hints
- added some missing documentation
Roland Häder [Mon, 20 Jun 2022 00:45:53 +0000 (02:45 +0200)]
Changes:
- added some documentation
- added type-hints
Roland Häder [Sun, 19 Jun 2022 23:08:52 +0000 (01:08 +0200)]
Changes:
- added type-hints
- added missing documentation
Roland Häder [Sun, 19 Jun 2022 22:51:59 +0000 (00:51 +0200)]
Changes:
- added more type-hints
Hypolite Petovan [Mon, 20 Jun 2022 00:23:29 +0000 (20:23 -0400)]
Merge pull request #11657 from Quix0r/fixes/post-media-size-bigint
Size "mediumint" wasn't enough
Hypolite Petovan [Mon, 20 Jun 2022 00:06:12 +0000 (20:06 -0400)]
Add missing identifier quote in Database->replaceInTableFields
- This caused hyphenated table names to fail the replace query
Roland Häder [Sun, 19 Jun 2022 22:58:52 +0000 (00:58 +0200)]
Changes:
- added type-hints
- changed some double-quotes to single
Roland Häder [Sun, 19 Jun 2022 21:06:04 +0000 (23:06 +0200)]
Changes:
- `url` to `varbinary(1024)`
- `preview` to `varbinary(512)`
as the previous once (half length) were not enough in real-life scenarios
Roland Häder [Sun, 19 Jun 2022 13:32:14 +0000 (15:32 +0200)]
Incremented again
Roland Häder [Sun, 19 Jun 2022 07:10:36 +0000 (09:10 +0200)]
Fixed documentation/SQL dump with ./bin/console dbstructure dump
Roland Häder [Sun, 19 Jun 2022 00:31:59 +0000 (02:31 +0200)]
Size "mediumint" wasn't enough:
https://digitalcourage.video/static/webseed/
5a039eb2 -9fbc-441d-a772-
59ae3ee65c15 -1080.mp4 has
6758472669 Bytes
So let's go REALLY big.
Hypolite Petovan [Sun, 19 Jun 2022 13:27:29 +0000 (09:27 -0400)]
Merge pull request #11655 from Quix0r/fixes/more-type-hints-002
More type-hints and documentation added
Roland Häder [Sun, 19 Jun 2022 12:41:04 +0000 (14:41 +0200)]
Incremented database version
Roland Häder [Sun, 19 Jun 2022 12:06:20 +0000 (14:06 +0200)]
Ops, not here wanted. :-(
Roland Häder [Sun, 19 Jun 2022 11:59:58 +0000 (13:59 +0200)]
Changes:
- added type-hints
- added returned type-hints in interface (I checked all)
Hypolite Petovan [Sun, 19 Jun 2022 11:09:20 +0000 (07:09 -0400)]
Merge pull request #11658 from tobiasd/
20220619 -accesskey
Accesskey was used twice
Roland Häder [Sun, 19 Jun 2022 09:25:52 +0000 (11:25 +0200)]
Some calls saved
Roland Häder [Sun, 19 Jun 2022 08:49:26 +0000 (10:49 +0200)]
Changes:
- added missing type-hints
- added documentation for a method
Roland Häder [Sun, 19 Jun 2022 08:48:47 +0000 (10:48 +0200)]
Changes:
- MySQL index on BLOB/TEXT can only be partial (e.g.: `column`(length))
Roland Häder [Sun, 19 Jun 2022 07:35:53 +0000 (09:35 +0200)]
Contact::getAccountType()'s parameter is never a string, ops
Roland Häder [Sun, 19 Jun 2022 07:11:08 +0000 (09:11 +0200)]
Changes:
- dbstructure(null) is no longer possible, an empty string does it
Tobias Diekershoff [Sun, 19 Jun 2022 04:33:21 +0000 (06:33 +0200)]
updated the Accesskey documentation accordingly
Tobias Diekershoff [Sun, 19 Jun 2022 04:30:00 +0000 (06:30 +0200)]
Accesskey was used twice
The accesskey on the User Settings pages for the _account settings_ and the _two factor authentication_ were the same. This PR is assinging a new one to the 2FA.
Roland Häder [Sun, 19 Jun 2022 00:39:51 +0000 (02:39 +0200)]
Wrong returned type, has to be array
Roland Häder [Sun, 19 Jun 2022 00:10:04 +0000 (02:10 +0200)]
Changes:
- added more type-hints
- DBStructure::existsTable() does no longer need array support for table name
because this is no longer used (good work!)
Roland Häder [Sat, 18 Jun 2022 23:10:50 +0000 (01:10 +0200)]
Changes:
- changed to proper "use Foo\Bar;"
- added doctag
- added return type as this is fixed
Roland Häder [Sat, 18 Jun 2022 21:31:44 +0000 (23:31 +0200)]
Ops, also this!
Roland Häder [Sat, 18 Jun 2022 21:30:13 +0000 (23:30 +0200)]
Changed to suggestings (back to original) + fixed typo in scalar type
Roland Häder [Sat, 18 Jun 2022 21:23:50 +0000 (23:23 +0200)]
Changed back to suggestions by @MrPetovan
Roland Häder [Sat, 18 Jun 2022 21:16:07 +0000 (23:16 +0200)]
Naming-convention:
- variables should start lower-case: $image
Roland Häder [Sat, 18 Jun 2022 21:12:25 +0000 (23:12 +0200)]
Changes:
- added type-hints
- added documentation
- changed double-quotes to single
Roland Häder [Sat, 18 Jun 2022 16:41:07 +0000 (18:41 +0200)]
Proper type is string
Roland Häder [Sat, 18 Jun 2022 16:30:03 +0000 (18:30 +0200)]
Maybe fix for:
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
Roland Häder [Sat, 18 Jun 2022 16:21:05 +0000 (18:21 +0200)]
Changes:
- added more type-hints
- added missing documentation
Roland Häder [Sat, 18 Jun 2022 15:56:01 +0000 (17:56 +0200)]
Nodeinfo::getOrganization() doesn't need configuration object being inserted
when you have DI::config() around.
Roland Häder [Sat, 18 Jun 2022 15:52:34 +0000 (17:52 +0200)]
Added missing type-hints
Roland Häder [Sat, 18 Jun 2022 15:49:57 +0000 (17:49 +0200)]
Renamed variable, no need for "orig_" prefix
Roland Häder [Sat, 18 Jun 2022 15:45:53 +0000 (17:45 +0200)]
Continued:
- changed some double-quotes to single
- added missing type-hints
- added missing documentation
- fixed indenting a bit
Roland Häder [Sat, 18 Jun 2022 15:22:10 +0000 (17:22 +0200)]
Continued:
- added more type-hints
- added some missing documentation
- Return the result from DBA::delete() to let other methods know about it
Roland Häder [Sat, 18 Jun 2022 15:09:18 +0000 (17:09 +0200)]
Changes:
- added more type-hints
- added missing documentation
Roland Häder [Sat, 18 Jun 2022 14:58:48 +0000 (16:58 +0200)]
Changes:
- added missing type-hints
- added missing documentation
Hypolite Petovan [Sat, 18 Jun 2022 14:33:33 +0000 (10:33 -0400)]
Merge pull request #11653 from Quix0r/fixes/more-type-hints
More type-hints added
Hypolite Petovan [Sat, 18 Jun 2022 14:28:00 +0000 (10:28 -0400)]
Merge pull request #11654 from Quix0r/fixes/post-media-url-size
post-media has too small sizes for video files
Roland Häder [Sat, 18 Jun 2022 14:02:10 +0000 (16:02 +0200)]
Updated documentation and SQL dump, according to woodpecker tests
Roland Häder [Sat, 18 Jun 2022 13:56:58 +0000 (15:56 +0200)]
Continued:
- prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"
Roland Häder [Sat, 18 Jun 2022 13:30:36 +0000 (15:30 +0200)]
Sizes increased for:
- video files that have sizes var being int allowes
- URLs that might be longer (e.g. magnet: URLs) than varbinary(511) allows
Roland Häder [Sat, 18 Jun 2022 07:58:44 +0000 (09:58 +0200)]
Ops, needs to be a variable:
Error: "Cannot pass parameter 2 by reference" at /var/www/.../src/Module/DFRN/Poll.php line 36
Roland Häder [Sat, 18 Jun 2022 03:41:19 +0000 (05:41 +0200)]
Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be
of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php
on line 37"
Roland Häder [Sat, 18 Jun 2022 03:18:38 +0000 (05:18 +0200)]
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch()
is the same and being handled over.
Roland Häder [Sat, 18 Jun 2022 03:06:00 +0000 (05:06 +0200)]
Some outside code relies on returned "false"
Roland Häder [Sat, 18 Jun 2022 03:04:04 +0000 (05:04 +0200)]
Fixed indenting
Roland Häder [Sat, 18 Jun 2022 03:01:51 +0000 (05:01 +0200)]
Changes:
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
Roland Häder [Fri, 17 Jun 2022 16:00:06 +0000 (18:00 +0200)]
Fixed incompatible types
Roland Häder [Fri, 17 Jun 2022 11:02:43 +0000 (13:02 +0200)]
Ops, wrong type again
Roland Häder [Fri, 17 Jun 2022 10:22:40 +0000 (12:22 +0200)]
Ops, wrong type
Roland Häder [Fri, 17 Jun 2022 09:48:52 +0000 (11:48 +0200)]
Continued:
- changed back to 'return false;' as other methods heavily rely on false instead
of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
code more crazier than it already is (see APContact::getByURL())
Roland Häder [Fri, 17 Jun 2022 09:17:53 +0000 (11:17 +0200)]
Some more type-hints added
Roland Häder [Fri, 17 Jun 2022 09:04:47 +0000 (11:04 +0200)]
Nore fixes
Roland Häder [Fri, 17 Jun 2022 08:57:17 +0000 (10:57 +0200)]
Possible fix for
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
Roland Häder [Fri, 17 Jun 2022 08:53:45 +0000 (10:53 +0200)]
Fix for "Uncaught Exception TypeError: "Argument 1 passed to
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
Roland Häder [Fri, 17 Jun 2022 08:44:13 +0000 (10:44 +0200)]
Continued:
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
changed it to -1 to have a proper type-hint
Roland Häder [Fri, 17 Jun 2022 07:51:11 +0000 (09:51 +0200)]
Also need to declare $profile or otherwise an invocation of
Receiver::getReceiverForActor() will fail.
Roland Häder [Thu, 16 Jun 2022 20:17:37 +0000 (22:17 +0200)]
Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(
Roland Häder [Thu, 16 Jun 2022 20:15:06 +0000 (22:15 +0200)]
Ops, wrong type-hint here, must be string ($nickname can never be an integer).
Roland Häder [Thu, 16 Jun 2022 20:12:38 +0000 (22:12 +0200)]
Continued:
- added type-hints
- removed out-dated documentation
- added some missing documentation
Roland Häder [Thu, 16 Jun 2022 19:57:02 +0000 (21:57 +0200)]
Continued:
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
Roland Häder [Thu, 16 Jun 2022 18:58:24 +0000 (20:58 +0200)]
Fix for non-existing record system.mobile_theme in config table
Roland Häder [Thu, 16 Jun 2022 18:47:59 +0000 (20:47 +0200)]
Fixed:
- $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd
parameter expect it to be string
Roland Häder [Thu, 16 Jun 2022 18:42:40 +0000 (20:42 +0200)]
Some fixes:
- $gsid's default value cannot sadly be 0, it now must be null to allow some
code work
- added some more type-hints
- documented a bit more
Roland Häder [Thu, 16 Jun 2022 18:33:10 +0000 (20:33 +0200)]
Added more type-hints
Roland Häder [Thu, 16 Jun 2022 18:17:04 +0000 (20:17 +0200)]
Added again more type-hints
Roland Häder [Thu, 16 Jun 2022 18:01:09 +0000 (20:01 +0200)]
Continued:
- added more type-hints
- added some missing documentation
Roland Häder [Thu, 16 Jun 2022 17:39:49 +0000 (19:39 +0200)]
Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool"
Roland Häder [Thu, 16 Jun 2022 17:21:07 +0000 (19:21 +0200)]
MrPetovan brought the right one up:
> Since this is depending on remote systems, the log can quickly fill with unactionable messages.
Roland Häder [Thu, 16 Jun 2022 17:17:25 +0000 (19:17 +0200)]
Ops, bad type-hint here
Roland Häder [Thu, 16 Jun 2022 16:36:56 +0000 (18:36 +0200)]
Another incompatible method declaration fixed + type-hints added
Roland Häder [Thu, 16 Jun 2022 16:28:38 +0000 (18:28 +0200)]
Continued:
- more type-hints
- fixed incompatible method declarations
Roland Häder [Thu, 16 Jun 2022 14:49:43 +0000 (16:49 +0200)]
Added more type-hints for "App" classes
Roland Häder [Thu, 16 Jun 2022 14:38:58 +0000 (16:38 +0200)]
Added more type-hints