Roland Häder [Sat, 21 Jan 2023 09:02:55 +0000 (10:02 +0100)]
Please cherry-pick:
- "validate" parameter, e.g. where you don't want null references, then check if
it is null to prevent possible logic errors and maybe here a wrong/misleading
result
Roland Häder [Thu, 19 Jan 2023 07:51:06 +0000 (08:51 +0100)]
Continued:
- attributes from registered validators are not exposed in component's
attribute list, they need to be set and read by setter/getter
- added missing navigation rules
- fixed navigation outcomes (copy-paste)
- also added missing 'value="#{controller.attribute}"' (ops)
Roland Häder [Thu, 19 Jan 2023 07:16:57 +0000 (08:16 +0100)]
Continued:
- fixed wrong variable name
- used proper message bundle (needs to be project-specific)
- fixed wrong JSF variable name (adminSkinActionController) due to import
Roland Häder [Thu, 19 Jan 2023 07:00:56 +0000 (08:00 +0100)]
WIP:
- added administrative action controller with add/create and update methods
- added static data method SkillStatus enumeration
- added field for it
- added method isSkillAlreadyAdded()
- added form field skillStatus with converter
Roland Häder [Sat, 5 Nov 2022 04:39:57 +0000 (05:39 +0100)]
Please cherry-pick:
- updated to latest changes in constructor (order of parameters)
- also used newly added constructor with all optional class fields, except
contactId, fax/land-line/mobile number and created/updated fields
Roland Häder [Sun, 23 Oct 2022 21:13:02 +0000 (23:13 +0200)]
Please cherry-pick:
- I don't know what maximum number is possible, e.g. +352 is Luxembourg which is
far bigger than intended maximum 99. So let's put it up to 999
Roland Häder [Thu, 20 Oct 2022 17:17:46 +0000 (19:17 +0200)]
Please cherry-pick:
- added missing parameter "country" for updated constructor
- also validated if contact's Country instance is set and already persisted
Roland Häder [Thu, 20 Oct 2022 16:42:21 +0000 (18:42 +0200)]
Please cherry-pick:
- renamed copyUser() to copyToUser() because that method "copies" (read: sets)
all required class fields except "entry-created" in given user instance
- also used UserContact's parameterized constructor instead of default one and
then setting all on my own
- removed @PostConstruct method
Roland Häder [Sun, 2 Oct 2022 17:42:56 +0000 (19:42 +0200)]
Please cherry-pick:
- these checks on if registered or not or provided or not makes here no sense
and has caused forms not accepting email addresses
- renamed template
- added country Hungary
Roland Häder [Sun, 25 Sep 2022 20:36:04 +0000 (22:36 +0200)]
Please cherry-pick:
- branch offices have optional email addresses (finally found the bug that you
always must enter an email address while the form field is not marked as
required)
Roland Häder [Sun, 25 Sep 2022 20:21:32 +0000 (22:21 +0200)]
Please cherry-pick:
- removed duplicate validator for branch office's email address
- validators should check specific fields, not generic
- arranged code a bit for better readability
- renamed private method
Roland Häder [Fri, 23 Sep 2022 16:52:47 +0000 (18:52 +0200)]
Please cherry-pick:
- cannot copy whole user instance to RequestScoped bean as this is being
forgotten on next request, SessionScoped will be a little overdose + it can
be solved by taking the user instance already set in beanHelper bean
Roland Häder [Mon, 1 Jun 2020 13:32:24 +0000 (15:32 +0200)]
Please cherry-pick:
- all extra email address validators (so not the generic one) have no attribute
"allowEmptyRequiredData" anymore as the email address for them (e.g. branch
office) is always optional
- converted own JSF tag core:outputAdminContactDataFormFields to template again
- reformatted some JSF tags to have each attribute in a single line
- the gender-specific backing bean was superflous since there is a "static
data" backing bean
- added missing i18n string COUNTRY_POLAND (country was added in JFinancials)
- fixed tpzo in i18n key
Roland Häder [Wed, 20 May 2020 16:42:59 +0000 (18:42 +0200)]
Please cherry-pick:
- renamed userCreated -> userEntryCreated
- renamed userUpdated -> userEntryUpdated
- updateUserData() may throw a checked UserNotFoundException, let's catch it
here and throw a FacesException with it as cause
- same with confirmAccount()
Roland Häder [Mon, 11 May 2020 01:12:04 +0000 (03:12 +0200)]
Please cherry-pick:
- since departments, headquarters and branch offices cannot link to employes,
so also the view navigation rules must reflect this. Employees can have a
relationship to any these 3 entities and would lead to endless loop
- introduced adminDepartmentActionController instead of without "Action", let
us keep these empty ("dead") backing beans around, they may one day be filled
with life again. Or they will be removed if no purpose could be found.
- closed some TODOs in views where p:fieldset allows a title attribute
- also a ui:fragment can be avoided when p:fieldset allows a render attribute
- added view for administrative editing of departments
- removed double // NOI18N strings (ops?) which is for some language string
scanning and translation tools to ignore these lines (exception messages
should normally not show up to the user).
Roland Häder [Tue, 28 Apr 2020 21:03:01 +0000 (23:03 +0200)]
Please cherry-pick:
- added javax.faces.FACELETS_SKIP_COMMENTS to let JSF +2.1 (2.3 is used anyway)
engines ignore commented out JSF tags (and the EL code inside it). With this
option, the developer has what he needs, IMO as this allowws temporary
removing JSF tags from the component tree as the developer desires. Okay,
ui:remove is also around ...
Roland Häder [Sat, 25 Apr 2020 16:41:39 +0000 (18:41 +0200)]
Please cherry-pick:
- introduced new administrative action backing bean (add/update/delete being
done here)
- land-line, fax and mobile instances must be intialized with null first, then
check all respective backing bean properties if they all exist. This fixes
the NPEs coming from updated constructors
- check Country instance against the interface Country and not not being null
- added missing i18n string
Roland Häder [Fri, 24 Apr 2020 03:05:31 +0000 (05:05 +0200)]
Please cherry-pick:
- added view admin-edit-branch-office view including backing bean action method
- added navigation rule from admin-edit-branch-office to
admin-list-branch-offices view, including redirect
- added event observer for when an administrator has updated a branch office
- renamed adminBranchOfficeController to adminBranchOfficeActionController
- added many missing i18n strings
- renamed i18n string
Roland Häder [Fri, 24 Apr 2020 03:05:31 +0000 (05:05 +0200)]
Please cherry-pick:
- added view admin-edit-branch-office view including backing bean action method
- added navigation rule from admin-edit-branch-office to
admin-list-branch-offices view, including redirect
- added event observer for when an administrator has updated a branch office
- renamed adminBranchOfficeController to adminBranchOfficeActionController
- added many missing i18n strings
- renamed i18n string
Roland Häder [Thu, 23 Apr 2020 00:29:42 +0000 (02:29 +0200)]
Please cherry-pick:
- got rid of admin_form_basic_data.tpl, now moved back to original view, I guess
I will do that for all forms, which would lead to "duplicate" forms elements
butter with no targetController which was never resolvable anyway.
- added showEmailAddress boolean flag to many renderFoo() methods to whether
show email address which is mostly not wanted in selection boxes ...
- added companyRoadNumber to basic-data backing bean and proper forms/list view
- in converters/validators now the FOO_LIST_CONTROLLER static instance shall
always be initialized directly before the try{} block
Roland Häder [Wed, 22 Apr 2020 14:49:38 +0000 (16:49 +0200)]
Don't cherry-pick:
- renamed backing beans and their interfaces to JJobs
- fixed JNDI name
- fixed converters/validators because of JFinancials -> JJobs cherry-picking,
otherwise you have to write that all from scratch ...
Roland Häder [Tue, 21 Apr 2020 23:59:56 +0000 (01:59 +0200)]
Don't cherry-pick:
- JJobs has no need for addressbooks, it can be done without them
- renamed backing beans for JJobs
- fixed (maybe?) some JNDI names
- a lot other fixes, still something is not correct, some interfaces have some
missing methods while they should be there
Roland Häder [Sun, 19 Apr 2020 16:58:49 +0000 (18:58 +0200)]
Please cherry-pick:
- rewrote to not use fax_input_table_row.tpl
- realigned JSF tags to have attributes in a separate line
- got rid of some old tags from pre-PrimeFaces times
Roland Häder [Sun, 19 Apr 2020 00:07:53 +0000 (02:07 +0200)]
Please cherry-pick:
- got rid of admin-contact-links menu template
- reformatted a lot templates
- got rid of some core:outputMessageBox as p:growl does it already
- implemented missing deleteContactData() action method
- also implemented missing even observer for updating cache and list
- replaced FaceletException with FacesException
- renamed variables
Roland Häder [Fri, 17 Apr 2020 14:54:20 +0000 (16:54 +0200)]
Please cherry-pick:
- heavy rewrite on (almost?) all admin-list-foo views, to use @ViewScoped beans
and working JSR107 caching
- also sorted out mixed usage of userController (or so?) as the login and
register backing beans can surely have their own properties
- rewrote web/WEB-INF/resources/tags/admin/dropdown/ to have it included back
in views again, was a bad idea
projects / jjobs-war.git / log