Roland Häder [Wed, 24 Aug 2016 10:49:46 +0000 (12:49 +0200)]
Please cherry-pick:
- currently not otherwise possible: if contact's fax number from user profile is being unlinked/linked, a redirect to admin_contact_show happens as no user id is available at this time
Roland Häder [Wed, 24 Aug 2016 08:52:00 +0000 (10:52 +0200)]
Please cherry-pick:
- got rid of redundant hasFoos() as #{ no someController.allFoos().isEmpty()} works fine
- renamed controller method allMobileProvider() -> allMobileProviders()
Roland Häder [Tue, 23 Aug 2016 15:34:05 +0000 (17:34 +0200)]
Please cherry-pick:
- fixed administrative fax listing (column data was in facet=header)
- added event observer afterAdminLinked(Fax|LandLine|Mobile)NumberEvent()
- these observers only add new (not existing) phone numbers to the corresponding lists
Roland Häder [Tue, 23 Aug 2016 13:29:19 +0000 (15:29 +0200)]
Please cherry-pick:
- added events for updated fax, land-line and mobile number
- added events for deleted fax, land-line and mobile number
- renamed event method to have Event suffix
Roland Häder [Tue, 23 Aug 2016 10:16:21 +0000 (12:16 +0200)]
Please cherry-pick:
- edit/delete(Fax|LandLine|Mobile)Data() must have the phone number being handled over as a parameter
- the instance in beanHelper is null on POST (-back)
- setting onPostback="true" overrides the set value (from JSF page)
- so it needs to be as a parameter
Roland Häder [Mon, 22 Aug 2016 13:18:40 +0000 (15:18 +0200)]
Please cherry-pick:
- removed onPostback from "edit pages" (as if this is set, the old data is being set back ... yes, remember the JSF life-cycle
- added error message when no data has been changed (generic)
- added missing navigation rule
- added noisy debug lines
Roland Häder [Mon, 22 Aug 2016 10:22:01 +0000 (12:22 +0200)]
Please cherry-pick:
- fixed i18n string name
- added missing navigation rule so linking contacts with fax, land-line and mobile numbers /should/ work
- added missing i18n strings
- ids for data input fields are all camelCased (same as backing bean property)
Roland Häder [Fri, 19 Aug 2016 14:48:20 +0000 (16:48 +0200)]
"Re-scoped" bean helper: (please cherry-pick)
- the bean helper needs to be view-scoped (valid until the view has been changed)
- this way, the setted instances remain until the view is invalidated
- maybe no onPostback="true" is then no more needed? @TODO
Roland Häder [Fri, 19 Aug 2016 13:19:03 +0000 (15:19 +0200)]
Please cherry-pick:
- added debugger class for making JSF life-cycles visible, thanks to BalusC for this free code
- registered above debugger
- rewrote all templates with f:metadata to, again, BalusC's recommendation to have "metadata" in a own ui:define block
- added NOISY debug lines (please comment out on productive systems!)
Roland Häder [Thu, 18 Aug 2016 14:56:02 +0000 (16:56 +0200)]
Continued a bit: (please cherry-pick)
- added needed try-catch block and return a nice facet message to the user (admin)
- changed no longer existing exceptions with more generic exception as this is fine here
Roland Häder [Thu, 18 Aug 2016 13:43:04 +0000 (15:43 +0200)]
Continued with add/link forms: (please cherry-pick)
- implemented doLinkAdd(Fax|LandLine|Mobile)Number() which fire events when the number has been linked/added
- removed field mobileNumber as it is redundant to phoneNumber
- form_contact_data needs mobileNumber as all 3 are being asked there
- renamed countryPhoneCode -> phoneCountry as this is more accurate
- added missing i18n strings
Roland Häder [Thu, 18 Aug 2016 10:15:59 +0000 (12:15 +0200)]
Please cherry-pick:
- f:viewAction needs to be executed on POST request as well
- still the registered h:commandButton's method is not being invoked :-(
- again?!
Roland Häder [Thu, 18 Aug 2016 10:15:29 +0000 (12:15 +0200)]
Please cherry-pick:
- f:viewAction needs to be executed on POST request as well
- still the registered h:commandButton's method is not being invoked :-(
- again?!
Roland Häder [Thu, 18 Aug 2016 08:06:40 +0000 (10:06 +0200)]
Continued with templates: (please cherry-pick)
- reanmed + moved templates as there was no selection box in it, but input fields
- added missing clear divs (CSS class)
- added missing error boxes for dial area code and dial numbers
Roland Häder [Wed, 17 Aug 2016 14:14:57 +0000 (16:14 +0200)]
Continued a bit: (please cherry-pick)
- changed to medium table, only listings or show pages should be big (full) tables
- renamed table_big -> table_full
Roland Häder [Wed, 17 Aug 2016 11:03:39 +0000 (13:03 +0200)]
Continued with missing i18n strings: (please cherry-pick)
- added missing i18n strings for table summaries
- renamed some i18n strings to make them more clear
Roland Häder [Wed, 17 Aug 2016 10:53:20 +0000 (12:53 +0200)]
Fixed some comment-stuff: (please cherry-pick)
- comments in JSF templates/pages may cause columns being rendered in h:panelGrid, better put such things in XML definition (outside ui:composition)
Roland Häder [Wed, 17 Aug 2016 10:39:46 +0000 (12:39 +0200)]
Continued with contact data:
- introduced template admin_contact_data_columns.tpl which will show all contact data
- @TODO maybe later add phone numbers as "main" numbers?
- renamed templates to make them more clear
- added missing i18n string(s)
Roland Häder [Wed, 17 Aug 2016 10:09:28 +0000 (12:09 +0200)]
Continued with fax, land-line, mobile: (please cherry-pick)
- added getter/setter for choosen fax/land-line numbers
- added template includes for fax/land-line numbers (admin_show_contact)
- added created/updated timestamp for fax/land-line/mobile data
- added templates for fax/land-line "selection boxes" (input forms, needs renaming)
- introduced template admin_user_data.tpl (similar to admin_contact_data.tpl)
- fixed "add" EL code for fax/land-line numbers
- renamed some i18n strings as they can be combined into a generic "Administrative links" string
- added missing i18n strings
- added suffix _NUMBER to i18n strings as they are about ("phone") numbers ...
Roland Häder [Wed, 17 Aug 2016 07:37:34 +0000 (09:37 +0200)]
Continued a bit: (please cherry-pick)
- added missing backing bean properties for fax/land-line edit templates (both share the same properties as they are same data but for different purposes)
- fixed copy-paste mobile -> fax/land-line stuff I forgot
- admin_form_(fax|landline)_data.tpl should be more complete now
Roland Häder [Tue, 16 Aug 2016 14:08:48 +0000 (16:08 +0200)]
Continued with land-line and fax numbers: (please cherry-pick)
- added "all" (?) JSF pages for administrative land-line/fax number pages
- added admin menus for fax/land-line number listing
- added navigation rules
- added more class (controller=managed bean) fields for fax/land-line
- implemented method allFaxNumberContacts()
- implemented method allLandLineNumberContacts()
- implemented method allNonLinkedFaxNumbers()
- implemented method allNonLinkedLandLineNumbers()
- some methods had been renamed (cellphone -> mobile)
- added missing i18n strings
- renamed some i18n strings as they can be generic (for all 3 types)
Roland Häder [Mon, 15 Aug 2016 15:50:17 +0000 (17:50 +0200)]
Continued with contact-cellphone: (please cherry-pick)
- renamed template to admin_form_add_contact_cellphone.tpl to make it more clear
- adminContactPhoneController is a request-scoped controller
- implemented allNonLinkedCellphoneNumbers() which fires an event to remove already used contacts
- this may become handy when more than one entity (now only contact) links to cellphone numbers
- added missing i18n strings
Roland Häder [Mon, 15 Aug 2016 14:14:33 +0000 (16:14 +0200)]
Continued with reparation: (please cherry-pick)
- placed all "error_container" div inside "table_row" div
- added missing error_container class for a div
- this prepares the project for rewrite towards more JSF 2.0 and lesser vanilla-HTML tags
Roland Häder [Mon, 15 Aug 2016 13:49:44 +0000 (15:49 +0200)]
Continued with switching vanilla HTML -> JSF2.0 tags: (please cherry-pick)
- Switched some div tags (for "tables") to h:panelGroup
- Maybe more can be changed without having ugly nested h:panelGroup tags ?
Roland Häder [Mon, 15 Aug 2016 13:07:47 +0000 (15:07 +0200)]
Continued with XHTML changes: (please cherry-pick)
- added div (at least id) for upcoming JavaScript (onselect) expansion
- if the admin chooses already but not linked contact data, disable contact form data
- if none is selected show form
- this required that an ui:inlude needs to be moved
Roland Häder [Mon, 15 Aug 2016 12:56:56 +0000 (14:56 +0200)]
Continued with contact-cellphone unlink: (please cherry-pick)
- implemented afterAdminUnlinkedCellphoneContactDataEvent() which observes events being fired after cellphone has been unlinked from contact
- also checked if contact and cellphone are really linked
- renamed message key to ERROR_BEAN_HELPER_CELLPHONE_NUMBER_NOT_SET as this reflects what is there
- added missing i18n message
Roland Häder [Mon, 15 Aug 2016 09:27:15 +0000 (11:27 +0200)]
finally fixed this madness, thanks to @BalusC again:
- I wanted to have a general ("base") controller that hold methods for every controller (bean).
- like many controllers do, I want that bean to return localized message from my resource bundle and not unlocalized English-only messages
- this is now done by getting the container's locale and then loading the bundle with it's base name (not variable name)
- thank you, BalusC for enlighten us. :-)
Roland Häder [Fri, 12 Aug 2016 10:43:12 +0000 (12:43 +0200)]
Continued a bit: (please cherry-pick)
- please let the application and not the validator decide what to do with already registered or unregistered email addresses.
- the validator should only validate (against regex) and not make sure (means control) that the valid email address is okay to use for the requested action.
- else there is a double-check and the validator will come first with non-localized messages
Roland Häder [Fri, 12 Aug 2016 10:26:42 +0000 (12:26 +0200)]
Continued a bit: (please cherry-pick)
- added CSS class checkbox for, well, what else? ;-)
- combined border-style, border-size and border-color in one "border"
projects / jjobs-war.git / log