From 053e99733f62a92e76c5250353e1813b2369485c Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@status.net>
Date: Thu, 20 Oct 2011 11:47:44 -0400
Subject: [PATCH] add rel=nofollow to bookmark links if needed
---
plugins/Bookmark/bookmarklistitem.php | 43 +++++++++++++--------------
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/plugins/Bookmark/bookmarklistitem.php b/plugins/Bookmark/bookmarklistitem.php
index 9b7a3742fa..a2dbf8156d 100644
--- a/plugins/Bookmark/bookmarklistitem.php
+++ b/plugins/Bookmark/bookmarklistitem.php
@@ -62,38 +62,37 @@ class BookmarkListItem extends NoticeListItemAdapter
$nb = Bookmark::getByNotice($notice);
- $profile = $notice->getProfile();
+ if (empty($nb)) {
+ common_log(LOG_ERR, "No bookmark for notice {$notice->id}");
+ parent::showContent();
+ return;
+ } else if (empty($nb->url)) {
+ common_log(LOG_ERR, "No url for bookmark {$nb->id} for notice {$notice->id}");
+ parent::showContent();
+ return;
+ }
- $atts = $notice->attachments();
+ $profile = $notice->getProfile();
- if (empty($atts)) {
+ $out->elementStart('p', array('class' => 'entry-content'));
- // Something went wrong!
+ // Whether to nofollow
- common_log(
- LOG_ERR,
- sprintf(
- 'Bookmark %1$s (notice %2$d) has no attachments.',
- $nb->id,
- $notice->id
- )
- );
+ $attrs = array('href' => $nb->url,
+ 'class' => 'bookmark-title');
- // try to show the notice as plain text
+ $nf = common_config('nofollow', 'external');
- parent::showContent();
- return;
+ if ($nf == 'never' || ($nf == 'sometimes' and $out instanceof ShowstreamAction)) {
+ $attrs['rel'] = 'external';
+ } else {
+ $attrs['rel'] = 'nofollow external';
}
- $out->elementStart('p', array('class' => 'entry-content'));
-
- $att = $atts[0];
-
$out->elementStart('h3');
$out->element('a',
- array('href' => $att->url,
- 'class' => 'bookmark-title'),
- $nb->title);
+ $attrs,
+ $nb->title);
$out->elementEnd('h3');
// Replies look like "for:" tags
--
2.39.5