From 06e325d61bd57783af944ebc6d328820399fc9d4 Mon Sep 17 00:00:00 2001 From: hannes Date: Thu, 28 Jan 2016 15:19:29 +0000 Subject: [PATCH] fixes two issues when the oembed thumbnail is blank --- plugins/Oembed/OembedPlugin.php | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/plugins/Oembed/OembedPlugin.php b/plugins/Oembed/OembedPlugin.php index f8b78e08d6..0253018c02 100644 --- a/plugins/Oembed/OembedPlugin.php +++ b/plugins/Oembed/OembedPlugin.php @@ -72,6 +72,21 @@ class OembedPlugin extends Plugin // Just ignore it! $metadata = OpenGraphHelper::ogFromHtml($dom); } + + // sometimes sites serve the path, not the full URL, for images + // let's "be liberal in what you accept from others"! + // add protocol and host if the thumbnail_url starts with / + if(substr($metadata->thumbnail_url,0,1) == '/') { + $thumbnail_url_parsed = parse_url($metadata->url); + $metadata->thumbnail_url = $thumbnail_url_parsed['scheme']."://".$thumbnail_url_parsed['host'].$metadata->thumbnail_url; + } + + // some wordpress opengraph implementations sometimes return a white blank image + // no need for us to save that! + if($metadata->thumbnail_url == 'https://s0.wp.com/i/blank.jpg') { + unset($metadata->thumbnail_url); + } + } public function onEndShowHeadElements(Action $action) -- 2.39.5