From 09dab2ce5ae819c73d7984822d418c43f1fba223 Mon Sep 17 00:00:00 2001
From: Zach Copley <zach@status.net>
Date: Tue, 25 May 2010 15:40:38 +0000
Subject: [PATCH] Dequeue notice when we hit any Facebook error.
---
plugins/Facebook/facebookutil.php | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/plugins/Facebook/facebookutil.php b/plugins/Facebook/facebookutil.php
index 0f24f5441e..c7b0f02c31 100644
--- a/plugins/Facebook/facebookutil.php
+++ b/plugins/Facebook/facebookutil.php
@@ -229,8 +229,8 @@ function handleFacebookError($e, $notice, $flink)
default:
$msg = "FacebookPlugin - Facebook returned an error we don't know how to deal with while trying to "
. "post notice %d. Error code: %d, error message: \"%s\". (Notice details: "
- . "nickname=%s, user ID=%d, Facebook ID=%d, notice content=\"%s\"). Re-queueing "
- . "notice, and will try to send again later.";
+ . "nickname=%s, user ID=%d, Facebook ID=%d, notice content=\"%s\"). Removing notice "
+ . "from the Facebook queue for safety.";
common_log(
LOG_ERR, sprintf(
$msg,
@@ -243,8 +243,7 @@ function handleFacebookError($e, $notice, $flink)
$notice->content
)
);
- // Re-queue and try again later
- return false;
+ return true; // dequeue
break;
}
}
--
2.39.5