From 1104ea2a0e8a497a6c872b11cf14191727112c6e Mon Sep 17 00:00:00 2001
From: Mikael Nordfeldth <mmn@hethane.se>
Date: Tue, 3 Feb 2015 14:58:22 +0100
Subject: [PATCH] Fave insert logging directly in insert()

---
 plugins/Favorite/classes/Fave.php | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/plugins/Favorite/classes/Fave.php b/plugins/Favorite/classes/Fave.php
index 2e60defa4f..e1f70a7978 100644
--- a/plugins/Favorite/classes/Fave.php
+++ b/plugins/Favorite/classes/Fave.php
@@ -63,12 +63,9 @@ class Fave extends Managed_DataObject
                                             $notice,
                                             $fave->created);
 
-            try {
-                $fave->insert();
-            } catch (ServerException $e) {
-                common_log_db_error($fave, 'INSERT', __FILE__);
-                throw $e;
-            }
+            // throws exception (Fave specific until migrated into Managed_DataObject
+            $fave->insert();
+
             self::blowCacheForProfileId($fave->user_id);
             self::blowCacheForNoticeId($fave->notice_id);
             self::blow('popular');
@@ -82,7 +79,8 @@ class Fave extends Managed_DataObject
     // exception throwing takeover!
     public function insert()
     {
-        if (!parent::insert()) {
+        if (parent::insert()===false) {
+            common_log_db_error($this, 'INSERT', __FILE__);
             throw new ServerException(sprintf(_m('Could not store new object of type %s'), get_called_class()));
         }
         self::blowCacheForProfileId($this->user_id);
-- 
2.39.2