From 16aca39aad42749527919c6baf50dfdc7aa96d4c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Fri, 25 Sep 2009 21:15:08 +0000 Subject: [PATCH] publishHubDescriptor() added, TODOs.txt updated --- .../hub/main/nodes/class_BaseHubNode.php | 12 +++- .../hub/main/nodes/list/class_HubListNode.php | 11 ++- .../main/nodes/master/class_HubMasterNode.php | 9 ++- .../nodes/regular/class_HubRegularNode.php | 9 ++- docs/TODOs.txt | 71 +++++++++++-------- 5 files changed, 76 insertions(+), 36 deletions(-) diff --git a/application/hub/main/nodes/class_BaseHubNode.php b/application/hub/main/nodes/class_BaseHubNode.php index 422fe6f17..cebc45bde 100644 --- a/application/hub/main/nodes/class_BaseHubNode.php +++ b/application/hub/main/nodes/class_BaseHubNode.php @@ -316,7 +316,17 @@ class BaseHubNode extends BaseHubSystem implements Updateable { // Debug message $this->debugOutput('BOOTSTRAP: Initialize queues: FINISHED'); } - + + /** + * Publish our hub descriptor to the upper hub(s) + * + * @return void + * @todo This should be implemented in a generic way to keep things easy. + */ + protected function publishHubDescriptor () { + $this->partialStub('Unfinished method.'); + } + /** * Adds hub data elements to a given dataset instance * diff --git a/application/hub/main/nodes/list/class_HubListNode.php b/application/hub/main/nodes/list/class_HubListNode.php index f9d289f45..37e74a0ad 100644 --- a/application/hub/main/nodes/list/class_HubListNode.php +++ b/application/hub/main/nodes/list/class_HubListNode.php @@ -55,10 +55,17 @@ class HubListNode extends BaseHubNode implements NodeHelper, Registerable { * should communicate with the bootstrap-nodes at this point. * * @return void - * @todo Implement this method + * @todo Implement more bootstrap steps */ public function doBootstrapping () { - $this->partialStub('Please implement this method.'); + // Do more here + $this->partialStub('Do something before hub descriptor is published.'); + + // Publish the descriptor of this hub, this will "announce" us to upper hubs + $this->publishHubDescriptor(); + + // Do more here + $this->partialStub('Do something after hub descriptor is published.'); } /** diff --git a/application/hub/main/nodes/master/class_HubMasterNode.php b/application/hub/main/nodes/master/class_HubMasterNode.php index 4c9aeeb12..c68d0a321 100644 --- a/application/hub/main/nodes/master/class_HubMasterNode.php +++ b/application/hub/main/nodes/master/class_HubMasterNode.php @@ -58,7 +58,14 @@ class HubMasterNode extends BaseHubNode implements NodeHelper, Registerable { * @todo Implement this method */ public function doBootstrapping () { - $this->partialStub('Please implement this method.'); + // Do more here + $this->partialStub('Do something before hub descriptor is published.'); + + // Publish the descriptor of this hub, this will "announce" us to upper hubs + $this->publishHubDescriptor(); + + // Do more here + $this->partialStub('Do something after hub descriptor is published.'); } /** diff --git a/application/hub/main/nodes/regular/class_HubRegularNode.php b/application/hub/main/nodes/regular/class_HubRegularNode.php index c1bfaa0b8..d73ba618c 100644 --- a/application/hub/main/nodes/regular/class_HubRegularNode.php +++ b/application/hub/main/nodes/regular/class_HubRegularNode.php @@ -58,7 +58,14 @@ class HubRegularNode extends BaseHubNode implements NodeHelper, Registerable { * @todo Implement this method */ public function doBootstrapping () { - $this->partialStub('Please implement this method.'); + // Do more here + $this->partialStub('Do something before hub descriptor is published.'); + + // Publish the descriptor of this hub, this will "announce" us to upper hubs + $this->publishHubDescriptor(); + + // Do more here + $this->partialStub('Do something after hub descriptor is published.'); } /** diff --git a/docs/TODOs.txt b/docs/TODOs.txt index 7e868c5b8..57553e46d 100644 --- a/docs/TODOs.txt +++ b/docs/TODOs.txt @@ -26,32 +26,37 @@ ./application/hub/main/nodes/boot/class_HubBootNode.php:113: * @todo 0% ./application/hub/main/nodes/boot/class_HubBootNode.php:58: * @todo add some more special bootstrap things for this boot node ./application/hub/main/nodes/boot/class_HubBootNode.php:99: * @todo Unfinished method -./application/hub/main/nodes/class_BaseHubNode.php:348: * @todo Try to make this method more generic so we can move it in BaseFrameworkSystem -./application/hub/main/nodes/class_BaseHubNode.php:500: // @TODO Add some criteria, e.g. if the node is active or so -./application/hub/main/nodes/list/class_HubListNode.php:58: * @todo Implement this method -./application/hub/main/nodes/list/class_HubListNode.php:68: * @todo Unfinished method -./application/hub/main/nodes/list/class_HubListNode.php:82: * @todo 0% +./application/hub/main/nodes/class_BaseHubNode.php:324: * @todo This should be implemented in a generic way to keep things easy. +./application/hub/main/nodes/class_BaseHubNode.php:358: * @todo Try to make this method more generic so we can move it in BaseFrameworkSystem +./application/hub/main/nodes/class_BaseHubNode.php:510: // @TODO Add some criteria, e.g. if the node is active or so +./application/hub/main/nodes/list/class_HubListNode.php:58: * @todo Implement more bootstrap steps +./application/hub/main/nodes/list/class_HubListNode.php:75: * @todo Unfinished method +./application/hub/main/nodes/list/class_HubListNode.php:89: * @todo 0% ./application/hub/main/nodes/master/class_HubMasterNode.php:58: * @todo Implement this method -./application/hub/main/nodes/master/class_HubMasterNode.php:68: * @todo Unfinished method -./application/hub/main/nodes/master/class_HubMasterNode.php:82: * @todo 0% +./application/hub/main/nodes/master/class_HubMasterNode.php:75: * @todo Unfinished method +./application/hub/main/nodes/master/class_HubMasterNode.php:89: * @todo 0% ./application/hub/main/nodes/regular/class_HubRegularNode.php:58: * @todo Implement this method -./application/hub/main/nodes/regular/class_HubRegularNode.php:68: * @todo Unfinished method -./application/hub/main/nodes/regular/class_HubRegularNode.php:82: * @todo 0% +./application/hub/main/nodes/regular/class_HubRegularNode.php:75: * @todo Unfinished method +./application/hub/main/nodes/regular/class_HubRegularNode.php:89: * @todo 0% ./application/hub/main/resolver/state/network/class_NetworkStateResolver.php:69: * @todo 0% ./application/hub/main/resolver/state/network/class_NetworkStateResolver.php:78: // @TODO On some systems it is 134, on some 107? ./application/hub/main/tasks/hub/class_HubSelfConnectTask.php:53: * @todo 0% +./application/hub/main/tasks/hub/ping/class_HubPingTask.php:63: * @todo 0% +./application/hub/main/tasks/hub/update/class_HubUpdateCheckTask.php:53: * @todo 0% ./application/hub/main/visitor/tasks/class_ActiveTaskVisitor.php:90: * @todo Does a query needs to perform some actions as an active task? ./inc/classes/exceptions/io/class_FileNotFoundException.php:10: * @todo Rename this class to FileIoException ./inc/classes/exceptions/main/class_ClassNotFoundException.php:10: * @todo Rename this class to NoClassException ./inc/classes/exceptions/main/class_ConfigEntryNotFoundException.php:10: * @todo Rename this class to NoFoundEntryException ./inc/classes/exceptions/main/class_MissingMethodException.php:13: * @todo Try to rewrite user/guest login classes and mark this exception as deprecated ./inc/classes/interfaces/class_FrameworkInterface.php:11: * @todo Find a better name for this interface -./inc/classes/main/class_BaseFrameworkSystem.php:1045: * @todo Write a logging mechanism for productive mode -./inc/classes/main/class_BaseFrameworkSystem.php:1059: // @TODO Finish this part! -./inc/classes/main/class_BaseFrameworkSystem.php:109: // @todo Try to clean these constants up -./inc/classes/main/class_BaseFrameworkSystem.php:190: * @todo This is old code. Do we still need this old lost code? -./inc/classes/main/class_BaseFrameworkSystem.php:258: * @todo SearchableResult and UpdateableResult shall have a super interface to use here +./inc/classes/main/class_BaseFrameworkSystem.php:1078: * @todo Write a logging mechanism for productive mode +./inc/classes/main/class_BaseFrameworkSystem.php:1092: // @TODO Finish this part! +./inc/classes/main/class_BaseFrameworkSystem.php:119: // @todo Try to clean these constants up +./inc/classes/main/class_BaseFrameworkSystem.php:200: * @todo This is old code. Do we still need this old lost code? +./inc/classes/main/class_BaseFrameworkSystem.php:268: * @todo SearchableResult and UpdateableResult shall have a super interface to use here ./inc/classes/main/commands/web/class_WebLoginAreaCommand.php:64: * @todo Add some stuff here: Some personal data, app/game related data +./inc/classes/main/commands/web/class_WebProblemCommand.php:58: * @todo 0% done +./inc/classes/main/commands/web/class_WebStatusCommand.php:58: * @todo 0% done ./inc/classes/main/console/class_ConsoleTools.php:41: * @todo We should connect this to a caching class to cache DNS requests ./inc/classes/main/console/class_ConsoleTools.php:54: // @TODO Here should the cacher be implemented ./inc/classes/main/controller/console/class_ConsoleDefaultController.php:10: * @todo This controller shall still provide some headlines for sidebars @@ -61,6 +66,7 @@ ./inc/classes/main/controller/web/class_WebLoginController.php:41: * @todo Add some filters to this controller ./inc/classes/main/controller/web/class_WebLogoutController.php:10: * @todo This controller shall still provide some headlines for sidebars ./inc/classes/main/controller/web/class_WebLogoutDoneController.php:40: * @todo Add some filters to this controller +./inc/classes/main/controller/web/class_WebProblemController.php:40: * @todo Add some filters to this controller ./inc/classes/main/controller/web/class_WebRegisterController.php:40: * @todo Add some filters to this controller ./inc/classes/main/controller/web/class_WebStatusController.php:10: * @todo This controller shall still provide some headlines for sidebars ./inc/classes/main/criteria/search/class_SearchCriteria.php:114: * @todo Find a nice casting here. (int) allows until and including 32766. @@ -73,11 +79,13 @@ ./inc/classes/main/filter/payment/class_PaymentDiscoveryFilter.php:97: * @todo 0% done ./inc/classes/main/filter/update/class_UserUpdateFilter.php:55: * @todo Add more user updates here ./inc/classes/main/filter/verifier/class_AccountPasswordVerifierFilter.php:57: * @todo Rewrite handling of different password fields -./inc/classes/main/helper/class_BaseHelper.php:171: * @todo Rewrite this method using a helper class for filtering data -./inc/classes/main/helper/web/class_BaseWebHelper.php:151: * @todo Implement check if rules have been changed +./inc/classes/main/helper/class_BaseHelper.php:173: * @todo Rewrite this method using a helper class for filtering data +./inc/classes/main/helper/class_BaseHelper.php:202: // @TODO Try to log it here ./inc/classes/main/helper/web/forms/class_WebFormHelper.php:102: * @todo Add some unique PIN here to bypass problems with some browser and/or extensions ./inc/classes/main/helper/web/forms/class_WebFormHelper.php:621: * @todo Add checking if sub option is already added ./inc/classes/main/helper/web/forms/class_WebFormHelper.php:649: * @todo Add checking if sub option is already added +./inc/classes/main/helper/web/forms/class_WebFormHelper.php:683: // @TODO We need to log this later +./inc/classes/main/helper/web/forms/class_WebFormHelper.php:852: * @todo Implement check if rules have been changed ./inc/classes/main/helper/web/links/class_WebLinkHelper.php:184: * @todo Completely unimplemented ./inc/classes/main/images/class_BaseImage.php:156: * @todo Find something usefull for this method. ./inc/classes/main/images/class_BaseImage.php:166: * @todo Find something usefull for this method. @@ -90,37 +98,37 @@ ./inc/classes/main/images/class_BaseImage.php:255: * @todo Find something usefull for this method. ./inc/classes/main/io/class_FileIoStream.php:74: * @todo This method needs heavy rewrite ./inc/classes/main/mailer/debug/class_DebugMailer.php:124: * @todo 0% done -./inc/classes/main/output/class_ConsoleOutput.php:61: // @TODO Need to rewrite this to $requestInstance->addHeader() -./inc/classes/main/output/class_WebOutput.php:55: // @TODO Need to rewrite this to $requestInstance->addHeader() -./inc/classes/main/points/class_UserPoints.php:103: // @TODO Load points here -./inc/classes/main/points/class_UserPoints.php:81: * @todo Finish loading part of points +./inc/classes/main/menu/class_BaseMenu.php:59: // @TODO Should we log it here? We should, because it will be silently ignored. +./inc/classes/main/output/class_ConsoleOutput.php:56: // @TODO Need to rewrite this to $requestInstance->addHeader() +./inc/classes/main/parser/xml/class_XmlParser.php:69: // @TODO We need to find a fallback solution here +./inc/classes/main/points/class_UserPoints.php:100: * @todo Finish loading part of points ./inc/classes/main/request/console/class_ConsoleRequest.php:115: // @TODO There are no cookies on console ./inc/classes/main/request/console/class_ConsoleRequest.php:55: * @todo Needs to be implemented -./inc/classes/main/resolver/controller/class_BaseControllerResolver.php:137: // @TODO Maybe we need to log this? ./inc/classes/main/response/http/class_HttpResponse.php:77: * @todo Encryption of cookie data not yet supported. ./inc/classes/main/response/http/class_HttpResponse.php:78: * @todo Why are these parameters conflicting? ./inc/classes/main/response/http/class_HttpResponse.php:79: * @todo If the return statement is removed and setcookie() commented out, ./inc/classes/main/response/http/class_HttpResponse.php:80: * @todo this will send only one cookie out, the first one. -./inc/classes/main/response/image/class_ImageResponse.php:93: * @todo Encryption of cookie data not yet supported. -./inc/classes/main/response/image/class_ImageResponse.php:94: * @todo Why are these parameters conflicting? -./inc/classes/main/response/image/class_ImageResponse.php:95: * @todo If the return statement is removed and setcookie() commented out, -./inc/classes/main/response/image/class_ImageResponse.php:96: * @todo this will send only one cookie out, the first one. +./inc/classes/main/response/image/class_ImageResponse.php:88: * @todo Encryption of cookie data not yet supported. +./inc/classes/main/response/image/class_ImageResponse.php:89: * @todo Why are these parameters conflicting? +./inc/classes/main/response/image/class_ImageResponse.php:90: * @todo If the return statement is removed and setcookie() commented out, +./inc/classes/main/response/image/class_ImageResponse.php:91: * @todo this will send only one cookie out, the first one. ./inc/classes/main/result/class_DatabaseResult.php:226: * @todo 0% done ./inc/classes/main/result/class_DatabaseResult.php:379:4 * @todo Find a caching way without modifying the result array ./inc/classes/main/rng/class_RandomNumberGenerator.php:150: * @todo I had a better random number generator here but now it is somewhere lost :( ./inc/classes/main/rng/class_RandomNumberGenerator.php:83: * @todo Add site key for stronger salt! -./inc/classes/main/template/class_BaseTemplateEngine.php:1303: // @TODO We need to find a fallback solution here ./inc/classes/main/template/class_BaseTemplateEngine.php:810: * @todo Unfinished work or don't die here. ./inc/classes/main/template/class_BaseTemplateEngine.php:827: // @TODO Non-string found so we need some deeper analysis... ./inc/classes/main/template/class_BaseTemplateEngine.php:904: // @TODO Old behaviour, will become obsolete! ./inc/classes/main/template/class_BaseTemplateEngine.php:907: // @TODO Yet another old way -./inc/classes/main/template/class_BaseTemplateEngine.php:981: * @todo Make this code some nicer... -./inc/classes/main/template/image/class_ImageTemplateEngine.php:229: * @todo Find something usefull with this! -./inc/classes/main/template/image/class_ImageTemplateEngine.php:249: * @todo Add cache creation here +./inc/classes/main/template/class_BaseTemplateEngine.php:983: * @todo Make this code some nicer... +./inc/classes/main/template/image/class_ImageTemplateEngine.php:224: * @todo Find something usefull with this! +./inc/classes/main/template/image/class_ImageTemplateEngine.php:244: * @todo Add cache creation here ./inc/classes/main/template/mail/class_MailTemplateEngine.php:234: * @todo Add cache creation here ./inc/classes/main/template/mail/class_MailTemplateEngine.php:244: * @todo Should we call back the mailer class here? ./inc/classes/main/template/mail/class_MailTemplateEngine.php:325: * @todo 0% done -./inc/classes/main/user/class_BaseUser.php:305: * @todo Try to make this method more generic so we can move it in BaseFrameworkSystem +./inc/classes/main/template/menu/class_MenuTemplateEngine.php:257: * @todo Find something useful with this! +./inc/classes/main/template/menu/class_MenuTemplateEngine.php:302: * @todo Add cache creation here +./inc/classes/main/user/class_BaseUser.php:308: * @todo Try to make this method more generic so we can move it in BaseFrameworkSystem ./inc/classes/main/user/class_BaseUser.php:80: * @todo Find a way of casting here. "(int)" might destroy the user id > 32766 ./inc/classes/main/user/member/class_Member.php:84: * @todo Add more ways over creating user classes ./inc/classes/middleware/debug/class_DebugMiddleware.php:112: // @TODO Initialization phase @@ -135,4 +143,5 @@ ./inc/classes/exceptions/io/class_InvalidDirectoryResourceException.php:10: * @deprecated ./inc/classes/exceptions/main/class_ClassNotFoundException.php:11: * @deprecated ./inc/classes/exceptions/main/class_ConfigEntryNotFoundException.php:11: * @deprecated -./inc/classes/main/template/class_BaseTemplateEngine.php:1131: * @deprecated +./inc/classes/main/template/class_BaseTemplateEngine.php:1133: * @deprecated +./inc/classes/main/template/class_BaseTemplateEngine.php:953: * @deprecated -- 2.39.5