From 1b3d84422e27b5d1f728a4e4fedc8231e6e81453 Mon Sep 17 00:00:00 2001 From: Vasudev Kamath Date: Sat, 7 Jul 2012 16:17:26 +0530 Subject: [PATCH] orient function uses exif_read_data for which valid image types are only JPEG and TIFF as per the document [1]. When trying to upload an screenshot with png type I was getting message as *failed* even though image was uploading. So added a fix to check image type before calling orient function. Not sure if this is a proper fix but after this i'm not getting any error during file upload [1] http://au2.php.net/manual/en/function.exif-read-data.php --- mod/photos.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mod/photos.php b/mod/photos.php index 624f0bdcaa..42cad42f9c 100644 --- a/mod/photos.php +++ b/mod/photos.php @@ -740,7 +740,8 @@ function photos_post(&$a) { killme(); } - $ph->orient($src); + if($ph->getType() != 'image/png') + $ph->orient($src); @unlink($src); $max_length = get_config('system','max_image_length'); -- 2.39.5