From 2f312726826db5c4c3363926c743fea3c1c23b34 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Sat, 28 Nov 2009 17:29:25 +0000 Subject: [PATCH] make-euros has replied me, now when you add request parameters only those from selected type handler will be shown which makes live at easier --- DOCS/TODOs.txt | 5 ++--- inc/extensions/ext-network.php | 1 - inc/language/network_de.php | 2 ++ inc/modules/admin/what-list_network_params.php | 12 +++++++++++- 4 files changed, 15 insertions(+), 5 deletions(-) diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index cfd39e59b0..b8ef1eb82f 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -17,9 +17,8 @@ ./inc/extensions/ext-network.php:28: * @TODO Fusion-Ads: Has click/banner URL in API response * ./inc/extensions/ext-network.php:29: * @TODO GolloX: Which charset? * ./inc/extensions/ext-network.php:30: * @TODO homeADS: Which charset? * -./inc/extensions/ext-network.php:31: * @TODO make-euros: Which charset? * -./inc/extensions/ext-network.php:32: * @TODO paid4ad: Waiting for approval * -./inc/extensions/ext-network.php:85: // @TODO network_type_handle is an internal name and needs documentation +./inc/extensions/ext-network.php:31: * @TODO paid4ad: Waiting for approval * +./inc/extensions/ext-network.php:84: // @TODO network_type_handle is an internal name and needs documentation ./inc/extensions/ext-newsletter.php:215: // @TODO Move these into configuration ./inc/extensions/ext-rallye.php:330: // @TODO Move this code into rallye_functions.php ./inc/extensions/ext-rallye.php:93: // @TODO Fix config_rallye_prices to list_rallye_prices diff --git a/inc/extensions/ext-network.php b/inc/extensions/ext-network.php index 2fa817841a..2bd5e21e7e 100644 --- a/inc/extensions/ext-network.php +++ b/inc/extensions/ext-network.php @@ -28,7 +28,6 @@ * @TODO Fusion-Ads: Has click/banner URL in API response * * @TODO GolloX: Which charset? * * @TODO homeADS: Which charset? * - * @TODO make-euros: Which charset? * * @TODO paid4ad: Waiting for approval * * -------------------------------------------------------------------- * * Copyright (c) 2003 - 2009 by Roland Haeder * diff --git a/inc/language/network_de.php b/inc/language/network_de.php index 7574486b7e..ff45dd9466 100644 --- a/inc/language/network_de.php +++ b/inc/language/network_de.php @@ -108,6 +108,8 @@ addMessages(array( 'ADMIN_NETWORK_TYPES_LIST_NOTE' => "Seien Sie mit dem Löschen und Editieren von Werbeart-Handlern sehr vorsichtig. Sie sollten hierzu Rücksprache im Forum halten. Dokumentation zu den Platzhaltern (%FOO%, %BAR% usw.) finden Sie in der Dokumentation DOCs/de/network/README.txt.", 'ADMIN_NETWORK_PARAMS_ADD_NOTE' => "Fügen Sie hier weitere Abfrageparameter dem ausgwählten Werbenetzwerk hinzu. Geben Sie keine Werte an, wie z.B. 5 Sekunden oder 30 Mails, geben Sie bei Abfrageparameter den GET- bzw. POST-Parameternamen an.", 'ADMIN_NETWORK_PARAMS_LIST_NOTE' => "Seien Sie mit dem Löschen und Editieren von API-Abfrageparameter sehr vorsichtig. Sie sollten hierzu Rücksprache im Forum halten. Dokumentation zu den Abfragenamen (%FOO%, %BAR% usw.) finden Sie in der Dokumentation DOCs/de/network/README.txt.", + // - Other messages + 'ADMIN_NETWORK_PARAMS_LIST_LIMITED_TO_TYPE' => "Es wurden nur die Abfrageparameter des ausgewählten Werbeart-Handlers angezeigt.", // - Advertise types 'ADMIN_NETWORK_TYPES_BANNER_CLICK' => "Banner-Klick", 'ADMIN_NETWORK_TYPES_BANNER_VIEW' => "Banner-View", diff --git a/inc/modules/admin/what-list_network_params.php b/inc/modules/admin/what-list_network_params.php index 881a69cf7a..e951930717 100644 --- a/inc/modules/admin/what-list_network_params.php +++ b/inc/modules/admin/what-list_network_params.php @@ -70,6 +70,16 @@ if (isGetRequestParameterSet('network')) { // Init disabled list $networkData['disabled'] = array(); + // Only show params from given type handler if choosen + $ADD = ''; + if (isPostRequestParameterSet('network_type_id')) { + // Only show from current type handler + $ADD = sprintf(" AND p.`network_type_id`=%s", bigintval(postRequestParameter('network_type_id'))); + + // Display message + loadTemplate('admin_settings_saved', false, getMessage('ADMIN_NETWORK_PARAMS_LIST_LIMITED_TO_TYPE')); + } // END - if + // Load all advert types for given network $result = SQL_QUERY_ESC("SELECT p.`network_param_id`, t.`network_type_id`, t.`network_type_handle`, p.`request_param_key`, p.`request_param_value`, p.`request_param_default` @@ -80,7 +90,7 @@ INNER JOIN ON p.`network_type_id`=t.`network_type_id` WHERE - p.`network_id`=%s + p.`network_id`=%s".$ADD." ORDER BY t.`network_type_handle` ASC, p.`network_param_id` ASC", -- 2.39.5