From 31bf2cd6b9ca51eb7c09bbe9e6e1e5a271144005 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 28 Feb 2011 11:59:37 -0800 Subject: [PATCH] quick hack -- switch order on inline convo view (comments in forward chron) --- lib/threadednoticelist.php | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/threadednoticelist.php b/lib/threadednoticelist.php index 1af778721d..3a6e5e76c4 100644 --- a/lib/threadednoticelist.php +++ b/lib/threadednoticelist.php @@ -156,19 +156,25 @@ class ThreadedNoticeListItem extends NoticeListItem function showEnd() { $notice = Notice::conversationStream($this->notice->conversation); - - $this->out->elementStart('ul', 'notices threaded-notices xoxo'); + $notices = array(); while ($notice->fetch()) { if ($notice->id == $this->notice->id) { // Skip! continue; } - $this->out->elementStart('li'); - $item = new NoticeListItem($notice, $this->out); - $item->show(); - $this->out->elementEnd('li'); + $notices[] = clone($notice); // *grumble* inefficient as hell + } + + if ($notices) { + $this->out->elementStart('ul', 'notices threaded-notices xoxo'); + foreach (array_reverse($notices) as $notice) { + $this->out->elementStart('li'); + $item = new NoticeListItem($notice, $this->out); + $item->show(); + $this->out->elementEnd('li'); + } + $this->out->elementEnd('ul'); } - $this->out->elementEnd('ul'); parent::showEnd(); } -- 2.39.5