From 3cef75bcac999487fe88b5bd3250abb408c4c4a9 Mon Sep 17 00:00:00 2001
From: Mikael Nordfeldth <mmn@hethane.se>
Date: Fri, 12 Feb 2016 14:38:03 +0100
Subject: [PATCH] Update the comment on silencing privileged users in ModHelper
---
plugins/ModHelper/ModHelperPlugin.php | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/plugins/ModHelper/ModHelperPlugin.php b/plugins/ModHelper/ModHelperPlugin.php
index 2752a21539..88f2f2a731 100644
--- a/plugins/ModHelper/ModHelperPlugin.php
+++ b/plugins/ModHelper/ModHelperPlugin.php
@@ -17,9 +17,7 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
-if (!defined('STATUSNET')) {
- exit(1);
-}
+if (!defined('GNUSOCIAL')) { exit(1); }
/**
* @package ModHelperPlugin
@@ -45,7 +43,9 @@ class ModHelperPlugin extends Plugin
function onUserRightsCheck($profile, $right, &$result)
{
if (in_array($right, self::$rights)) {
- // Hrm.... really we should confirm that the *other* user isn't privleged. :)
+ // To silence a profile without accidentally silencing other
+ // privileged users, always call Profile->silenceAs($actor)
+ // since it checks target's privileges too.
if ($profile->hasRole('modhelper')) {
$result = true;
return false;
--
2.39.5