From 494746e66561bb30fe29539d0880669bb68b7702 Mon Sep 17 00:00:00 2001
From: Mikael Nordfeldth <mmn@hethane.se>
Date: Wed, 13 Jan 2016 19:24:38 +0100
Subject: [PATCH] Minor PuSH comment and debug stuff
---
plugins/OStatus/actions/pushcallback.php | 2 +-
plugins/OStatus/actions/pushhub.php | 1 -
plugins/OStatus/classes/HubSub.php | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/plugins/OStatus/actions/pushcallback.php b/plugins/OStatus/actions/pushcallback.php
index 95514112ca..317398243d 100644
--- a/plugins/OStatus/actions/pushcallback.php
+++ b/plugins/OStatus/actions/pushcallback.php
@@ -82,7 +82,7 @@ class PushCallbackAction extends Action
$mode = $this->arg('hub_mode');
$topic = $this->arg('hub_topic');
$challenge = $this->arg('hub_challenge');
- $lease_seconds = $this->arg('hub_lease_seconds'); // Must be >0 for PuSH 0.4!
+ $lease_seconds = $this->arg('hub_lease_seconds'); // Must be >0 for PuSH 0.4! And only checked on mode='subscribe' of course
common_log(LOG_INFO, __METHOD__ . ": sub verification mode: $mode topic: $topic challenge: $challenge lease_seconds: $lease_seconds");
if ($mode != 'subscribe' && $mode != 'unsubscribe') {
diff --git a/plugins/OStatus/actions/pushhub.php b/plugins/OStatus/actions/pushhub.php
index 8f54a1497b..be8076b75e 100644
--- a/plugins/OStatus/actions/pushhub.php
+++ b/plugins/OStatus/actions/pushhub.php
@@ -118,7 +118,6 @@ class PushHubAction extends Action
$sub->secret = $secret;
}
if ($lease) {
- common_debug('PuSH hub setting dataobject lease to:'._ve(intval($lease)));
$sub->setLease(intval($lease));
}
}
diff --git a/plugins/OStatus/classes/HubSub.php b/plugins/OStatus/classes/HubSub.php
index c9c1bf54e7..54949c6113 100644
--- a/plugins/OStatus/classes/HubSub.php
+++ b/plugins/OStatus/classes/HubSub.php
@@ -84,7 +84,7 @@ class HubSub extends Managed_DataObject
common_debug('PuSH hub got requested lease_seconds=='._ve($length));
assert(is_int($length));
- $min = 86400;
+ $min = 86400; // 3600*24 (one day)
$max = 86400 * 30;
if ($length == 0) {
--
2.39.5