From 4d99b8f3b1ea73e14c664886e0f8a5da948e4044 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Roland=20H=C3=A4der?= <roland@mxchange.org>
Date: Sun, 12 Feb 2012 11:26:56 +0000
Subject: [PATCH] Renamed it to make it clear what it does
---
.../hub/interfaces/package/assembler/class_Assembler.php | 8 ++++----
.../hub/main/package/assembler/class_PackageAssembler.php | 2 +-
application/hub/main/package/class_NetworkPackage.php | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/application/hub/interfaces/package/assembler/class_Assembler.php b/application/hub/interfaces/package/assembler/class_Assembler.php
index 38fc930c4..5b18035fc 100644
--- a/application/hub/interfaces/package/assembler/class_Assembler.php
+++ b/application/hub/interfaces/package/assembler/class_Assembler.php
@@ -23,13 +23,13 @@
*/
interface Assembler extends FrameworkInterface {
/**
- * Assembles the content from $packageContent into a raw package data array.
- * This method may throw exceptions if some checks fails.
+ * Chunks the content from $packageContent and feeds it into another queue
+ * for verification and possible re-requesting.
*
* @param $packageContent An array with two elements: 'decoded_data' and 'error_code'
- * @return $packageData A valid raw package data array
+ * @return void
*/
- function assemblePackageDataArrayFromContent (array $packageContent);
+ function chunkPackageContent (array $packageContent);
}
// [EOF]
diff --git a/application/hub/main/package/assembler/class_PackageAssembler.php b/application/hub/main/package/assembler/class_PackageAssembler.php
index 2255fe1f1..9e952487b 100644
--- a/application/hub/main/package/assembler/class_PackageAssembler.php
+++ b/application/hub/main/package/assembler/class_PackageAssembler.php
@@ -60,7 +60,7 @@ class PackageAssembler extends BaseFrameworkSystem implements Assembler, Registe
* @return void
* @throws UnsupportedPackageCodeHandlerException If the package code handler is not implemented
*/
- public function assemblePackageDataArrayFromContent (array $packageContent) {
+ public function chunkPackageContent (array $packageContent) {
// Validate the package content array again
assert(
(isset($packageContent[BaseRawDataHandler::PACKAGE_DECODED_DATA])) &&
diff --git a/application/hub/main/package/class_NetworkPackage.php b/application/hub/main/package/class_NetworkPackage.php
index 631d0101b..37c36f19a 100644
--- a/application/hub/main/package/class_NetworkPackage.php
+++ b/application/hub/main/package/class_NetworkPackage.php
@@ -702,8 +702,8 @@ class NetworkPackage extends BaseFrameworkSystem implements Deliverable, Receiva
// Get a package assembler instance from factory
$assemblerInstance = PackageAssemblerFactory::createAssemblerInstance();
- // Start assembling the raw package data array
- $assemblerInstance->assemblePackageDataArrayFromContent($packageContent);
+ // Start assembling the raw package data array by chunking it
+ $assemblerInstance->chunkPackageContent($packageContent);
die(__METHOD__.': BACK!' . chr(10));
}
--
2.39.5