From 54a0e801f3485424d0ad352c02ab331b2f7a11fb Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Tue, 14 Dec 2010 13:12:24 -0800 Subject: [PATCH] AtomPub fixes: return '201 Created' on POST of new message; better error checking on Atom input --- actions/apitimelineuser.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/actions/apitimelineuser.php b/actions/apitimelineuser.php index d90507aa44..ca4b090a16 100644 --- a/actions/apitimelineuser.php +++ b/actions/apitimelineuser.php @@ -309,9 +309,15 @@ class ApiTimelineUserAction extends ApiBareAuthAction return; } - $xml = file_get_contents('php://input'); + $xml = trim(file_get_contents('php://input')); + if (empty($xml)) { + $this->clientError(_('Atom post must not be empty.')); + } $dom = DOMDocument::loadXML($xml); + if (!$dom) { + $this->clientError(_('Atom post must be well-formed XML.')); + } if ($dom->documentElement->namespaceURI != Activity::ATOM || $dom->documentElement->localName != 'entry') { @@ -349,6 +355,7 @@ class ApiTimelineUserAction extends ApiBareAuthAction } if (!empty($saved)) { + header('HTTP/1.1 201 Created'); header("Location: " . common_local_url('ApiStatusesShow', array('notice_id' => $saved->id, 'format' => 'atom'))); $this->showSingleAtomStatus($saved); -- 2.39.5