From 8092188991abe4bb234d7d8f40f31a9b1ab60e79 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Tue, 21 Jun 2022 21:12:43 +0200 Subject: [PATCH] Added important comment from @nupplaphil@github.com --- tests/Util/Database/StaticDatabase.php | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/Util/Database/StaticDatabase.php b/tests/Util/Database/StaticDatabase.php index 2c05b921b5..81bb5a9961 100644 --- a/tests/Util/Database/StaticDatabase.php +++ b/tests/Util/Database/StaticDatabase.php @@ -179,7 +179,18 @@ class StaticDatabase extends Database self::$staticConnection = @new ExtendedPDO($connect, $user, $pass); self::$staticConnection->setAttribute(PDO::ATTR_AUTOCOMMIT,0); } catch (PDOException $e) { - /// @TODO Try to find a way to log this exception as it contains valueable information + /* + * @TODO Try to find a way to log this exception as it contains valueable information + * @nupplaphil@github.com comment: + * + * There is no easy possibility to add a logger here, that's why + * there isn't any yet and instead a placeholder.. This execution + * point is a critical state during a testrun, and tbh I'd like to + * leave here no further logic (yet) because I spent hours debugging + * cases, where transactions weren't fully closed and + * strange/unpredictable errors occur (sometimes -mainly during + * debugging other errors :) ...) + */ } } -- 2.39.5