From 8356c2495cfae61e3e6bac67cfcf3cba1904364f Mon Sep 17 00:00:00 2001 From: Mikael Nordfeldth Date: Fri, 26 Feb 2016 13:52:25 +0100 Subject: [PATCH] Use mb_* and strict === comparison --- classes/File.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/classes/File.php b/classes/File.php index c6677c2fd3..4e51be4938 100644 --- a/classes/File.php +++ b/classes/File.php @@ -109,8 +109,8 @@ class File extends Managed_DataObject // if the given url is an local attachment url and the id already exists, don't // save a new file record. This should never happen, but let's make it foolproof $attachment_path = common_path('attachment/'); - if(strpos($given_url,$attachment_path) == 0) { - $possible_file_id = substr($given_url,strlen($attachment_path)); + if (mb_strpos($given_url,$attachment_path) === 0) { + $possible_file_id = mb_substr($given_url, mb_strlen($attachment_path)); if(is_numeric($possible_file_id)) { $file = File::getKV('id',$possible_file_id); if($file instanceof File) { -- 2.39.5