From a3a2168292855ce99246b6244084be58552e8172 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Tue, 1 Dec 2009 15:44:07 -0800 Subject: [PATCH] Fix regression in password settings: users have been unable to change their passwords since introduction of ChangePassword event (later StartChangePassword) November 5 in commit d6ddb84132d7b9510ba82064c67f2a39822dab49 Logic was inversed; new password was only being saved if a plugin claimed the event; so when no auth plugin was present to take it, passwords never got saved. --- actions/passwordsettings.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/actions/passwordsettings.php b/actions/passwordsettings.php index 4395f772bd..3bb8e3bb9f 100644 --- a/actions/passwordsettings.php +++ b/actions/passwordsettings.php @@ -170,7 +170,7 @@ class PasswordsettingsAction extends AccountSettingsAction } $success = false; - if(! Event::handle('StartChangePassword', array($user, $oldpassword, $newpassword))){ + if(Event::handle('StartChangePassword', array($user, $oldpassword, $newpassword))){ //no handler changed the password, so change the password internally $original = clone($user); -- 2.39.5