From b1e07faf4f302f4fecc66a86292ca9fa5cfa5c9c Mon Sep 17 00:00:00 2001
From: rabuzarus <trebor@central-unit>
Date: Wed, 20 Apr 2016 23:08:01 +0200
Subject: [PATCH] contacts page: batch actions are now links in a dropdown menu
 - The new js funcion batch_submit_handler should handle the submission of the
 batch Values

---
 templates/contacts-template.tpl | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/templates/contacts-template.tpl b/templates/contacts-template.tpl
index 9e4d6407be..67eb92f0bd 100644
--- a/templates/contacts-template.tpl
+++ b/templates/contacts-template.tpl
@@ -25,7 +25,11 @@
 	<div id="contacts-search-end"></div>
 
 	{{* we need the form container to make batch actions work *}}
-	<form action="{{$baseurl}}/contacts/batch/" method="POST">
+	<form name="batch_actions_submit" action="{{$baseurl}}/contacts/batch/" method="POST">
+
+		{{* we put here a hidden input element. This is needed to transmit the batch actions with javascript*}}
+		<input type="hidden" class="batch-action no-input fakelist" name="batch_submit" value="{{$l|escape:'html'}}">
+
 		{{* We put the contact batch actions in a dropdown menu *}}
 		<ul class="nav nav-pills preferences">
 			<li class="dropdown pull-right">
@@ -34,8 +38,9 @@
 				</a>
 				<ul class="dropdown-menu pull-right" role="menu" aria-labelledby="BatchActionDropdownMenuTools">
 				{{foreach $batch_actions as $n=>$l}}
-					<li role="presentation">
-						<input class="batch-action no-input fakelist" name="{{$n}}" value="{{$l|escape:'html'}}" type="submit">
+					<li role="menuitem">
+						{{* call the js batch_submit_handler. Have a look at the buttom of this file *}}
+						<a onclick="batch_submit_handler('{{$n}}', '{{$l}}')">{{$l}}</a>
 					</li>
 				{{/foreach}}
 				</ul>
@@ -81,5 +86,21 @@
    
   });
  });
+
+/**
+ * @brief This function submits the form with the batch action values
+ *
+ * @param string name The name of the batch action
+ * @param string value If it isn't empty the action will be posted
+ */
+function batch_submit_handler(name, value) {
+    // set the value of the hidden input element with the name batch_submit
+    document.batch_actions_submit.batch_submit.value=value;
+    // change the name of the input element from batch_submit according to the
+    // name which is transmitted to this function
+    document.batch_actions_submit.batch_submit.name=name;
+    // transmit the form
+    document.batch_actions_submit.submit() ;
+}
  </script>
 
-- 
2.39.5