From b513a597c81b1443f39721716316e162690dc8a4 Mon Sep 17 00:00:00 2001 From: Michael Date: Sat, 21 Oct 2017 16:13:25 +0000 Subject: [PATCH] Static methods should be called statically --- include/Photo.php | 4 ++-- mod/photo.php | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/include/Photo.php b/include/Photo.php index a86942ee29..457a2e31c4 100644 --- a/include/Photo.php +++ b/include/Photo.php @@ -26,7 +26,7 @@ class Photo { /** * @brief supported mimetypes and corresponding file extensions */ - static function supportedTypes() { + static public function supportedTypes() { if (class_exists('Imagick')) { // Imagick::queryFormats won't help us a lot there... @@ -49,7 +49,7 @@ class Photo { public function __construct($data, $type=null) { $this->imagick = class_exists('Imagick'); - $this->types = $this->supportedTypes(); + $this->types = static::supportedTypes(); if (!array_key_exists($type, $this->types)){ $type='image/jpeg'; } diff --git a/mod/photo.php b/mod/photo.php index e223808307..72b7e8e95a 100644 --- a/mod/photo.php +++ b/mod/photo.php @@ -202,12 +202,15 @@ function photo_init(App $a) { if ($public and ($file != "")) { // If the photo path isn't there, try to create it $basepath = $a->get_basepath(); - if (!is_dir($basepath."/photo")) - if (is_writable($basepath)) + if (!is_dir($basepath."/photo")) { + if (is_writable($basepath)) { mkdir($basepath."/photo"); + } + } - if (is_dir($basepath."/photo")) + if (is_dir($basepath."/photo")) { file_put_contents($basepath."/photo/".$file, $data); + } } killme(); -- 2.39.5