From c5fcebd3d76023296ffc643be8736ac5a9c3dbb6 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Roland=20H=C3=A4der?= <roland@mxchange.org>
Date: Fri, 25 Mar 2011 10:34:19 +0000
Subject: [PATCH] Renamed script to baseUrl to make it more clear

---
 inc/http-functions.php                | 27 ++++++++++++++-------------
 inc/modules/admin/what-list_links.php |  4 ++--
 2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/inc/http-functions.php b/inc/http-functions.php
index 6289d6d2b8..5e7aefa571 100644
--- a/inc/http-functions.php
+++ b/inc/http-functions.php
@@ -59,17 +59,17 @@ function sendHttpHeaders () {
 }
 
 // Send a GET request
-function sendGetRequest ($script, $data = array(), $removeHeader = false) {
+function sendGetRequest ($baseUrl, $data = array(), $removeHeader = false) {
 	// Extract hostname and port from script
-	$host = extractHostnameFromUrl($script);
+	$host = extractHostnameFromUrl($baseUrl);
 
 	// Add data
 	$body = http_build_query($data, '', '&');
 
-	// There should be data, else we don't need to extend $script with $body
+	// There should be data, else we don't need to extend $baseUrl with $body
 	if (!empty($body)) {
 		// Do we have a question-mark in the script?
-		if (strpos($script, '?') === false) {
+		if (strpos($baseUrl, '?') === false) {
 			// No, so first char must be question mark
 			$body = '?' . $body;
 		} else {
@@ -78,16 +78,16 @@ function sendGetRequest ($script, $data = array(), $removeHeader = false) {
 		}
 
 		// Add script data
-		$script .= $body;
+		$baseUrl .= $body;
 
 		// Remove trailed & to make it more conform
-		if (substr($script, -1, 1) == '&') {
-			$script = substr($script, 0, -1);
+		if (substr($baseUrl, -1, 1) == '&') {
+			$baseUrl = substr($baseUrl, 0, -1);
 		} // END - if
 	} // END - if
 
 	// Generate GET request header
-	$request  = 'GET /' . trim($script) . ' HTTP/1.1' . getConfig('HTTP_EOL');
+	$request  = 'GET /' . trim($baseUrl) . ' HTTP/1.1' . getConfig('HTTP_EOL');
 	$request .= 'Host: ' . $host . getConfig('HTTP_EOL');
 	$request .= 'Referer: ' . getUrl() . '/admin.php' . getConfig('HTTP_EOL');
 	if (isConfigEntrySet('FULL_VERSION')) {
@@ -115,15 +115,15 @@ function sendGetRequest ($script, $data = array(), $removeHeader = false) {
 }
 
 // Send a POST request
-function sendPostRequest ($script, array $postData, $removeHeader = false) {
+function sendPostRequest ($baseUrl, array $postData, $removeHeader = false) {
 	// Extract host name from script
-	$host = extractHostnameFromUrl($script);
+	$host = extractHostnameFromUrl($baseUrl);
 
 	// Construct request body
 	$body = http_build_query($postData, '', '&');
 
 	// Generate POST request header
-	$request  = 'POST /' . trim($script) . ' HTTP/1.0' . getConfig('HTTP_EOL');
+	$request  = 'POST /' . trim($baseUrl) . ' HTTP/1.0' . getConfig('HTTP_EOL');
 	$request .= 'Host: ' . $host . getConfig('HTTP_EOL');
 	$request .= 'Referer: ' . getUrl() . '/admin.php' . getConfig('HTTP_EOL');
 	$request .= 'User-Agent: ' . getTitle() . '/' . getFullVersion() . getConfig('HTTP_EOL');
@@ -193,7 +193,7 @@ function sendRawRequest ($host, $request) {
 	$resolver = new HostnameResolver();
 
 	// Open connection
-	//* DEBUG: */ die('SCRIPT=' . $script);
+	//* DEBUG: */ die('baseUrl=' . $baseUrl);
 	if ($useProxy === true) {
 		// Resolve hostname into IP address
 		$ip = $resolver->resolveHostname(compileRawCode(getProxyHost()));
@@ -485,7 +485,8 @@ if (!function_exists('http_chunked_decode')) {
 	 *
 	 * @param	$chunk		The encoded message
 	 * @return	$dechunk	The decoded message. If $chunk wasn't encoded properly debug_report_bug() is being called
-	 * @author	Marques Johansson
+	 * @author	Marques Johansson (initial author)
+	 * @author	Roland Haeder (heavy modifications and simplification)
 	 * @link	http://php.net/manual/en/function.http-chunked-decode.php#89786
 	 */
 	function http_chunked_decode ($chunk) {
diff --git a/inc/modules/admin/what-list_links.php b/inc/modules/admin/what-list_links.php
index 31a456a678..252a22e156 100644
--- a/inc/modules/admin/what-list_links.php
+++ b/inc/modules/admin/what-list_links.php
@@ -84,11 +84,11 @@ if (isGetRequestParameterSet('userid')) {
 				// List all unconfirmed mails
 				// @TODO Find a way to rewrite this. See some lines above for different queries
 				while (list($id, $id2, $type) = SQL_FETCHROW($result)) {
-					// Initializes some variables
+					// Initializes all variables
 					$cat = '';
 					$DATA = '';
 					$PROBLEM = '{--ADMIN_GENERAL_MAIL_PROBLEM--}';
-					$result_data = false; // Closes Bug #58
+					$result_data = false;
 
 					// Load data from stats table...
 					// @TODO Rewrite this to includes/filter
-- 
2.39.5