From ca256746fe0757a23df4064824c8fe2087ad5634 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Sun, 6 Jan 2013 20:25:35 +0000 Subject: [PATCH] Mailer project rwritten: - Extension ext-network continued: + More missing type handlers added + Also array element translations added + Made API query generally working + Added missing what-config_network.php to allow configuration + Many other improvements - Used correct MIME type for JavaScripts (text/javascript) - Many other rewrites - TODOs.txt updated --- .gitattributes | 44 +- DOCS/TODOs.txt | 134 +- DOCS/de/network/README.txt | 40 +- api.php | 74 + beg.php | 4 +- birthday_confirm.php | 4 +- doubler.php | 2 +- inc/ajax/ajax_ | 3 +- inc/ajax/ajax_admin.php | 3 +- inc/ajax/ajax_installer.php | 5 +- inc/callback-functions.php | 213 +- inc/classes/primera_api.class.php | 2 +- inc/classes/rdf.class.php | 4 +- inc/config-functions.php | 32 + inc/config-global.php | 3 + inc/db/lib-mysql3.php | 2 +- inc/email-functions.php | 4 +- inc/expression-functions.php | 2 +- inc/extensions-functions.php | 31 +- inc/extensions/ext-network.php | 4015 ++++++++++------- inc/filter/coupon_filter.php | 2 +- inc/filters.php | 11 +- inc/functions.php | 159 +- inc/http-functions.php | 86 +- inc/js/js-admin_ajax.php | 2 +- inc/js/js-install_ajax.php | 2 +- inc/js/js-surfbar_frame_top.php | 2 +- inc/js/js-surfbar_member_edit.php | 2 +- inc/language-functions.php | 6 +- inc/language/de.php | 12 +- inc/language/network_de.php | 130 +- inc/libs/admins_functions.php | 31 +- inc/libs/autopurge_functions.php | 2 +- inc/libs/beg_functions.php | 2 +- inc/libs/bonus_functions.php | 4 +- inc/libs/doubler_functions.php | 8 +- inc/libs/forced_functions.php | 8 +- inc/libs/network_functions.php | 1286 +++++- inc/libs/rallye_functions.php | 6 +- inc/libs/refback_functions.php | 2 +- inc/libs/register_functions.php | 4 +- inc/libs/sponsor_functions.php | 20 +- inc/libs/surfbar_functions.php | 10 +- inc/libs/task_functions.php | 14 +- inc/libs/user_functions.php | 10 +- inc/libs/wernis_functions.php | 6 +- inc/libs/yoomedia_functions.php | 2 +- inc/module-functions.php | 2 +- inc/modules/admin/admin-inc.php | 22 +- inc/modules/admin/overview-inc.php | 6 +- inc/modules/admin/what-admins_mails.php | 4 +- inc/modules/admin/what-config_holiday.php | 4 +- inc/modules/admin/what-config_network.php | 68 + inc/modules/admin/what-config_network_api.php | 22 +- .../admin/what-config_network_types.php | 35 +- inc/modules/admin/what-config_order.php | 8 +- inc/modules/admin/what-config_other.php | 10 +- inc/modules/admin/what-config_refid.php | 4 +- inc/modules/admin/what-config_removeip.php | 6 +- inc/modules/admin/what-config_surfbar.php | 4 +- inc/modules/admin/what-config_yoomedia.php | 4 +- inc/modules/admin/what-extensions.php | 2 +- inc/modules/admin/what-list_autopurge.php | 8 +- .../what-list_network_array_translation.php | 32 +- .../what-list_network_request_params.php | 8 +- inc/modules/admin/what-list_network_types.php | 8 +- .../admin/what-list_network_vcheck_params.php | 8 +- inc/modules/admin/what-list_payouts.php | 40 +- inc/modules/admin/what-list_task.php | 2 +- inc/modules/admin/what-query_network_apis.php | 20 + inc/modules/admin/what-unlock_sponsor.php | 4 +- inc/modules/admin/what-updates.php | 2 +- inc/modules/admin/what-user_contct.php | 2 +- inc/modules/admin/what-usr_online.php | 2 +- inc/modules/guest/what-sponsor_reg.php | 4 +- inc/modules/member/what-book_surfbar.php | 2 +- inc/modules/member/what-order.php | 4 +- inc/modules/member/what-reflinks.php | 2 +- inc/modules/member/what-transfer.php | 4 +- inc/modules/member/what-unconfirmed.php | 2 +- inc/monthly/monthly_beg.php | 2 +- inc/mysql-manager.php | 197 +- inc/pool/pool-user.php | 4 +- inc/purge/purge-general.php | 2 +- inc/purge/purge-inact.php | 2 +- inc/referral-functions.php | 60 +- inc/revision-functions.php | 2 +- inc/session-functions.php | 4 +- inc/sql-functions.php | 15 +- inc/template-functions.php | 313 +- inc/wrapper-functions.php | 37 +- inc/xml-functions.php | 147 +- install/tables.sql | 6 +- js/admin-network-query-api.js | 114 + js/ajax-common.js | 300 +- js/ajax-loader.js | 5 +- js/ajax-test.js | 2 +- js/core-common.js | 17 +- js/install-common.js | 50 +- js/menu-common.js | 2 +- mailid.php | 7 +- mailid_top.php | 9 +- ref.php | 2 +- show_bonus.php | 2 +- surfbar.php | 2 +- .../de/emails/guest/guest_register_done.tpl | 2 - .../de/emails/guest/guest_request_confirm.tpl | 2 - .../member/member_bonus_pool_normal.tpl | 2 +- .../emails/member/member_order_accepted.tpl | 2 - .../de/emails/member/member_order_deleted.tpl | 2 - .../de/emails/member/member_order_normal.tpl | 2 - .../emails/member/member_order_rejected.tpl | 2 - templates/de/emails/member/member_profile.tpl | 2 - .../de/emails/member/member_user_deleted.tpl | 2 - .../de/emails/member/member_user_locked.tpl | 2 - .../emails/member/member_user_pool_done.tpl | 2 - .../emails/member/member_user_pool_normal.tpl | 2 - .../de/emails/member/member_user_unlocked.tpl | 2 - .../de/emails/sponsor/sponsor_deleted.tpl | 2 - .../de/emails/sponsor/sponsor_locked.tpl | 2 - .../admin_add_config_network_type_form.tpl | 36 +- .../admin_add_network_array_translation.tpl | 2 +- .../admin/admin_add_network_request_param.tpl | 2 +- .../de/html/admin/admin_add_network_type.tpl | 2 +- .../admin/admin_add_network_vcheck_param.tpl | 2 +- templates/de/html/admin/admin_ajax_main.tpl | 32 +- .../de/html/admin/admin_ajax_windows.tpl | 53 + .../de/html/admin/admin_config_network.tpl | 50 + .../html/admin/admin_config_network_api.tpl | 29 +- .../html/admin/admin_config_network_types.tpl | 2 +- ...admin_delete_network_array_translation.tpl | 2 +- .../admin_delete_network_request_params.tpl | 2 +- .../html/admin/admin_delete_network_types.tpl | 2 +- .../admin/admin_delete_network_types_row.tpl | 2 +- .../admin_edit_config_network_type_form.tpl | 30 +- .../admin_edit_network_array_translation.tpl | 2 +- .../admin_edit_network_request_params.tpl | 2 +- .../html/admin/admin_edit_network_types.tpl | 2 +- .../admin_list_network_array_translation.tpl | 2 +- .../de/html/admin/admin_list_network_data.tpl | 4 + .../admin/admin_list_network_data_row.tpl | 2 +- .../admin/admin_list_network_query_api.tpl | 52 + .../admin_list_network_query_api_row.tpl | 12 + .../admin_list_network_request_params.tpl | 5 +- .../html/admin/admin_list_network_types.tpl | 2 +- .../admin/admin_list_network_types_row.tpl | 2 +- .../admin_list_network_vcheck_params.tpl | 3 +- .../admin/admin_show_config_network_type.tpl | 28 +- .../de/html/install/install_main_ajax.tpl | 2 +- .../de/html/install/install_selector.tpl | 4 +- templates/de/html/js/js_ | 27 + templates/de/html/js/js_admin_ajax.tpl | 32 +- templates/de/html/js/js_install_ajax.tpl | 33 +- templates/de/html/js/js_surfbar_frame_top.tpl | 8 +- .../de/html/js/js_surfbar_member_edit.tpl | 2 +- templates/de/html/js/js_surfbar_stopped.tpl | 2 +- .../select/select_network_configured_box.tpl | 23 + .../select_network_configured_option.tpl | 3 + .../html/select/select_network_type_box.tpl | 4 +- .../select_network_unconfigured_box.tpl | 23 + .../select_network_unconfigured_option.tpl | 3 + templates/xml/admin/admin_list_booking.xml | 7 + templates/xml/admin/admin_list_forced_ads.xml | 11 + .../xml/admin/admin_list_forced_campaigns.xml | 11 + .../xml/admin/admin_list_forced_costs.xml | 11 + templates/xml/admin/admin_list_grade_data.xml | 11 + .../admin_list_network_query_api_config.xml | 146 + .../xml/admin/admin_list_nickname_history.xml | 7 + .../xml/admin/admin_list_point_accounts.xml | 11 + .../xml/admin/admin_list_referral_levels.xml | 7 + .../xml/admin/admin_list_server_name_log.xml | 11 + .../xml/admin/admin_list_surfbar_actions.xml | 11 + .../xml/admin/admin_list_surfbar_packages.xml | 11 + .../xml/admin/admin_list_surfbar_urls.xml | 11 + templates/xml/admin/admin_list_user_subid.xml | 7 + .../xml/admin/admin_list_user_subid_stats.xml | 7 + templates/xml/admin_list_data_template.xml | 17 +- templates/xml/member/member_list_booking.xml | 2 +- templates/xml/member/member_list_subid.xml | 2 +- .../xml/member/member_list_subid_stats.xml | 2 +- theme/business/css/ajax.css | 45 +- theme/business/css/general.css | 10 +- theme/default/css/ajax.css | 22 +- theme/default/css/general.css | 10 +- theme/desert/css/ajax.css | 44 +- theme/desert/css/general.css | 10 +- theme/org/css/ajax.css | 23 +- theme/org/css/general.css | 10 +- theme/schleuder/css/ajax.css | 179 +- theme/ship-simu/css/ajax.css | 188 + 190 files changed, 6587 insertions(+), 2927 deletions(-) create mode 100644 api.php create mode 100644 inc/modules/admin/what-config_network.php create mode 100644 js/admin-network-query-api.js create mode 100644 templates/de/html/admin/admin_ajax_windows.tpl create mode 100644 templates/de/html/admin/admin_config_network.tpl create mode 100644 templates/de/html/admin/admin_list_network_query_api.tpl create mode 100644 templates/de/html/admin/admin_list_network_query_api_row.tpl create mode 100644 templates/de/html/js/js_ create mode 100644 templates/de/html/select/select_network_configured_box.tpl create mode 100644 templates/de/html/select/select_network_configured_option.tpl create mode 100644 templates/de/html/select/select_network_unconfigured_box.tpl create mode 100644 templates/de/html/select/select_network_unconfigured_option.tpl create mode 100644 templates/xml/admin/admin_list_network_query_api_config.xml create mode 100644 theme/ship-simu/css/ajax.css diff --git a/.gitattributes b/.gitattributes index 2acb04059b..4af5150e21 100644 --- a/.gitattributes +++ b/.gitattributes @@ -90,6 +90,7 @@ DOCS/tpl-validator.php svneol=native#text/plain /admin.php svneol=native#text/plain /agb.php svneol=native#text/plain /ajax.php svneol=native#text/plain +/api.php svneol=native#text/plain /autoreg.php svneol=native#text/plain /beg.php svneol=native#text/plain /birthday_confirm.php svneol=native#text/plain @@ -528,6 +529,7 @@ inc/modules/admin/what-config_imprint.php svneol=native#text/plain inc/modules/admin/what-config_mediadata.php svneol=native#text/plain inc/modules/admin/what-config_menu.php svneol=native#text/plain inc/modules/admin/what-config_mods.php svneol=native#text/plain +inc/modules/admin/what-config_network.php svneol=native#text/plain inc/modules/admin/what-config_network_api.php svneol=native#text/plain inc/modules/admin/what-config_network_types.php svneol=native#text/plain inc/modules/admin/what-config_newsletter.php svneol=native#text/plain @@ -864,21 +866,22 @@ inc/xml-functions.php svneol=native#text/plain /install.php svneol=native#text/plain /js.php svneol=native#text/plain js/.js svneol=native#text/plain -js/admin-common.js svneol=native#text/plain -js/admin-data.js svneol=native#text/plain -js/ajax-common.js svneol=native#text/plain -js/ajax-loader.js svneol=native#text/plain -js/ajax-test.js svneol=native#text/plain -js/core-common.js svneol=native#text/plain -js/install-common.js svneol=native#text/plain -js/install-data.js svneol=native#text/plain -js/jquery-ui.custom.js svneol=native#text/plain -js/jquery-ui.js svneol=native#text/plain -js/jquery-ui.uncompressed.js svneol=native#text/plain -js/jquery-uncompressed.js svneol=native#text/plain -js/jquery.js svneol=native#text/plain -js/jquery.uncompressed.js svneol=native#text/plain -js/menu-common.js svneol=native#text/plain +js/admin-common.js svneol=native#text/javascript +js/admin-data.js svneol=native#text/javascript +js/admin-network-query-api.js svneol=native#text/javascript +js/ajax-common.js svneol=native#text/javascript +js/ajax-loader.js svneol=native#text/javascript +js/ajax-test.js svneol=native#text/javascript +js/core-common.js svneol=native#text/javascript +js/install-common.js svneol=native#text/javascript +js/install-data.js svneol=native#text/javascript +js/jquery-ui.custom.js svneol=native#text/javascript +js/jquery-ui.js svneol=native#text/javascript +js/jquery-ui.uncompressed.js svneol=native#text/javascript +js/jquery-uncompressed.js svneol=native#text/javascript +js/jquery.js svneol=native#text/javascript +js/jquery.uncompressed.js svneol=native#text/javascript +js/menu-common.js svneol=native#text/javascript /lead-confirm.php svneol=native#text/plain /login.php svneol=native#text/plain /mailid.php svneol=native#text/plain @@ -1206,6 +1209,7 @@ templates/de/html/admin/admin_admins_mails_edit_row.tpl svneol=native#text/plain templates/de/html/admin/admin_admins_mails_list.tpl svneol=native#text/plain templates/de/html/admin/admin_admins_mails_list_row.tpl svneol=native#text/plain templates/de/html/admin/admin_ajax_main.tpl svneol=native#text/plain +templates/de/html/admin/admin_ajax_windows.tpl svneol=native#text/plain templates/de/html/admin/admin_cache_stats.tpl svneol=native#text/plain templates/de/html/admin/admin_config_ svneol=native#text/plain templates/de/html/admin/admin_config_active.tpl svneol=native#text/plain @@ -1228,6 +1232,7 @@ templates/de/html/admin/admin_config_home_main.tpl svneol=native#text/plain templates/de/html/admin/admin_config_home_settings_pro.tpl svneol=native#text/plain templates/de/html/admin/admin_config_mediadata.tpl svneol=native#text/plain templates/de/html/admin/admin_config_menu.tpl svneol=native#text/plain +templates/de/html/admin/admin_config_network.tpl svneol=native#text/plain templates/de/html/admin/admin_config_network_api.tpl svneol=native#text/plain templates/de/html/admin/admin_config_network_types.tpl svneol=native#text/plain templates/de/html/admin/admin_config_network_types_row.tpl svneol=native#text/plain @@ -1486,6 +1491,8 @@ templates/de/html/admin/admin_list_network_array_translation.tpl svneol=native#t templates/de/html/admin/admin_list_network_array_translation_row.tpl svneol=native#text/plain templates/de/html/admin/admin_list_network_data.tpl svneol=native#text/plain templates/de/html/admin/admin_list_network_data_row.tpl svneol=native#text/plain +templates/de/html/admin/admin_list_network_query_api.tpl svneol=native#text/plain +templates/de/html/admin/admin_list_network_query_api_row.tpl svneol=native#text/plain templates/de/html/admin/admin_list_network_request_params.tpl svneol=native#text/plain templates/de/html/admin/admin_list_network_request_params_row.tpl svneol=native#text/plain templates/de/html/admin/admin_list_network_types.tpl svneol=native#text/plain @@ -1898,6 +1905,7 @@ templates/de/html/install/install_warning_previous.tpl svneol=native#text/plain templates/de/html/install/install_warning_tab.tpl svneol=native#text/plain templates/de/html/install/install_welcome.tpl svneol=native#text/plain templates/de/html/js/.htaccess svneol=native#text/plain +templates/de/html/js/js_ svneol=native#text/plain templates/de/html/js/js_admin_ajax.tpl svneol=native#text/plain templates/de/html/js/js_cookies_disabled.tpl svneol=native#text/plain templates/de/html/js/js_install_ajax.tpl svneol=native#text/plain @@ -2138,11 +2146,15 @@ templates/de/html/select/select_forced_costs_id_option.tpl svneol=native#text/pl templates/de/html/select/select_forced_costs_visibility_box.tpl svneol=native#text/plain templates/de/html/select/select_forced_costs_visibility_option.tpl svneol=native#text/plain templates/de/html/select/select_network_box.tpl svneol=native#text/plain +templates/de/html/select/select_network_configured_box.tpl svneol=native#text/plain +templates/de/html/select/select_network_configured_option.tpl svneol=native#text/plain templates/de/html/select/select_network_option.tpl svneol=native#text/plain templates/de/html/select/select_network_type_box.tpl svneol=native#text/plain templates/de/html/select/select_network_type_option.tpl svneol=native#text/plain templates/de/html/select/select_network_type_title_box.tpl svneol=native#text/plain templates/de/html/select/select_network_type_title_option.tpl svneol=native#text/plain +templates/de/html/select/select_network_unconfigured_box.tpl svneol=native#text/plain +templates/de/html/select/select_network_unconfigured_option.tpl svneol=native#text/plain templates/de/html/select/select_points_locked_mode_box.tpl svneol=native#text/plain templates/de/html/select/select_points_locked_mode_option.tpl svneol=native#text/plain templates/de/html/select/select_points_payment_method_box.tpl svneol=native#text/plain @@ -2244,6 +2256,7 @@ templates/xml/admin/admin_list_forced_ads.xml svneol=native#text/plain templates/xml/admin/admin_list_forced_campaigns.xml svneol=native#text/plain templates/xml/admin/admin_list_forced_costs.xml svneol=native#text/plain templates/xml/admin/admin_list_grade_data.xml svneol=native#text/plain +templates/xml/admin/admin_list_network_query_api_config.xml svneol=native#text/plain templates/xml/admin/admin_list_nickname_history.xml svneol=native#text/plain templates/xml/admin/admin_list_point_accounts.xml svneol=native#text/plain templates/xml/admin/admin_list_referral_levels.xml svneol=native#text/plain @@ -2320,6 +2333,7 @@ theme/schleuder/images/menu/menu_title_rals.jpg -text svneol=unset#image/jpeg theme/schleuder/images/menu/menu_title_stats.jpg -text svneol=unset#image/jpeg theme/schleuder/images/menu/menu_title_themes.jpg -text svneol=unset#image/jpeg theme/schleuder/theme.php svneol=native#text/plain +theme/ship-simu/css/ajax.css -text theme/ship-simu/css/bonus.css -text theme/ship-simu/images/code_bg.jpg -text svneol=unset#image/jpeg theme/ship-simu/images/code_bg.png -text svneol=unset#image/png diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index 27b58fc3e9..91ca493d06 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -1,5 +1,6 @@ ### WARNING: THIS FILE IS AUTO-GENERATED BY ../../contrib/todo-builder.sh (uid=/user=quix0r) ### ### DO NOT EDIT THIS FILE. ### +./api.php:68:// @TODO Do stuff here ./autoreg.php:58:// @TODO Add processing of request here ./beg.php:175: // @TODO Opps, what is missing here??? ./inc/classes/cachesystem.class.php:516: // @TODO Add support for more types which break in last else-block @@ -14,33 +15,31 @@ ./inc/expression-functions.php:46: // @TODO is escapeQuotes() enough for strings with single/double quotes? ./inc/extensions/ext-html_mail.php:136: // @TODO Move these arrays into config ./inc/extensions/ext-menu.php:52: // @TODO Convert menu-Id to one coding-standard. admin(edit|_add) => admin_menu_(edit|add), mem(edit|_add) => (edit|add)_(admin|guest|member)_menu -./inc/extensions/ext-network.php:100: // @TODO network_type_handler is an internal name and needs documentation -./inc/extensions/ext-network.php:18: * @TODO Ad-Magnet: Layer(klick?). Layerviews.Skybannerklick/-view, * -./inc/extensions/ext-network.php:19: * @TODO Ad-Magnet: Banner-View, Textlink-Klick/-View. Page-Peel * -./inc/extensions/ext-network.php:20: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * -./inc/extensions/ext-network.php:21: * @TODO ADCocktail: Zero array element is return code! * -./inc/extensions/ext-network.php:22: * @TODO adgain.de: Textlink-View is a JavaScript URL * -./inc/extensions/ext-network.php:23: * @TODO ADkracher: Textlink-View is a JavaScript URL * -./inc/extensions/ext-network.php:24: * @TODO Admono.de: highforcedbanner, traffic from abroad * -./inc/extensions/ext-network.php:25: * @TODO Affiliblatt: Layer requires script in head * -./inc/extensions/ext-network.php:26: * @TODO Affiliblatt: Textlinks, popup, popunder, HTML mail, lead * -./inc/extensions/ext-network.php:27: * @TODO AllAds4You: Traffic from abroad, High-Forced banner * -./inc/extensions/ext-network.php:28: * @TODO eu-ADS/WeltPromotion: Text for banner/buttons? * -./inc/extensions/ext-network.php:29: * @TODO FuCoExSponsor: Textlink-View is JavaScript! * -./inc/extensions/ext-network.php:30: * @TODO Fusion-Ads: Has click/banner URL in API response * -./inc/extensions/ext-network.php:31: * @TODO GeldSponsor.de Requires ID card copy/business reg. * -./inc/extensions/ext-network.php:32: * @TODO GolloX: Which charset? * -./inc/extensions/ext-network.php:33: * @TODO paid4ad: Which URLs for click and banner? * -./inc/extensions/ext-network.php:34: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer * -./inc/extensions/ext-network.php:35: * @TODO SuperPromo24: Textlink view is a JavaScript * -./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * -./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Forced textlink not correct * -./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Layer not correct * -./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * -./inc/extensions/ext-network.php:40: * @TODO Der Werbepartner.cc: Surfbar click not correct * -./inc/extensions/ext-network.php:41: * @TODO Der Werbepartner.cc: Textlink not not correct * -./inc/extensions/ext-network.php:42: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL) * -./inc/extensions/ext-network.php:43: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * +./inc/extensions/ext-network.php:18: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * +./inc/extensions/ext-network.php:19: * @TODO ADCocktail: Zero array element is return code! * +./inc/extensions/ext-network.php:20: * @TODO adgain.de: Textlink-View is a JavaScript URL * +./inc/extensions/ext-network.php:21: * @TODO ADkracher: Textlink-View is a JavaScript URL * +./inc/extensions/ext-network.php:22: * @TODO Admono.de: highforcedbanner, traffic from abroad * +./inc/extensions/ext-network.php:23: * @TODO Affiliblatt: Layer requires script in head * +./inc/extensions/ext-network.php:24: * @TODO Affiliblatt: Textlinks, popup, popunder, HTML mail, lead * +./inc/extensions/ext-network.php:25: * @TODO AllAds4You: Traffic from abroad, High-Forced banner * +./inc/extensions/ext-network.php:26: * @TODO eu-ADS/WeltPromotion: Text for banner/buttons? * +./inc/extensions/ext-network.php:27: * @TODO FuCoExSponsor: Textlink-View is JavaScript! * +./inc/extensions/ext-network.php:28: * @TODO Fusion-Ads: Has click/banner URL in API response * +./inc/extensions/ext-network.php:29: * @TODO GeldSponsor.de Requires ID card copy/business reg. * +./inc/extensions/ext-network.php:30: * @TODO GolloX: Which charset? * +./inc/extensions/ext-network.php:31: * @TODO paid4ad: Which URLs for click and banner? * +./inc/extensions/ext-network.php:32: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer * +./inc/extensions/ext-network.php:33: * @TODO SuperPromo24: Textlink view is a JavaScript * +./inc/extensions/ext-network.php:34: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * +./inc/extensions/ext-network.php:35: * @TODO Der Werbepartner.cc: Forced textlink not correct * +./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Layer not correct * +./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * +./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Surfbar click not correct * +./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Textlink not not correct * +./inc/extensions/ext-network.php:40: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL) * +./inc/extensions/ext-network.php:41: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * +./inc/extensions/ext-network.php:98: // @TODO network_type_handler is an internal name and needs documentation ./inc/extensions/ext-newsletter.php:218: // @TODO Move these into configuration ./inc/extensions/ext-nickname.php:52: // @TODO NOT NULL DEFAULT '' is bad practice, use NULL ./inc/extensions/ext-yoomedia.php:121: // @TODO Can this be moved into a database table? @@ -53,36 +52,35 @@ ./inc/filter/bonus_filter.php:56: // @TODO This query isn't right, it will only update if the user was for a longer time away! ./inc/filter/cache_filter.php:94: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. ./inc/filter/forced_filter.php:73: // @TODO This part is unfinished -./inc/filters.php:1310: // @TODO No banner found, output some default banner -./inc/functions.php:1106: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? -./inc/functions.php:1192: // @TODO Are these convertions still required? -./inc/functions.php:1213:// @TODO Rewrite this function to use readFromFile() and writeToFile() -./inc/functions.php:1822: // @TODO Find a way to cache this -./inc/functions.php:1926: // @TODO This is still very static, rewrite it somehow -./inc/functions.php:2130: // @TODO Rename column data_type to e.g. mail_status -./inc/functions.php:2480:// @TODO cacheFiles is not yet supported +./inc/filters.php:1319: // @TODO No banner found, output some default banner +./inc/functions.php:1126: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? +./inc/functions.php:1212: // @TODO Are these convertions still required? +./inc/functions.php:1233:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:1842: // @TODO Find a way to cache this +./inc/functions.php:1946: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:2150: // @TODO Rename column data_type to e.g. mail_status +./inc/functions.php:2500:// @TODO cacheFiles is not yet supported ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter ./inc/header.php:66:// @TODO Find a way to not use direct module comparison ./inc/install-functions.php:446: // @TODO Comparing with DEFAULT_MAIN_TITLE doesn't work ./inc/install-functions.php:97: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); -./inc/language/de.php:1147: // @TODO Rewrite these two constants -./inc/language/de.php:1163: // @TODO Rewrite these three constants +./inc/language/de.php:1154: // @TODO Rewrite these two constants +./inc/language/de.php:1170: // @TODO Rewrite these three constants ./inc/language/de.php:46: // @TODO Please sort these language elements -./inc/language/de.php:741:// @TODO Are these constants longer used? -./inc/language-functions.php:255: // @TODO These are all valid languages, again hard-coded -./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function. +./inc/language/de.php:742:// @TODO Are these constants longer used? +./inc/language-functions.php:254: // @TODO These are all valid languages, again hard-coded ./inc/language/install_de.php:142: // @TODO Move this to e.g. ext-smtp ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no * ./inc/language/order_de.php:70: // @TODO Find better text ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings * ./inc/language/refback_de.php:51: // @TODO Rewrite these constants to one -./inc/libs/admins_functions.php:528: // @TODO This can be, somehow, rewritten +./inc/libs/admins_functions.php:537: // @TODO This can be, somehow, rewritten ./inc/libs/bonus_functions.php:195: // @TODO Move this HTML to a template ./inc/libs/doubler_functions.php:44:// @TODO Lame description ./inc/libs/doubler_functions.php:96: // @TODO Can't this be moved into EL? ./inc/libs/forced_functions.php:457:// @TODO Can't we use our new expression language instead of this ugly code? ./inc/libs/mailid_functions.php:47: // @TODO Rewrite this to a dynamic include or so -./inc/libs/network_functions.php:1124: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine +./inc/libs/network_functions.php:1182: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine ./inc/libs/order_functions.php:46: // @TODO Move this array into a filter ./inc/libs/rallye_functions.php:771:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() ./inc/libs/rallye_functions.php:838: $EXPIRE = 3; // @TODO The hard-coded value... @@ -181,37 +179,38 @@ ./inc/modules/member/what-unconfirmed.php:178: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() ./inc/modules/member/what-unconfirmed.php:247: // @TODO This 'userid' cannot be saved because of encapsulated EL code ./inc/modules/order.php:78: // @TODO Unused: 2,4 -./inc/mysql-manager.php:1450: // @TODO Rewrite these lines to a filter -./inc/mysql-manager.php:1474: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1780: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1977: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided -./inc/mysql-manager.php:2100: // @TODO Used generic 'userid' here -./inc/mysql-manager.php:2321:// @TODO cacheFiles is not yet supported +./inc/mysql-manager.php:1492: // @TODO Rewrite these lines to a filter +./inc/mysql-manager.php:1516: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1822: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1990: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided +./inc/mysql-manager.php:2113: // @TODO Used generic 'userid' here +./inc/mysql-manager.php:2334:// @TODO cacheFiles is not yet supported ./inc/mysql-manager.php:408: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:44:// @TODO Can we cache this? ./inc/purge/purge-inact.php:55: // @TODO Rewrite these if() blocks to a filter ./inc/revision-functions.php:168:// @TODO This function does also set and get in 'cache_array' -./inc/template-functions.php:1142: // @TODO Deprecate this thing -./inc/template-functions.php:1153: // @TODO Deprecate this thing -./inc/template-functions.php:1275: // @TODO This can be easily moved out after the merge from EL branch to this is complete -./inc/template-functions.php:1324: // @TODO Add a little more infos here -./inc/template-functions.php:1705:// @TODO Lame description for this function -./inc/template-functions.php:1727: // @TODO Move this in a filter -./inc/template-functions.php:200: * @TODO On some pages this is buggy -./inc/template-functions.php:2361: // @TODO Is this needed for e.g. $GLOBALS['template_content'] ? $this->setRawTemplateData($compactedContent); -./inc/template-functions.php:288: // @TODO Remove these sanity checks if all is fine -./inc/template-functions.php:731: // @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates +./inc/template-functions.php:1040: // @TODO