From f415e2353d7cd7ac4c9b7ab77b7af393c040bb65 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Fri, 1 Oct 2010 22:01:18 +0200 Subject: [PATCH] * i18n review * onPluginVersion --- .../GroupFavorited/GroupFavoritedPlugin.php | 24 +++++++++++++++++++ .../GroupFavorited/groupfavoritedaction.php | 7 +++--- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/plugins/GroupFavorited/GroupFavoritedPlugin.php b/plugins/GroupFavorited/GroupFavoritedPlugin.php index 68815530aa..27ce289c2e 100644 --- a/plugins/GroupFavorited/GroupFavoritedPlugin.php +++ b/plugins/GroupFavorited/GroupFavoritedPlugin.php @@ -76,4 +76,28 @@ class GroupFavoritedPlugin extends Plugin $action_name == 'groupfavorited', 'nav_group_group'); } + + /** + * Provide plugin version information. + * + * This data is used when showing the version page. + * + * @param array &$versions array of version data arrays; see EVENTS.txt + * + * @return boolean hook value + */ + function onPluginVersion(&$versions) + { + $url = 'http://status.net/wiki/Plugin:GroupFavorited'; + + $versions[] = array('name' => 'GroupFavorited', + 'version' => STATUSNET_VERSION, + 'author' => 'Brion Vibber', + 'homepage' => $url, + 'rawdescription' => + // TRANS: Plugin description. + _m('This plugin adds a menu item for popular notices in groups.')); + + return true; + } } diff --git a/plugins/GroupFavorited/groupfavoritedaction.php b/plugins/GroupFavorited/groupfavoritedaction.php index 6803bea8d6..dbd37abbcf 100644 --- a/plugins/GroupFavorited/groupfavoritedaction.php +++ b/plugins/GroupFavorited/groupfavoritedaction.php @@ -32,27 +32,27 @@ if (!defined('STATUSNET') && !defined('LACONICA')) { exit(1); } - class GroupFavoritedAction extends ShowgroupAction { - /** * Title of the page * * @return string page title, with page number */ - function title() { if (!empty($this->group->fullname)) { + // @todo Create a core method to create this properly. i18n issue. $base = $this->group->fullname . ' (' . $this->group->nickname . ')'; } else { $base = $this->group->nickname; } if ($this->page == 1) { + // TRANS: %s is a group name. return sprintf(_m('Popular posts in %s group'), $base); } else { + // TRANS: %1$s is a group name, %2$s is a group number. return sprintf(_m('Popular posts in %1$s group, page %2$d'), $base, $this->page); @@ -66,7 +66,6 @@ class GroupFavoritedAction extends ShowgroupAction * * @return void */ - function showContent() { $groupId = intval($this->group->id); -- 2.39.5