From f4681807439ac90239d114093a3841ef738282a3 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Thu, 18 Nov 2010 14:30:00 -0800 Subject: [PATCH] Fix regression in PopularNoticeSection: tag parameter was broken, causing sidebar on tag pages to show untagged favorites. --- lib/popularity.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/popularity.php b/lib/popularity.php index b6987138b5..7ab259a391 100644 --- a/lib/popularity.php +++ b/lib/popularity.php @@ -53,12 +53,12 @@ class Popularity { // @fixme there should be a common func for this if (common_config('db', 'type') == 'pgsql') { - if (!empty($this->out->tag)) { - $tag = pg_escape_string($this->out->tag); + if (!empty($this->tag)) { + $tag = pg_escape_string($this->tag); } } else { - if (!empty($this->out->tag)) { - $tag = mysql_escape_string($this->out->tag); + if (!empty($this->tag)) { + $tag = mysql_escape_string($this->tag); } } $weightexpr = common_sql_weight('fave.modified', common_config('popular', 'dropoff')); -- 2.39.5