From feb87e8dc32f922b9c9233c7facc91bad0492dbd Mon Sep 17 00:00:00 2001
From: =?utf8?q?Roland=20H=C3=A4der?= <roland@mxchange.org>
Date: Mon, 20 Jun 2022 19:08:23 +0200
Subject: [PATCH] Changes: - let's start throwing exceptions on e.g. invalid
 arguments instead of returning   FALSE

---
 src/Database/Database.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/Database/Database.php b/src/Database/Database.php
index 590c3d83d0..e0471b3635 100644
--- a/src/Database/Database.php
+++ b/src/Database/Database.php
@@ -26,6 +26,7 @@ use Friendica\Core\System;
 use Friendica\Network\HTTPException\ServiceUnavailableException;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Profiler;
+use InvalidArgumentException;
 use mysqli;
 use mysqli_result;
 use mysqli_stmt;
@@ -1512,7 +1513,7 @@ class Database
 	 * @param array        $condition Array of fields for condition
 	 * @param array        $params    Array of several parameters
 	 *
-	 * @return int
+	 * @return int Count of rows
 	 *
 	 * Example:
 	 * $table = "post";
@@ -1524,11 +1525,10 @@ class Database
 	 * $count = DBA::count($table, $condition);
 	 * @throws \Exception
 	 */
-	public function count($table, array $condition = [], array $params = [])
+	public function count($table, array $condition = [], array $params = []): int
 	{
-		// @TODO Can we dump this to have ": int" as returned type-hint?
 		if (empty($table)) {
-			return false;
+			throw new InvalidArgumentException('Parameter "table" cannot be empty.');
 		}
 
 		$table_string = DBA::buildTableString($table);
-- 
2.39.5