From 33e58a151e3a744de917a691bb6a0ccc4adf51fa Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Sun, 22 Jan 2023 04:22:03 +0100 Subject: [PATCH] Continued: - fixed some flaws found by NetBeans' inspector --- test/org/mxchange/jcontacts/ContactTestData.java | 4 ++-- .../jcontacts/model/contact/UserContactObjectTest.java | 4 ++-- test/org/mxchange/jcontacts/model/utils/ContactUtilsTest.java | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/org/mxchange/jcontacts/ContactTestData.java b/test/org/mxchange/jcontacts/ContactTestData.java index 05cff2f..5bd0ffe 100644 --- a/test/org/mxchange/jcontacts/ContactTestData.java +++ b/test/org/mxchange/jcontacts/ContactTestData.java @@ -80,9 +80,9 @@ public class ContactTestData { public static final String CONTACT_TITLE2 = "PHD"; //NOI18N - public static final Integer CONTACT_ZIP_CODE1 = 12345; + public static final Integer CONTACT_ZIP_CODE1 = 12_345; - public static final Integer CONTACT_ZIP_CODE2 = 67890; + public static final Integer CONTACT_ZIP_CODE2 = 67_890; static { // Fake ids diff --git a/test/org/mxchange/jcontacts/model/contact/UserContactObjectTest.java b/test/org/mxchange/jcontacts/model/contact/UserContactObjectTest.java index 56f4baa..803df74 100644 --- a/test/org/mxchange/jcontacts/model/contact/UserContactObjectTest.java +++ b/test/org/mxchange/jcontacts/model/contact/UserContactObjectTest.java @@ -426,7 +426,7 @@ public class UserContactObjectTest { ); // Should always be false - Assert.assertFalse(contact.equals(null)); + Assert.assertFalse(contact == null); } @Test (description = "Tests Contact.equals() with null and set primary key") @@ -590,7 +590,7 @@ public class UserContactObjectTest { ContactTestData.CONTACT_COUNTRY1, Boolean.FALSE, ContactTestData.CONTACT_STREET_NAME1, - Short.parseShort("-1"), //NOI18N + Short.valueOf("-1"), //NOI18N ContactTestData.CONTACT_HOUSE_NUMBER_EXTENSION1, ContactTestData.CONTACT_ZIP_CODE1, ContactTestData.CONTACT_CITY1, diff --git a/test/org/mxchange/jcontacts/model/utils/ContactUtilsTest.java b/test/org/mxchange/jcontacts/model/utils/ContactUtilsTest.java index 3ed874d..4bcb947 100644 --- a/test/org/mxchange/jcontacts/model/utils/ContactUtilsTest.java +++ b/test/org/mxchange/jcontacts/model/utils/ContactUtilsTest.java @@ -327,7 +327,7 @@ public class ContactUtilsTest { ContactTestData.CONTACT_STREET_NAME1, ContactTestData.CONTACT_HOUSE_NUMBER1, ContactTestData.CONTACT_HOUSE_NUMBER_EXTENSION1, - 67890, + 67_890, ContactTestData.CONTACT_CITY1, ContactTestData.CONTACT_EMAIL1, ContactTestData.CONTACT_TITLE1, -- 2.39.5