From f5722a465f351f3eb6f2605972060e7688fb9855 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Tue, 14 Apr 2020 21:49:46 +0200 Subject: [PATCH] Continued: - renamed allSomeEntities() to fetchAllSomeEntities() - maybe removed deprecated or not recommended business methods - if a method fetches e.g. a limited list of "Bar" entities, limited by an entity "Foo" it must be named "fetchAllBarsByFoo()" MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Roland Häder --- .../model/user/UserSessionBeanRemote.java | 75 +------------------ .../UserEmailChangeSessionBeanRemote.java | 17 +---- .../UserPasswordHistorySessionBeanRemote.java | 2 +- 3 files changed, 6 insertions(+), 88 deletions(-) diff --git a/src/org/mxchange/jusercore/model/user/UserSessionBeanRemote.java b/src/org/mxchange/jusercore/model/user/UserSessionBeanRemote.java index 1c8e99f..7466736 100644 --- a/src/org/mxchange/jusercore/model/user/UserSessionBeanRemote.java +++ b/src/org/mxchange/jusercore/model/user/UserSessionBeanRemote.java @@ -62,16 +62,6 @@ public interface UserSessionBeanRemote extends Serializable { */ User confirmAccount (final User user, final String baseUrl) throws UserStatusConfirmedException, UserStatusLockedException; - /** - * Generates random user name that is available. - *

- * @return Generated user name - *

- * @deprecated Please fetch whole user list and cache it in your application - */ - @Deprecated - String generateRandomUserName (); - /** * Updates entity from given user instance and returns updated instance. *

@@ -87,70 +77,7 @@ public interface UserSessionBeanRemote extends Serializable { *

* @return A list of all users */ - List allUsers (); - - /** - * Fills given user instance with all available data - *

- * @param user Initial User instance - *

- * @return Prepared User instance - *

- * @throws UserNotFoundException If the user was not found - * @deprecated Don't use this anymore - */ - @Deprecated - User fillUserData (final User user) throws UserNotFoundException; - - /** - * Some "getter" for a full user name list - *

- * @return User name list - *

- * @deprecated Please fetch whole user list and extract all user names - * instead - */ - @Deprecated - List allUserNames (); - - /** - * Checks if given user name is already used - *

- * @param userName User name to check - *

- * @return Whether given user name is found - */ - boolean ifUserNameExists (final String userName); - - /** - * Checks if given user exists - *

- * @param user User to check - *

- * @return Whether the user exists - *

- * @deprecated Please use your application's JCache instead - */ - @Deprecated - boolean ifUserExists (final User user); - - /** - * Checks if the the given user's name is already registered - *

- * @param user User instance - *

- * @return Whether the user is already registered - */ - boolean isUserNameRegistered (final User user); - - /** - * Checks if the the given user's email address is already registered - *

- * @param user User instance - *

- * @return Whether the user is already registered - */ - boolean isEmailAddressRegistered (final User user); + List fetchAllUsers (); /** * Updates given user instance in database diff --git a/src/org/mxchange/jusercore/model/user/email_address/UserEmailChangeSessionBeanRemote.java b/src/org/mxchange/jusercore/model/user/email_address/UserEmailChangeSessionBeanRemote.java index 36065ff..9e47541 100644 --- a/src/org/mxchange/jusercore/model/user/email_address/UserEmailChangeSessionBeanRemote.java +++ b/src/org/mxchange/jusercore/model/user/email_address/UserEmailChangeSessionBeanRemote.java @@ -30,26 +30,17 @@ import org.mxchange.jusercore.model.email_address.ChangeableEmailAddress; public interface UserEmailChangeSessionBeanRemote extends Serializable { /** - * Checks whether given email address is already enqueued + * Returns a list of all queued email address changes. *

- * @param emailAddress Email address to check - *

- * @return Whether the email address has already been enqueued - */ - boolean isEmailAddressEnqueued (final String emailAddress); - - /** - * Returns a list of all queued email addresses, not limited to a user - *

- * @return A list of all queued email addresses + * @return A list of all queued email address changes */ - List allQueuedAddresses (); + List fetchAllQueuedAddressChanges (); /** * "Enqueues" given email change object *

* @param emailChange Email change instance to insert - * @param baseUrl Base URL + * @param baseUrl Base URL */ void enqueueEmailAddressForChange (final ChangeableEmailAddress emailChange, final String baseUrl); diff --git a/src/org/mxchange/jusercore/model/user/password_history/UserPasswordHistorySessionBeanRemote.java b/src/org/mxchange/jusercore/model/user/password_history/UserPasswordHistorySessionBeanRemote.java index 8e51071..b790ae9 100644 --- a/src/org/mxchange/jusercore/model/user/password_history/UserPasswordHistorySessionBeanRemote.java +++ b/src/org/mxchange/jusercore/model/user/password_history/UserPasswordHistorySessionBeanRemote.java @@ -39,6 +39,6 @@ public interface UserPasswordHistorySessionBeanRemote extends Serializable { *

* @return List of all user's password history */ - List getUserPasswordHistory (final User user); + List fetchPasswordHistoryByUser (final User user); } -- 2.39.5