From 25a7f5c48d8e5f03ff7777757ec7e2420a5bdb09 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Tue, 17 May 2011 21:37:08 +0000 Subject: [PATCH] Now two methods should never be called, the UnsupportedOperationException will be thrown if you still do so. --- .../main/request/console/class_ConsoleRequest.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/inc/classes/main/request/console/class_ConsoleRequest.php b/inc/classes/main/request/console/class_ConsoleRequest.php index e1b2bd31..1402332e 100644 --- a/inc/classes/main/request/console/class_ConsoleRequest.php +++ b/inc/classes/main/request/console/class_ConsoleRequest.php @@ -52,7 +52,6 @@ class ConsoleRequest extends BaseRequest implements Requestable { * Prepares the request data for usage * * @return void - * @todo Needs to be implemented */ public function prepareRequestData () { // Get the "request data" from the command-line argument list @@ -91,9 +90,11 @@ class ConsoleRequest extends BaseRequest implements Requestable { * * @param $headerName Name of the header * @return $headerValue Value of the header or 'null' if not found + * @throws UnsupportedOperationException This method should never be called */ public function getHeader ($headerName) { - $this->partialStub('Please implement this method.'); + // Console doesn't have any headers + throw new UnsupportedOperationException(array($this, __FUNCTION__, $executorInstance), self::EXCEPTION_UNSPPORTED_OPERATION); } /** @@ -102,6 +103,7 @@ class ConsoleRequest extends BaseRequest implements Requestable { * @return $requestMethod Used request method */ public final function getRequestMethod () { + // @TODO Can't this be 'CONSOLE' ? return 'LOCAL'; } @@ -110,10 +112,11 @@ class ConsoleRequest extends BaseRequest implements Requestable { * * @param $cookieName Name of cookie we shall read * @return $cookieValue Value of cookie or null if not found + * @throws UnsupportedOperationException This method should never be called */ public final function readCookie ($cookieName) { - // @TODO There are no cookies on console - return null; + // There are no cookies on console + throw new UnsupportedOperationException(array($this, __FUNCTION__, $executorInstance), self::EXCEPTION_UNSPPORTED_OPERATION); } } -- 2.30.2