From 85a7e4f5a319ab346a7d09fc1ed031df554399e3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Wed, 7 Sep 2022 16:07:37 +0200 Subject: [PATCH] Continued: - removed deprecated files - updated TODOs.txt --- application/tests/init.php | 2 - docs/TODOs.txt | 245 +++++++++--------- ...ass_AlreadyInitializedStackerException.php | 2 - .../api/wernisportal/class_WernisApi.php | 2 - 4 files changed, 123 insertions(+), 128 deletions(-) delete mode 100644 application/tests/init.php delete mode 100644 framework/main/exceptions/stacker/class_AlreadyInitializedStackerException.php delete mode 100644 framework/main/third_party/api/wernisportal/class_WernisApi.php diff --git a/application/tests/init.php b/application/tests/init.php deleted file mode 100644 index 7d6dceec..00000000 --- a/application/tests/init.php +++ /dev/null @@ -1,2 +0,0 @@ -debugOutput('[' . __METHOD__ . ':' . __LINE__ . '] fieldName=' . $fieldName . ' is not set! - @TODO'); -./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:116: * @todo Add some unique PIN here to bypass problems with some browser and/or extensions -./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:629: * @todo Add checking if sub option is already added -./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:657: * @todo Add checking if sub option is already added -./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:691: // @TODO We need to log this later -./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:860: * @todo Implement check if rules have been changed -./framework/main/classes/helper/html/links/class_HtmlLinkHelper.php:195: * @todo Completely unimplemented -./framework/main/classes/images/class_BaseImage.php:179: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:189: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:199: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:209: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:219: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:238: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:257: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:268: * @todo Find something usefull for this method. -./framework/main/classes/images/class_BaseImage.php:278: * @todo Find something usefull for this method. -./framework/main/classes/images/extended/class_PngImage.php:69: * @todo Rewrite this to SplFileInfo/Object -./framework/main/classes/index/class_BaseIndex.php:160: * @todo Currently the index file is not cached, please implement a memory-handling class and if enough RAM is found, cache the whole index file. -./framework/main/classes/language/class_LanguageSystem.php:73: * @throws InvalidArgumentException If languageBasePath remains empty (@TODO Get rid of that old-lost code) +./framework/main/classes/handler/tasks/class_TaskHandler.php:163: // @TODO Messurement can be added around this call +./framework/main/classes/helper/class_BaseHelper.php:194: * @todo Rewrite this method using a helper class for filtering data +./framework/main/classes/helper/class_BaseHelper.php:229: // @TODO Try to log it here +./framework/main/classes/helper/class_BaseHelper.php:501: $this->debugOutput('BASE-HELPER: fieldName=' . $fieldName . ' is not set! - @TODO'); +./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:122: * @todo Add some unique PIN here to bypass problems with some browser and/or extensions +./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:637: * @todo Add checking if sub option is already added +./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:665: * @todo Add checking if sub option is already added +./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:699: // @TODO We need to log this later +./framework/main/classes/helper/html/forms/class_HtmlFormHelper.php:887: * @todo Implement check if rules have been changed +./framework/main/classes/helper/html/links/class_HtmlLinkHelper.php:198: * @todo Completely unimplemented +./framework/main/classes/images/class_BaseImage.php:183: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:193: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:203: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:213: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:223: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:242: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:261: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:272: * @todo Find something usefull for this method. +./framework/main/classes/images/class_BaseImage.php:282: * @todo Find something usefull for this method. +./framework/main/classes/images/png/class_PngImage.php:69: * @todo Rewrite this to SplFileInfo/Object +./framework/main/classes/index/file/class_BaseFileIndex.php:179: * @todo Currently the index file is not cached, please implement a memory-handling class and if enough RAM is found, cache the whole index file. +./framework/main/classes/index/file/class_BaseFileIndex.php:287: * @todo Unfinished work +./framework/main/classes/language/class_LanguageSystem.php:76: * @throws InvalidArgumentException If languageBasePath remains empty (@TODO Get rid of that old-lost code) ./framework/main/classes/lists/groups/class_ListGroupList.php:68: * @todo 0% done ./framework/main/classes/mailer/debug/class_DebugMailer.php:137: * @todo 0% done -./framework/main/classes/menu/class_BaseMenu.php:76: // Log exception @TODO Maybe to intrusive? -./framework/main/classes/output/console/class_ConsoleOutput.php:65: // @TODO Need to rewrite this to $requestInstance->addHeader() -./framework/main/classes/parser/xml/class_XmlParser.php:87: // @TODO We need to find a fallback solution here -./framework/main/classes/points/class_UserPoints.php:112: * @todo Finish loading part of points -./framework/main/classes/points/class_UserPoints.php:184: * @todo $requestInstance is currently unused +./framework/main/classes/menu/class_BaseMenu.php:80: // Log exception @TODO Maybe to intrusive? +./framework/main/classes/output/console/class_ConsoleOutput.php:64: // @TODO Need to rewrite this to $requestInstance->addHeader() +./framework/main/classes/parser/xml/class_XmlParser.php:82: // @TODO We need to find a fallback solution here +./framework/main/classes/points/class_UserPoints.php:118: * @todo Finish loading part of points +./framework/main/classes/points/class_UserPoints.php:189: * @todo $requestInstance is currently unused +./framework/main/classes/registry/format_upgrade/database/class_LocalFileDatabaseFormatUpgradeRegistry.php:70: * @todo 0% done ./framework/main/classes/request/console/class_ConsoleRequest.php:119: // @TODO Can't this be 'CONSOLE' ? -./framework/main/classes/request/html/class_HtmlRequest.php:16: * @todo Move out the cookie part to a seperate class, e.g. Cookie -./framework/main/classes/response/html/class_HtmlResponse.php:80: * @todo Encryption of cookie data not yet supported. -./framework/main/classes/response/html/class_HtmlResponse.php:81: * @todo Why are these parameters conflicting? -./framework/main/classes/response/html/class_HtmlResponse.php:82: * @todo If the return statement is removed and setcookie() commented out, -./framework/main/classes/response/html/class_HtmlResponse.php:83: * @todo this will send only one cookie out, the first one. -./framework/main/classes/response/image/class_ImageResponse.php:76: // @TODO Please fix this -./framework/main/classes/response/image/class_ImageResponse.php:92: * @todo Encryption of cookie data not yet supported. -./framework/main/classes/response/image/class_ImageResponse.php:93: * @todo Why are these parameters conflicting? -./framework/main/classes/response/image/class_ImageResponse.php:94: * @todo If the return statement is removed and setcookie() commented out, -./framework/main/classes/response/image/class_ImageResponse.php:95: * @todo this will send only one cookie out, the first one. +./framework/main/classes/request/html/class_HtmlRequest.php:17: * @todo Move out the cookie part to a seperate class, e.g. Cookie +./framework/main/classes/resolver/command/html/class_HtmlCommandResolver.php:71: // @TODO Missing namespace! +./framework/main/classes/resolver/command/image/class_ImageCommandResolver.php:70: // @TODO Missing namespace! +./framework/main/classes/response/html/class_HtmlResponse.php:73: * @todo Encryption of cookie data not yet supported. +./framework/main/classes/response/html/class_HtmlResponse.php:74: * @todo If the return statement is removed and setcookie() commented out, +./framework/main/classes/response/html/class_HtmlResponse.php:75: * @todo this will send only one cookie out, the first one. +./framework/main/classes/response/image/class_ImageResponse.php:100: * @todo this will send only one cookie out, the first one. +./framework/main/classes/response/image/class_ImageResponse.php:98: * @todo Encryption of cookie data not yet supported. +./framework/main/classes/response/image/class_ImageResponse.php:99: * @todo If the return statement is removed and setcookie() commented out, ./framework/main/classes/rng/class_RandomNumberGenerator.php:105: * @todo Add site key for stronger salt! ./framework/main/classes/rng/class_RandomNumberGenerator.php:183: * @todo I had a better random number generator here but now it is somewhere lost :( -./framework/main/classes/stacker/file/class_BaseFileStack.php:172: * @todo Currently the stack file is not cached, please implement a memory-handling class and if enough RAM is found, cache the whole stack file. -./framework/main/classes/stacker/file/class_BaseFileStack.php:347: // @TODO Please implement this, returning false -./framework/main/classes/stacker/file/class_BaseFileStack.php:70: * @todo To hard assertions here, better rewrite them to exceptions -./framework/main/classes/streams/crypto/class_McryptStream.php:18: * @todo mcrypt will become deprecated, rewrite to OpenSSL -./framework/main/classes/streams/crypto/class_OpenSslStream.php:138: // @TODO unfinished -./framework/main/classes/streams/crypto/class_OpenSslStream.php:68: // @TODO unfinished -./framework/main/classes/template/class_BaseTemplateEngine.php:1070: // @TODO This silent abort should be logged, maybe. -./framework/main/classes/template/class_BaseTemplateEngine.php:1078: // @TODO Old behaviour, will become obsolete! -./framework/main/classes/template/class_BaseTemplateEngine.php:1081: // @TODO Yet another old way -./framework/main/classes/template/class_BaseTemplateEngine.php:1304: * @todo Make this code some nicer... -./framework/main/classes/template/class_BaseTemplateEngine.php:967: * @todo Unfinished work or don't die here. -./framework/main/classes/template/class_BaseTemplateEngine.php:992: // @TODO Non-string found so we need some deeper analysis... -./framework/main/classes/template/console/class_ConsoleTemplateEngine.php:22: * @todo This template engine does not make use of setTemplateType() -./framework/main/classes/template/image/class_ImageTemplateEngine.php:233: * @todo Find something usefull with this! -./framework/main/classes/template/image/class_ImageTemplateEngine.php:253: * @todo Add cache creation here +./framework/main/classes/stacker/file/class_BaseFileStack.php:222: * @todo Currently the stack file is not cached, please implement a memory-handling class and if enough RAM is found, cache the whole stack file. +./framework/main/classes/stacker/file/class_BaseFileStack.php:464: // @TODO Please implement this, returning false +./framework/main/classes/stacker/file/class_BaseFileStack.php:72: * @todo To hard assertions here, better rewrite them to exceptions +./framework/main/classes/stacker/file/fifo/class_FiFoFileStack.php:176: // @TODO Unfinished method or invoke inner iterator's method? +./framework/main/classes/streams/crypto/mcrypt/class_McryptStream.php:19: * @todo mcrypt will become deprecated, rewrite to OpenSSL +./framework/main/classes/streams/crypto/openssl/class_OpenSslStream.php:139: // @TODO unfinished +./framework/main/classes/streams/crypto/openssl/class_OpenSslStream.php:69: // @TODO unfinished +./framework/main/classes/template/class_BaseTemplateEngine.php:1065: // @TODO This silent abort should be logged, maybe. +./framework/main/classes/template/class_BaseTemplateEngine.php:1073: // @TODO Old behaviour, will become obsolete! +./framework/main/classes/template/class_BaseTemplateEngine.php:1076: // @TODO Yet another old way +./framework/main/classes/template/class_BaseTemplateEngine.php:1300: * @todo Make this code some nicer... +./framework/main/classes/template/class_BaseTemplateEngine.php:962: * @todo Unfinished work or don't die here. +./framework/main/classes/template/class_BaseTemplateEngine.php:987: // @TODO Non-string found so we need some deeper analysis... +./framework/main/classes/template/console/class_ConsoleTemplateEngine.php:24: * @todo This template engine does not make use of setTemplateType() +./framework/main/classes/template/image/class_ImageTemplateEngine.php:255: * @todo Find something usefull with this! +./framework/main/classes/template/image/class_ImageTemplateEngine.php:275: * @todo Add cache creation here +./framework/main/classes/template/image/class_ImageTemplateEngine.php:522: * @todo Nothing to really "transfer" here? ./framework/main/classes/template/mail/class_MailTemplateEngine.php:245: * @todo Add cache creation here ./framework/main/classes/template/mail/class_MailTemplateEngine.php:255: * @todo Should we call back the mailer class here? -./framework/main/classes/template/mail/class_MailTemplateEngine.php:25: * @todo This template engine does not make use of setTemplateType() -./framework/main/classes/template/menu/class_MenuTemplateEngine.php:321: * @todo Find something useful with this! -./framework/main/classes/template/menu/class_MenuTemplateEngine.php:367: * @todo Add cache creation here -./framework/main/classes/tools/console/class_ConsoleTools.php:179: * @todo This should be connected to a caching class to cache DNS requests -./framework/main/classes/tools/console/class_ConsoleTools.php:207: // @TODO Here should the cacher be implemented -./framework/main/classes/tools/console/class_ConsoleTools.php:308: * @todo This should be moved out to an external class, e.g. HttpClient -./framework/main/classes/tools/console/class_ConsoleTools.php:309: * @todo Make IP, host name, port and script name configurable -./framework/main/classes/tools/console/class_ConsoleTools.php:316: // @TODO Add some DNS caching here -./framework/main/classes/user/class_BaseUser.php:320: * @todo Try to make this method more generic so we can move it in BaseFrameworkSystem -./framework/main/classes/user/class_BaseUser.php:92: * @todo Find a way of casting here. "(int)" might destroy the user id > 32766 -./framework/main/classes/user/guest/class_Guest.php:55: * @todo Add more ways over creating user classes -./framework/main/classes/user/member/class_Member.php:98: * @todo Add more ways over creating user classes +./framework/main/classes/template/mail/class_MailTemplateEngine.php:28: * @todo This template engine does not make use of setTemplateType() +./framework/main/classes/template/menu/class_MenuTemplateEngine.php:342: * @todo Find something useful with this! +./framework/main/classes/template/menu/class_MenuTemplateEngine.php:388: * @todo Add cache creation here +./framework/main/classes/template/xml/class_BaseXmlTemplateEngine.php:29: * @todo This template engine does not make use of setTemplateType() +./framework/main/classes/tools/console/class_ConsoleTools.php:211: * @todo This should be connected to a caching class to cache DNS requests +./framework/main/classes/tools/console/class_ConsoleTools.php:242: // @TODO Here should the cacher be implemented +./framework/main/classes/tools/console/class_ConsoleTools.php:343: * @todo This should be moved out to an external class, e.g. HttpClient +./framework/main/classes/tools/console/class_ConsoleTools.php:344: * @todo Make IP, host name, port and script name configurable +./framework/main/classes/tools/console/class_ConsoleTools.php:351: // @TODO Add some DNS caching here +./framework/main/classes/user/class_BaseUser.php:325: * @todo Try to make this method more generic so we can move it in BaseFrameworkSystem +./framework/main/classes/user/class_BaseUser.php:97: * @todo Find a way of casting here. "(int)" might destroy the user id > 32766 +./framework/main/classes/user/guest/class_Guest.php:56: * @todo Add more ways over creating user classes +./framework/main/classes/user/member/class_Member.php:100: * @todo Add more ways over creating user classes +./framework/main/classes/utils/strings/class_StringUtils.php:395: * @todo Improve documentation ./framework/main/exceptions/compressor/class_MismatchingCompressorsException.php:16: * @todo Rename to CompressorMismatchException ./framework/main/exceptions/config/class_ConfigValueTypeUnsupportedException.php:18: * @todo These are invalid argument exceptions ./framework/main/exceptions/config/class_NoConfigEntryException.php:16: * @todo Rename this class to NoFoundEntryException -./framework/main/exceptions/language/class_LanguagePathIsNoDirectoryException.php:16: * @todo Don't use this anymore ./framework/main/exceptions/socket/class_NoSocketErrorDetectedException.php:15: * @todo Those are logic exceptions and should be rewritten ./framework/main/exceptions/user/class_UserNoGuestException.php:17: * @todo Better rename this -./framework/main/interfaces/application/class_ManageableApplication.php:79: * @todo Nothing to add? +./framework/main/interfaces/application/class_ManageableApplication.php:124: * @todo Nothing to add? ./framework/main/interfaces/class_FrameworkInterface.php:14: * @todo Find a better name for this interface -./framework/main/interfaces/criteria/extended/class_LocalSearchCriteria.php:36: * @todo Find a nice casting here. (int) allows until and including 32766. -./framework/main/interfaces/criteria/extended/class_LocalSearchCriteria.php:60: * @todo Find a nice casting here. (int) allows until and including 32766. +./framework/main/interfaces/criteria/search/class_LocalSearchCriteria.php:36: * @todo Find a nice casting here. (int) allows until and including 32766. +./framework/main/interfaces/criteria/search/class_LocalSearchCriteria.php:60: * @todo Find a nice casting here. (int) allows until and including 32766. ./framework/main/interfaces/database/backend/class_DatabaseBackend.php:117: * @todo Add more generic non-data for removal ./framework/main/interfaces/database/backend/class_DatabaseBackend.php:69: * @todo Do some checks on the database directory and files here ./framework/main/interfaces/handler/task/class_HandleableTask.php:18: * @todo HandleableDataSet looks strange here +./framework/main/interfaces/stacker/file/class_StackableFile.php:70: * @todo To hard assertions here, better rewrite them to exceptions ./framework/main/interfaces/visitor/decorator/class_DecoratorVisitor.php:37: * @todo Find interface for this type-hint (only interface/array as type-hints rule) -./framework/main/middleware/compressor/class_CompressorChannel.php:121: // @TODO Is there a configurable fall-back compressor needed, or is NullCompressor okay? -./framework/main/middleware/database/class_DatabaseConnection.php:70: * @todo $debugInstance is currently not used -./framework/main/middleware/debug/class_DebugMiddleware.php:125: // @TODO Initialization phase -./framework/main/middleware/io/class_FileIoHandler.php:189: * @todo 0% done -./framework/main/tests/filter/tests/configuration/classes/class_TestConfigurationLoadableClassesFilter.php:66: * @todo 0% done +./framework/main/middleware/compressor/class_CompressorChannel.php:122: // @TODO Is there a configurable fall-back compressor needed, or is NullCompressor okay? +./framework/main/middleware/database/class_DatabaseConnection.php:73: * @todo $debugInstance is currently not used +./framework/main/middleware/debug/class_DebugMiddleware.php:119: // @TODO Initialization phase +./framework/main/middleware/io/class_FileIoHandler.php:146: * @todo 0% done +./framework/main/middleware/io/class_FileIoHandler.php:176: * @todo 0% done +./framework/main/tests/filter/tests/configuration/classes/class_TestConfigurationLoadableClassesFilter.php:67: * @todo 0% done ./framework/main/tests/filter/tests/requirements/class_TestsPhpRequirementsFilter.php:63: * @todo 0% done -./framework/main/third_party/api/wernisportal/class_WernisApi.php:16: * @todo Out-dated since 0.6-BETA -./index.php:58: * @todo This method is old code and needs heavy rewrite and should be moved to ApplicationHelper +./framework/main/traits/manager/account/class_ManageableAccountTrait.php:33: * @todo Rename to $accountInstance ? +./framework/main/traits/result/search/class_SearchableResultTrait.php:41: * @todo SearchableResult and UpdateableResult shall have a super interface to use here +./index.php:59: * @todo This method is old code and needs heavy rewrite and should be moved to ApplicationHelper ### ### DEPRECATION FOLLOWS: ### ### -./framework/main/classes/class_BaseFrameworkSystem.php:1846: * @deprecated Not fully, as the new Logger facilities are not finished yet. +./framework/main/classes/class_BaseFrameworkSystem.php:603: * @deprecated Not fully, as the new Logger facilities are not finished yet. ./framework/main/exceptions/base64/class_Base64EncodingBadException.php:17: * @deprecated Don't use this anymore ./framework/main/exceptions/base64/class_Base64EncodingModuloException.php:16: * @deprecated Don't use this anymore -./framework/main/exceptions/crypto/class_EncryptInvalidLengthException.php:17: * @deprecated Don't use this anymore +./framework/main/exceptions/crypto/class_EncryptInvalidLengthException.php:18: * @deprecated Don't use this anymore ./framework/main/exceptions/crypto/class_EncryptMissingException.php:17: * @deprecated Don't use this anymore ./framework/main/exceptions/database/local_file/class_SavePathIsNoDirectoryException.php:16: * @deprecated Don't use this ./framework/main/exceptions/database/local_file/class_SavePathReadProtectedException.php:16: * @deprecated Please don't use this @@ -176,15 +183,9 @@ ./framework/main/exceptions/helper/class_InvalidFormNameException.php:17: * @deprecated Don't use this anymore ./framework/main/exceptions/helper/class_NoGroupOpenedException.php:16: * @deprecated Don't use this anymore ./framework/main/exceptions/helper/class_UserInstanceMissingException.php:16: * @deprecated Don't use this anymore -./framework/main/exceptions/language/class_InvalidLanguagePathStringException.php:16: * @deprecated Don't use this anymore -./framework/main/exceptions/language/class_LanguagePathReadProtectedException.php:16: * @deprecated Don't use this anymore ./framework/main/exceptions/main/class_DimNotFoundInArrayException.php:17: * @deprecated Please don't use this anymore ./framework/main/exceptions/main/class_InvalidArrayCountException.php:16: * @deprecated Don't use this anymore -./framework/main/exceptions/main/class_InvalidClassNameException.php:17: * @deprecated Don't use this anymore -./framework/main/exceptions/main/class_InvalidObjectException.php:17: * @deprecated Don't use this anymore -./framework/main/exceptions/main/class_MissingDecimalsThousandsSeparatorException.php:16: * @deprecated Don't use this anymore ./framework/main/exceptions/main/class_VariableIsNotSetException.php:16: * @deprecated Don't use this anymore -./framework/main/exceptions/stacker/class_EmptyStackerException.php:16: * @deprecated Don't use this anymore ./framework/main/exceptions/template/class_BasePathReadProtectedException.php:16: * @deprecated Don't use this anymore ./framework/main/exceptions/template/class_NoVariableException.php:16: * @deprecated Don't use this anymore ./framework/main/exceptions/template/class_UnexpectedTemplateTypeException.php:16: * @deprecated Don't use this anymore diff --git a/framework/main/exceptions/stacker/class_AlreadyInitializedStackerException.php b/framework/main/exceptions/stacker/class_AlreadyInitializedStackerException.php deleted file mode 100644 index 7d6dceec..00000000 --- a/framework/main/exceptions/stacker/class_AlreadyInitializedStackerException.php +++ /dev/null @@ -1,2 +0,0 @@ -