]> git.mxchange.org Git - friendica-addons.git/blobdiff - statusnet/statusnet.php
Merge branch '3.6-rc'
[friendica-addons.git] / statusnet / statusnet.php
index c54ff55f6c923ce65d4b4e3051bf2d770144884c..16f68a8aa1f5b36f5cf190ebdcddb4b8278b9896 100644 (file)
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * Name: GNU Social Connector
  * Description: Bidirectional (posting, relaying and reading) connector for GNU Social.
@@ -56,8 +55,7 @@ use Friendica\Model\User;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
 
-function statusnet_install()
-{
+function statusnet_install() {
        //  we need some hooks, for the configuration and for sending tweets
        Addon::registerHook('connector_settings', 'addon/statusnet/statusnet.php', 'statusnet_settings');
        Addon::registerHook('connector_settings_post', 'addon/statusnet/statusnet.php', 'statusnet_settings_post');
@@ -87,52 +85,46 @@ function statusnet_uninstall()
        Addon::unregisterHook('addon_settings_post', 'addon/statusnet/statusnet.php', 'statusnet_settings_post');
 }
 
-function statusnet_check_item_notification(App $a, &$notification_data)
-{
-       $notification_data["profiles"][] = PConfig::get($notification_data["uid"], 'statusnet', 'own_url');
+function statusnet_check_item_notification($a, &$notification_data) {
+       $notification_data["profiles"][] = get_pconfig($notification_data["uid"], 'statusnet', 'own_url');
 }
 
-function statusnet_jot_nets(App $a, &$b)
-{
-       if (!local_user()) {
+function statusnet_jot_nets(&$a,&$b) {
+       if(! local_user())
                return;
-       }
 
-       $statusnet_post = PConfig::get(local_user(), 'statusnet', 'post');
-       if (intval($statusnet_post) == 1) {
-               $statusnet_defpost = PConfig::get(local_user(), 'statusnet', 'post_by_default');
+       $statusnet_post = get_pconfig(local_user(),'statusnet','post');
+       if(intval($statusnet_post) == 1) {
+               $statusnet_defpost = get_pconfig(local_user(),'statusnet','post_by_default');
                $selected = ((intval($statusnet_defpost) == 1) ? ' checked="checked" ' : '');
                $b .= '<div class="profile-jot-net"><input type="checkbox" name="statusnet_enable"' . $selected . ' value="1" /> '
                        . L10n::t('Post to GNU Social') . '</div>';
        }
 }
 
-function statusnet_settings_post(App $a, $post)
-{
-       if (!local_user()) {
+function statusnet_settings_post ($a,$post) {
+       if(! local_user())
                return;
-       }
        // don't check GNU Social settings if GNU Social submit button is not clicked
-       if (!x($_POST, 'statusnet-submit')) {
+       if (!x($_POST,'statusnet-submit'))
                return;
-       }
 
        if (isset($_POST['statusnet-disconnect'])) {
-               /*               * *
+               /***
                 * if the GNU Social-disconnect checkbox is set, clear the GNU Social configuration
                 */
-               PConfig::delete(local_user(), 'statusnet', 'consumerkey');
-               PConfig::delete(local_user(), 'statusnet', 'consumersecret');
-               PConfig::delete(local_user(), 'statusnet', 'post');
-               PConfig::delete(local_user(), 'statusnet', 'post_by_default');
-               PConfig::delete(local_user(), 'statusnet', 'oauthtoken');
-               PConfig::delete(local_user(), 'statusnet', 'oauthsecret');
-               PConfig::delete(local_user(), 'statusnet', 'baseapi');
-               PConfig::delete(local_user(), 'statusnet', 'lastid');
-               PConfig::delete(local_user(), 'statusnet', 'mirror_posts');
-               PConfig::delete(local_user(), 'statusnet', 'import');
-               PConfig::delete(local_user(), 'statusnet', 'create_user');
-               PConfig::delete(local_user(), 'statusnet', 'own_id');
+               del_pconfig(local_user(), 'statusnet', 'consumerkey');
+               del_pconfig(local_user(), 'statusnet', 'consumersecret');
+               del_pconfig(local_user(), 'statusnet', 'post');
+               del_pconfig(local_user(), 'statusnet', 'post_by_default');
+               del_pconfig(local_user(), 'statusnet', 'oauthtoken');
+               del_pconfig(local_user(), 'statusnet', 'oauthsecret');
+               del_pconfig(local_user(), 'statusnet', 'baseapi');
+               del_pconfig(local_user(), 'statusnet', 'lastid');
+               del_pconfig(local_user(), 'statusnet', 'mirror_posts');
+               del_pconfig(local_user(), 'statusnet', 'import');
+               del_pconfig(local_user(), 'statusnet', 'create_user');
+               del_pconfig(local_user(), 'statusnet', 'own_id');
        } else {
                if (isset($_POST['statusnet-preconf-apiurl'])) {
                        /*                       * *
@@ -164,11 +156,10 @@ function statusnet_settings_post(App $a, $post)
                                $apibase = $_POST['statusnet-baseapi'];
                                $c = Network::fetchUrl($apibase . 'statusnet/version.xml');
                                if (strlen($c) > 0) {
-                                       //  ok the API path is correct, let's save the settings
-                                       PConfig::set(local_user(), 'statusnet', 'consumerkey', $_POST['statusnet-consumerkey']);
-                                       PConfig::set(local_user(), 'statusnet', 'consumersecret', $_POST['statusnet-consumersecret']);
-                                       PConfig::set(local_user(), 'statusnet', 'baseapi', $apibase);
-                                       //PConfig::set(local_user(), 'statusnet', 'application_name', $_POST['statusnet-applicationname'] );
+                                       set_pconfig(local_user(), 'statusnet', 'consumerkey', $asn['consumerkey'] );
+                                       set_pconfig(local_user(), 'statusnet', 'consumersecret', $asn['consumersecret'] );
+                                       set_pconfig(local_user(), 'statusnet', 'baseapi', $asn['apiurl'] );
+                                       //set_pconfig(local_user(), 'statusnet', 'application_name', $asn['applicationname'] );
                                } else {
                                        //  the API path is not correct, maybe missing trailing / ?
                                        $apibase = $apibase . '/';
@@ -183,7 +174,31 @@ function statusnet_settings_post(App $a, $post)
                                                notice(L10n::t('We could not contact the GNU Social API with the Path you entered.') . EOL);
                                        }
                                }
-                               goaway('settings/connectors');
+                       }
+               }
+               goaway($a->get_baseurl().'/settings/connectors');
+       } else {
+       if (isset($_POST['statusnet-consumersecret'])) {
+               //  check if we can reach the API of the GNU Social server
+               //  we'll check the API Version for that, if we don't get one we'll try to fix the path but will
+               //  resign quickly after this one try to fix the path ;-)
+               $apibase = $_POST['statusnet-baseapi'];
+               $c = fetch_url( $apibase . 'statusnet/version.xml' );
+               if (strlen($c) > 0) {
+                       //  ok the API path is correct, let's save the settings
+                       set_pconfig(local_user(), 'statusnet', 'consumerkey', $_POST['statusnet-consumerkey']);
+                       set_pconfig(local_user(), 'statusnet', 'consumersecret', $_POST['statusnet-consumersecret']);
+                       set_pconfig(local_user(), 'statusnet', 'baseapi', $apibase );
+                       //set_pconfig(local_user(), 'statusnet', 'application_name', $_POST['statusnet-applicationname'] );
+               } else {
+                       //  the API path is not correct, maybe missing trailing / ?
+                       $apibase = $apibase . '/';
+                       $c = fetch_url( $apibase . 'statusnet/version.xml' );
+                       if (strlen($c) > 0) {
+                               //  ok the API path is now correct, let's save the settings
+                               set_pconfig(local_user(), 'statusnet', 'consumerkey', $_POST['statusnet-consumerkey']);
+                               set_pconfig(local_user(), 'statusnet', 'consumersecret', $_POST['statusnet-consumersecret']);
+                               set_pconfig(local_user(), 'statusnet', 'baseapi', $apibase );
                        } else {
                                if (isset($_POST['statusnet-pin'])) {
                                        //  if the user supplied us with a PIN from GNU Social, let the magic of OAuth happen
@@ -218,38 +233,67 @@ function statusnet_settings_post(App $a, $post)
                                }
                        }
                }
-       }
+               goaway($a->get_baseurl().'/settings/connectors');
+       } else {
+       if (isset($_POST['statusnet-pin'])) {
+               //  if the user supplied us with a PIN from GNU Social, let the magic of OAuth happen
+               $api     = get_pconfig(local_user(), 'statusnet', 'baseapi');
+               $ckey    = get_pconfig(local_user(), 'statusnet', 'consumerkey'  );
+               $csecret = get_pconfig(local_user(), 'statusnet', 'consumersecret' );
+               //  the token and secret for which the PIN was generated were hidden in the settings
+               //  form as token and token2, we need a new connection to GNU Social using these token
+               //  and secret to request a Access Token with the PIN
+               $connection = new StatusNetOAuth($api, $ckey, $csecret, $_POST['statusnet-token'], $_POST['statusnet-token2']);
+               $token   = $connection->getAccessToken( $_POST['statusnet-pin'] );
+               //  ok, now that we have the Access Token, save them in the user config
+               set_pconfig(local_user(),'statusnet', 'oauthtoken',  $token['oauth_token']);
+               set_pconfig(local_user(),'statusnet', 'oauthsecret', $token['oauth_token_secret']);
+               set_pconfig(local_user(),'statusnet', 'post', 1);
+               set_pconfig(local_user(),'statusnet', 'post_taglinks', 1);
+               //  reload the Addon Settings page, if we don't do it see Bug #42
+               goaway($a->get_baseurl().'/settings/connectors');
+       } else {
+               //  if no PIN is supplied in the POST variables, the user has changed the setting
+               //  to post a dent for every new __public__ posting to the wall
+               set_pconfig(local_user(),'statusnet','post',intval($_POST['statusnet-enable']));
+               set_pconfig(local_user(),'statusnet','post_by_default',intval($_POST['statusnet-default']));
+               set_pconfig(local_user(), 'statusnet', 'mirror_posts', intval($_POST['statusnet-mirror']));
+               set_pconfig(local_user(), 'statusnet', 'import', intval($_POST['statusnet-import']));
+               set_pconfig(local_user(), 'statusnet', 'create_user', intval($_POST['statusnet-create_user']));
+
+               if (!intval($_POST['statusnet-mirror']))
+                       del_pconfig(local_user(),'statusnet','lastid');
+
+               info( t('GNU Social settings updated.') . EOL);
+       }}}}
 }
-
-function statusnet_settings(App $a, &$s)
-{
-       if (!local_user()) {
+function statusnet_settings(&$a,&$s) {
+       if(! local_user())
                return;
-       }
        $a->page['htmlhead'] .= '<link rel="stylesheet"  type="text/css" href="' . $a->get_baseurl() . '/addon/statusnet/statusnet.css' . '" media="all" />' . "\r\n";
-       /*       * *
+       /***
         * 1) Check that we have a base api url and a consumer key & secret
         * 2) If no OAuthtoken & stuff is present, generate button to get some
         *    allow the user to cancel the connection process at this step
         * 3) Checkbox for "Send public notices (respect size limitation)
         */
-       $api     = PConfig::get(local_user(), 'statusnet', 'baseapi');
-       $ckey    = PConfig::get(local_user(), 'statusnet', 'consumerkey');
-       $csecret = PConfig::get(local_user(), 'statusnet', 'consumersecret');
-       $otoken  = PConfig::get(local_user(), 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get(local_user(), 'statusnet', 'oauthsecret');
-       $enabled = PConfig::get(local_user(), 'statusnet', 'post');
+       $api     = get_pconfig(local_user(), 'statusnet', 'baseapi');
+       $ckey    = get_pconfig(local_user(), 'statusnet', 'consumerkey');
+       $csecret = get_pconfig(local_user(), 'statusnet', 'consumersecret');
+       $otoken  = get_pconfig(local_user(), 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig(local_user(), 'statusnet', 'oauthsecret');
+       $enabled = get_pconfig(local_user(), 'statusnet', 'post');
        $checked = (($enabled) ? ' checked="checked" ' : '');
-       $defenabled = PConfig::get(local_user(), 'statusnet', 'post_by_default');
+       $defenabled = get_pconfig(local_user(),'statusnet','post_by_default');
        $defchecked = (($defenabled) ? ' checked="checked" ' : '');
-       $mirrorenabled = PConfig::get(local_user(), 'statusnet', 'mirror_posts');
+       $mirrorenabled = get_pconfig(local_user(),'statusnet','mirror_posts');
        $mirrorchecked = (($mirrorenabled) ? ' checked="checked" ' : '');
-       $import = PConfig::get(local_user(), 'statusnet', 'import');
-       $importselected = ["", "", ""];
+       $import = get_pconfig(local_user(),'statusnet','import');
+       $importselected = array("", "", "");
        $importselected[$import] = ' selected="selected"';
-       //$importenabled = PConfig::get(local_user(),'statusnet','import');
+       //$importenabled = get_pconfig(local_user(),'statusnet','import');
        //$importchecked = (($importenabled) ? ' checked="checked" ' : '');
-       $create_userenabled = PConfig::get(local_user(), 'statusnet', 'create_user');
+       $create_userenabled = get_pconfig(local_user(),'statusnet','create_user');
        $create_userchecked = (($create_userenabled) ? ' checked="checked" ' : '');
 
        $css = (($enabled) ? '' : '-disabled');
@@ -262,12 +306,12 @@ function statusnet_settings(App $a, &$s)
        $s .= '<img class="connector' . $css . '" src="images/gnusocial.png" /><h3 class="connector">' . L10n::t('GNU Social Import/Export/Mirror') . '</h3>';
        $s .= '</span>';
 
-       if ((!$ckey) && (!$csecret)) {
-               /*               * *
+       if ( (!$ckey) && (!$csecret) ) {
+               /***
                 * no consumer keys
                 */
-               $globalsn = Config::get('statusnet', 'sites');
-               /*               * *
+               $globalsn = get_config('statusnet', 'sites');
+               /***
                 * lets check if we have one or more globally configured GNU Social
                 * server OAuth credentials in the configuration. If so offer them
                 * with a little explanation to the user as choice - otherwise
@@ -278,7 +322,7 @@ function statusnet_settings(App $a, &$s)
                        $s .= '<p>' . L10n::t("There are preconfigured OAuth key pairs for some GNU Social servers available. If you are using one of them, please use these credentials. If not feel free to connect to any other GNU Social instance \x28see below\x29.") . '</p>';
                        $s .= '<div id="statusnet-preconf-wrapper">';
                        foreach ($globalsn as $asn) {
-                               $s .= '<input type="radio" name="statusnet-preconf-apiurl" value="' . $asn['apiurl'] . '">' . $asn['sitename'] . '<br />';
+                               $s .= '<input type="radio" name="statusnet-preconf-apiurl" value="'. $asn['apiurl'] .'">'. $asn['sitename'] .'<br />';
                        }
                        $s .= '<p></p><div class="clear"></div></div>';
                        $s .= '<div class="settings-submit-wrapper" ><input type="submit" name="statusnet-submit" class="settings-submit" value="' . L10n::t('Save Settings') . '" /></div>';
@@ -301,11 +345,11 @@ function statusnet_settings(App $a, &$s)
                $s .= '<div class="settings-submit-wrapper" ><input type="submit" name="statusnet-submit" class="settings-submit" value="' . L10n::t('Save Settings') . '" /></div>';
                $s .= '</div>';
        } else {
-               /*               * *
+               /***
                 * ok we have a consumer key pair now look into the OAuth stuff
                 */
-               if ((!$otoken) && (!$osecret)) {
-                       /*                       * *
+               if ( (!$otoken) && (!$osecret) ) {
+                       /***
                         * the user has not yet connected the account to GNU Social
                         * get a temporary OAuth key/secret pair and display a button with
                         * which the user can request a PIN to connect the account to a
@@ -314,7 +358,7 @@ function statusnet_settings(App $a, &$s)
                        $connection = new StatusNetOAuth($api, $ckey, $csecret);
                        $request_token = $connection->getRequestToken('oob');
                        $token = $request_token['oauth_token'];
-                       /*                       * *
+                       /***
                         *  make some nice form
                         */
                        $s .= '<p>' . L10n::t('To connect to your GNU Social account click the button below to get a security code from GNU Social which you have to copy into the input box below and submit the form. Only your <strong>public</strong> posts will be posted to GNU Social.') . '</p>';
@@ -322,8 +366,8 @@ function statusnet_settings(App $a, &$s)
                        $s .= '<div id="statusnet-pin-wrapper">';
                        $s .= '<label id="statusnet-pin-label" for="statusnet-pin">' . L10n::t('Copy the security code from GNU Social here') . '</label>';
                        $s .= '<input id="statusnet-pin" type="text" name="statusnet-pin" />';
-                       $s .= '<input id="statusnet-token" type="hidden" name="statusnet-token" value="' . $token . '" />';
-                       $s .= '<input id="statusnet-token2" type="hidden" name="statusnet-token2" value="' . $request_token['oauth_token_secret'] . '" />';
+                       $s .= '<input id="statusnet-token" type="hidden" name="statusnet-token" value="'.$token.'" />';
+                       $s .= '<input id="statusnet-token2" type="hidden" name="statusnet-token2" value="'.$request_token['oauth_token_secret'].'" />';
                        $s .= '</div><div class="clear"></div>';
                        $s .= '<div class="settings-submit-wrapper" ><input type="submit" name="statusnet-submit" class="settings-submit" value="' . L10n::t('Save Settings') . '" /></div>';
                        $s .= '<h4>' . L10n::t('Cancel Connection Process') . '</h4>';
@@ -334,11 +378,11 @@ function statusnet_settings(App $a, &$s)
                        $s .= '</div><div class="clear"></div>';
                        $s .= '<div class="settings-submit-wrapper" ><input type="submit" name="statusnet-submit" class="settings-submit" value="' . L10n::t('Save Settings') . '" /></div>';
                } else {
-                       /*                       * *
+                       /***
                         *  we have an OAuth key / secret pair for the user
                         *  so let's give a chance to disable the postings to GNU Social
                         */
-                       $connection = new StatusNetOAuth($api, $ckey, $csecret, $otoken, $osecret);
+                       $connection = new StatusNetOAuth($api,$ckey,$csecret,$otoken,$osecret);
                        $details = $connection->get('account/verify_credentials');
                        $s .= '<div id="statusnet-info" ><img id="statusnet-avatar" src="' . $details->profile_image_url . '" /><p id="statusnet-info-block">' . L10n::t('Currently connected to: ') . '<a href="' . $details->statusnet_profile_url . '" target="_statusnet">' . $details->screen_name . '</a><br /><em>' . $details->description . '</em></p></div>';
                        $s .= '<p>' . L10n::t('If enabled all your <strong>public</strong> postings can be posted to the associated GNU Social account. You can choose to do so by default (here) or for every posting separately in the posting options when writing the entry.') . '</p>';
@@ -383,8 +427,8 @@ function statusnet_settings(App $a, &$s)
        $s .= '</div><div class="clear"></div>';
 }
 
-function statusnet_post_local(App $a, &$b)
-{
+
+function statusnet_post_local(&$a, &$b) {
        if ($b['edit']) {
                return;
        }
@@ -393,11 +437,11 @@ function statusnet_post_local(App $a, &$b)
                return;
        }
 
-       $statusnet_post = PConfig::get(local_user(), 'statusnet', 'post');
-       $statusnet_enable = (($statusnet_post && x($_REQUEST, 'statusnet_enable')) ? intval($_REQUEST['statusnet_enable']) : 0);
+       $statusnet_post = get_pconfig(local_user(),'statusnet','post');
+       $statusnet_enable = (($statusnet_post && x($_REQUEST,'statusnet_enable')) ? intval($_REQUEST['statusnet_enable']) : 0);
 
        // if API is used, default to the chosen settings
-       if ($b['api_source'] && intval(PConfig::get(local_user(), 'statusnet', 'post_by_default'))) {
+       if ($b['api_source'] && intval(get_pconfig(local_user(),'statusnet','post_by_default'))) {
                $statusnet_enable = 1;
        }
 
@@ -412,61 +456,64 @@ function statusnet_post_local(App $a, &$b)
        $b['postopts'] .= 'statusnet';
 }
 
-function statusnet_action(App $a, $uid, $pid, $action)
-{
-       $api = PConfig::get($uid, 'statusnet', 'baseapi');
-       $ckey = PConfig::get($uid, 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($uid, 'statusnet', 'consumersecret');
-       $otoken = PConfig::get($uid, 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($uid, 'statusnet', 'oauthsecret');
+function statusnet_action($a, $uid, $pid, $action) {
+       $api     = get_pconfig($uid, 'statusnet', 'baseapi');
+       $ckey    = get_pconfig($uid, 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($uid, 'statusnet', 'consumersecret');
+       $otoken  = get_pconfig($uid, 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($uid, 'statusnet', 'oauthsecret');
 
-       $connection = new StatusNetOAuth($api, $ckey, $csecret, $otoken, $osecret);
+       $connection = new StatusNetOAuth($api,$ckey,$csecret,$otoken,$osecret);
 
-       logger("statusnet_action '" . $action . "' ID: " . $pid, LOGGER_DATA);
+       logger("statusnet_action '".$action."' ID: ".$pid, LOGGER_DATA);
 
        switch ($action) {
                case "delete":
-                       $result = $connection->post("statuses/destroy/" . $pid);
+                       $result = $connection->post("statuses/destroy/".$pid);
                        break;
                case "like":
-                       $result = $connection->post("favorites/create/" . $pid);
+                       $result = $connection->post("favorites/create/".$pid);
                        break;
                case "unlike":
-                       $result = $connection->post("favorites/destroy/" . $pid);
+                       $result = $connection->post("favorites/destroy/".$pid);
                        break;
        }
-       logger("statusnet_action '" . $action . "' send, result: " . print_r($result, true), LOGGER_DEBUG);
+       logger("statusnet_action '".$action."' send, result: " . print_r($result, true), LOGGER_DEBUG);
 }
 
-function statusnet_post_hook(App $a, &$b)
-{
+function statusnet_post_hook(&$a,&$b) {
+
        /**
         * Post to GNU Social
         */
-       if (!PConfig::get($b["uid"], 'statusnet', 'import')) {
-               if ($b['deleted'] || $b['private'] || ($b['created'] !== $b['edited']))
+
+       if (!get_pconfig($b["uid"],'statusnet','import')) {
+               if($b['deleted'] || $b['private'] || ($b['created'] !== $b['edited']))
                        return;
        }
 
-       $api = PConfig::get($b["uid"], 'statusnet', 'baseapi');
+       $api = get_pconfig($b["uid"], 'statusnet', 'baseapi');
        $hostname = preg_replace("=https?://([\w\.]*)/.*=ism", "$1", $api);
 
-       if ($b['parent'] != $b['id']) {
-               logger("statusnet_post_hook: parameter " . print_r($b, true), LOGGER_DATA);
+       if($b['parent'] != $b['id']) {
+               logger("statusnet_post_hook: parameter ".print_r($b, true), LOGGER_DATA);
 
                // Looking if its a reply to a GNU Social post
                $hostlength = strlen($hostname) + 2;
-               if ((substr($b["parent-uri"], 0, $hostlength) != $hostname . "::") && (substr($b["extid"], 0, $hostlength) != $hostname . "::") && (substr($b["thr-parent"], 0, $hostlength) != $hostname . "::")) {
-                       logger("statusnet_post_hook: no GNU Social post " . $b["parent"]);
+               if ((substr($b["parent-uri"], 0, $hostlength) != $hostname."::") && (substr($b["extid"], 0, $hostlength) != $hostname."::")
+                       && (substr($b["thr-parent"], 0, $hostlength) != $hostname."::")) {
+                       logger("statusnet_post_hook: no GNU Social post ".$b["parent"]);
                        return;
                }
 
                $r = q("SELECT `item`.`author-link`, `item`.`uri`, `contact`.`nick` AS contact_nick
                        FROM `item` INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id`
-                       WHERE `item`.`uri` = '%s' AND `item`.`uid` = %d LIMIT 1", dbesc($b["thr-parent"]), intval($b["uid"]));
+                       WHERE `item`.`uri` = '%s' AND `item`.`uid` = %d LIMIT 1",
+                       dbesc($b["thr-parent"]),
+                       intval($b["uid"]));
 
-               if (!count($r)) {
-                       logger("statusnet_post_hook: no parent found " . $b["thr-parent"]);
+               if(!count($r)) {
+                       logger("statusnet_post_hook: no parent found ".$b["thr-parent"]);
                        return;
                } else {
                        $iscomment = true;
@@ -478,36 +525,26 @@ function statusnet_post_hook(App $a, &$b)
 
                $nick = preg_replace("=https?://(.*)/(.*)=ism", "$2", $orig_post["author-link"]);
 
-               $nickname = "@[url=" . $orig_post["author-link"] . "]" . $nick . "[/url]";
-               $nicknameplain = "@" . $nick;
+               $nickname = "@[url=".$orig_post["author-link"]."]".$nick."[/url]";
+               $nicknameplain = "@".$nick;
 
-               logger("statusnet_post_hook: comparing " . $nickname . " and " . $nicknameplain . " with " . $b["body"], LOGGER_DEBUG);
-               if ((strpos($b["body"], $nickname) === false) && (strpos($b["body"], $nicknameplain) === false)) {
-                       $b["body"] = $nickname . " " . $b["body"];
-               }
+               logger("statusnet_post_hook: comparing ".$nickname." and ".$nicknameplain." with ".$b["body"], LOGGER_DEBUG);
+               if ((strpos($b["body"], $nickname) === false) && (strpos($b["body"], $nicknameplain) === false))
+                       $b["body"] = $nickname." ".$b["body"];
 
-               logger("statusnet_post_hook: parent found " . print_r($orig_post, true), LOGGER_DEBUG);
+               logger("statusnet_post_hook: parent found ".print_r($orig_post, true), LOGGER_DEBUG);
        } else {
                $iscomment = false;
 
-               if ($b['private'] || !strstr($b['postopts'], 'statusnet')) {
-                       return;
-               }
-
-               // Dont't post if the post doesn't belong to us.
-               // This is a check for forum postings
-               $self = dba::selectFirst('contact', ['id'], ['uid' => $b['uid'], 'self' => true]);
-               if ($b['contact-id'] != $self['id']) {
+               if($b['private'] || !strstr($b['postopts'],'statusnet'))
                        return;
-               }
        }
 
-       if (($b['verb'] == ACTIVITY_POST) && $b['deleted']) {
+       if (($b['verb'] == ACTIVITY_POST) && $b['deleted'])
                statusnet_action($a, $b["uid"], substr($orig_post["uri"], $hostlength), "delete");
-       }
 
-       if ($b['verb'] == ACTIVITY_LIKE) {
-               logger("statusnet_post_hook: parameter 2 " . substr($b["thr-parent"], $hostlength), LOGGER_DEBUG);
+       if($b['verb'] == ACTIVITY_LIKE) {
+               logger("statusnet_post_hook: parameter 2 ".substr($b["thr-parent"], $hostlength), LOGGER_DEBUG);
                if ($b['deleted'])
                        statusnet_action($a, $b["uid"], substr($b["thr-parent"], $hostlength), "unlike");
                else
@@ -515,39 +552,36 @@ function statusnet_post_hook(App $a, &$b)
                return;
        }
 
-       if ($b['deleted'] || ($b['created'] !== $b['edited'])) {
+       if($b['deleted'] || ($b['created'] !== $b['edited']))
                return;
-       }
 
        // if posts comes from GNU Social don't send it back
-       if ($b['extid'] == NETWORK_STATUSNET) {
+       if($b['extid'] == NETWORK_STATUSNET)
                return;
-       }
 
-       if ($b['app'] == "StatusNet") {
+       if($b['app'] == "StatusNet")
                return;
-       }
 
        logger('GNU Socialpost invoked');
 
-       PConfig::load($b['uid'], 'statusnet');
+       load_pconfig($b['uid'], 'statusnet');
+
+       $api     = get_pconfig($b['uid'], 'statusnet', 'baseapi');
+       $ckey    = get_pconfig($b['uid'], 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($b['uid'], 'statusnet', 'consumersecret');
+       $otoken  = get_pconfig($b['uid'], 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($b['uid'], 'statusnet', 'oauthsecret');
 
-       $api     = PConfig::get($b['uid'], 'statusnet', 'baseapi');
-       $ckey    = PConfig::get($b['uid'], 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($b['uid'], 'statusnet', 'consumersecret');
-       $otoken  = PConfig::get($b['uid'], 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($b['uid'], 'statusnet', 'oauthsecret');
+       if($ckey && $csecret && $otoken && $osecret) {
 
-       if ($ckey && $csecret && $otoken && $osecret) {
                // If it's a repeated message from GNU Social then do a native retweet and exit
-               if (statusnet_is_retweet($a, $b['uid'], $b['body'])) {
+               if (statusnet_is_retweet($a, $b['uid'], $b['body']))
                        return;
-               }
 
                $dent = new StatusNetOAuth($api, $ckey, $csecret, $otoken, $osecret);
                $max_char = $dent->get_maxlength(); // max. length for a dent
 
-               PConfig::set($b['uid'], 'statusnet', 'max_char', $max_char);
+               set_pconfig($b['uid'], 'statusnet', 'max_char', $max_char);
 
                $tempfile = "";
                $msgarr = BBCode::toPlaintext($b, $max_char, true, 7);
@@ -562,22 +596,20 @@ function statusnet_post_hook(App $a, &$b)
                        $msg .= " \n" . $msgarr["url"];
                } elseif (isset($msgarr["image"]) && ($msgarr["type"] != "video")) {
                        $image = $msgarr["image"];
-               }
 
                if ($image != "") {
                        $img_str = Network::fetchUrl($image);
                        $tempfile = tempnam(get_temppath(), "cache");
                        file_put_contents($tempfile, $img_str);
-                       $postdata = ["status" => $msg, "media[]" => $tempfile];
-               } else {
-                       $postdata = ["status" => $msg];
-               }
+                       $postdata = array("status" => $msg, "media[]" => $tempfile);
+               } else
+                       $postdata = array("status"=>$msg);
 
                // and now send it :-)
                if (strlen($msg)) {
                        if ($iscomment) {
                                $postdata["in_reply_to_status_id"] = substr($orig_post["uri"], $hostlength);
-                               logger('statusnet_post send reply ' . print_r($postdata, true), LOGGER_DEBUG);
+                               logger('statusnet_post send reply '.print_r($postdata, true), LOGGER_DEBUG);
                        }
 
                        // New code that is able to post pictures
@@ -588,23 +620,21 @@ function statusnet_post_hook(App $a, &$b)
                        $cb->setToken($otoken, $osecret);
                        $result = $cb->statuses_update($postdata);
                        //$result = $dent->post('statuses/update', $postdata);
-                       logger('statusnet_post send, result: ' . print_r($result, true) .
-                               "\nmessage: " . $msg, LOGGER_DEBUG . "\nOriginal post: " . print_r($b, true) . "\nPost Data: " . print_r($postdata, true));
+                       logger('statusnet_post send, result: ' . print_r($result, true).
+                               "\nmessage: ".$msg, LOGGER_DEBUG."\nOriginal post: ".print_r($b, true)."\nPost Data: ".print_r($postdata, true));
 
-                       if ($result->source) {
-                               PConfig::set($b["uid"], "statusnet", "application_name", strip_tags($result->source));
-                       }
+                       if ($result->source)
+                               set_pconfig($b["uid"], "statusnet", "application_name", strip_tags($result->source));
 
                        if ($result->error) {
-                               logger('Send to GNU Social failed: "' . $result->error . '"');
+                               logger('Send to GNU Social failed: "'.$result->error.'"');
                        } elseif ($iscomment) {
                                logger('statusnet_post: Update extid ' . $result->id . " for post id " . $b['id']);
                                Item::update(['extid' => $hostname . "::" . $result->id, 'body' => $result->text], ['id' => $b['id']]);
                        }
                }
-               if ($tempfile != "") {
+               if ($tempfile != "")
                        unlink($tempfile);
-               }
        }
 }
 
@@ -612,32 +642,34 @@ function statusnet_addon_admin_post(App $a)
 {
        $sites = [];
 
-       foreach ($_POST['sitename'] as $id => $sitename) {
-               $sitename = trim($sitename);
-               $apiurl = trim($_POST['apiurl'][$id]);
-               if (!(substr($apiurl, -1) == '/')) {
-                       $apiurl = $apiurl . '/';
-               }
-               $secret = trim($_POST['secret'][$id]);
-               $key = trim($_POST['key'][$id]);
+       $sites = array();
+
+       foreach($_POST['sitename'] as $id=>$sitename){
+               $sitename=trim($sitename);
+               $apiurl=trim($_POST['apiurl'][$id]);
+               if (! (substr($apiurl, -1)=='/'))
+                   $apiurl=$apiurl.'/';
+               $secret=trim($_POST['secret'][$id]);
+               $key=trim($_POST['key'][$id]);
                //$applicationname = ((x($_POST, 'applicationname')) ? notags(trim($_POST['applicationname'][$id])):'');
-               if ($sitename != "" &&
-                       $apiurl != "" &&
-                       $secret != "" &&
-                       $key != "" &&
-                       !x($_POST['delete'][$id])) {
-
-                       $sites[] = [
-                               'sitename' => $sitename,
-                               'apiurl' => $apiurl,
-                               'consumersecret' => $secret,
-                               'consumerkey' => $key,
-                               //'applicationname' => $applicationname
-                       ];
+               if ($sitename!="" &&
+                       $apiurl!="" &&
+                       $secret!="" &&
+                       $key!="" &&
+                       !x($_POST['delete'][$id])){
+
+                               $sites[] = Array(
+                                       'sitename' => $sitename,
+                                       'apiurl' => $apiurl,
+                                       'consumersecret' => $secret,
+                                       'consumerkey' => $key,
+                                       //'applicationname' => $applicationname
+                               );
                }
        }
 
-       $sites = Config::set('statusnet', 'sites', $sites);
+       $sites = set_config('statusnet','sites', $sites);
+
 }
 
 function statusnet_addon_admin(App $a, &$o)
@@ -652,8 +684,8 @@ function statusnet_addon_admin(App $a, &$o)
                                'secret' => ["secret[$id]", "Secret", $s['consumersecret'], ""],
                                'key' => ["key[$id]", "Key", $s['consumerkey'], ""],
                                //'applicationname' => Array("applicationname[$id]", "Application name", $s['applicationname'], ""),
-                               'delete' => ["delete[$id]", "Delete", False, "Check to delete this preset"],
-                       ];
+                               'delete' => Array("delete[$id]", "Delete", False , "Check to delete this preset"),
+                       );
                }
        }
        /* empty form to add new site */
@@ -670,20 +702,17 @@ function statusnet_addon_admin(App $a, &$o)
        $o = replace_macros($t, [
                '$submit' => L10n::t('Save Settings'),
                '$sites' => $sitesform,
-       ]);
+       ));
 }
 
-function statusnet_prepare_body(App $a, &$b)
-{
-       if ($b["item"]["network"] != NETWORK_STATUSNET) {
-               return;
-       }
+function statusnet_prepare_body(&$a,&$b) {
+        if ($b["item"]["network"] != NETWORK_STATUSNET)
+                return;
 
-       if ($b["preview"]) {
-               $max_char = PConfig::get(local_user(), 'statusnet', 'max_char');
-               if (intval($max_char) == 0) {
+        if ($b["preview"]) {
+               $max_char = get_pconfig(local_user(),'statusnet','max_char');
+               if (intval($max_char) == 0)
                        $max_char = 140;
-               }
 
                $item = $b["item"];
                $item["plink"] = $a->get_baseurl() . "/display/" . $a->user["nickname"] . "/" . $item["parent"];
@@ -694,48 +723,46 @@ function statusnet_prepare_body(App $a, &$b)
                         dbesc($item["thr-parent"]),
                         intval(local_user()));
 
-               if (count($r)) {
-                       $orig_post = $r[0];
+                if(count($r)) {
+                        $orig_post = $r[0];
                        //$nickname = "@[url=".$orig_post["author-link"]."]".$orig_post["contact_nick"]."[/url]";
                        //$nicknameplain = "@".$orig_post["contact_nick"];
 
                        $nick = preg_replace("=https?://(.*)/(.*)=ism", "$2", $orig_post["author-link"]);
 
-                       $nickname = "@[url=" . $orig_post["author-link"] . "]" . $nick . "[/url]";
-                       $nicknameplain = "@" . $nick;
+                       $nickname = "@[url=".$orig_post["author-link"]."]".$nick."[/url]";
+                       $nicknameplain = "@".$nick;
 
-                       if ((strpos($item["body"], $nickname) === false) && (strpos($item["body"], $nicknameplain) === false)) {
-                               $item["body"] = $nickname . " " . $item["body"];
-                       }
-               }
+                       if ((strpos($item["body"], $nickname) === false) && (strpos($item["body"], $nicknameplain) === false))
+                               $item["body"] = $nickname." ".$item["body"];
+                }
 
                $msgarr = BBCode::toPlaintext($item, $max_char, true, 7);
                $msg = $msgarr["text"];
 
-               if (isset($msgarr["url"]) && ($msgarr["type"] != "photo")) {
-                       $msg .= " " . $msgarr["url"];
-               }
+                $msgarr = plaintext($a, $item, $max_char, true, 7);
+                $msg = $msgarr["text"];
 
-               if (isset($msgarr["image"])) {
-                       $msg .= " " . $msgarr["image"];
-               }
+                if (isset($msgarr["url"]) && ($msgarr["type"] != "photo"))
+                        $msg .= " ".$msgarr["url"];
 
-               $b['html'] = nl2br(htmlspecialchars($msg));
-       }
+                if (isset($msgarr["image"]))
+                        $msg .= " ".$msgarr["image"];
+
+                $b['html'] = nl2br(htmlspecialchars($msg));
+        }
 }
 
-function statusnet_cron(App $a, $b)
-{
-       $last = Config::get('statusnet', 'last_poll');
+function statusnet_cron($a,$b) {
+       $last = get_config('statusnet','last_poll');
 
-       $poll_interval = intval(Config::get('statusnet', 'poll_interval'));
-       if (!$poll_interval) {
+       $poll_interval = intval(get_config('statusnet','poll_interval'));
+       if(! $poll_interval)
                $poll_interval = STATUSNET_DEFAULT_POLL_INTERVAL;
-       }
 
-       if ($last) {
+       if($last) {
                $next = $last + ($poll_interval * 60);
-               if ($next > time()) {
+               if($next > time()) {
                        logger('statusnet: poll intervall not reached');
                        return;
                }
@@ -743,188 +770,171 @@ function statusnet_cron(App $a, $b)
        logger('statusnet: cron_start');
 
        $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'statusnet' AND `k` = 'mirror_posts' AND `v` = '1' ORDER BY RAND() ");
-       if (count($r)) {
-               foreach ($r as $rr) {
-                       logger('statusnet: fetching for user ' . $rr['uid']);
+       if(count($r)) {
+               foreach($r as $rr) {
+                       logger('statusnet: fetching for user '.$rr['uid']);
                        statusnet_fetchtimeline($a, $rr['uid']);
                }
        }
 
-       $abandon_days = intval(Config::get('system', 'account_abandon_days'));
-       if ($abandon_days < 1) {
+       $abandon_days = intval(get_config('system','account_abandon_days'));
+       if ($abandon_days < 1)
                $abandon_days = 0;
-       }
 
        $abandon_limit = date(DateTimeFormat::MYSQL, time() - $abandon_days * 86400);
 
        $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'statusnet' AND `k` = 'import' AND `v` ORDER BY RAND()");
-       if (count($r)) {
-               foreach ($r as $rr) {
+       if(count($r)) {
+               foreach($r as $rr) {
                        if ($abandon_days != 0) {
                                $user = q("SELECT `login_date` FROM `user` WHERE uid=%d AND `login_date` >= '%s'", $rr['uid'], $abandon_limit);
                                if (!count($user)) {
-                                       logger('abandoned account: timeline from user ' . $rr['uid'] . ' will not be imported');
+                                       logger('abandoned account: timeline from user '.$rr['uid'].' will not be imported');
                                        continue;
                                }
                        }
 
-                       logger('statusnet: importing timeline from user ' . $rr['uid']);
+                       logger('statusnet: importing timeline from user '.$rr['uid']);
                        statusnet_fetchhometimeline($a, $rr["uid"], $rr["v"]);
                }
        }
 
        logger('statusnet: cron_end');
 
-       Config::set('statusnet', 'last_poll', time());
+       set_config('statusnet','last_poll', time());
 }
 
-function statusnet_fetchtimeline(App $a, $uid)
-{
-       $ckey    = PConfig::get($uid, 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($uid, 'statusnet', 'consumersecret');
-       $api     = PConfig::get($uid, 'statusnet', 'baseapi');
-       $otoken  = PConfig::get($uid, 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($uid, 'statusnet', 'oauthsecret');
-       $lastid  = PConfig::get($uid, 'statusnet', 'lastid');
-
-       require_once 'mod/item.php';
-       require_once 'include/items.php';
+function statusnet_fetchtimeline($a, $uid) {
+       $ckey    = get_pconfig($uid, 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($uid, 'statusnet', 'consumersecret');
+       $api     = get_pconfig($uid, 'statusnet', 'baseapi');
+       $otoken  = get_pconfig($uid, 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($uid, 'statusnet', 'oauthsecret');
+       $lastid  = get_pconfig($uid, 'statusnet', 'lastid');
+
+       require_once('mod/item.php');
+       require_once('include/items.php');
 
        //  get the application name for the SN app
        //  1st try personal config, then system config and fallback to the
        //  hostname of the node if neither one is set.
-       $application_name = PConfig::get($uid, 'statusnet', 'application_name');
-       if ($application_name == "") {
-               $application_name = Config::get('statusnet', 'application_name');
-       }
-       if ($application_name == "") {
+       $application_name  = get_pconfig( $uid, 'statusnet', 'application_name');
+       if ($application_name == "")
+               $application_name  = get_config('statusnet', 'application_name');
+       if ($application_name == "")
                $application_name = $a->get_hostname();
-       }
 
-       $connection = new StatusNetOAuth($api, $ckey, $csecret, $otoken, $osecret);
+       $connection = new StatusNetOAuth($api, $ckey,$csecret,$otoken,$osecret);
 
-       $parameters = ["exclude_replies" => true, "trim_user" => true, "contributor_details" => false, "include_rts" => false];
+       $parameters = array("exclude_replies" => true, "trim_user" => true, "contributor_details" => false, "include_rts" => false);
 
        $first_time = ($lastid == "");
 
-       if ($lastid <> "") {
+       if ($lastid <> "")
                $parameters["since_id"] = $lastid;
-       }
 
        $items = $connection->get('statuses/user_timeline', $parameters);
 
-       if (!is_array($items)) {
+       if (!is_array($items))
                return;
-       }
 
        $posts = array_reverse($items);
 
        if (count($posts)) {
-               foreach ($posts as $post) {
-                       if ($post->id > $lastid)
-                               $lastid = $post->id;
+           foreach ($posts as $post) {
+               if ($post->id > $lastid)
+                       $lastid = $post->id;
 
-                       if ($first_time) {
-                               continue;
-                       }
+               if ($first_time)
+                       continue;
 
-                       if ($post->source == "activity") {
-                               continue;
-                       }
+               if ($post->source == "activity")
+                       continue;
 
-                       if (is_object($post->retweeted_status)) {
-                               continue;
-                       }
+               if (is_object($post->retweeted_status))
+                       continue;
 
-                       if ($post->in_reply_to_status_id != "") {
-                               continue;
-                       }
+               if ($post->in_reply_to_status_id != "")
+                       continue;
 
-                       if (!stristr($post->source, $application_name)) {
-                               $_SESSION["authenticated"] = true;
-                               $_SESSION["uid"] = $uid;
+               if (!stristr($post->source, $application_name)) {
+                       $_SESSION["authenticated"] = true;
+                       $_SESSION["uid"] = $uid;
 
-                               unset($_REQUEST);
-                               $_REQUEST["type"] = "wall";
-                               $_REQUEST["api_source"] = true;
-                               $_REQUEST["profile_uid"] = $uid;
-                               //$_REQUEST["source"] = "StatusNet";
-                               $_REQUEST["source"] = $post->source;
-                               $_REQUEST["extid"] = NETWORK_STATUSNET;
+                       unset($_REQUEST);
+                       $_REQUEST["type"] = "wall";
+                       $_REQUEST["api_source"] = true;
+                       $_REQUEST["profile_uid"] = $uid;
+                       //$_REQUEST["source"] = "StatusNet";
+                       $_REQUEST["source"] = $post->source;
+                       $_REQUEST["extid"] = NETWORK_STATUSNET;
 
-                               if (isset($post->id)) {
-                                       $_REQUEST['message_id'] = item_new_uri($a->get_hostname(), $uid, NETWORK_STATUSNET . ":" . $post->id);
-                               }
+                       if (isset($post->id)) {
+                               $_REQUEST['message_id'] = item_new_uri($a->get_hostname(), $uid, NETWORK_STATUSNET.":".$post->id);
+                       }
 
-                               //$_REQUEST["date"] = $post->created_at;
+                       //$_REQUEST["date"] = $post->created_at;
 
-                               $_REQUEST["title"] = "";
+                       $_REQUEST["title"] = "";
 
-                               $_REQUEST["body"] = add_page_info_to_body($post->text, true);
-                               if (is_string($post->place->name)) {
-                                       $_REQUEST["location"] = $post->place->name;
-                               }
+                       $_REQUEST["body"] = add_page_info_to_body($post->text, true);
+                       if (is_string($post->place->name))
+                               $_REQUEST["location"] = $post->place->name;
 
-                               if (is_string($post->place->full_name)) {
-                                       $_REQUEST["location"] = $post->place->full_name;
-                               }
+                       if (is_string($post->place->full_name))
+                               $_REQUEST["location"] = $post->place->full_name;
 
-                               if (is_array($post->geo->coordinates)) {
-                                       $_REQUEST["coord"] = $post->geo->coordinates[0] . " " . $post->geo->coordinates[1];
-                               }
+                       if (is_array($post->geo->coordinates))
+                               $_REQUEST["coord"] = $post->geo->coordinates[0]." ".$post->geo->coordinates[1];
 
-                               if (is_array($post->coordinates->coordinates)) {
-                                       $_REQUEST["coord"] = $post->coordinates->coordinates[1] . " " . $post->coordinates->coordinates[0];
-                               }
+                       if (is_array($post->coordinates->coordinates))
+                               $_REQUEST["coord"] = $post->coordinates->coordinates[1]." ".$post->coordinates->coordinates[0];
 
-                               //print_r($_REQUEST);
-                               if ($_REQUEST["body"] != "") {
-                                       logger('statusnet: posting for user ' . $uid);
+                       //print_r($_REQUEST);
+                       if ($_REQUEST["body"] != "") {
+                               logger('statusnet: posting for user '.$uid);
 
-                                       item_post($a);
-                               }
+                               item_post($a);
                        }
                }
+           }
        }
-       PConfig::set($uid, 'statusnet', 'lastid', $lastid);
+       set_pconfig($uid, 'statusnet', 'lastid', $lastid);
 }
 
-function statusnet_address($contact)
-{
+function statusnet_address($contact) {
        $hostname = normalise_link($contact->statusnet_profile_url);
        $nickname = $contact->screen_name;
 
        $hostname = preg_replace("=https?://([\w\.]*)/.*=ism", "$1", $contact->statusnet_profile_url);
 
-       $address = $contact->screen_name . "@" . $hostname;
+       $address = $contact->screen_name."@".$hostname;
 
-       return $address;
+       return($address);
 }
 
-function statusnet_fetch_contact($uid, $contact, $create_user)
-{
-       if ($contact->statusnet_profile_url == "") {
-               return -1;
-       }
+function statusnet_fetch_contact($uid, $contact, $create_user) {
+       if ($contact->statusnet_profile_url == "")
+               return(-1);
 
-       GContact::update(["url" => $contact->statusnet_profile_url,
-               "network" => NETWORK_STATUSNET, "photo" => $contact->profile_image_url,
-               "name" => $contact->name, "nick" => $contact->screen_name,
-               "location" => $contact->location, "about" => $contact->description,
-               "addr" => statusnet_address($contact), "generation" => 3]);
+       update_gcontact(array("url" => $contact->statusnet_profile_url,
+                       "network" => NETWORK_STATUSNET, "photo" => $contact->profile_image_url,
+                       "name" => $contact->name, "nick" => $contact->screen_name,
+                       "location" => $contact->location, "about" => $contact->description,
+                       "addr" => statusnet_address($contact), "generation" => 3));
 
-       $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `alias` = '%s' AND `network` = '%s'LIMIT 1", intval($uid), dbesc(normalise_link($contact->statusnet_profile_url)), dbesc(NETWORK_STATUSNET));
+       $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `alias` = '%s' AND `network` = '%s'LIMIT 1",
+               intval($uid), dbesc(normalise_link($contact->statusnet_profile_url)), dbesc(NETWORK_STATUSNET));
 
-       if (!count($r) && !$create_user) {
-               return 0;
-       }
+       if(!count($r) && !$create_user)
+               return(0);
 
        if (count($r) && ($r[0]["readonly"] || $r[0]["blocked"])) {
-               logger("statusnet_fetch_contact: Contact '" . $r[0]["nick"] . "' is blocked or readonly.", LOGGER_DEBUG);
-               return -1;
+               logger("statusnet_fetch_contact: Contact '".$r[0]["nick"]."' is blocked or readonly.", LOGGER_DEBUG);
+               return(-1);
        }
 
-       if (!count($r)) {
+       if(!count($r)) {
                // create contact record
                q("INSERT INTO `contact` ( `uid`, `created`, `url`, `nurl`, `addr`, `alias`, `notify`, `poll`,
                                        `name`, `nick`, `photo`, `network`, `rel`, `priority`,
@@ -954,15 +964,23 @@ function statusnet_fetch_contact($uid, $contact, $create_user)
                        intval($uid),
                        dbesc(NETWORK_STATUSNET));
 
-               if (!count($r)) {
-                       return false;
-               }
+               if(! count($r))
+                       return(false);
+
+               $contact_id  = $r[0]['id'];
+
+               $g = q("SELECT def_gid FROM user WHERE uid = %d LIMIT 1",
+                       intval($uid)
+               );
 
-               $contact_id = $r[0]['id'];
+               if($g && intval($g[0]['def_gid'])) {
+                       require_once('include/group.php');
+                       group_add_member($uid,'',$contact_id,$g[0]['def_gid']);
+               }
 
-               Group::addMember(User::getDefaultGroup($uid), $contact_id);
+               require_once("Photo.php");
 
-               $photos = Photo::importProfilePhoto($contact->profile_image_url, $uid, $contact_id);
+               $photos = import_profile_photo($contact->profile_image_url,$uid,$contact_id);
 
                q("UPDATE `contact` SET `photo` = '%s',
                                        `thumb` = '%s',
@@ -981,10 +999,14 @@ function statusnet_fetch_contact($uid, $contact, $create_user)
                $update_photo = ($r[0]['avatar-date'] < DateTimeFormat::utc('now -12 hours'));
 
                // check that we have all the photos, this has been known to fail on occasion
-               if ((!$r[0]['photo']) || (!$r[0]['thumb']) || (!$r[0]['micro']) || ($update_photo)) {
-                       logger("statusnet_fetch_contact: Updating contact " . $contact->screen_name, LOGGER_DEBUG);
 
-                       $photos = Photo::importProfilePhoto($contact->profile_image_url, $uid, $r[0]['id']);
+               if((!$r[0]['photo']) || (!$r[0]['thumb']) || (!$r[0]['micro']) || ($update_photo)) {
+
+                       logger("statusnet_fetch_contact: Updating contact ".$contact->screen_name, LOGGER_DEBUG);
+
+                       require_once("Photo.php");
+
+                       $photos = import_profile_photo($contact->profile_image_url, $uid, $r[0]['id']);
 
                        q("UPDATE `contact` SET `photo` = '%s',
                                                `thumb` = '%s',
@@ -1018,16 +1040,15 @@ function statusnet_fetch_contact($uid, $contact, $create_user)
                }
        }
 
-       return $r[0]["id"];
+       return($r[0]["id"]);
 }
 
-function statusnet_fetchuser(App $a, $uid, $screen_name = "", $user_id = "")
-{
-       $ckey    = PConfig::get($uid, 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($uid, 'statusnet', 'consumersecret');
-       $api     = PConfig::get($uid, 'statusnet', 'baseapi');
-       $otoken  = PConfig::get($uid, 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($uid, 'statusnet', 'oauthsecret');
+function statusnet_fetchuser($a, $uid, $screen_name = "", $user_id = "") {
+       $ckey    = get_pconfig($uid, 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($uid, 'statusnet', 'consumersecret');
+       $api     = get_pconfig($uid, 'statusnet', 'baseapi');
+       $otoken  = get_pconfig($uid, 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($uid, 'statusnet', 'oauthsecret');
 
        require_once __DIR__ . DIRECTORY_SEPARATOR . 'library' . DIRECTORY_SEPARATOR . 'codebirdsn.php';
 
@@ -1038,44 +1059,40 @@ function statusnet_fetchuser(App $a, $uid, $screen_name = "", $user_id = "")
        $r = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
                intval($uid));
 
-       if (count($r)) {
+       if(count($r)) {
                $self = $r[0];
-       } else {
+       } else
                return;
-       }
 
-       $parameters = [];
+       $parameters = array();
 
-       if ($screen_name != "") {
+       if ($screen_name != "")
                $parameters["screen_name"] = $screen_name;
-       }
 
-       if ($user_id != "") {
+       if ($user_id != "")
                $parameters["user_id"] = $user_id;
-       }
 
        // Fetching user data
        $user = $cb->users_show($parameters);
 
-       if (!is_object($user)) {
+       if (!is_object($user))
                return;
-       }
 
        $contact_id = statusnet_fetch_contact($uid, $user, true);
 
        return $contact_id;
 }
 
-function statusnet_createpost(App $a, $uid, $post, $self, $create_user, $only_existing_contact)
-{
-       require_once "include/html2bbcode.php";
+function statusnet_createpost($a, $uid, $post, $self, $create_user, $only_existing_contact) {
+
+       require_once("include/html2bbcode.php");
 
        logger("statusnet_createpost: start", LOGGER_DEBUG);
 
-       $api = PConfig::get($uid, 'statusnet', 'baseapi');
+       $api = get_pconfig($uid, 'statusnet', 'baseapi');
        $hostname = preg_replace("=https?://([\w\.]*)/.*=ism", "$1", $api);
 
-       $postarray = [];
+       $postarray = array();
        $postarray['network'] = NETWORK_STATUSNET;
        $postarray['gravity'] = 0;
        $postarray['uid'] = $uid;
@@ -1084,31 +1101,29 @@ function statusnet_createpost(App $a, $uid, $post, $self, $create_user, $only_ex
        if (is_object($post->retweeted_status)) {
                $content = $post->retweeted_status;
                statusnet_fetch_contact($uid, $content->user, false);
-       } else {
+       } else
                $content = $post;
-       }
 
-       $postarray['uri'] = $hostname . "::" . $content->id;
+       $postarray['uri'] = $hostname."::".$content->id;
 
        $r = q("SELECT * FROM `item` WHERE `extid` = '%s' AND `uid` = %d LIMIT 1",
                        dbesc($postarray['uri']),
                        intval($uid)
-       );
+               );
 
-       if (count($r)) {
-               return [];
-       }
+       if (count($r))
+               return(array());
 
        $contactid = 0;
 
        if ($content->in_reply_to_status_id != "") {
 
-               $parent = $hostname . "::" . $content->in_reply_to_status_id;
+               $parent = $hostname."::".$content->in_reply_to_status_id;
 
                $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
                                dbesc($parent),
                                intval($uid)
-               );
+                       );
                if (count($r)) {
                        $postarray['thr-parent'] = $r[0]["uri"];
                        $postarray['parent-uri'] = $r[0]["parent-uri"];
@@ -1118,7 +1133,7 @@ function statusnet_createpost(App $a, $uid, $post, $self, $create_user, $only_ex
                        $r = q("SELECT * FROM `item` WHERE `extid` = '%s' AND `uid` = %d LIMIT 1",
                                        dbesc($parent),
                                        intval($uid)
-                       );
+                               );
                        if (count($r)) {
                                $postarray['thr-parent'] = $r[0]['uri'];
                                $postarray['parent-uri'] = $r[0]['parent-uri'];
@@ -1132,21 +1147,20 @@ function statusnet_createpost(App $a, $uid, $post, $self, $create_user, $only_ex
                }
 
                // Is it me?
-               $own_url = PConfig::get($uid, 'statusnet', 'own_url');
+               $own_url = get_pconfig($uid, 'statusnet', 'own_url');
 
                if ($content->user->id == $own_url) {
                        $r = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
                                intval($uid));
 
-                       if (count($r)) {
+                       if(count($r)) {
                                $contactid = $r[0]["id"];
 
-                               $postarray['owner-name'] = $r[0]["name"];
+                               $postarray['owner-name'] =  $r[0]["name"];
                                $postarray['owner-link'] = $r[0]["url"];
-                               $postarray['owner-avatar'] = $r[0]["photo"];
-                       } else {
-                               return [];
-                       }
+                               $postarray['owner-avatar'] =  $r[0]["photo"];
+                       } else
+                               return(array());
                }
                // Don't create accounts of people who just comment something
                $create_user = false;
@@ -1161,11 +1175,10 @@ function statusnet_createpost(App $a, $uid, $post, $self, $create_user, $only_ex
                $postarray['owner-link'] = $post->user->statusnet_profile_url;
                $postarray['owner-avatar'] = $post->user->profile_image_url;
        }
-       if (($contactid == 0) && !$only_existing_contact) {
+       if(($contactid == 0) && !$only_existing_contact)
                $contactid = $self['id'];
-       } elseif ($contactid <= 0) {
-               return [];
-       }
+       elseif ($contactid <= 0)
+               return(array());
 
        $postarray['contact-id'] = $contactid;
 
@@ -1176,9 +1189,9 @@ function statusnet_createpost(App $a, $uid, $post, $self, $create_user, $only_ex
        $postarray['author-avatar'] = $content->user->profile_image_url;
 
        // To-Do: Maybe unreliable? Can the api be entered without trailing "/"?
-       $hostname = str_replace("/api/", "/notice/", PConfig::get($uid, 'statusnet', 'baseapi'));
+       $hostname = str_replace("/api/", "/notice/", get_pconfig($uid, 'statusnet', 'baseapi'));
 
-       $postarray['plink'] = $hostname . $content->id;
+       $postarray['plink'] = $hostname.$content->id;
        $postarray['app'] = strip_tags($content->source);
 
        if ($content->user->protected) {
@@ -1195,75 +1208,82 @@ function statusnet_createpost(App $a, $uid, $post, $self, $create_user, $only_ex
        $postarray['created'] = DateTimeFormat::utc($content->created_at);
        $postarray['edited'] = DateTimeFormat::utc($content->created_at);
 
-       if (is_string($content->place->name)) {
+       if (is_string($content->place->name))
                $postarray["location"] = $content->place->name;
-       }
 
-       if (is_string($content->place->full_name)) {
+       if (is_string($content->place->full_name))
                $postarray["location"] = $content->place->full_name;
-       }
 
-       if (is_array($content->geo->coordinates)) {
-               $postarray["coord"] = $content->geo->coordinates[0] . " " . $content->geo->coordinates[1];
-       }
+       if (is_array($content->geo->coordinates))
+               $postarray["coord"] = $content->geo->coordinates[0]." ".$content->geo->coordinates[1];
 
-       if (is_array($content->coordinates->coordinates)) {
-               $postarray["coord"] = $content->coordinates->coordinates[1] . " " . $content->coordinates->coordinates[0];
-       }
+       if (is_array($content->coordinates->coordinates))
+               $postarray["coord"] = $content->coordinates->coordinates[1]." ".$content->coordinates->coordinates[0];
 
-       logger("statusnet_createpost: end", LOGGER_DEBUG);
+       /*if (is_object($post->retweeted_status)) {
+               $postarray['body'] = html2bbcode($post->retweeted_status->statusnet_html);
+
+               $converted = statusnet_convertmsg($a, $postarray['body'], false);
+               $postarray['body'] = $converted["body"];
+               $postarray['tag'] = $converted["tags"];
+
+               statusnet_fetch_contact($uid, $post->retweeted_status->user, false);
 
-       return $postarray;
+               // Let retweets look like wall-to-wall posts
+               $postarray['author-name'] = $post->retweeted_status->user->name;
+               $postarray['author-link'] = $post->retweeted_status->user->statusnet_profile_url;
+               $postarray['author-avatar'] = $post->retweeted_status->user->profile_image_url;
+       }*/
+       logger("statusnet_createpost: end", LOGGER_DEBUG);
+       return($postarray);
 }
 
-function statusnet_checknotification(App $a, $uid, $own_url, $top_item, $postarray)
-{
+function statusnet_checknotification($a, $uid, $own_url, $top_item, $postarray) {
+
        // This function necer worked and need cleanup
+
        $user = q("SELECT * FROM `contact` WHERE `uid` = %d AND `self` LIMIT 1",
                        intval($uid)
-       );
+               );
 
-       if (!count($user)) {
+       if(!count($user))
                return;
-       }
 
        // Is it me?
-       if (link_compare($user[0]["url"], $postarray['author-link'])) {
+       if (link_compare($user[0]["url"], $postarray['author-link']))
                return;
-       }
 
        $own_user = q("SELECT * FROM `contact` WHERE `uid` = %d AND `alias` = '%s' LIMIT 1",
                        intval($uid),
                        dbesc($own_url)
-       );
+               );
 
-       if (!count($own_user)) {
+       if(!count($own_user))
                return;
-       }
 
        // Is it me from GNU Social?
-       if (link_compare($own_user[0]["url"], $postarray['author-link'])) {
+       if (link_compare($own_user[0]["url"], $postarray['author-link']))
                return;
-       }
 
        $myconv = q("SELECT `author-link`, `author-avatar`, `parent` FROM `item` WHERE `parent-uri` = '%s' AND `uid` = %d AND `parent` != 0 AND `deleted` = 0",
                        dbesc($postarray['parent-uri']),
                        intval($uid)
-       );
+                       );
 
-       if (count($myconv)) {
-               foreach ($myconv as $conv) {
+       if(count($myconv)) {
+
+               foreach($myconv as $conv) {
                        // now if we find a match, it means we're in this conversation
-                       if (!link_compare($conv['author-link'], $user[0]["url"]) && !link_compare($conv['author-link'], $own_user[0]["url"])) {
+
+                       if(!link_compare($conv['author-link'],$user[0]["url"]) && !link_compare($conv['author-link'],$own_user[0]["url"]))
                                continue;
-                       }
 
-                       require_once 'include/enotify.php';
+                       require_once('include/enotify.php');
 
                        $conv_parent = $conv['parent'];
 
-                       notification([
-                               'type' => NOTIFY_COMMENT,
+                       notification(array(
+                               'type'         => NOTIFY_COMMENT,
                                'notify_flags' => $user[0]['notify-flags'],
                                'language' => $user[0]['language'],
                                'to_name' => $user[0]['username'],
@@ -1274,10 +1294,10 @@ function statusnet_checknotification(App $a, $uid, $own_url, $top_item, $postarr
                                'source_name' => $postarray['author-name'],
                                'source_link' => $postarray['author-link'],
                                'source_photo' => $postarray['author-avatar'],
-                               'verb' => ACTIVITY_POST,
-                               'otype' => 'item',
-                               'parent' => $conv_parent,
-                       ]);
+                               'verb'         => ACTIVITY_POST,
+                               'otype'        => 'item',
+                               'parent'       => $conv_parent,
+                       ));
 
                        // only send one notification
                        break;
@@ -1285,25 +1305,24 @@ function statusnet_checknotification(App $a, $uid, $own_url, $top_item, $postarr
        }
 }
 
-function statusnet_fetchhometimeline(App $a, $uid, $mode = 1)
-{
-       $conversations = [];
+function statusnet_fetchhometimeline($a, $uid, $mode = 1) {
+       $conversations = array();
 
-       $ckey    = PConfig::get($uid, 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($uid, 'statusnet', 'consumersecret');
-       $api     = PConfig::get($uid, 'statusnet', 'baseapi');
-       $otoken  = PConfig::get($uid, 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($uid, 'statusnet', 'oauthsecret');
-       $create_user = PConfig::get($uid, 'statusnet', 'create_user');
+       $ckey    = get_pconfig($uid, 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($uid, 'statusnet', 'consumersecret');
+       $api     = get_pconfig($uid, 'statusnet', 'baseapi');
+       $otoken  = get_pconfig($uid, 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($uid, 'statusnet', 'oauthsecret');
+       $create_user = get_pconfig($uid, 'statusnet', 'create_user');
 
        // "create_user" is deactivated, since currently you cannot add users manually by now
        $create_user = true;
 
-       logger("statusnet_fetchhometimeline: Fetching for user " . $uid, LOGGER_DEBUG);
+       logger("statusnet_fetchhometimeline: Fetching for user ".$uid, LOGGER_DEBUG);
 
        require_once 'include/items.php';
 
-       $connection = new StatusNetOAuth($api, $ckey, $csecret, $otoken, $osecret);
+       $connection = new StatusNetOAuth($api, $ckey,$csecret,$otoken,$osecret);
 
        $own_contact = statusnet_fetch_own_contact($a, $uid);
 
@@ -1311,75 +1330,71 @@ function statusnet_fetchhometimeline(App $a, $uid, $mode = 1)
                intval($own_contact),
                intval($uid));
 
-       if (count($r)) {
+       if(count($r)) {
                $nick = $r[0]["nick"];
        } else {
-               logger("statusnet_fetchhometimeline: Own GNU Social contact not found for user " . $uid, LOGGER_DEBUG);
+               logger("statusnet_fetchhometimeline: Own GNU Social contact not found for user ".$uid, LOGGER_DEBUG);
                return;
        }
 
        $r = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
                intval($uid));
 
-       if (count($r)) {
+       if(count($r)) {
                $self = $r[0];
        } else {
-               logger("statusnet_fetchhometimeline: Own contact not found for user " . $uid, LOGGER_DEBUG);
+               logger("statusnet_fetchhometimeline: Own contact not found for user ".$uid, LOGGER_DEBUG);
                return;
        }
 
        $u = q("SELECT * FROM user WHERE uid = %d LIMIT 1",
                intval($uid));
-       if (!count($u)) {
-               logger("statusnet_fetchhometimeline: Own user not found for user " . $uid, LOGGER_DEBUG);
+       if(!count($u)) {
+               logger("statusnet_fetchhometimeline: Own user not found for user ".$uid, LOGGER_DEBUG);
                return;
        }
 
-       $parameters = ["exclude_replies" => false, "trim_user" => false, "contributor_details" => true, "include_rts" => true];
+       $parameters = array("exclude_replies" => false, "trim_user" => false, "contributor_details" => true, "include_rts" => true);
        //$parameters["count"] = 200;
 
        if ($mode == 1) {
                // Fetching timeline
-               $lastid = PConfig::get($uid, 'statusnet', 'lasthometimelineid');
+               $lastid  = get_pconfig($uid, 'statusnet', 'lasthometimelineid');
                //$lastid = 1;
 
                $first_time = ($lastid == "");
 
-               if ($lastid != "") {
+               if ($lastid <> "")
                        $parameters["since_id"] = $lastid;
-               }
 
                $items = $connection->get('statuses/home_timeline', $parameters);
 
                if (!is_array($items)) {
-                       if (is_object($items) && isset($items->error)) {
+                       if (is_object($items) && isset($items->error))
                                $errormsg = $items->error;
-                       } elseif (is_object($items)) {
+                       elseif (is_object($items))
                                $errormsg = print_r($items, true);
-                       } elseif (is_string($items) || is_float($items) || is_int($items)) {
+                       elseif (is_string($items) || is_float($items) || is_int($items))
                                $errormsg = $items;
-                       } else {
+                       else
                                $errormsg = "Unknown error";
-                       }
 
-                       logger("statusnet_fetchhometimeline: Error fetching home timeline: " . $errormsg, LOGGER_DEBUG);
+                       logger("statusnet_fetchhometimeline: Error fetching home timeline: ".$errormsg, LOGGER_DEBUG);
                        return;
                }
 
                $posts = array_reverse($items);
 
-               logger("statusnet_fetchhometimeline: Fetching timeline for user " . $uid . " " . sizeof($posts) . " items", LOGGER_DEBUG);
+               logger("statusnet_fetchhometimeline: Fetching timeline for user ".$uid." ".sizeof($posts)." items", LOGGER_DEBUG);
 
                if (count($posts)) {
                        foreach ($posts as $post) {
 
-                               if ($post->id > $lastid) {
+                               if ($post->id > $lastid)
                                        $lastid = $post->id;
-                               }
 
-                               if ($first_time) {
+                               if ($first_time)
                                        continue;
-                               }
 
                                if (isset($post->statusnet_conversation_id)) {
                                        if (!isset($conversations[$post->statusnet_conversation_id])) {
@@ -1389,52 +1404,48 @@ function statusnet_fetchhometimeline(App $a, $uid, $mode = 1)
                                } else {
                                        $postarray = statusnet_createpost($a, $uid, $post, $self, $create_user, true);
 
-                                       if (trim($postarray['body']) == "") {
+                                       if (trim($postarray['body']) == "")
                                                continue;
-                                       }
 
                                        $item = Item::insert($postarray);
                                        $postarray["id"] = $item;
 
-                                       logger('statusnet_fetchhometimeline: User ' . $self["nick"] . ' posted home timeline item ' . $item);
+                                       logger('statusnet_fetchhometimeline: User '.$self["nick"].' posted home timeline item '.$item);
 
-                                       if ($item && !function_exists("check_item_notification")) {
+                                       if ($item && !function_exists("check_item_notification"))
                                                statusnet_checknotification($a, $uid, $nick, $item, $postarray);
-                                       }
                                }
+
                        }
                }
-               PConfig::set($uid, 'statusnet', 'lasthometimelineid', $lastid);
+               set_pconfig($uid, 'statusnet', 'lasthometimelineid', $lastid);
        }
 
        // Fetching mentions
-       $lastid = PConfig::get($uid, 'statusnet', 'lastmentionid');
+       $lastid  = get_pconfig($uid, 'statusnet', 'lastmentionid');
        $first_time = ($lastid == "");
 
-       if ($lastid != "") {
+       if ($lastid <> "")
                $parameters["since_id"] = $lastid;
-       }
 
        $items = $connection->get('statuses/mentions_timeline', $parameters);
 
        if (!is_array($items)) {
-               logger("statusnet_fetchhometimeline: Error fetching mentions: " . print_r($items, true), LOGGER_DEBUG);
+               logger("statusnet_fetchhometimeline: Error fetching mentions: ".print_r($items, true), LOGGER_DEBUG);
                return;
        }
 
        $posts = array_reverse($items);
 
-       logger("statusnet_fetchhometimeline: Fetching mentions for user " . $uid . " " . sizeof($posts) . " items", LOGGER_DEBUG);
+       logger("statusnet_fetchhometimeline: Fetching mentions for user ".$uid." ".sizeof($posts)." items", LOGGER_DEBUG);
 
        if (count($posts)) {
                foreach ($posts as $post) {
-                       if ($post->id > $lastid) {
+                       if ($post->id > $lastid)
                                $lastid = $post->id;
-                       }
 
-                       if ($first_time) {
+                       if ($first_time)
                                continue;
-                       }
 
                        $postarray = statusnet_createpost($a, $uid, $post, $self, false, false);
 
@@ -1444,17 +1455,16 @@ function statusnet_fetchhometimeline(App $a, $uid, $mode = 1)
                                        $conversations[$post->statusnet_conversation_id] = $post->statusnet_conversation_id;
                                }
                        } else {
-                               if (trim($postarray['body']) == "") {
+                               if (trim($postarray['body']) != "") {
                                        continue;
-                               }
 
                                $item = Item::insert($postarray);
                                $postarray["id"] = $item;
 
-                               logger('statusnet_fetchhometimeline: User ' . $self["nick"] . ' posted mention timeline item ' . $item);
+                                       logger('statusnet_fetchhometimeline: User '.$self["nick"].' posted mention timeline item '.$item);
 
-                               if ($item && function_exists("check_item_notification")) {
-                                       check_item_notification($item, $uid, NOTIFY_TAGSELF);
+                                       if ($item && function_exists("check_item_notification"))
+                                               check_item_notification($item, $uid, NOTIFY_TAGSELF);
                                }
                        }
 
@@ -1468,8 +1478,8 @@ function statusnet_fetchhometimeline(App $a, $uid, $mode = 1)
                        }
 
                        if (($item != 0) && !function_exists("check_item_notification")) {
-                               require_once 'include/enotify.php';
-                               notification([
+                               require_once('include/enotify.php');
+                               notification(array(
                                        'type'         => NOTIFY_TAGSELF,
                                        'notify_flags' => $u[0]['notify-flags'],
                                        'language'     => $u[0]['language'],
@@ -1484,46 +1494,43 @@ function statusnet_fetchhometimeline(App $a, $uid, $mode = 1)
                                        'verb'         => ACTIVITY_TAG,
                                        'otype'        => 'item',
                                        'parent'       => $parent_id,
-                               ]);
+                               ));
                        }
                }
        }
 
-       PConfig::set($uid, 'statusnet', 'lastmentionid', $lastid);
+       set_pconfig($uid, 'statusnet', 'lastmentionid', $lastid);
 }
 
-function statusnet_complete_conversation(App $a, $uid, $self, $create_user, $nick, $conversation)
-{
-       $ckey    = PConfig::get($uid, 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($uid, 'statusnet', 'consumersecret');
-       $api     = PConfig::get($uid, 'statusnet', 'baseapi');
-       $otoken  = PConfig::get($uid, 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($uid, 'statusnet', 'oauthsecret');
-       $own_url = PConfig::get($uid, 'statusnet', 'own_url');
+function statusnet_complete_conversation($a, $uid, $self, $create_user, $nick, $conversation) {
+       $ckey    = get_pconfig($uid, 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($uid, 'statusnet', 'consumersecret');
+       $api     = get_pconfig($uid, 'statusnet', 'baseapi');
+       $otoken  = get_pconfig($uid, 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($uid, 'statusnet', 'oauthsecret');
+       $own_url = get_pconfig($uid, 'statusnet', 'own_url');
 
        $connection = new StatusNetOAuth($api, $ckey, $csecret, $otoken, $osecret);
 
        $parameters["count"] = 200;
 
-       $items = $connection->get('statusnet/conversation/' . $conversation, $parameters);
+       $items = $connection->get('statusnet/conversation/'.$conversation, $parameters);
        if (is_array($items)) {
                $posts = array_reverse($items);
 
                foreach ($posts as $post) {
                        $postarray = statusnet_createpost($a, $uid, $post, $self, false, false);
 
-                       if (trim($postarray['body']) == "") {
+                       if (trim($postarray['body']) == "")
                                continue;
-                       }
 
                        $item = Item::insert($postarray);
                        $postarray["id"] = $item;
 
-                       logger('statusnet_complete_conversation: User ' . $self["nick"] . ' posted home timeline item ' . $item);
+                       logger('statusnet_complete_conversation: User '.$self["nick"].' posted home timeline item '.$item);
 
-                       if ($item && !function_exists("check_item_notification")) {
+                       if ($item && !function_exists("check_item_notification"))
                                statusnet_checknotification($a, $uid, $nick, $item, $postarray);
-                       }
                }
        }
 }
@@ -1532,10 +1539,10 @@ function statusnet_convertmsg(App $a, $body, $no_tags = false)
 {
        require_once "include/items.php";
 
-       $body = preg_replace("=\[url\=https?://([0-9]*).([0-9]*).([0-9]*).([0-9]*)/([0-9]*)\](.*?)\[\/url\]=ism", "$1.$2.$3.$4/$5", $body);
+       $body = preg_replace("=\[url\=https?://([0-9]*).([0-9]*).([0-9]*).([0-9]*)/([0-9]*)\](.*?)\[\/url\]=ism","$1.$2.$3.$4/$5",$body);
 
        $URLSearchString = "^\[\]";
-       $links = preg_match_all("/[^!#@]\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism", $body, $matches, PREG_SET_ORDER);
+       $links = preg_match_all("/[^!#@]\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism", $body,$matches,PREG_SET_ORDER);
 
        $footer = "";
        $footerurl = "";
@@ -1544,27 +1551,25 @@ function statusnet_convertmsg(App $a, $body, $no_tags = false)
 
        if ($links) {
                foreach ($matches AS $match) {
-                       $search = "[url=" . $match[1] . "]" . $match[2] . "[/url]";
+                       $search = "[url=".$match[1]."]".$match[2]."[/url]";
 
-                       logger("statusnet_convertmsg: expanding url " . $match[1], LOGGER_DEBUG);
+                       logger("statusnet_convertmsg: expanding url ".$match[1], LOGGER_DEBUG);
 
                        $expanded_url = Network::finalUrl($match[1]);
 
-                       logger("statusnet_convertmsg: fetching data for " . $expanded_url, LOGGER_DEBUG);
+                       logger("statusnet_convertmsg: fetching data for ".$expanded_url, LOGGER_DEBUG);
 
-                       $oembed_data = OEmbed::fetchURL($expanded_url, true);
+                       $oembed_data = oembed_fetch_url($expanded_url, true);
 
                        logger("statusnet_convertmsg: fetching data: done", LOGGER_DEBUG);
 
-                       if ($type == "") {
+                       if ($type == "")
                                $type = $oembed_data->type;
-                       }
-
                        if ($oembed_data->type == "video") {
                                //$body = str_replace($search, "[video]".$expanded_url."[/video]", $body);
                                $type = $oembed_data->type;
                                $footerurl = $expanded_url;
-                               $footerlink = "[url=" . $expanded_url . "]" . $expanded_url . "[/url]";
+                               $footerlink = "[url=".$expanded_url."]".$expanded_url."[/url]";
 
                                $body = str_replace($search, $footerlink, $body);
                        } elseif (($oembed_data->type == "photo") && isset($oembed_data->url) && !$dontincludemedia) {
@@ -1581,72 +1586,67 @@ function statusnet_convertmsg(App $a, $body, $no_tags = false)
 
                                if (substr($mime, 0, 6) == "image/") {
                                        $type = "photo";
-                                       $body = str_replace($search, "[img]" . $expanded_url . "[/img]", $body);
+                                       $body = str_replace($search, "[img]".$expanded_url."[/img]", $body);
                                } else {
                                        $type = $oembed_data->type;
                                        $footerurl = $expanded_url;
-                                       $footerlink = "[url=" . $expanded_url . "]" . $expanded_url . "[/url]";
+                                       $footerlink = "[url=".$expanded_url."]".$expanded_url."[/url]";
 
                                        $body = str_replace($search, $footerlink, $body);
                                }
                        }
                }
 
-               if ($footerurl != "") {
+               if ($footerurl != "")
                        $footer = add_page_info($footerurl);
-               }
 
                if (($footerlink != "") && (trim($footer) != "")) {
                        $removedlink = trim(str_replace($footerlink, "", $body));
 
-                       if (($removedlink == "") || strstr($body, $removedlink)) {
+                       if (($removedlink == "") || strstr($body, $removedlink))
                                $body = $removedlink;
-                       }
 
                        $body .= $footer;
                }
        }
 
-       if ($no_tags) {
-               return ["body" => $body, "tags" => ""];
-       }
+       if ($no_tags)
+               return(array("body" => $body, "tags" => ""));
 
        $str_tags = '';
 
-       $cnt = preg_match_all("/([!#@])\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism", $body, $matches, PREG_SET_ORDER);
-       if ($cnt) {
-               foreach ($matches as $mtch) {
-                       if (strlen($str_tags)) {
+       $cnt = preg_match_all("/([!#@])\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism",$body,$matches,PREG_SET_ORDER);
+       if($cnt) {
+               foreach($matches as $mtch) {
+                       if(strlen($str_tags))
                                $str_tags .= ',';
-                       }
 
                        if ($mtch[1] == "#") {
                                // Replacing the hash tags that are directed to the GNU Social server with internal links
-                               $snhash = "#[url=" . $mtch[2] . "]" . $mtch[3] . "[/url]";
-                               $frdchash = '#[url=' . $a->get_baseurl() . '/search?tag=' . rawurlencode($mtch[3]) . ']' . $mtch[3] . '[/url]';
+                               $snhash = "#[url=".$mtch[2]."]".$mtch[3]."[/url]";
+                               $frdchash = '#[url='.$a->get_baseurl().'/search?tag='.rawurlencode($mtch[3]).']'.$mtch[3].'[/url]';
                                $body = str_replace($snhash, $frdchash, $body);
 
                                $str_tags .= $frdchash;
-                       } else {
-                               $str_tags .= "@[url=" . $mtch[2] . "]" . $mtch[3] . "[/url]";
-                       }
-                       // To-Do:
-                       // There is a problem with links with to GNU Social groups, so these links are stored with "@" like friendica groups
-                       //$str_tags .= $mtch[1]."[url=".$mtch[2]."]".$mtch[3]."[/url]";
+                       } else
+                               $str_tags .= "@[url=".$mtch[2]."]".$mtch[3]."[/url]";
+                               // To-Do:
+                               // There is a problem with links with to GNU Social groups, so these links are stored with "@" like friendica groups
+                               //$str_tags .= $mtch[1]."[url=".$mtch[2]."]".$mtch[3]."[/url]";
                }
        }
 
-       return ["body" => $body, "tags" => $str_tags];
+       return(array("body"=>$body, "tags"=>$str_tags));
+
 }
 
-function statusnet_fetch_own_contact(App $a, $uid)
-{
-       $ckey    = PConfig::get($uid, 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($uid, 'statusnet', 'consumersecret');
-       $api     = PConfig::get($uid, 'statusnet', 'baseapi');
-       $otoken  = PConfig::get($uid, 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($uid, 'statusnet', 'oauthsecret');
-       $own_url = PConfig::get($uid, 'statusnet', 'own_url');
+function statusnet_fetch_own_contact($a, $uid) {
+       $ckey    = get_pconfig($uid, 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($uid, 'statusnet', 'consumersecret');
+       $api     = get_pconfig($uid, 'statusnet', 'baseapi');
+       $otoken  = get_pconfig($uid, 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($uid, 'statusnet', 'oauthsecret');
+       $own_url = get_pconfig($uid, 'statusnet', 'own_url');
 
        $contact_id = 0;
 
@@ -1656,73 +1656,66 @@ function statusnet_fetch_own_contact(App $a, $uid)
                // Fetching user data
                $user = $connection->get('account/verify_credentials');
 
-               PConfig::set($uid, 'statusnet', 'own_url', normalise_link($user->statusnet_profile_url));
+               set_pconfig($uid, 'statusnet', 'own_url', normalise_link($user->statusnet_profile_url));
 
                $contact_id = statusnet_fetch_contact($uid, $user, true);
+
        } else {
                $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `alias` = '%s' LIMIT 1",
                        intval($uid), dbesc($own_url));
-               if (count($r)) {
+               if(count($r))
                        $contact_id = $r[0]["id"];
-               } else {
-                       PConfig::delete($uid, 'statusnet', 'own_url');
-               }
+               else
+                       del_pconfig($uid, 'statusnet', 'own_url');
+
        }
-       return $contact_id;
+       return($contact_id);
 }
 
-function statusnet_is_retweet(App $a, $uid, $body)
-{
+function statusnet_is_retweet($a, $uid, $body) {
        $body = trim($body);
 
        // Skip if it isn't a pure repeated messages
        // Does it start with a share?
-       if (strpos($body, "[share") > 0) {
-               return false;
-       }
+       if (strpos($body, "[share") > 0)
+               return(false);
 
        // Does it end with a share?
-       if (strlen($body) > (strrpos($body, "[/share]") + 8)) {
-               return false;
-       }
+       if (strlen($body) > (strrpos($body, "[/share]") + 8))
+               return(false);
 
-       $attributes = preg_replace("/\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism", "$1", $body);
+       $attributes = preg_replace("/\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism","$1",$body);
        // Skip if there is no shared message in there
-       if ($body == $attributes) {
-               return false;
-       }
+       if ($body == $attributes)
+               return(false);
 
        $link = "";
        preg_match("/link='(.*?)'/ism", $attributes, $matches);
-       if ($matches[1] != "") {
+       if ($matches[1] != "")
                $link = $matches[1];
-       }
 
        preg_match('/link="(.*?)"/ism', $attributes, $matches);
-       if ($matches[1] != "") {
+       if ($matches[1] != "")
                $link = $matches[1];
-       }
 
-       $ckey    = PConfig::get($uid, 'statusnet', 'consumerkey');
-       $csecret = PConfig::get($uid, 'statusnet', 'consumersecret');
-       $api     = PConfig::get($uid, 'statusnet', 'baseapi');
-       $otoken  = PConfig::get($uid, 'statusnet', 'oauthtoken');
-       $osecret = PConfig::get($uid, 'statusnet', 'oauthsecret');
+       $ckey    = get_pconfig($uid, 'statusnet', 'consumerkey');
+       $csecret = get_pconfig($uid, 'statusnet', 'consumersecret');
+       $api     = get_pconfig($uid, 'statusnet', 'baseapi');
+       $otoken  = get_pconfig($uid, 'statusnet', 'oauthtoken');
+       $osecret = get_pconfig($uid, 'statusnet', 'oauthsecret');
        $hostname = preg_replace("=https?://([\w\.]*)/.*=ism", "$1", $api);
 
-       $id = preg_replace("=https?://" . $hostname . "/notice/(.*)=ism", "$1", $link);
+       $id = preg_replace("=https?://".$hostname."/notice/(.*)=ism", "$1", $link);
 
-       if ($id == $link) {
-               return false;
-       }
+       if ($id == $link)
+               return(false);
 
-       logger('statusnet_is_retweet: Retweeting id ' . $id . ' for user ' . $uid, LOGGER_DEBUG);
-
-       $connection = new StatusNetOAuth($api, $ckey, $csecret, $otoken, $osecret);
+       logger('statusnet_is_retweet: Retweeting id '.$id.' for user '.$uid, LOGGER_DEBUG);
 
-       $result = $connection->post('statuses/retweet/' . $id);
+       $connection = new StatusNetOAuth($api, $ckey,$csecret,$otoken,$osecret);
 
-       logger('statusnet_is_retweet: result ' . print_r($result, true), LOGGER_DEBUG);
+       $result = $connection->post('statuses/retweet/'.$id);
 
-       return isset($result->id);
+       logger('statusnet_is_retweet: result '.print_r($result, true), LOGGER_DEBUG);
+       return(isset($result->id));
 }