TODOs.txt updated
[mailer.git] / DOCS / TODOs.txt
index cdaf36a4e3ccd0aa22378d5e50bbfb52a4bbe3aa..16610f0de0e7d1d771d9c9e17526024f9ffaf240 100644 (file)
@@ -6,7 +6,9 @@
 ./inc/autopurge/purge-inact.php:55:    // @TODO Rewrite these if() blocks to a filter
 ./inc/cache/config-local.php:124:// @TODO Rewrite the following three constants, somehow...
 ./inc/classes/cachesystem.class.php:501:       // @TODO Add support for more types which break in last else-block
-./inc/config-functions.php:139:        // @TODO Make this all better... :-/
+./inc/config-functions.php:136:        // @TODO Make this all better... :-/
+./inc/daily/daily_beg.php:52:// @TODO This should be converted in a daily beg rallye
+./inc/daily/daily_birthday.php:92:                     // @TODO 4 is hard-coded here, should we move it out in config?
 ./inc/expression-functions.php:164:// @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again
 ./inc/expression-functions.php:46:     // @TODO is escapeQuotes() enougth for strings with single/double quotes?
 ./inc/extensions/ext-html_mail.php:136:                // @TODO Move these arrays into config
@@ -33,7 +35,7 @@
 ./inc/extensions/ext-network.php:37: * @TODO Yoo!Media: What is LayerAd compared to Layer click?            *
 ./inc/extensions/ext-network.php:91:           // @TODO network_type_handle is an internal name and needs documentation
 ./inc/extensions/ext-newsletter.php:218:               // @TODO Move these into configuration
-./inc/extensions/ext-order.php:335:            // @TODO This should be moved out to inc/reset/
+./inc/extensions/ext-order.php:336:            // @TODO This should be moved out to inc/daily/
 ./inc/extensions/ext-rallye.php:329:           // @TODO Move this code into rallye_functions.php
 ./inc/extensions/ext-rallye.php:92:            // @TODO Fix config_rallye_prices to list_rallye_prices
 ./inc/extensions/ext-yoomedia.php:121:         // @TODO Can this be moved into a database table?
 ./inc/extensions-functions.php:434:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) )
 ./inc/extensions-functions.php:564:            // @TODO Extension is loaded, what next?
 ./inc/functions.php:110:               // @TODO Extension 'msg' does not exist
-./inc/functions.php:1505:                      // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
-./inc/functions.php:1593:                      // @TODO Are these convertions still required?
-./inc/functions.php:1611:// @TODO Rewrite this function to use readFromFile() and writeToFile()
+./inc/functions.php:1512:                      // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
+./inc/functions.php:1600:                      // @TODO Are these convertions still required?
+./inc/functions.php:1618:// @TODO Rewrite this function to use readFromFile() and writeToFile()
 ./inc/functions.php:181:// @TODO Rewrite this to an extension 'smtp'
-./inc/functions.php:2269:      // @TODO This is still very static, rewrite it somehow
+./inc/functions.php:2191:      // @TODO Find a way to cache this
+./inc/functions.php:2292:      // @TODO This is still very static, rewrite it somehow
+./inc/functions.php:2472:      // @TODO Rename column data_type to e.g. mail_status
 ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter
 ./inc/install-functions.php:57:        // @TODO DEACTIVATED: changeDataInInclude(getCachePath() . 'config-local.php', 'OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestParameter('omode'), 0);
-./inc/language/de.php:1085:// @TODO Rewrite these two constants
-./inc/language/de.php:1100:// @TODO Rewrite these three constants
-./inc/language/de.php:280:     // @TODO Following two are unused?
-./inc/language/de.php:784:// @TODO Are these constants longer used?
-./inc/language-functions.php:243:      // @TODO These are all valid languages, again hard-coded
+./inc/language/de.php:1083:    // @TODO Rewrite these two constants
+./inc/language/de.php:1104:    // @TODO Rewrite these three constants
+./inc/language/de.php:779:// @TODO Are these constants longer used?
+./inc/language-functions.php:250:      // @TODO These are all valid languages, again hard-coded
 ./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function.
 ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no       *
 ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings             *
 ./inc/language/refback_de.php:44:// @TODO Rewrite these constants to one
 ./inc/language/sponsor_de.php:117:// @TODO Rewrite these four constants to one and use sprintf()
-./inc/libs/admins_functions.php:433:           // @TODO This can be, somehow, rewritten
+./inc/libs/admins_functions.php:435:           // @TODO This can be, somehow, rewritten
 ./inc/libs/beg_functions.php:55:               // @TODO Try to rewrite the following unset()
-./inc/libs/bonus_functions.php:199:            // @TODO Move this HTML to a template
-./inc/libs/bonus_functions.php:287:            // @TODO This query isn't right, it will only update if the user was for a longer time away!
+./inc/libs/bonus_functions.php:201:            // @TODO Move this HTML to a template
+./inc/libs/bonus_functions.php:293:            // @TODO This query isn't right, it will only update if the user was for a longer time away!
 ./inc/libs/cache_functions.php:78:             // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal.
 ./inc/libs/doubler_functions.php:44:// @TODO Lame description
 ./inc/libs/doubler_functions.php:91:                   // @TODO Can't this be moved into EL?
 ./inc/libs/user_functions.php:611:                                     // @TODO Try to rewrite the following unset()
 ./inc/libs/yoomedia_functions.php:114: $response = YOOMEDIA_QUERY_API('out_textmail.php', true); // @TODO Ask Yoo!Media for test script
 ./inc/load_config.php:75:      // @TODO Rewrite them to avoid this else block
-./inc/loader/load_cache-extension.php:13: * @TODO Rewrite this whole file to load_cache-extensions.php           *
+./inc/loader/load-extension.php:13: * @TODO Rewrite this whole file                                        *
 ./inc/module-functions.php:267:                        // @TODO Nothing helped???
 ./inc/module-functions.php:308:                        // @TODO Rewrite this to a filter
-./inc/modules/admin/admin-inc.php:262:         // @TODO Rewrite this to $content = SQL_FETCHARRAY()
-./inc/modules/admin/admin-inc.php:267:                         // @TODO ACL is 'allow'... hmmm
-./inc/modules/admin/admin-inc.php:333:                                 // @TODO Rewrite this to $content = SQL_FETCHARRAY()
-./inc/modules/admin/admin-inc.php:339:                                                 // @TODO ACL is 'allow'... hmmm
-./inc/modules/admin/admin-inc.php:439:// @TODO Try to rewrite this to adminAddMenuSelectionBox()
+./inc/modules/admin/admin-inc.php:171:         // @TODO This and the next getCurrentAdminId() call might be moved into the templates?
+./inc/modules/admin/admin-inc.php:242:         // @TODO This can be rewritten into a filter
+./inc/modules/admin/admin-inc.php:274:         // @TODO Rewrite this to $content = SQL_FETCHARRAY()
+./inc/modules/admin/admin-inc.php:339:                                 // @TODO Rewrite this to $content = SQL_FETCHARRAY()
+./inc/modules/admin/admin-inc.php:437:// @TODO Try to rewrite this to adminAddMenuSelectionBox()
 ./inc/modules/admin/overview-inc.php:162:                              // @TODO Rewrite this to a filter
 ./inc/modules/admin/overview-inc.php:275:                              // @TODO Rewrite this to something with include files and/or filter
 ./inc/modules/admin/overview-inc.php:309:                                              // @TODO This may also be rewritten to include files
 ./inc/modules/admin/what-config_points.php:111:                        // @TODO Rewrite this to a filter
 ./inc/modules/admin/what-config_rallye_prices.php:195:                 // @TODO Rewrite these two constants
 ./inc/modules/admin/what-config_register.php:75:       // @TODO Move this HTML code into a template
-./inc/modules/admin/what-del_email.php:60:             // @TODO Unused: $price = getPaymentPoints($content['payment_id'], 'price');
 ./inc/modules/admin/what-del_email.php:61:             // @TODO Unused: cat_id, payment_id
 ./inc/modules/admin/what-edit_user.php:18: * @TODO Add support for ext-country                                    *
 ./inc/modules/admin/what-email_stats.php:46:// @TODO Unused at the moment
 ./inc/modules/admin/what-list_links.php:85:                            // @TODO Find a way to rewrite this. See some lines above for different queries
 ./inc/modules/admin/what-list_links.php:94:                                    // @TODO Rewrite this to includes/filter
 ./inc/modules/admin/what-list_refs.php:107:                                                            // @TODO Try to rewrite some to EL
-./inc/modules/admin/what-list_unconfirmed.php:77:      // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}');
-./inc/modules/admin/what-list_unconfirmed.php:96:      // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
+./inc/modules/admin/what-list_unconfirmed.php:80:      // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}');
+./inc/modules/admin/what-list_unconfirmed.php:99:      // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
 ./inc/modules/admin/what-list_user.php:149:            // @TODO Rewrite these to filters
 ./inc/modules/admin/what-list_user.php:255:            // @TODO Rewrite this into a filter
 ./inc/modules/admin/what-list_user.php:295:                    // @TODO Rewrite this into a filter
 ./inc/modules/member/what-unconfirmed.php:206:                         // @TODO This 'userid' cannot be saved because of encapsulated EL code
 ./inc/modules/order.php:74:            // @TODO Unused: 2,4
 ./inc/monthly/monthly_bonus.php:67:    // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1183:  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1438:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
-./inc/mysql-manager.php:1544:  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1915:                  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1959:// @TODO Fix inconsistency between last_module and getWhat()
+./inc/mysql-manager.php:1195:  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1453:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
+./inc/mysql-manager.php:1559:  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1933:                  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1977:// @TODO Fix inconsistency between last_module and getWhat()
 ./inc/mysql-manager.php:368:   // @TODO Try to rewrite this to one or more functions
 ./inc/mysql-manager.php:44:// @TODO Can we cache this?
-./inc/reset/reset_beg.php:52:// @TODO This should be converted in a daily beg rallye
-./inc/reset/reset_birthday.php:92:                     // @TODO 4 is hard-coded here, should we move it out in config?
 ./inc/revision-functions.php:169:// @TODO This function does also set and get in 'cache_array'
-./inc/template-functions.php:1041:                     // @TODO Deprecate this thing
-./inc/template-functions.php:1052:                     // @TODO Deprecate this thing
-./inc/template-functions.php:1139:     // @TODO This can be easily moved out after the merge from EL branch to this is complete
-./inc/template-functions.php:1172:             // @TODO Add a little more infos here
-./inc/template-functions.php:1460:// @TODO Lame description for this function
-./inc/template-functions.php:1482:                     // @TODO Move this in a filter
-./inc/template-functions.php:187:       * @TODO On some pages this is buggy
-./inc/template-functions.php:263:      // @TODO Remove this sanity-check if all is fine
-./inc/template-functions.php:576:// @TODO $simple/$constants are deprecated
-./inc/template-functions.php:600:      // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates
+./inc/template-functions.php:1047:                     // @TODO Deprecate this thing
+./inc/template-functions.php:1058:                     // @TODO Deprecate this thing
+./inc/template-functions.php:1145:     // @TODO This can be easily moved out after the merge from EL branch to this is complete
+./inc/template-functions.php:1178:             // @TODO Add a little more infos here
+./inc/template-functions.php:1487:// @TODO Lame description for this function
+./inc/template-functions.php:1509:                     // @TODO Move this in a filter
+./inc/template-functions.php:189:       * @TODO On some pages this is buggy
+./inc/template-functions.php:265:      // @TODO Remove this sanity-check if all is fine
+./inc/template-functions.php:578:// @TODO $simple/$constants are deprecated
+./inc/template-functions.php:604:      // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates
 ./inc/wrapper-functions.php:130:// @TODO Implement $compress
 ./inc/wrapper-functions.php:137:// @TODO Implement $decompress
-./inc/wrapper-functions.php:452:// @TODO Do some more sanity check here
+./inc/wrapper-functions.php:489:// @TODO Do some more sanity check here
 ./mailid.php:139:                                      // @TODO Rewrite this to a filter
 ./mailid.php:96:               // @TODO Rewrite this to a filter
 ./mailid_top.php:103:          // @TODO Rewrite this to a filter
 ./view.php:68:         // @TODO No banner found, output some default banner
 ./templates/de/html/admin/admin_add_country.tpl:23:                    <!-- @TODO Rewrite this selection box to our generic functions //-->
 ./templates/de/html/admin/admin_admins_contct_form.tpl:4:      <!-- @TODO Shouldn't we add a title here? //-->
-./templates/de/html/admin/admin_config_other.tpl:67:                   <!-- @TODO Rewrite this selection to one of our functions //-->
+./templates/de/html/admin/admin_config_other.tpl:79:                   <!-- @TODO Rewrite this selection to one of our functions //-->
 ./templates/de/html/admin/admin_edit_admin_menu.tpl:4:<!-- @TODO Shouldn't we add a title here? //-->
 ./templates/de/html/admin/admin_edit_mods.tpl:4:       <!-- @TODO Shouldn't we add a title here? //-->
 ./templates/de/html/admin/admin_list_autopurge.tpl:2:  <!-- @TODO Shouldn't we add a title here? //-->
 ./templates/de/html/member/member_unconfirmed_table_nopoints.tpl:11:           <!-- @TODO Nothing to say here? //-->
 ./templates/de/html/surfbar/surfbar_frame_textlinks.tpl:5:             <!-- @TODO These are static lines and should be replaced by a filter (see ext-sponsor) //-->
 ### ### DEPRECATION FOLLOWS: ### ###
-./inc/modules/admin/admin-inc.php:440:// @DEPRECATED
+./inc/loader/load_cache-admin.php:2:// @DEPRECATED
+./inc/loader/load_cache-config.php:2:// @DEPRECATED
+./inc/loader/load_cache-extension.php:2:// @DEPRECATED
+./inc/loader/load_cache-filter.php:2:// @DEPRECATED
+./inc/loader/load_cache-impressum.php:2:// @DEPRECATED
+./inc/loader/load_cache-modules.php:2:// @DEPRECATED
+./inc/loader/load_cache-refdepths.php:2:// @DEPRECATED
+./inc/loader/load_cache-refsystem.php:2:// @DEPRECATED
+./inc/loader/load_cache-revision.php:2:// @DEPRECATED
+./inc/loader/load_cache-them.php:2:// @DEPRECATED
+./inc/loader/load-extensions.php:2:// @DEPRECATED
+./inc/modules/admin/admin-inc.php:438:// @DEPRECATED
+./inc/reset/reset_100_bonus.php:2:// @DEPRECATED
+./inc/reset/reset_autopurge.php:2:// @DEPRECATED
+./inc/reset/reset_beg.php:2:// @DEPRECATED
+./inc/reset/reset_birthday.php:2:// @DEPRECATED
+./inc/reset/reset_bonus.php:2:// @DEPRECATED
+./inc/reset/reset_daily.php:2:// @DEPRECATED
+./inc/reset/reset_doubler.php:2:// @DEPRECATED
+./inc/reset/reset_engine.php:2:// @DEPRECATED
+./inc/reset/reset_holiday.php:2:// @DEPRECATED
+./inc/reset/reset_profile.php:2:// @DEPRECATED
+./inc/reset/reset_surfbar.php:2:// @DEPRECATED
+./inc/reset/reset_yoomedia.php:2:// @DEPRECATED
+./templates/de/html/admin/admin_reset_pass_done.tpl:1:<!-- @DEPRECATED //-->
+./templates/de/html/admin/admin_send_reset_link.tpl:1:<!-- @DEPRECATED //-->
 ### ### template-warnings.log follows: ### ###
 Warning: Not parsing JavaScript templates/de/html/js/js_order_send.tpl.
 Warning: Not parsing JavaScript templates/de/html/js/js_cookies_disabled.tpl.
@@ -253,17 +278,10 @@ PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : td in templates/
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : tr in templates/de/html/member/member_content_right.tpl, line: 5 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : div in templates/de/html/member/member_welcome_footer.tpl, line: 1 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : table in templates/de/html/member/member_footer.tpl, line: 6 in 
-PHP Warning:  DOMDocument::loadHTMLFile(): Attribute class redefined in templates/de/html/install/install_page3.tpl, line: 21 in 
-PHP Warning:  DOMDocument::loadHTMLFile(): Attribute class redefined in templates/de/html/install/install_page3.tpl, line: 27 in 
-PHP Warning:  DOMDocument::loadHTMLFile(): Attribute class redefined in templates/de/html/install/install_page3.tpl, line: 33 in 
-PHP Warning:  DOMDocument::loadHTMLFile(): Attribute class redefined in templates/de/html/install/install_page3.tpl, line: 39 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : div in templates/de/html/page_footer.tpl, line: 1 in /home
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : td in templates/de/html/menu/menu_what_end.tpl, line: 1 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : tr in templates/de/html/menu/menu_what_end.tpl, line: 2 in 
-PHP Warning:  DOMDocument::loadHTMLFile(): Attribute class redefined in templates/de/html/admin/admin_list_beg.tpl, line: 23 in 
-PHP Warning:  DOMDocument::loadHTMLFile(): Attribute align redefined in templates/de/html/admin/admin_list_beg.tpl, line: 23 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : table in templates/de/html/admin/admin_logout_sql_patches_remove.tpl, line: 10 in 
-PHP Warning:  DOMDocument::loadHTMLFile(): Attribute class redefined in templates/de/html/admin/admin_login_form.tpl, line: 29 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : td in templates/de/html/admin/admin_main_footer.tpl, line: 1 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : tr in templates/de/html/admin/admin_main_footer.tpl, line: 2 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : table in templates/de/html/admin/admin_main_footer.tpl, line: 12 in