]> git.mxchange.org Git - mailer.git/blobdiff - DOCS/TODOs.txt
Some more cleanups/improvements:
[mailer.git] / DOCS / TODOs.txt
index c2f3e620575705be77e0472e1b0ebc2e0f6e4618..41661cfa2af451063c55b2fbf8a3d279a7728a33 100644 (file)
 ./inc/extensions-functions.php:424:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) )
 ./inc/extensions-functions.php:548:            // @TODO Extension is loaded, what next?
 ./inc/functions.php:115:               // @TODO Extension 'msg' does not exist
-./inc/functions.php:1483:                      // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
-./inc/functions.php:1506:                      // @TODO Rewrite this old lost code to a template
-./inc/functions.php:1574:                      // @TODO Are these convertions still required?
-./inc/functions.php:1592:// @TODO Rewrite this function to use readFromFile() and writeToFile()
+./inc/functions.php:1486:                      // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
+./inc/functions.php:1509:                      // @TODO Rewrite this old lost code to a template
+./inc/functions.php:1577:                      // @TODO Are these convertions still required?
+./inc/functions.php:1595:// @TODO Rewrite this function to use readFromFile() and writeToFile()
 ./inc/functions.php:178:// @TODO Rewrite this to an extension 'smtp'
-./inc/functions.php:2245:      // @TODO This is still very static, rewrite it somehow
+./inc/functions.php:2248:      // @TODO This is still very static, rewrite it somehow
 ./inc/gen_sql_patches.php:96:// @TODO Rewrite this to a filter
 ./inc/install-functions.php:63:        // @TODO DEACTIVATED: changeDataInFile(getCachePath() . 'config-local.php', 'OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestParameter('omode'), 0);
-./inc/language/de.php:1140:// @TODO Rewrite these two constants
-./inc/language/de.php:1155:// @TODO Rewrite these three constants
-./inc/language/de.php:302:     // @TODO Following two are unused?
-./inc/language/de.php:833:// @TODO Are these constants longer used?
+./inc/language/de.php:1129:// @TODO Rewrite these two constants
+./inc/language/de.php:1144:// @TODO Rewrite these three constants
+./inc/language/de.php:301:     // @TODO Following two are unused?
+./inc/language/de.php:822:// @TODO Are these constants longer used?
 ./inc/language-functions.php:234:      // @TODO These are all valid languages, again hard-coded
 ./inc/language-functions.php:46:// @TODO Rewrite all language constants to this function.
 ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings             *
 ./inc/language/refback_de.php:46:// @TODO Rewrite these constants to one
 ./inc/language/sponsor_de.php:119:// @TODO Rewrite these four constants to one and use sprintf()
-./inc/libs/admins_functions.php:434:           // @TODO This can be, somehow, rewritten
+./inc/libs/admins_functions.php:435:           // @TODO This can be, somehow, rewritten
 ./inc/libs/beg_functions.php:58:               // @TODO Try to rewrite the following unset()
-./inc/libs/bonus_functions.php:206:            // @TODO Move this HTML to a template
-./inc/libs/bonus_functions.php:290:            // @TODO This query isn't right, it will only update if the user was for a longer time away!
+./inc/libs/bonus_functions.php:204:            // @TODO Move this HTML to a template
+./inc/libs/bonus_functions.php:288:            // @TODO This query isn't right, it will only update if the user was for a longer time away!
 ./inc/libs/doubler_functions.php:46:// @TODO Lame description
 ./inc/libs/doubler_functions.php:94:                   // @TODO Can't this be moved into EL?
 ./inc/libs/mailid_functions.php:49:            // @TODO Rewrite this to a dynamic include or so
 ./inc/libs/rallye_functions.php:700:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId()
-./inc/libs/rallye_functions.php:768:   $EXPIRE = 3; // @TODO The hard-coded value...
-./inc/libs/rallye_functions.php:854:// @TODO Please document this function
-./inc/libs/rallye_functions.php:910:           // Load count @TODO Can't we rewrite this to our API?
+./inc/libs/rallye_functions.php:765:   $EXPIRE = 3; // @TODO The hard-coded value...
+./inc/libs/rallye_functions.php:851:// @TODO Please document this function
+./inc/libs/rallye_functions.php:907:           // Load count @TODO Can't we rewrite this to our API?
 ./inc/libs/refback_functions.php:61:           // @TODO Try to rewrite the following unset()
 ./inc/libs/register_functions.php:292: // @TODO Rewrite these all to a single filter
 ./inc/libs/register_functions.php:365: // @TODO Rewrite this to a filter
@@ -96,9 +96,9 @@
 ./inc/modules/admin/admin-inc.php:438:// @TODO Try to rewrite this to adminAddMenuSelectionBox()
 ./inc/modules/admin/overview-inc.php:164:                              // @TODO Rewrite this to a filter
 ./inc/modules/admin/overview-inc.php:277:                              // @TODO Rewrite this to something with include files and/or filter
-./inc/modules/admin/overview-inc.php:315:                                              // @TODO This may also be rewritten to include files
-./inc/modules/admin/overview-inc.php:317:                                                      default: // @TODO Unknown support mode
-./inc/modules/admin/overview-inc.php:432:                      // @TODO Try to move this in includes
+./inc/modules/admin/overview-inc.php:311:                                              // @TODO This may also be rewritten to include files
+./inc/modules/admin/overview-inc.php:313:                                                      default: // @TODO Unknown support mode
+./inc/modules/admin/overview-inc.php:428:                      // @TODO Try to move this in includes
 ./inc/modules/admin/overview-inc.php:45:// @TODO This function does also check for uncompleted tasks
 ./inc/modules/admin/what-add_guestnl_cat.php:49:       // @TODO Check if category does already exist
 ./inc/modules/admin/what-add_surfbar_url.php:57:       // @TODO Find all convertSelectionsToTimestamp() calls and rewrite postRequestParameter() calls to $postData
 ./inc/modules/admin/what-adminedit.php:58:     // @TODO Kill all constants in this file
 ./inc/modules/admin/what-admins_mails.php:61:                          // @TODO Can this be rewritten to an API function?
 ./inc/modules/admin/what-bonus.php:48:// @TODO Unused at the moment
-./inc/modules/admin/what-config_admins.php:126:        // @TODO Rewrite this to filter 'run_sqls'
+./inc/modules/admin/what-config_admins.php:128:        // @TODO Rewrite this to filter 'run_sqls'
 ./inc/modules/admin/what-config_mods.php:57:                   // @TODO This can be moved into mysql-function.php, see checkModulePermissions() function
 ./inc/modules/admin/what-config_points.php:113:                        // @TODO Rewrite this to a filter
 ./inc/modules/admin/what-config_rallye_prices.php:197:                 // @TODO Rewrite these two constants
 ./inc/modules/admin/what-mem_add.php:126:                              // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-mem_add.php:65:               // @TODO Cant this be rewritten?
 ./inc/modules/admin/what-mem_add.php:81:               // @TODO This can be somehow rewritten to a function
-./inc/modules/admin/what-unlock_emails.php:89:                                 // @TODO Rewrite these if-blocks to a filter
+./inc/modules/admin/what-unlock_emails.php:86:                                 // @TODO Rewrite these if-blocks to a filter
 ./inc/modules/admin/what-usage.php:88: // @TODO This code is double, see loadTemplate() and loadEmailTemplate() in functions.php
 ./inc/modules/admin/what-usr_online.php:51:    // @TODO Add a filter for sponsor
 ./inc/modules/guest/what-beg.php:53:// @TODO No more needed? define('__BEG_UID_TIMEOUT', createFancyTime(getConfig('beg_userid_timeout')));
 ./inc/modules/member/what-beg.php:56:// @TODO Can't this be moved into EL?
 ./inc/modules/member/what-beg.php:65:// @TODO No more needed? define('__BEG_UID_TIMEOUT', createFancyTime(getConfig('beg_userid_timeout')));
 ./inc/modules/member/what-bonus.php:57:        // @TODO Rewrite this to a filter
-./inc/modules/member/what-categories.php:129:          // @TODO Rewrite this to use $OUT .= ...
-./inc/modules/member/what-order.php:457:                       // @TODO Rewrite this to a filter
-./inc/modules/member/what-order.php:65:// @TODO Rewrite this to a filter
+./inc/modules/member/what-categories.php:132:          // @TODO Rewrite this to use $OUT .= ...
+./inc/modules/member/what-order.php:427:                       // @TODO Rewrite this to a filter
 ./inc/modules/member/what-payout.php:196:                                      // @TODO Rewrite this to a filter
 ./inc/modules/member/what-points.php:55:// @TODO Should we rewrite this to a filter?
 ./inc/modules/member/what-rallyes.php:91:      // @TODO Reactivate this: $content['admin'] = '<a href="{%url=modules.php?module=index&amp;what=impressum&amp;admin=' . $content['admin_id'] . '%}">' . $content['login'] . '</a>';
 ./inc/modules/member/what-refback.php:126:                     // @TODO UNUSED: $refRow['status']      = translateUserStatus($refRow['status']);
 ./inc/modules/member/what-reflinks.php:54:// @TODO Move this into a filter
-./inc/modules/member/what-themes.php:116:      // @TODO Move this code into a template
 ./inc/modules/member/what-transfer.php:132:                            // @TODO Rewrite this to a filter
 ./inc/modules/member/what-transfer.php:222:                            // @TODO Try to rewrite his to $content = SQL_FETCHARRAY(), see some lines above for two different queries
 ./inc/modules/member/what-transfer.php:304:                    // @TODO This should be somehow rewritten to $row = SQL_FETCHARRAY(), see switch() block above for SQL queries
 ./inc/mysql-manager.php:1164:  // @TODO Rewrite this to a filter
 ./inc/mysql-manager.php:1411:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
 ./inc/mysql-manager.php:1509:  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1888:                  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1932:// @TODO Fix inconsistency between last_module and getWhat()
+./inc/mysql-manager.php:1876:                  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1920:// @TODO Fix inconsistency between last_module and getWhat()
 ./inc/mysql-manager.php:370:   // @TODO Try to rewrite this to one or more functions
 ./inc/mysql-manager.php:46:// @TODO Can we cache this?
 ./inc/reset/reset_beg.php:51:// @TODO This should be converted in a daily beg rallye