Some rewrites, TODOs handled:
[mailer.git] / DOCS / TODOs.txt
index eb4caf60323c04f9613f33991a7909684928f6be..6bd21db085d79f4a84cacda955c1f308fc3072a9 100644 (file)
@@ -1,34 +1,37 @@
-### WARNING: THIS FILE IS AUTO-GENERATED BY DOCS/todo-builder.sh ###
+### WARNING: THIS FILE IS AUTO-GENERATED BY DOCS/todo-builder.sh (1000/quix0r) ###
 ### DO NOT EDIT THIS FILE. ###
-./beg.php:196:                         // @TODO Opps, what is missing here???
-./inc/extensions/ext-sql_patches.php:705:                      // @TODO Rewrite this to a filter!
-./inc/extensions/ext-sql_patches.php:743:              // @TODO Can we remove this? setConfigEntry('verbose_sql'        , 'N');
-./inc/extensions/ext-sql_patches.php:93:       /* @TODO SQL_ALTER_TABLE() should work now properly
-./inc/extensions/ext-surfbar.php:237:  // @TODO Set some constants we need???
-./inc/extensions.php:343:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) )
-./inc/extensions.php:419:              // @TODO Extension is loaded, what next?
-./inc/functions.php:1277:      // @TODO Rewrite this unnice code
-./inc/functions.php:1338:      // @TODO Remove this if() block if all is working fine
-./inc/functions.php:1638:              // @TODO This can be, somehow, rewritten
-./inc/functions.php:1991:      // @TODO eregi() should be rewritten here
-./inc/functions.php:2367:// @TODO Rewrite all language constants to this function.
-./inc/functions.php:248:                       // @TODO Fine all templates which are using these direct variables and rewrite them.
-./inc/functions.php:249:                       // @TODO After this step is done, this else-block is history
-./inc/functions.php:2614:                      $GLOBALS['cache_instance']->destroyCacheFile(); // @TODO isn't it better to do $GLOBALS['cache_instance']->destroyCacheFile('revision')?
-./inc/functions.php:2616:                      // @TODO shouldn't do the unset and the reloading $GLOBALS['cache_instance']->destroyCacheFile() Or a new methode like forceCacheReload('revision')?
-./inc/functions.php:2677:// @TODO Please describe this function
-./inc/functions.php:2689:      searchDirsRecursive($next_dir, $last_changed); // @TODO small change to API to $last_changed = searchDirsRecursive($next_dir, $time);
-./inc/functions.php:2801:              // @TODO Add a little more infos here
-./inc/functions.php:2812:      // @TODO This cannot be rewritten to app_die(), try to find a solution for this.
-./inc/functions.php:2909:// @TODO Implement $compress
-./inc/functions.php:2916:// @TODO Implement $decompress
-./inc/functions.php:3027:// @TODO Rewrite this function to use readFromFile() and writeToFile()
-./inc/functions.php:464:// @TODO Rewrite this to an extension 'smtp'
-./inc/language/de.php:1156:// @TODO Rewrite these two constants
-./inc/language/de.php:1172:// @TODO Rewrite these five constants
+./beg.php:193:                         // @TODO Opps, what is missing here???
+./inc/cache/config-local.php:120:// @TODO Rewrite the following three constants, somehow...
+./inc/config-functions.php:182:        // @TODO Make this all better... :-/
+./inc/config-functions.php:207:        // @TODO Rewrite these all to config entries, if somehow possible
+./inc/extensions/ext-sql_patches.php:705:                                              // @TODO Rewrite this to a filter!
+./inc/extensions/ext-sql_patches.php:743:                                      // @TODO Can we remove this? setConfigEntry('verbose_sql'        , 'N');
+./inc/extensions/ext-sql_patches.php:93:               /* @TODO SQL_ALTER_TABLE() should work now properly
+./inc/extensions/ext-surfbar.php:237:                          // @TODO Set some constants we need???
+./inc/extensions.php:355:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) )
+./inc/extensions.php:431:              // @TODO Extension is loaded, what next?
+./inc/functions.php:1224:      // @TODO Rewrite this unnice code
+./inc/functions.php:1285:      // @TODO Remove this if() block if all is working fine
+./inc/functions.php:1585:              // @TODO This can be, somehow, rewritten
+./inc/functions.php:211:       // @TODO Remove this sanity-check if all is fine
+./inc/functions.php:2459:                      $GLOBALS['cache_instance']->destroyCacheFile(); // @TODO isn't it better to do $GLOBALS['cache_instance']->destroyCacheFile('revision')?
+./inc/functions.php:2461:                      // @TODO shouldn't do the unset and the reloading $GLOBALS['cache_instance']->destroyCacheFile() Or a new methode like forceCacheReload('revision')?
+./inc/functions.php:250:                       // @TODO Fine all templates which are using these direct variables and rewrite them.
+./inc/functions.php:251:                       // @TODO After this step is done, this else-block is history
+./inc/functions.php:2522:// @TODO Please describe this function
+./inc/functions.php:2534:      searchDirsRecursive($next_dir, $last_changed); // @TODO small change to API to $last_changed = searchDirsRecursive($next_dir, $time);
+./inc/functions.php:2617:              // @TODO Add a little more infos here
+./inc/functions.php:2628:      // @TODO This cannot be rewritten to app_die(), try to find a solution for this.
+./inc/functions.php:2785:                      // @TODO Are these convertions still required?
+./inc/functions.php:2803:// @TODO Rewrite this function to use readFromFile() and writeToFile()
+./inc/functions.php:466:// @TODO Rewrite this to an extension 'smtp'
+./inc/install-inc.php:20: * @TODO Rewrite all constants in this include file                     *
+./inc/language/de.php:1159:// @TODO Rewrite these two constants
+./inc/language/de.php:1175:// @TODO Rewrite these five constants
 ./inc/language/de.php:756:// @TODO The template 'admin_extensions_installed' is using this. But the template is no longer used.
 ./inc/language/de.php:855:// @TODO Are these constants still used?
 ./inc/language/de.php:866:// @TODO Are these constants longer used?
+./inc/language-functions.php:45:// @TODO Rewrite all language constants to this function.
 ./inc/language/holiday_de.php:49:// @TODO Rewrite these two constants to one
 ./inc/language/rallye_de.php:110:// @TODO Rewrite following two lines to one
 ./inc/language/refback_de.php:46:// @TODO Rewrite these constants to one
 ./inc/libs/rallye_functions.php:697:           // @TODO Rewrite this to our API function
 ./inc/libs/register_functions.php:53:          // @TODO Rewrite these constants
 ./inc/libs/register_functions.php:62:  // @TODO Rewrite these constants, too
-./inc/libs/surfbar_functions.php:1469:         // @TODO This can be somehow rewritten
-./inc/libs/surfbar_functions.php:942:  // @TODO Invalid salt should be refused
+./inc/libs/surfbar_functions.php:1481:         // @TODO This can be somehow rewritten
+./inc/libs/surfbar_functions.php:954:  // @TODO Invalid salt should be refused
 ./inc/libs/task_functions.php:261:             // @TODO These can be rewritten to filter
 ./inc/libs/task_functions.php:53:// @TODO Move all extension-dependent queries into filters
-./inc/libs/user_functions.php:317:                     // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content);
-./inc/libs/user_functions.php:342:                     // @TODO Make this filter working: $URL = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON));
-./inc/libs/user_functions.php:377:             // @TODO Can this query be merged with above query?
-./inc/libs/yoomedia_functions.php:65:  $response = YOOMEDIA_QUERY_API("out_textmail.php", true); // @TODO Ask Yoo!Media for test script
+./inc/libs/user_functions.php:317:                             // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content);
+./inc/libs/user_functions.php:342:                             // @TODO Make this filter working: $URL = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON));
+./inc/libs/user_functions.php:377:                     // @TODO Can this query be merged with above query?
+./inc/libs/yoomedia_functions.php:65:  $response = YOOMEDIA_QUERY_API('out_textmail.php', true); // @TODO Ask Yoo!Media for test script
+./inc/load_config.php:77:      // @TODO Rewrite them to avoid this else block
 ./inc/load_extensions.php:13: * @TODO Rewrite this whole file to load_cache-extensions.php           *
 ./inc/mails/birthday_mails.php:85:                     // @TODO 4 is hard-coded here, should we move it out in config?
 ./inc/modules/admin/admin-inc.php:343:         // @TODO Rewrite this to $content = SQL_FETCHARRAY()
 ./inc/modules/admin/admin-inc.php:390:                                 // @TODO Rewrite this to $content = SQL_FETCHARRAY()
 ./inc/modules/admin/admin-inc.php:504:         // @TODO Rewrite these both constants
 ./inc/modules/admin/admin-inc.php:530:         // @TODO Try to rewrite this to $content = SQL_FETCHARRAY(). Please look some lines above for the dynamic query
-./inc/modules/admin/overview-inc.php:143:                              // @TODO Rewrite this to a filter
-./inc/modules/admin/overview-inc.php:230:                              // @TODO Rewrite this to something with include files
-./inc/modules/admin/overview-inc.php:269:                                      // @TODO This may also be rewritten to include files
-./inc/modules/admin/overview-inc.php:272:                                      default: // @TODO Unknown support mode
-./inc/modules/admin/overview-inc.php:418:                      // @TODO Rewritings: admin->assigned_admin,uid->userid,type->task_type_msg in template
+./inc/modules/admin/overview-inc.php:144:                              // @TODO Rewrite this to a filter
+./inc/modules/admin/overview-inc.php:154:                                      // @TODO Can this SQL be encapsulated in a function, so all similar queries can be rewritten?
+./inc/modules/admin/overview-inc.php:190:                                              // @TODO Should we init sql_notes here or inside REGISTER_EXTENSION()?
+./inc/modules/admin/overview-inc.php:253:                              // @TODO Rewrite this to something with include files
+./inc/modules/admin/overview-inc.php:291:                                              // @TODO This may also be rewritten to include files
+./inc/modules/admin/overview-inc.php:293:                                                      default: // @TODO Unknown support mode
+./inc/modules/admin/overview-inc.php:425:                      // @TODO Try to move this in includes
+./inc/modules/admin/overview-inc.php:444:                      // @TODO Rewritings: admin->assigned_admin,uid->userid,type->task_type_msg in template
 ./inc/modules/admin.php:257:   // @TODO Rewrite all these constants
-./inc/modules/admin.php:94:                            // @TODO Why is this set to 'done'?
+./inc/modules/admin.php:95:                                    // @TODO Why is this set to 'done'?
 ./inc/modules/admin/what-add_points.php:120:                   // @TODO Rewrite these both constants
 ./inc/modules/admin/what-add_points.php:54:            // @TODO Rewrite this constant
-./inc/modules/admin/what-admin_add.php:120:                            // @TODO This can be somehow rewritten to a function
-./inc/modules/admin/what-admin_add.php:77:             // @TODO This can be somehow rewritten to a function
+./inc/modules/admin/what-add_surfbar_url.php:57:       // @TODO Find all convertSelectionsToTimestamp() calls and rewrite REQUEST_POST() calls to $POST
+./inc/modules/admin/what-admin_add.php:121:                            // @TODO This can be somehow rewritten to a function
+./inc/modules/admin/what-admin_add.php:62:             // @TODO Cant this be rewritten?
+./inc/modules/admin/what-admin_add.php:78:             // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-adminedit.php:250:            // @TODO Rewrite this constant
-./inc/modules/admin/what-admins_add.php:68:    // @TODO Do we still need this ugly code here?
 ./inc/modules/admin/what-admins_mails.php:100:         // @TODO Rewrite this constant
 ./inc/modules/admin/what-admins_mails.php:173:         // @TODO Rewrite this constant
 ./inc/modules/admin/what-admins_mails.php:61:                          // @TODO Can this be rewritten???
 ./inc/modules/admin/what-chk_regs.php:62:              // @TODO Rewritings: sname->surname,fname->family,ip->REMOTE_ADDR,ref->refid,hash->user_hash in template
 ./inc/modules/admin/what-chk_regs.php:81:      // @TODO Rewrite this constant
-./inc/modules/admin/what-config_admins.php:160:                // @TODO This causes the whole (!) menu cache being rebuild
+./inc/modules/admin/what-config_admins.php:154:        // @TODO Rewrite this to filter 'run_sqls'
+./inc/modules/admin/what-config_admins.php:164:                // @TODO This causes the whole (!) menu cache being rebuild
 ./inc/modules/admin/what-config_cats.php:192:          // @TODO Rewrite this constant
 ./inc/modules/admin/what-config_cats.php:199:  // @TODO Rewrite this constant
 ./inc/modules/admin/what-config_mods.php:139:          // @TODO Rewritings: mod->module in template
 ./inc/modules/admin/what-edit_emails.php:113:          // @TODO Yet another constant to rewrite
 ./inc/modules/admin/what-edit_emails.php:60:           // @TODO More constants to rewrite
 ./inc/modules/admin/what-edit_emails.php:95:                   // @TODO Rewritings: subj->subject in template
-./inc/modules/admin/what-extensions.php:154:           // @TODO Rewrite this constant
-./inc/modules/admin/what-extensions.php:333:                                   // @TODO Rewrite this to a filter
-./inc/modules/admin/what-guest_add.php:122:                            // @TODO This can be somehow rewritten to a function
-./inc/modules/admin/what-guest_add.php:77:             // @TODO This can be somehow rewritten to a function
+./inc/modules/admin/what-extensions.php:159:           // @TODO Rewrite this constant
+./inc/modules/admin/what-extensions.php:338:                                           // @TODO Rewrite this to a filter
+./inc/modules/admin/what-guest_add.php:123:                            // @TODO This can be somehow rewritten to a function
+./inc/modules/admin/what-guest_add.php:62:             // @TODO Cant this be rewritten?
+./inc/modules/admin/what-guest_add.php:78:             // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-guestedit.php:284:            // @TODO Rewrite this constant
 ./inc/modules/admin/what-list_autopurge.php:55:// @TODO Rewrite those lines to filter
 ./inc/modules/admin/what-list_autopurge.php:78:                // @TODO Rewritings: sname->surname,fname->family in templates
 ./inc/modules/admin/what-lock_user.php:133:                            // @TODO Rewrite these all constants
 ./inc/modules/admin/what-logs.php:69:                  // @TODO Fix content-type here
 ./inc/modules/admin/what-logs.php:72:                  // @TODO Fix content-type here
-./inc/modules/admin/what-mem_add.php:120:                              // @TODO This can be somehow rewritten to a function
-./inc/modules/admin/what-mem_add.php:78:               // @TODO This can be somehow rewritten to a function
+./inc/modules/admin/what-mem_add.php:121:                              // @TODO This can be somehow rewritten to a function
+./inc/modules/admin/what-mem_add.php:63:               // @TODO Cant this be rewritten?
+./inc/modules/admin/what-mem_add.php:79:               // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-memedit.php:252:              // @TODO Rewrite this constant
 ./inc/modules/admin/what-memedit.php:288:              // @TODO Rewrite this constant
 ./inc/modules/admin/what-payments.php:154:                     // @TODO Rewritings: title->mail_title, pay->payment in template
 ./inc/modules/guest/what-sponsor_reg.php:284:          // @TODO Swap this HTML code to templates
 ./inc/modules/guest/what-sponsor_reg.php:298:          // @TODO Rewrite this constant
 ./inc/modules/guest/what-sponsor_reg.php:304:                  // @TODO Rewrite these constants
-./inc/modules/guest/what-stats.php:110:        // @TODO This can be somehow rewritten
-./inc/modules/guest/what-stats.php:123:        // @TODO Rewrite all these constants
-./inc/modules/guest/what-stats.php:192:                // @TODO Rewrite this to one template and $OUT .= ....
+./inc/modules/guest/what-stats.php:110:                // @TODO This can be somehow rewritten
+./inc/modules/guest/what-stats.php:123:                // @TODO Rewrite all these constants
+./inc/modules/guest/what-stats.php:192:                        // @TODO Rewrite this to one template and $OUT .= ....
 ./inc/modules/guest/what-top10.php:107:// @TODO Rewrite this constant
 ./inc/modules/guest/what-top10.php:145:        // @TODO Rewritings: nick->nickname,uid->userid in template
 ./inc/modules/guest/what-top10.php:177:// @TODO Rewrite this constant
 ./inc/modules/guest/what-wernis_portal.php:85://  @TODO Can this be removed? $rdf->clear_cache();
 ./inc/modules/member/what-bonus.php:55:        // @TODO Rewrite this to a filter
 ./inc/modules/member/what-categories.php:112:          // @TODO Rewrite this to use $OUT .= ...
+./inc/modules/member/what-mydata.php:53:// @TODO Try to rewrite this constant
 ./inc/modules/member/what-order.php:411:                       // @TODO Rewrite this to a filter
-./inc/modules/member/what-order.php:506:                                       // @TODO Rewrite this old lost code to a template
+./inc/modules/member/what-order.php:506:                                        // @TODO Rewrite this old lost code to a template
 ./inc/modules/member/what-payout.php:132:                              // @TODO Rewritings: acc->target_account,bank->target_bank in templates
 ./inc/modules/member/what-payout.php:148:                      // @TODO Rewrite this constant
 ./inc/modules/member/what-payout.php:182:              // @TODO Rewrite these constants
 ./inc/modules/member/what-payout.php:235:                                      // @TODO Rewrite this to a filter
 ./inc/modules/member/what-points.php:54:// @TODO Should we rewrite this to a filter?
 ./inc/modules/member/what-reflinks.php:105:            // @TODO Rewritings: alt->alternate,cnt->counter,cks->clicks,uid->userid in template
-./inc/modules/member/what-transfer.php:116:                    // @TODO Rewrite all these constants to array elements
-./inc/modules/member/what-transfer.php:247:                    // @TODO Try to rewrite his to $content = SQL_FETCHARRAY(), see some lines above for two different queries
-./inc/modules/member/what-transfer.php:309:            // @TODO Rewrite these constants
-./inc/modules/member/what-transfer.php:317:            // @TODO Rewrite these constants
-./inc/modules/member/what-transfer.php:329:            // @TODO This should be somehow rewritten to $content = SQL_FETCHARRAY(), see switch() block above for SQL queries
-./inc/modules/member/what-transfer.php:364:    // @TODO Rewrite these constants
-./inc/modules/member/what-transfer.php:451:    // @TODO Rewrite all these constants
+./inc/modules/member/what-transfer.php:116:                            // @TODO Rewrite all these constants to array elements
+./inc/modules/member/what-transfer.php:247:                            // @TODO Try to rewrite his to $content = SQL_FETCHARRAY(), see some lines above for two different queries
+./inc/modules/member/what-transfer.php:309:                            // @TODO Rewrite these constants
+./inc/modules/member/what-transfer.php:317:                            // @TODO Rewrite these constants
+./inc/modules/member/what-transfer.php:329:                    // @TODO This should be somehow rewritten to $content = SQL_FETCHARRAY(), see switch() block above for SQL queries
+./inc/modules/member/what-transfer.php:364:            // @TODO Rewrite these constants
+./inc/modules/member/what-transfer.php:451:                            // @TODO Rewrite all these constants
 ./inc/modules/member/what-unconfirmed.php:134: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
-./inc/mysql-manager.php:1549:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
-./inc/mysql-manager.php:1592:          // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1768:                          // @TODO Find a way for updating $_CONFIG here
-./inc/mysql-manager.php:1792:          // @TODO Find a way for updating $_CONFIG here
-./inc/mysql-manager.php:1815:// @TODO Can this be rewritten to a filter?
-./inc/mysql-manager.php:1877:                  // @TODO Rewrite this to $content = SQL_FETCHARRAY()
+./inc/mysql-manager.php:1552:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
+./inc/mysql-manager.php:1595:                  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1773:                          // @TODO Find a way for updating $_CONFIG here
+./inc/mysql-manager.php:1797:          // @TODO Find a way for updating $_CONFIG here
+./inc/mysql-manager.php:1820:// @TODO Can this be rewritten to a filter?
+./inc/mysql-manager.php:1882:                  // @TODO Rewrite this to $content = SQL_FETCHARRAY()
 ./inc/mysql-manager.php:199:                   // @TODO Nothing helped???
-./inc/mysql-manager.php:2171:          // @TODO This can be somehow rewritten
+./inc/mysql-manager.php:2176:          // @TODO This can be somehow rewritten
 ./inc/mysql-manager.php:513:   // @TODO Why is this global??? #100
-./inc/mysql-manager.php:947:                   // @TODO Why does this lead into an endless loop but we still need it???
-./inc/mysql-manager.php:948:                   // @TODO Commented out LOAD_URL('admin.php');
-./mailid_top.php:208:                                                                  // @TODO Rewrite these blocks to filter
+./inc/mysql-manager.php:950:                   // @TODO Why does this lead into an endless loop but we still need it???
+./inc/mysql-manager.php:951:                   // @TODO Commented out redirectToUrl('admin.php');
+./inc/wrapper-functions.php:152:// @TODO Implement $compress
+./inc/wrapper-functions.php:159:// @TODO Implement $decompress
+./inc/wrapper-functions.php:391:// @TODO Do some more sanity check here
+./mailid_top.php:208:                                                                          // @TODO Rewrite these blocks to filter
 ./surfbar.php:65:              // @TODO Display quick login form here or redirect as configured
 ### ### DEPRECATION FOLLOWS: ### ###
-./inc/functions.php:233:       // @DEPRECATED Try to rewrite the if() condition
-./inc/functions.php:2377:              // @DEPRECATED Language array element found in BIG_LETTERS
-./inc/functions.php:2380:              // @DEPRECATED Deprecated constant found
-./inc/functions.php:247:                       // @DEPRECATED
+./inc/functions.php:235:       // @DEPRECATED Try to rewrite the if() condition
+./inc/functions.php:249:                       // @DEPRECATED
+./inc/language-functions.php:55:               // @DEPRECATED Language array element found in BIG_LETTERS
+./inc/language-functions.php:58:               // @DEPRECATED Deprecated constant found