Used EL code {%template,LoadTemplate=foo%} instead of loadTemplate('foo', TRUE);
[mailer.git] / DOCS / TODOs.txt
index ce8826bfa3c2b49ac3f45dec8ec4d695f534fd27..7a821d651404cebaec9e8a49987f3175c35117e6 100644 (file)
@@ -1,13 +1,13 @@
 ### WARNING: THIS FILE IS AUTO-GENERATED BY ../../contrib/todo-builder.sh (uid=/user=quix0r) ###
 ### DO NOT EDIT THIS FILE. ###
 ./api.php:68:// @TODO Do stuff here
-./autoreg.php:58:// @TODO Add processing of request here
-./beg.php:175:                 // @TODO Opps, what is missing here???
+./autoreg.php:62:// @TODO Add processing of request here
+./beg.php:173:                 // @TODO Opps, what is missing here???
 ./cron.php:62:// @TODO Do stuff here
 ./inc/classes/cachesystem.class.php:516:       // @TODO Add support for more types which break in last else-block
-./inc/config-functions.php:149:        // @TODO Make this all better... :-/
-./inc/config-functions.php:325:                                        // @TODO Call setConfigEntry() somehow
-./inc/config-functions.php:353:                // @TODO Call setConfigEntry() somehow
+./inc/config-functions.php:150:        // @TODO Make this all better... :-/
+./inc/config-functions.php:326:                                        // @TODO Call setConfigEntry() somehow
+./inc/config-functions.php:354:                // @TODO Call setConfigEntry() somehow
 ./inc/daily/daily_beg.php:52:// @TODO This should be converted in a daily beg rallye
 ./inc/daily/daily_birthday.php:99:                     // @TODO 4 is hard-coded here, should we move it out in config?
 ./inc/email-functions.php:113: * @TODO Rewrite this to an extension 'smtp'
 ./inc/extensions/ext-network.php:23: * @TODO Affiliblatt: Layer requires script in head                     *
 ./inc/extensions/ext-network.php:24: * @TODO Affiliblatt: Textlinks, popup, popunder, HTML mail, lead       *
 ./inc/extensions/ext-network.php:25: * @TODO AllAds4You: Traffic from abroad, High-Forced banner            *
-./inc/extensions/ext-network.php:26: * @TODO eu-ADS/WeltPromotion: Text for banner/buttons?                 *
-./inc/extensions/ext-network.php:27: * @TODO FuCoExSponsor: Textlink-View is JavaScript!                    *
-./inc/extensions/ext-network.php:28: * @TODO Fusion-Ads: Has click/banner URL in API response               *
-./inc/extensions/ext-network.php:29: * @TODO GeldSponsor.de Requires ID card copy/business reg.             *
-./inc/extensions/ext-network.php:30: * @TODO GolloX: Which charset?                                         *
-./inc/extensions/ext-network.php:31: * @TODO paid4ad: Which URLs for click and banner?                      *
-./inc/extensions/ext-network.php:32: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer *
-./inc/extensions/ext-network.php:33: * @TODO SuperPromo24: Textlink view is a JavaScript                    *
-./inc/extensions/ext-network.php:34: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript!          *
-./inc/extensions/ext-network.php:35: * @TODO Der Werbepartner.cc: Forced textlink not correct               *
-./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Layer not correct                         *
-./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Sky banner is JavaScript!                 *
-./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Surfbar click not correct                 *
-./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Textlink not not correct                  *
-./inc/extensions/ext-network.php:40: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL)       *
-./inc/extensions/ext-network.php:41: * @TODO Yoo!Media: What is LayerAd compared to Layer click?            *
-./inc/extensions/ext-network.php:98:           // @TODO network_type_handler is an internal name and needs documentation
+./inc/extensions/ext-network.php:26: * @TODO FuCoExSponsor: Textlink-View is JavaScript!                    *
+./inc/extensions/ext-network.php:27: * @TODO Fusion-Ads: Has click/banner URL in API response               *
+./inc/extensions/ext-network.php:28: * @TODO GeldSponsor.de Requires ID card copy/business reg.             *
+./inc/extensions/ext-network.php:29: * @TODO GolloX: Which charset?                                         *
+./inc/extensions/ext-network.php:30: * @TODO paid4ad: Which URLs for click and banner?                      *
+./inc/extensions/ext-network.php:31: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer *
+./inc/extensions/ext-network.php:32: * @TODO SuperPromo24: Textlink view is a JavaScript                    *
+./inc/extensions/ext-network.php:33: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript!          *
+./inc/extensions/ext-network.php:34: * @TODO Der Werbepartner.cc: Forced textlink not correct               *
+./inc/extensions/ext-network.php:35: * @TODO Der Werbepartner.cc: Layer not correct                         *
+./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Sky banner is JavaScript!                 *
+./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Surfbar click not correct                 *
+./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Textlink not not correct                  *
+./inc/extensions/ext-network.php:39: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL)       *
+./inc/extensions/ext-network.php:40: * @TODO Yoo!Media: What is LayerAd compared to Layer click?            *
+./inc/extensions/ext-network.php:97:           // @TODO network_type_handler is an internal name and needs documentation
 ./inc/extensions/ext-newsletter.php:218:               // @TODO Move these into configuration
 ./inc/extensions/ext-nickname.php:52:          // @TODO NOT NULL DEFAULT '' is bad practice, use NULL
-./inc/extensions/ext-yoomedia.php:121:         // @TODO Can this be moved into a database table?
+./inc/extensions/ext-yoomedia.php:120:         // @TODO Can this be moved into a database table?
 ./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y');
 ./inc/extensions-functions.php:2169:                   // @TODO Is this really neccessary?
 ./inc/extensions-functions.php:2220:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable'
 ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings             *
 ./inc/language/refback_de.php:51:      // @TODO Rewrite these constants to one
 ./inc/libs/admins_functions.php:537:           // @TODO This can be, somehow, rewritten
-./inc/libs/bonus_functions.php:195:            // @TODO Move this HTML to a template
+./inc/libs/bonus_functions.php:115:    // @TODO Rewrite this to a filter
+./inc/libs/bonus_functions.php:199:            // @TODO Move this HTML to a template
+./inc/libs/doubler_functions.php:130:// @TODO This could be rewritten to a filter
 ./inc/libs/doubler_functions.php:44:// @TODO Lame description
 ./inc/libs/doubler_functions.php:96:                   // @TODO Can't this be moved into EL?
 ./inc/libs/forced_functions.php:457:// @TODO Can't we use our new expression language instead of this ugly code?
+./inc/libs/mailid_functions.php:123:   // @TODO Rewrite these blocks to filter
 ./inc/libs/mailid_functions.php:47:            // @TODO Rewrite this to a dynamic include or so
+./inc/libs/mailid_functions.php:93:    // @TODO Rewrite this to a filter
 ./inc/libs/network_functions.php:1182: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine
 ./inc/libs/order_functions.php:46:     // @TODO Move this array into a filter
 ./inc/libs/rallye_functions.php:771:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId()
 ./inc/modules/admin/what-list_mods.php:55:                     // @TODO This can be moved into mysql-function.php, see checkModulePermissions() function
 ./inc/modules/admin/what-list_rallye_prices.php:222:                   // @TODO Rewrite these two constants
 ./inc/modules/admin/what-list_refs.php:101:                                                    // @TODO Try to rewrite some to EL
-./inc/modules/admin/what-list_unconfirmed.php:114:     // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
-./inc/modules/admin/what-list_unconfirmed.php:84:      // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}');
-./inc/modules/admin/what-list_unconfirmed.php:87:      // @TODO `id` has been used two times???
+./inc/modules/admin/what-list_unconfirmed.php:118:     // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
+./inc/modules/admin/what-list_unconfirmed.php:89:      // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}');
+./inc/modules/admin/what-list_unconfirmed.php:92:      // @TODO `id` has been used two times???
 ./inc/modules/admin/what-list_user_cats.php:54:                // @TODO No longer needed? define('__CATEGORIES_BASE'   , '<a href="{%url=modules.php?module=admin&amp;userid=');
 ./inc/modules/admin/what-list_user_cats.php:68:                                // @TODO Rewrite this to countSum.....() function
 ./inc/modules/admin/what-list_user.php:104:            // @TODO Refacture these old link generation to functions
 ./inc/modules/admin/what-usr_online.php:49:    // @TODO Add a filter for sponsor
 ./inc/modules/frametester.php:95:      // @TODO Rewrite this somehow
 ./inc/modules/guest/what-beg.php:51:// @TODO No more needed? define('__BEG_USERID_TIMEOUT', createFancyTime(getBegUseridTimeout()));
-./inc/modules/guest/what-login.php:134:        // @TODO Move this HTML code into a template
 ./inc/modules/guest/what-mediadata.php:188:// @TODO Rewrite all these if-blocks to filters
 ./inc/modules/guest/what-mediadata.php:67:     // @TODO Find a better formular than this one
 ./inc/modules/guest/what-rallyes.php:99:       // @TODO Reactivate this: $content['admin'] = '<a href="{%url=modules.php?module=index&amp;what=impressum&amp;id=' . $content['admin_id'] . '%}">' . $content['login'] . '</a>';
 ./inc/modules/member/what-beg.php:63:// @TODO No more needed? define('__BEG_USERID_TIMEOUT', createFancyTime(getBegUseridTimeout()));
 ./inc/modules/member/what-logout.php:17: * @TODO Rewrite the code to a filter                                   *
 ./inc/modules/member/what-logout.php:52:       // @TODO Move this in a filter, e.g. member_logout
-./inc/modules/member/what-order.php:459:                       // @TODO Rewrite this to a filter
-./inc/modules/member/what-order.php:84:                // @TODO Rewrite this to SQL_FETCHARRAY()
+./inc/modules/member/what-mydata.php:82:               // @TODO Move this to a function (for better EL code)
+./inc/modules/member/what-order.php:463:                       // @TODO Rewrite this to a filter
 ./inc/modules/member/what-payout.php:208:                                      // @TODO Rewrite this to a filter
 ./inc/modules/member/what-points.php:61:// @TODO Should we rewrite this to a filter?
 ./inc/modules/member/what-rallyes.php:99:      // @TODO Reactivate this: $content['admin'] = '<a href="{%url=modules.php?module=index&amp;what=impressum&amp;id=' . $content['admin_id'] . '%}">' . $content['login'] . '</a>';
 ./inc/modules/order.php:78:            // @TODO Unused: 2,4
 ./inc/mysql-manager.php:1492:          // @TODO Rewrite these lines to a filter
 ./inc/mysql-manager.php:1516:  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1822:                  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1990:                          // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided
-./inc/mysql-manager.php:2113:                  // @TODO Used generic 'userid' here
-./inc/mysql-manager.php:2334:// @TODO cacheFiles is not yet supported
+./inc/mysql-manager.php:1832:                  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:2000:                          // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided
+./inc/mysql-manager.php:2123:                  // @TODO Used generic 'userid' here
+./inc/mysql-manager.php:2344:// @TODO cacheFiles is not yet supported
 ./inc/mysql-manager.php:408:   // @TODO Try to rewrite this to one or more functions
 ./inc/mysql-manager.php:44:// @TODO Can we cache this?
-./inc/purge/purge-inact.php:55:        // @TODO Rewrite these if() blocks to a filter
 ./inc/revision-functions.php:168:// @TODO This function does also set and get in 'cache_array'
 ./inc/template-functions.php:1040:                             // @TODO <label for="' . $prefix . '_' . $field . '"></<label> not working here
 ./inc/template-functions.php:1095:                     // @TODO Deprecate this thing
 ./inc/template-functions.php:1658:// @TODO Lame description for this function
 ./inc/template-functions.php:1680:                     // @TODO Move this in a filter
 ./inc/template-functions.php:209:       * @TODO On some pages this is buggy
-./inc/template-functions.php:2320:     // @TODO Is this needed for e.g. $GLOBALS['template_content'] ? $this->setRawTemplateData($compactedContent);
 ./inc/template-functions.php:298:      // @TODO Remove these sanity checks if all is fine
 ./inc/template-functions.php:747:                      // @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates
-./inc/wrapper-functions.php:3197:      // @TODO Find a way to not use direct module comparison
-./inc/wrapper-functions.php:512:// @TODO Do some more sanity check here
+./inc/wrapper-functions.php:3209:      // @TODO Find a way to not use direct module comparison
+./inc/wrapper-functions.php:524:// @TODO Do some more sanity check here
 ./inc/xml-functions.php:240:   // @TODO Handle characters
-./mailid.php:101:              // @TODO Rewrite this to a filter
-./mailid.php:144:                                      // @TODO Rewrite this to a filter
-./mailid_top.php:111:          // @TODO Rewrite this to a filter/function
-./mailid_top.php:148:                                  // @TODO Rewrite this to a filter
-./mailid_top.php:18: * @TODO Merge this script with mailid.php                              *
-./mailid_top.php:198:                                                  // @TODO Rewrite this to a filter
-./mailid_top.php:205:                                                                  // @TODO Rewrite this to a filter
-./mailid_top.php:240:                                                                  // @TODO Rewrite these blocks to filter
+./mailid.php:123:              // @TODO Rewrite this to a filter/function
+./mailid.php:160:                                      // @TODO Rewrite this to a filter
+./mailid.php:81:// @TODO Improve check on $data['type'], empty() is not very much ...
 ./templates/de/html/admin/admin_add_country.tpl:24:                    <!-- @TODO Rewrite this selection box to our generic functions //-->
 ./templates/de/html/admin/admin_config_other.tpl:79:                   <!-- @TODO Rewrite this selection to one of our functions //-->
 ./templates/de/html/admin/admin_config_rewrite.tpl:4:  <!-- @TODO No title here? //-->
 ./inc/sql_error.php:2:// @DEPRECATED
 ./inc/stats_bonus.php:2:// @DEPRECATED
 ./inc/template.php:2:// @DEPRECATED
+./mailid_top.php:2:// @DEPRECATED
 ./templates/de/html/admin/admin_add_reflevel.tpl:1:<!-- @DEPRECATED //-->
 ./templates/de/html/admin/admin_add_reflvl.tpl:1:<!-- @DEPRECATED //-->
 ./templates/de/html/admin/admin_add_shop_cat.tpl:1:<!-- @DEPRECATED //-->