Fix for missing array elements
[mailer.git] / DOCS / TODOs.txt
index f098b63a621c30a301d8a94f60264b955fee69ed..b27b2a4ba2964729f4c45b0b08db8789f46b3ae4 100644 (file)
@@ -8,6 +8,7 @@
 ./inc/classes/cachesystem.class.php:471:       // @TODO Add support for more types which break in last else-block
 ./inc/config-functions.php:144:        // @TODO Make this all better... :-/
 ./inc/expression-functions.php:136:// @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again
+./inc/expression-functions.php:199:    // @TODO is escapeQuotes enougth for strings with single/double quotes?
 ./inc/extensions/ext-html_mail.php:138:                // @TODO Move these arrays into config
 ./inc/extensions/ext-menu.php:54:              // @TODO Convert menu-Id to one coding-standard. admin(edit|_add) => admin_menu_(edit|add), mem(edit|_add) => mem_menu_(edit|add)
 ./inc/extensions/ext-network.php:20: * @TODO AbisZED: Which charset?                                        *
 ./inc/extensions-functions.php:493:            // @TODO Extension is loaded, what next?
 ./inc/functions.php:1026:// @TODO $simple is deprecated
 ./inc/functions.php:1061:      // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates
-./inc/functions.php:2537:              // @TODO Add a little more infos here
+./inc/functions.php:2535:              // @TODO Add a little more infos here
 ./inc/functions.php:256:       // @TODO Remove this sanity-check if all is fine
 ./inc/functions.php:259:       // @TODO Try to rewrite all $DATA to $content
-./inc/functions.php:2620:                      // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
-./inc/functions.php:2643:                      // @TODO Rewrite this old lost code to a template
-./inc/functions.php:2733:                      // @TODO Are these convertions still required?
-./inc/functions.php:2751:// @TODO Rewrite this function to use readFromFile() and writeToFile()
-./inc/functions.php:3630:// @TODO Lame description for this function
-./inc/functions.php:3652:                      // @TODO Move this in a filter
-./inc/functions.php:3776:      // @TODO This is still very static, rewrite it somehow
+./inc/functions.php:2618:                      // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
+./inc/functions.php:2641:                      // @TODO Rewrite this old lost code to a template
+./inc/functions.php:2731:                      // @TODO Are these convertions still required?
+./inc/functions.php:2749:// @TODO Rewrite this function to use readFromFile() and writeToFile()
+./inc/functions.php:3628:// @TODO Lame description for this function
+./inc/functions.php:3650:                      // @TODO Move this in a filter
+./inc/functions.php:3774:      // @TODO This is still very static, rewrite it somehow
 ./inc/functions.php:474:       // @TODO Do only use $content, not $DATA or raw variables
 ./inc/functions.php:544:               // @TODO Extension 'msg' does not exist
 ./inc/functions.php:613:// @TODO Rewrite this to an extension 'smtp'
@@ -77,8 +78,9 @@
 ./inc/libs/register_functions.php:373: // @TODO Rewrite this to a filter
 ./inc/libs/register_functions.php:380: // @TODO Rewrite this whole if() block to addPointsThroughReferalSystem(). This will also make following if() block obsolete
 ./inc/libs/register_functions.php:381: // @TODO Wether the registration bonus should only be added to user directly or through referal system should be configurable
-./inc/libs/surfbar_functions.php:1530:         // @TODO This can be somehow rewritten
-./inc/libs/surfbar_functions.php:963:  // @TODO Invalid salt should be refused
+./inc/libs/surfbar_functions.php:1556:         // @TODO This can be somehow rewritten
+./inc/libs/surfbar_functions.php:724:// @TODO Can't we use our new expression language instead of this ugly code?
+./inc/libs/surfbar_functions.php:972:  // @TODO Invalid salt should be refused
 ./inc/libs/task_functions.php:245:             // @TODO These can be rewritten to filter
 ./inc/libs/task_functions.php:53:// @TODO Move all extension-dependent queries into filters
 ./inc/libs/user_functions.php:138:     // @TODO These two constants are no longer used, maybe we reactivate this code?
@@ -94,7 +96,6 @@
 ./inc/modules/admin/admin-inc.php:325:                                 // @TODO Rewrite this to $content = SQL_FETCHARRAY()
 ./inc/modules/admin/admin-inc.php:331:                                                 // @TODO ACL is 'allow'... hmmm
 ./inc/modules/admin/admin-inc.php:431:// @TODO Try to rewrite this to adminAddMenuSelectionBox()
-./inc/modules/admin/admin-inc.php:445:         // @TODO Try to rewrite this to $content = SQL_FETCHARRAY(). Please look some lines above for the dynamic query
 ./inc/modules/admin/overview-inc.php:164:                              // @TODO Rewrite this to a filter
 ./inc/modules/admin/overview-inc.php:278:                              // @TODO Rewrite this to something with include files and/or filter
 ./inc/modules/admin/overview-inc.php:316:                                              // @TODO This may also be rewritten to include files
 ./inc/modules/admin/what-config_admins.php:146:        // @TODO Rewrite this to filter 'run_sqls'
 ./inc/modules/admin/what-config_mods.php:141:          // @TODO Rewritings: mod->module in template
 ./inc/modules/admin/what-config_mods.php:57:                   // @TODO This can be moved into mysql-function.php, see checkModulePermissions() function
+./inc/modules/admin/what-config_points.php:113:                        // @TODO Rewrite this to a filter
 ./inc/modules/admin/what-config_rallye_prices.php:209:                         // @TODO Rewritings: level->price_level, infos->info in template
 ./inc/modules/admin/what-config_rallye_prices.php:226:                 // @TODO Rewrite these two constants
 ./inc/modules/admin/what-config_register.php:78:       // @TODO Move this HTML code into a template
 ./inc/modules/admin/what-edit_user.php:20: * @TODO Add support for ext-country                                    *
 ./inc/modules/admin/what-email_stats.php:48:// @TODO Unused at the moment
-./inc/modules/admin/what-extensions.php:348:                                           // @TODO Rewrite this to a filter
+./inc/modules/admin/what-extensions.php:350:                                           // @TODO Rewrite this to a filter
 ./inc/modules/admin/what-guest_add.php:137:                            // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-guest_add.php:69:             // @TODO Cant this be rewritten?
 ./inc/modules/admin/what-guest_add.php:85:             // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-list_task.php:192:                            // @TODO Rewrite this to $OUT .= ..., true, ...
 ./inc/modules/admin/what-list_task.php:196:                            // @TODO Rewrite this to $OUT .= ..., true, ...
 ./inc/modules/admin/what-list_unconfirmed.php:100:             // @TODO Rewrite this to $content = SQL_FETCHARRAY(), look some lines above for two differrent queries
-./inc/modules/admin/what-list_unconfirmed.php:130:                             // @TODO Rewritings: userid->userid
 ./inc/modules/admin/what-list_unconfirmed.php:77:      // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', getMessage('LIST_UNCONFIRMED_BONUS_LINKS'));
 ./inc/modules/admin/what-list_unconfirmed.php:88:      // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
 ./inc/modules/admin/what-list_user.php:160:            // @TODO Rewrite these to filters
 ./inc/modules/admin/what-mem_add.php:81:               // @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-payments.php:152:                     // @TODO Rewritings: title->mail_title, pay->payment in template
 ./inc/modules/admin/what-refbanner.php:145:                    // @TODO Rewritings: alt->alternate,cnt->counter,clx->clicks in template
+./inc/modules/admin/what-surfbar_stats.php:119:                        // @TODO Can't all these translation blocks moved into templates? This code looks ugly.
 ./inc/modules/admin/what-unlock_emails.php:89:                                 // @TODO Rewrite these if-blocks to a filter
 ./inc/modules/admin/what-unlock_sponsor.php:192:               // @TODO Rewritings: remote->remote_addr, created->sponsor_created in template
 ./inc/modules/admin/what-usage.php:88: // @TODO This code is double, see loadTemplate() and loadEmailTemplate() in functions.php
 ./inc/modules/member/what-bonus.php:57:        // @TODO Rewrite this to a filter
 ./inc/modules/member/what-categories.php:129:          // @TODO Rewrite this to use $OUT .= ...
 ./inc/modules/member/what-doubler.php:56:// @TODO The '*100' is in the way to get moved into the template
-./inc/modules/member/what-order.php:453:                       // @TODO Rewrite this to a filter
+./inc/modules/member/what-order.php:456:                       // @TODO Rewrite this to a filter
 ./inc/modules/member/what-order.php:65:// @TODO Rewrite this to a filter
 ./inc/modules/member/what-payout.php:221:                                      // @TODO Rewrite this to a filter
 ./inc/modules/member/what-points.php:55:// @TODO Should we rewrite this to a filter?
 ./inc/revision-functions.php:153:// @TODO Please describe this function
 ./inc/wrapper-functions.php:127:// @TODO Implement $compress
 ./inc/wrapper-functions.php:134:// @TODO Implement $decompress
-./inc/wrapper-functions.php:449:// @TODO Do some more sanity check here
-./inc/wrapper-functions.php:764:        * @TODO Do we really need this check? If yes, try to fix this:
+./inc/wrapper-functions.php:455:// @TODO Do some more sanity check here
+./inc/wrapper-functions.php:793:        * @TODO Do we really need this check? If yes, try to fix this:
 ./mailid.php:135:                                      // @TODO Rewrite this to a filter
 ./mailid.php:215:      // @TODO Rewrite this to a dynamic include or so
 ./mailid.php:95:               // @TODO Rewrite this to a filter