Mailer project rwritten:

[mailer.git] / inc / extensions-functions.php

diff --git a/inc/extensions-functions.php b/inc/extensions-functions.php
index 526552cd5bcec4aa2f16e65abec342f8737fba1c..85fb7581958d4c843b0d61cda954b04aaf133f8f 100644 (file)
--- a/inc/extensions-functions.php
+++ b/inc/extensions-functions.php
@@ -216,17 +216,17 @@ function registerExtension ($ext_name, $taskId, $isDryRun = FALSE, $ignoreUpdate
        } // END - if
 
        // Is the task id zero? Then we need to auto-fix it here
-       if ((!isTaskIdValid($taskId)) && (!isInstallationPhase())) {
+       if ((!isValidId($taskId)) && (!isInstallationPhase())) {
                // Try to find the task
                $taskId = determineExtensionTaskId(getCurrentExtensionName());
 
                // Still zero and not in dry-run?
-               if ((!isTaskIdValid($taskId)) && (!isExtensionDryRun())) {
+               if ((!isValidId($taskId)) && (!isExtensionDryRun())) {
                        // Now try to create a new task
                        $taskId = createNewExtensionTask(getCurrentExtensionName());
 
                        // Is it still zero?
-                       if (!isTaskIdValid($taskId)) {
+                       if (!isValidId($taskId)) {
                                // Then request a bug report
                                reportBug(__FUNCTION__, __LINE__, sprintf("%s: task_id is still zero after determineExtensionTaskId/createNewExtensionTask(%s)",
                                        __FUNCTION__,
@@ -295,7 +295,7 @@ function registerExtension ($ext_name, $taskId, $isDryRun = FALSE, $ignoreUpdate
 
                                        // Entry found?
                                        //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'updateTaskId=' . $updateTaskId . ',isInstallationPhase()=' . intval(isInstallationPhase()) . ',currName=' . getCurrentExtensionName() . ',ext_update=' . $ext_update . ' - CHECKING!');
-                                       if (($updateTaskId > 0) || (isInstallationPhase())) {
+                                       if ((isValidId($updateTaskId)) || (isInstallationPhase())) {
                                                // Try to register the extension
                                                //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName() . ',ext_update=' . $ext_update . ',updateTaskId=' . $updateTaskId . ',isExtensionDryRun()=' . intval(isExtensionDryRun()));
                                                $processResult = registerExtension($ext_update, $updateTaskId, isExtensionDryRun(), TRUE, $ext_name);
@@ -426,7 +426,7 @@ function registerExtension ($ext_name, $taskId, $isDryRun = FALSE, $ignoreUpdate
                        //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currentExtension=' . getCurrentExtensionName());
                        $ret = FALSE;
                }
-       } elseif (($taskId > 0) && (getCurrentExtensionName() != '')) {
+       } elseif ((isValidId($taskId)) && (getCurrentExtensionName() != '')) {
                // Remove task from system when id and extension's name is valid
                //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'currName=' . getCurrentExtensionName());
                SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_task_system` WHERE `id`=%s AND `status`='NEW' LIMIT 1",
@@ -542,7 +542,7 @@ function isExtensionInstalled ($ext_name) {
                $ext_id = getExtensionId($ext_name);
 
                // Is there a record?
-               $isInstalled = ($ext_id > 0);
+               $isInstalled = isValidId($ext_id);
 
                // Log debug message
                //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . $ext_name . ',ext_id=' . $ext_id . ',isInstalled=' . intval($isInstalled));
@@ -1044,7 +1044,7 @@ function createExtensionUpdateTask ($adminId, $ext_name, $ext_ver, $notes) {
        // Is the extension there?
        if (isExtensionInstalled($ext_name)) {
                // Check if task is not there
-               if ($taskId == '0') {
+               if (!isValidId($taskId)) {
                        // Create extension update-task
                        $taskId = createNewTask($subject, $notes, 'EXTENSION_UPDATE', 0, $adminId);
                } // END - if
@@ -1067,7 +1067,7 @@ function createNewExtensionTask ($ext_name) {
 
        // Not installed and do we have created a task for the admin?
        //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . $ext_name . ',taskId[' . gettype($taskId) . ']=' . $taskId);
-       if ((!isTaskIdValid($taskId)) && (!isExtensionInstalled($ext_name))) {
+       if ((!isValidId($taskId)) && (!isExtensionInstalled($ext_name))) {
                // Set default message if ext-foo is missing
                $message = '{%message,ADMIN_EXTENSION_TEXT_FILE_MISSING=' . $ext_name . '%}';
 
@@ -1105,7 +1105,7 @@ function createExtensionDeactivationTask ($ext_name) {
 
        // Not installed and do we have created a task for the admin?
        //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'ext_name=' . $ext_name . ',taskId[' . gettype($taskId) . ']=' . $taskId);
-       if ((!isTaskIdValid($taskId)) && (isExtensionInstalled($ext_name))) {
+       if ((!isValidId($taskId)) && (isExtensionInstalled($ext_name))) {
                // Task not created so add it
                $taskId = createNewTask($subject, SQL_ESCAPE(loadTemplate('task_EXTENSION_deactivated', TRUE, $ext_name)), 'EXTENSION_DEACTIVATION');
        } // END - if
@@ -2304,19 +2304,6 @@ function copyExtensionDataToCacheArray ($ext_name, $ext_id) {
        $GLOBALS['cache_array']['extension']['ext_deprecated'][$ext_name] = 'N';
 }
 
-// Checks if given task id is valid
-function isTaskIdValid ($taskId) {
-       // Is there cache?
-       if (!isset($GLOBALS[__FUNCTION__][$taskId])) {
-               // Determine it
-               $GLOBALS[__FUNCTION__][$taskId] = ((!is_null($taskId)) && ($taskId > 0));
-       } // END - if
-
-       // Return "cached" value
-       //* DEBUG: */ logDebugMessage(__FUNCTION__, __LINE__, 'taskId[' . gettype($taskId) . ']=' . intval($taskId) . ',isValid=' . intval($GLOBALS[__FUNCTION__][$taskId]));
-       return $GLOBALS[__FUNCTION__][$taskId];
-}
-
 // "Getter" for "checked="checked" from given session data
 function getExtensionSelectedFromSession ($ext_name, $sessionName, $separator = ':') {
        // Get the data and explode it