Getter for boolean values should be named like ifFoo() or isBar()

[mailer.git] / inc / extensions / ext-online.php

diff --git a/inc/extensions/ext-online.php b/inc/extensions/ext-online.php
index ed14fad0a464349957dfdb6f20a59e1b5474db03..45051d68920ab0b4742f0d5a399cf49cb4d51a27 100644 (file)
--- a/inc/extensions/ext-online.php
+++ b/inc/extensions/ext-online.php
@@ -40,7 +40,7 @@
 // Some security stuff...
 if (!defined('__SECURITY')) {
        die();
-}
+} // END - if
 
 // Version number
 setThisExtensionVersion('0.0.5');
@@ -51,7 +51,7 @@ setExtensionVersionHistory(array('0.0', '0.0.1', '0.0.2', '0.0.3', '0.0.4', '0.0
 switch (getExtensionMode()) {
        case 'register': // Do stuff when installation is running (modules.php?module=admin is called)
                // SQL commands to run
-               addExtensionSql("DROP TABLE IF EXISTS `{?_MYSQL_PREFIX?}_online`");
+               addExtensionSql('DROP TABLE IF EXISTS `{?_MYSQL_PREFIX?}_online`');
                addExtensionSql("CREATE TABLE `{?_MYSQL_PREFIX?}_online` (
 `id` BIGINT(20) UNSIGNED NOT NULL AUTO_INCREMENT,
 `sid` VARCHAR(32) NOT NULL DEFAULT '',
@@ -74,12 +74,12 @@ KEY `admin_member` (`is_admin`,`is_member`)
 
        case 'remove': // Do stuff when removing extension
                // SQL commands to run
-               addExtensionSql("DROP TABLE IF EXISTS `{?_MYSQL_PREFIX?}_online`");
+               addExtensionSql('DROP TABLE IF EXISTS `{?_MYSQL_PREFIX?}_online`');
                addExtensionSql("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_admin_menu` WHERE `what`='usr_online'");
                addExtensionSql("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_guest_menu` WHERE `action`='online'");
 
                // Unregister filter
-               unregisterFilter('init', 'UPDATE_ONLINE_LIST', true, getExtensionDryRun());
+               unregisterFilter('init', 'UPDATE_ONLINE_LIST', true, isExtensionDryRun());
                break;
 
        case 'activate': // Do stuff when admin activates this extension
@@ -116,15 +116,16 @@ KEY `admin_member` (`is_admin`,`is_member`)
                                break;
 
                        case '0.0.5': // SQL queries for v0.0.5
-                               addGuestMenuSql('online',NULL,'Jetzt Online','Y','N',2);
+                               // Add guest menu
+                               addGuestMenuSql('online', NULL, 'Jetzt Online', 'Y', 'N', 2);
 
                                // Register filter
-                               registerFilter('init', 'UPDATE_ONLINE_LIST', false, true, getExtensionDryRun());
+                               registerFilter('init', 'UPDATE_ONLINE_LIST', false, true, isExtensionDryRun());
 
                                // Update notes (these will be set as task text!)
                                setExtensionUpdateNotes("Hinzufügen des Menüpunktes "Jetzt Online" wird nun von dieser Erweiterung erledigt. Filter hinzugefügt.");
                                break;
-               }
+               } // END - switch
                break;
 
        case 'modify': // When the extension got modified
@@ -137,9 +138,9 @@ KEY `admin_member` (`is_admin`,`is_member`)
                break;
 
        default: // Unknown extension mode
-               logDebugMessage(__FILE__, __LINE__, sprintf("Unknown extension mode %s detected.", getExtensionMode()));
+               logDebugMessage(__FILE__, __LINE__, sprintf("Unknown extension mode %s in extension %s detected.", getExtensionMode(), getCurrentExtensionName()));
                break;
-}
+} // END - switch
 
 // [EOF]
 ?>