Install SQL import is improved. Now no external shell command is required. :)
[mailer.git] / inc / install-inc.php
index 0909dd89bf3fee2de708c419b5fce8427bbe8321..043c701cfcadb65afcf79cae53fa278981ffedad 100644 (file)
@@ -334,9 +334,9 @@ if ((!mxchange_installed) || (!admin_registered))
                break;
 
        case "finalize": // Write captured data to files
-               if (!empty($_POST['finalize'])) {
+               if ((!empty($_POST['finalize'])) && (!mxchange_installed)) {
                        // You have submitted data then we have to reset the fatal messages
-                       $FATAL = array();
+                       $FATAL = array(); $SQLs = array();
 
                        // Connect to MySQL server
                        $link = SQL_CONNECT($mysql['host'], $mysql['login'], $mysql['pass1'], __FILE__, __LINE__);
@@ -345,52 +345,66 @@ if ((!mxchange_installed) || (!admin_registered))
                                $db = SQL_SELECT_DB($mysql['dbase'], $link, __FILE__, __LINE__);
                                if ($db) {
                                        // Automatically run install.sql
-                                       if (file_exists($_POST['spath']."install/tables.sql")) {
-                                               $ERRORS = $_POST['spath']."inc/sql.err";
-                                               $cmd = array(
-                                                       // "Dump" tha' s*** up... ;-) > /dev/null
-                                                       "mysql ".$mysql['dbase']." --force --host=".$mysql['host']." --user=".$mysql['login']." --password=".$mysql['pass1']." < ".$_POST['spath']."install/tables.sql",
-                                                       "mysql ".$mysql['dbase']." --force --host=".$mysql['host']." --user=".$mysql['login']." --password=".$mysql['pass1']." < ".$_POST['spath']."install/menu-".GET_LANGUAGE().".sql"
-                                               );
-
-                                               foreach ($cmd as $c) {
-                                                       @system($c);
+                                       if ((file_exists($_POST['spath']."install/tables.sql")) && (file_exists($_POST['spath']."install/menu-".GET_LANGUAGE().".sql"))) {
+                                               // Both exists so import them
+                                               foreach (array("tables.sql", "menu-".GET_LANGUAGE().".sql") as $dump) {
+                                                       // Should be save here because file_exists() is there but we check it again. :)
+                                                       $file = secureString($_POST['spath']) . "install/" . $dump;
+                                                       if ((file_exists($file)) && (is_readable($file))) {
+                                                               // Load the file
+                                                               $sql = implode("", file($file));
+
+                                                               // Remove some unwanted chars
+                                                               $sql = str_replace("\r", "", $sql);
+                                                               $sql = str_replace("\n\n", "\n", $sql);
+
+                                                               // And split it up against ;\n ...
+                                                               $SQLs = array_merge($SQLs, explode(";\n", $sql));
+                                                       }
                                                }
 
-                                               if ((file_exists($ERRORS)) && (filesize($ERRORS) > 0)) {
-                                                       ADD_FATAL(MYSQLDUMP_ERROR);
-                                               } elseif (!mxchange_installed) {
-                                                       // Remove error file if empty
-                                                       if (file_exists($ERRORS)) @unlink ($ERRORS);
-
-                                                       // Ok, all done. So we can write the config data to the php files
-                                                       if ($_POST['spath'] != PATH) install_WriteData($_POST['spath']."inc/config.php", "SERVER-PATH", "define ('PATH', \"", "\");", $_POST['spath'], 0);
-                                                       if ($_POST['burl']  != URL)  install_WriteData($_POST['spath']."inc/config.php", "HOST-URL", "define ('URL', \"", "\");", $_POST['burl'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "MAIN_TITLE", "define ('MAIN_TITLE', \"", "\");", $_POST['title'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "SLOGAN", "define ('SLOGAN', \"", "\");", $_POST['slogan'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "WEBMASTER", "define ('WEBMASTER', \"", "\");", $_POST['email'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "NULLPASS-WARNING", "define ('warn_no_pass', ", ");", $_POST['warn_no_pass'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "WRITE-FOOTER", "define ('WRITE_FOOTER', ", ");", $_POST['wfooter'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "BACKLINK", "define ('ENABLED_BACKLINK', ", ");", $_POST['blink'], 0);
-                                                       // install_WriteData($_POST['spath']."inc/config.php", "FRAMESET", "define ('frameset_active', ", ");", $_POST['frameset'], 0);
-                                                       // install_WriteData($_POST['spath']."inc/config.php", "OUTPUT-MODE", "define ('OUTPUT_MODE', \"", "\");", $_POST['omode'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "MYSQL-HOST", "     'host'     => \"", "\",", $mysql['host'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "MYSQL-DBASE", "    'dbase'    => \"", "\",", $mysql['dbase'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "MYSQL-LOGIN", "    'login'    => \"", "\",", $mysql['login'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "MYSQL-PASSWORD", " 'password' => \"", "\",", $mysql['pass1'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "MYSQL-PREFIX", "define ('_MYSQL_PREFIX', \"", "\");", $mysql['prefix'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "SMTP-HOSTNAME", "define ('SMTP_HOSTNAME', \"", "\");", $_POST['smtp_host'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "SMTP-USER", "define ('SMTP_USER', \"", "\");", $_POST['smtp_user'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "SMTP-PASSWORD", "define ('SMTP_PASSWORD', \"", "\");", $_POST['smtp_pass'], 0);
-                                                       install_WriteData($_POST['spath']."inc/config.php", "INSTALLED", "define ('mxchange_installed', ", ");", "true", 0);
-
-                                                       // Close the link
-                                                       SQL_CLOSE($link, __FILE__, __LINE__);
+                                               // Are some SQLs found?
+                                               if (count($SQLs) == 0) {
+                                                       // Abort here
+                                                       ADD_FATAL(INSTALL_SQL_IMPORT_FAILED);
+                                                       return;
                                                }
-                                                else
-                                               {
-                                                       ADD_FATAL(INSTALL_MAYBE_DONE);
+
+                                               // Now run all queries through and try to keep out empty or comment queries
+                                               foreach ($SQLs as $sql) {
+                                                       // Trim spaces away
+                                                       $sql = trim($sql);
+
+                                                       // Is this query not empty and not a comment?
+                                                       if ((!empty($sql)) && (substr($sql, 0, 2) != "--") && (substr($sql, 0, 1) != "#")) {
+                                                               // Then run it!
+                                                               SQL_QUERY($sql, __FILE__, __LINE__);
+                                                       }
                                                }
+
+                                               // Ok, all done. So we can write the config data to the php files
+                                               if ($_POST['spath'] != PATH) install_WriteData($_POST['spath']."inc/config.php", "SERVER-PATH", "define ('PATH', \"", "\");", $_POST['spath'], 0);
+                                               if ($_POST['burl']  != URL)  install_WriteData($_POST['spath']."inc/config.php", "HOST-URL", "define ('URL', \"", "\");", $_POST['burl'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "MAIN_TITLE", "define ('MAIN_TITLE', \"", "\");", $_POST['title'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "SLOGAN", "define ('SLOGAN', \"", "\");", $_POST['slogan'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "WEBMASTER", "define ('WEBMASTER', \"", "\");", $_POST['email'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "NULLPASS-WARNING", "define ('warn_no_pass', ", ");", $_POST['warn_no_pass'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "WRITE-FOOTER", "define ('WRITE_FOOTER', ", ");", $_POST['wfooter'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "BACKLINK", "define ('ENABLE_BACKLINK', ", ");", $_POST['blink'], 0);
+                                               // install_WriteData($_POST['spath']."inc/config.php", "FRAMESET", "define ('frameset_active', ", ");", $_POST['frameset'], 0);
+                                               // install_WriteData($_POST['spath']."inc/config.php", "OUTPUT-MODE", "define ('OUTPUT_MODE', \"", "\");", $_POST['omode'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "MYSQL-HOST", "     'host'     => \"", "\",", $mysql['host'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "MYSQL-DBASE", "    'dbase'    => \"", "\",", $mysql['dbase'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "MYSQL-LOGIN", "    'login'    => \"", "\",", $mysql['login'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "MYSQL-PASSWORD", " 'password' => \"", "\",", $mysql['pass1'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "MYSQL-PREFIX", "define ('_MYSQL_PREFIX', \"", "\");", $mysql['prefix'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "SMTP-HOSTNAME", "define ('SMTP_HOSTNAME', \"", "\");", $_POST['smtp_host'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "SMTP-USER", "define ('SMTP_USER', \"", "\");", $_POST['smtp_user'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "SMTP-PASSWORD", "define ('SMTP_PASSWORD', \"", "\");", $_POST['smtp_pass'], 0);
+                                               install_WriteData($_POST['spath']."inc/config.php", "INSTALLED", "define ('mxchange_installed', ", ");", "true", 0);
+
+                                               // Close the link
+                                               SQL_CLOSE($link, __FILE__, __LINE__);
                                        }
                                         else
                                        {
@@ -418,8 +432,7 @@ if ((!mxchange_installed) || (!admin_registered))
                                define('__TITLE_VALUE'  , $_POST['title']);
                                define('__SMTP_HOST'    , $_POST['smtp_host']);
                                define('__SMTP_USER'    , $_POST['smtp_user']);
-                               define('__SMTP_PASS1'   , $_POST['smtp_pass1']);
-                               define('__SMTP_PASS2'   , $_POST['smtp_pass2']);
+                               define('__SMTP_PASS'    , $_POST['smtp_pass']);
 
                                OUTPUT_HTML("<FORM action=\"".__BURL_ACTION."/install.php?page=2\" method=\"POST\">
 <TABLE border=\"0\" cellspacing=\"0\" cellpadding=\"0\" class=\"install_content\">