A lot eval() commands rewritten to constant() function

[mailer.git] / inc / mails / bonus_mails.php

diff --git a/inc/mails/bonus_mails.php b/inc/mails/bonus_mails.php
index 673681010457c5346a55a77e919f7f517974bab5..0e4e19224b722e24422418f9b275fa55a9b3fbad 100644 (file)
--- a/inc/mails/bonus_mails.php
+++ b/inc/mails/bonus_mails.php
@@ -32,22 +32,19 @@
  ************************************************************************/
 
 // Some security stuff...
-if (ereg(basename(__FILE__), $_SERVER['PHP_SELF']))
-{
+if (!defined('__SECURITY')) {
        $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
        require($INC);
-}
- elseif ((!EXT_IS_ACTIVE("bonus")) && (!IS_ADMIN()))
-{
-       ADD_FATAL(EXTENSION_PROBLEM_EXT_INACTIVE, "bonus");
+} elseif (!EXT_IS_ACTIVE("bonus")) {
        return;
 }
 
 // Do not execute when script is in CSS mode
+global $CSS;
 if ($CSS == 1) return;
 
 // Create timemark from saved month
-$mark = mktime(0, 0, 0, $_CONFIG['bonus_month'], date("d", time()), date('Y', time()));
+$mark = mktime(0, 0, 0, $_CONFIG['last_month'], date("d", time()), date('Y', time()));
 $SQL = ""; $MODE = "";
 
 // Shall I sent activation or deactivation mail?
@@ -55,36 +52,29 @@ $SQL = "SELECT userid, email FROM "._MYSQL_PREFIX."_user_data WHERE (bonus_ral_n
 switch ($_CONFIG['bonus_active'])
 {
 case 'Y': // Active rallye is activated
-       if ($_CONFIG['bonus_en_notify'] == 'Y')
-       {
+       if ($_CONFIG['bonus_en_notify'] == "Y") {
                // Okay, let's check for member accounts
                $SQL .= "= 0 OR (bonus_ral_notify > 0 AND bonus_ral_en_notify < bonus_ral_di_notify)";
                $MODE = "en";
-       }
-        else
-       {
+       } else {
                // Do not notify!
                $SQL = "";
        }
        break;
 
 case 'N': // Active rallye is deactivated
-       if ($_CONFIG['bonus_di_notify'] == 'Y')
-       {
+       if ($_CONFIG['bonus_di_notify'] == "Y") {
                // Okay, let's check for member accounts
                $SQL .= " > 0 AND bonus_ral_di_notify < bonus_ral_en_notify";
                $MODE = "di";
-       }
-        else
-       {
+       } else {
                // Do not notify!
                $SQL = "";
        }
        break;
 }
 
-if (!empty($SQL))
-{
+if (!empty($SQL)) {
        // The SQL command needs to be finisched here (only confirmed accounts!)
        $SQL .= ") AND status='CONFIRMED' ORDER BY last_online ASC";
 
@@ -92,8 +82,7 @@ if (!empty($SQL))
        $MAIL_MODE = (($_CONFIG['bonus_notify_points'] > 0) && ($MODE == "en") && (EXT_IS_ACTIVE("bonus")));
 
        // Generate subject line
-       $eval = "\$SUBJECT = BONUS_RALLYE_".strtoupper($MODE)."_NOTIFY;";
-       eval($eval);
+       $SUBJECT = constant('BONUS_RALLYE_'.strtoupper($MODE).'_NOTIFY');
 
        // Load message body for bonus mails
        $MSG = LOAD_EMAIL_TEMPLATE("bonus_en_notify_body", "", "{PER}uid{PER}");
@@ -101,38 +90,32 @@ if (!empty($SQL))
 
        // Check for accounts to be notified
        $result_main = SQL_QUERY($SQL, __FILE__, __LINE__);
-       if (SQL_NUMROWS($result_main) > 0)
-       {
+       if (SQL_NUMROWS($result_main) > 0) {
                // Okay lets notify all users!
-               while(list($uid, $email) = SQL_FETCHROW($result_main))
-               {
+               while(list($uid, $email) = SQL_FETCHROW($result_main)) {
                        // Update account
                        $result_update = SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_user_data
-SET bonus_ral_notify='%s', bonus_ral_%s_notify='%s' WHERE userid=%d LIMIT 1",
+SET bonus_ral_notify='%s', bonus_ral_%s_notify='%s' WHERE userid=%s LIMIT 1",
  array(time(), $MODE, time(), $uid), __FILE__, __LINE__);
 
                        // Load email template and send it to the user!
-                       if ($MAIL_MODE)
-                       {
+                       if ($MAIL_MODE) {
                                // Add userid to queue
                                $UIDs[] = $uid;
-                       }
-                        else
-                       {
+                       } else {
                                // Send normal notification mail to the members
-                               $MSG = LOAD_EMAIL_TEMPLATE("bonus_".$MODE."_notify", "", $uid);
-                               SEND_EMAIL($email, $SUBJECT, $MSG);
+                               $MSG = LOAD_EMAIL_TEMPLATE("bonus_".$MODE."_notify", array(), $uid);
+                               SEND_EMAIL($uid, $SUBJECT, $MSG);
                        }
-               }
+               } // END - if
 
                // Shall I send out bonus mails?
-               if ($MAIL_MODE)
-               {
+               if ($MAIL_MODE) {
                        // Okay, make array to string
                        $RECEIVER = implode(";", $UIDs);
                        $result = SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_bonus
 (subject, text, receivers, points, time, data_type, timestamp, url, cat_id, target_send, mails_sent, is_notify)
-VALUES ('%s', '%s', '%s', '%s', '%s', 'NEW', UNIX_TIMESTAMP(), '%s', '%s', '%s', '%s', 'Y')",
+VALUES ('%s','%s','%s','%s','%s','NEW', UNIX_TIMESTAMP(), '%s','%s','%s','%s','Y')",
  array(
        $SUBJECT,
        $MSG,
@@ -150,5 +133,6 @@ VALUES ('%s', '%s', '%s', '%s', '%s', 'NEW', UNIX_TIMESTAMP(), '%s', '%s', '%s',
        // Free memory
        SQL_FREERESULT($result_main);
 }
+
 //
 ?>