Wrapper function isAdminsExpertWarningEnabled() introduced
[mailer.git] / inc / modules / admin / admin-inc.php
index 78d2469e4bf62b58ef28534a79e296b0e62abd1d..f5a70264af536ecb155eccc65ca7de42dc8de978 100644 (file)
@@ -16,7 +16,7 @@
  * $Author::                                                          $ *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
- * Copyright (c) 2009, 2010 by Mailer Developer Team                    *
+ * Copyright (c) 2009 - 2011 by Mailer Developer Team                   *
  * For more information visit: http://www.mxchange.org                  *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
@@ -72,8 +72,9 @@ function addAdminAccount ($adminLogin, $passHash, $adminEmail) {
 
 // This function will be executed when the admin is not logged in and has submitted his login data
 function ifAdminLoginDataIsValid ($adminLogin, $adminPassword) {
-       // First of all, no admin login is found
+       // First of all, no admin login is found, so the admin hash is null
        $ret = '404';
+       $adminHash = null;
 
        // Get admin id from login
        $adminId = getAdminId($adminLogin);
@@ -165,15 +166,12 @@ function doAdminAction () {
        // Get action value
        $action = getActionFromModuleWhat(getModule(), $what);
 
-       // Define admin login name and id number
-       $content['login'] = getAdminLogin(getSession('admin_id'));
-       $content['id']    = getCurrentAdminId();
-
-       // Preload templates
+       // Load welcome template
        if (isExtensionActive('admins')) {
-               $content['welcome'] = loadTemplate('admin_welcome_admins', true, $content);
+               // @TODO This and the next getCurrentAdminId() call might be moved into the templates?
+               $content['welcome'] = loadTemplate('admin_welcome_admins', true, getCurrentAdminId());
        } else {
-               $content['welcome'] = loadTemplate('admin_welcome', true, $content);
+               $content['welcome'] = loadTemplate('admin_welcome', true, getCurrentAdminId());
        }
 
        // Load header, footer, render menu
@@ -220,11 +218,11 @@ LIMIT 1",
                        // Access denied
                        loadTemplate('admin_menu_failed', false, getMaskedMessage('ADMIN_ACCESS_DENIED', $what));
                } else {
-                       // Include file not found! :-(
+                       // Include file not found :-(
                        loadTemplate('admin_menu_failed', false, getMaskedMessage('ADMIN_ACTION_404', $action));
                }
        } else {
-               // Invalid action/what pair found!
+               // Invalid action/what pair found
                loadTemplate('admin_menu_failed', false, getMaskedMessage('ADMIN_ACTION_INVALID', $action . '/' . $what));
        }
 
@@ -235,8 +233,22 @@ LIMIT 1",
        loadTemplate('admin_main_footer', false, $content);
 }
 
+// Checks wether current admin is allowed to access given action/what combination
+// (only one is allowed to be null!)
+function isAdminAllowedAccessMenu ($action, $what = null) {
+       // Do we have cache?
+       if (!isset($GLOBALS[__FUNCTION__][$action][$what])) {
+               // ACL is always 'allow' when no ext-admins is installed
+               // @TODO This can be rewritten into a filter
+               $GLOBALS[__FUNCTION__][$action][$what] = ((!isExtensionInstalledAndNewer('admins', '0.2.0')) || (adminsCheckAdminAcl($action, $what)));
+       } // END - if
+
+       // Return the cached value
+       return $GLOBALS[__FUNCTION__][$action][$what];
+}
+
 // Adds an admin menu
-function addAdminMenu ($action, $what, $return=false) {
+function addAdminMenu ($action, $what, $return = false) {
        // Init variables
        $SUB = false;
        $OUT = '';
@@ -261,25 +273,19 @@ ORDER BY
                $OUT .= '<ul class="admin_menu_main">';
                // @TODO Rewrite this to $content = SQL_FETCHARRAY()
                while (list($menu, $title, $descr) = SQL_FETCHROW($result_main)) {
-                       if (isExtensionInstalledAndNewer('admins', '0.2.0')) {
-                               $ACL = adminsCheckAdminAcl($menu, '');
-                       } else {
-                               // @TODO ACL is 'allow'... hmmm
-                               $ACL = true;
-                       }
-
                        // Filename
                        $inc = sprintf("inc/modules/admin/action-%s.php", $menu);
 
                        // Is the file readable?
                        $readable = isIncludeReadable($inc);
 
-                       if ($ACL === true) {
+                       // Is the current admin allowed to access this 'action' menu?
+                       if (isAdminAllowedAccessMenu($menu)) {
                                if ($SUB === false) {
                                        // Insert compiled menu title and description
                                        $GLOBALS['menu']['title'][$menu]      = $title;
                                        $GLOBALS['menu']['description'][$menu] = $descr;
-                               }
+                               } // END - if
                                $OUT .= '<li class="admin_menu">
 <div class="nobr"><strong>&middot;</strong>&nbsp;';
 
@@ -332,22 +338,14 @@ ORDER BY
                                        $OUT .= '<li class="admin_menu_sub"><ul class="admin_menu_sub">';
                                        // @TODO Rewrite this to $content = SQL_FETCHARRAY()
                                        while (list($what_sub, $title_what, $desc_what) = SQL_FETCHROW($result_what)) {
-                                               // Check for access level
-                                               if (isExtensionInstalledAndNewer('admins', '0.2.0')) {
-                                                       $ACL = adminsCheckAdminAcl('', $what_sub);
-                                               } else {
-                                                       // @TODO ACL is 'allow'... hmmm
-                                                       $ACL = true;
-                                               }
-
                                                // Filename
                                                $inc = sprintf("inc/modules/admin/what-%s.php", $what_sub);
 
                                                // Is the file readable?
                                                $readable = isIncludeReadable($inc);
 
-                                               // Access allowed?
-                                               if ($ACL === true) {
+                                               // Is the current admin allowed to access this 'what' menu?
+                                               if (isAdminAllowedAccessMenu(null, $what_sub)) {
                                                        // Insert compiled title and description
                                                        $GLOBALS['menu']['title'][$what_sub]      = $title_what;
                                                        $GLOBALS['menu']['description'][$what_sub] = $desc_what;
@@ -650,7 +648,14 @@ function generateUserProfileLink ($userid, $title = '', $what = 'list_user') {
 // Check "logical-area-mode"
 function adminGetMenuMode () {
        // Set the default menu mode as the mode for all admins
-       $mode = getAdminMenu();
+       $mode = 'global';
+
+       // If sql_patches is up-to-date enough, use the configuration
+       if (isExtensionInstalledAndNewer('sql_patches', '0.3.2')) {
+               $mode = getAdminMenu();
+       } // END - if
+
+       // Backup it
        $adminMode = $mode;
 
        // Get admin id
@@ -1113,7 +1118,7 @@ function sendAdminPasswordResetLink ($email) {
 
        // Is there an account?
        if (SQL_HASZERONUMS($result)) {
-               // No account found!
+               // No account found
                return '{--ADMIN_NO_LOGIN_WITH_EMAIL--}';
        } // END - if
 
@@ -1124,20 +1129,20 @@ function sendAdminPasswordResetLink ($email) {
        SQL_FREERESULT($result);
 
        // Generate hash for reset link
-       $content['hash'] = generateHash(getUrl() . ':' . $content['id'] . ':' . $content['login'] . ':' . $content['password'], substr($content['password'], 10));
+       $content['hash'] = generateHash(getUrl() . getEncryptSeperator() . $content['id'] . getEncryptSeperator() . $content['login'] . getEncryptSeperator() . $content['password'], substr($content['password'], getSaltLength()));
 
        // Remove some data
        unset($content['id']);
        unset($content['password']);
 
        // Prepare email
-       $mailText = loadEmailTemplate('form_reset_password', $content);
+       $mailText = loadEmailTemplate('admin_reset_password', $content);
 
        // Send it out
-       sendEmail($email, '{--ADMIN_RESET_PASS_LINK_SUBJECT--}', $mailText);
+       sendEmail($email, '{--ADMIN_RESET_PASSWORD_LINK_SUBJECT--}', $mailText);
 
        // Prepare output
-       return '{--ADMIN_RESET_LINK_SENT--}';
+       return '{--ADMIN_RESET_PASSWORD_LINK_SENT--}';
 }
 
 // Validate hash and login for password reset
@@ -1155,7 +1160,7 @@ function adminResetValidateHashLogin ($hash, $login) {
                $content = SQL_FETCHARRAY($result);
 
                // Generate hash again
-               $hashFromData = generateHash(getUrl() . ':' . $content['id'] . ':' . $login . ':' . $content['password'], substr($content['password'], 10));
+               $hashFromData = generateHash(getUrl() . getEncryptSeperator() . $content['id'] . getEncryptSeperator() . $login . getEncryptSeperator() . $content['password'], substr($content['password'], getSaltLength()));
 
                // Does both match?
                $valid = ($hash == $hashFromData);
@@ -1306,13 +1311,13 @@ function doVerifyExpertSettings () {
                // Is he allowed?
                if ($expertSettings == 'Y') {
                        // Okay, does he want to see them?
-                       if (getAminsExpertWarning() == 'Y') {
+                       if (isAdminsExpertWarningEnabled()) {
                                // Ask for them
                                if (isFormSent()) {
                                        // Is the element set, then we need to change the admin
                                        if (isPostRequestParameterSet('expert_settings')) {
                                                // Get it and prepare final post data array
-                                               $postData['login'][getCurrentAdminId()] = getAdminLogin(getCurrentAdminId());
+                                               $postData['login'][getCurrentAdminId()] = getCurrentAdminLogin();
                                                $postData['expert_warning'][getCurrentAdminId()] = 'N';
 
                                                // Change it in the admin